xiaoxiang781216 commented on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812823518
@cclauss could you squach your patches into one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
xiaoxiang781216 commented on pull request #92:
URL:
https://github.com/apache/incubator-nuttx-testing/pull/92#issuecomment-812822710
Ubuntu setup isn't free too:
from the a
btashton commented on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812820388
It already includes flake8 black etc... We already have it for yaml linting
why not just enable it for python as well?
--
This is an automated message from the Apache
cclauss edited a comment on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812819891
That linter might be super but it is also super slow. In its 5 minute
runtime it should be able to automatically lint all programming languages known
to man.
cclauss commented on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812819891
That linter might be super but it is also super slow. In its 5 minute
runtime it should be able to lint all programming languages known to man.
The test I added t
xiaoxiang781216 merged pull request #646:
URL: https://github.com/apache/incubator-nuttx-apps/pull/646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about t
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 99138f6 testing/ostest: Add a
xiaoxiang781216 commented on pull request #647:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/647#issuecomment-812818855
@swkim101 you need remove all CONFIG_NSH_DISABLE_M[B|H|W]=y from
nuttx/boards/ to fix the error reported here:
https://github.com/apache/incubator-nuttx-a
xiaoxiang781216 merged pull request #3273:
URL: https://github.com/apache/incubator-nuttx/pull/3273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from b4b175c arch:rv64:add memory clobber to inline asm for syscall.
add 45dc778 sys/socket.h: Add "Soc
xiaoxiang781216 commented on pull request #3273:
URL: https://github.com/apache/incubator-nuttx/pull/3273#issuecomment-812818316
The change is trival, macOS build error is due to the unstable of github
infrastructure. So let's merge it.
--
This is an automated message from the Apache Git
xiaoxiang781216 commented on pull request #3212:
URL: https://github.com/apache/incubator-nuttx/pull/3212#issuecomment-812817710
@btashton it is finally pass CI, coud you review again and merge it if no
more concern?
--
This is an automated message from the Apache Git Service.
To respond
xiaoxiang781216 merged pull request #3283:
URL: https://github.com/apache/incubator-nuttx/pull/3283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 18f88c3 esp32: Fix small typo that will trigger an error when IPv6 is
enabled
add b4b175c arch:rv
xiaoxiang781216 merged pull request #3282:
URL: https://github.com/apache/incubator-nuttx/pull/3282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 18f88c3 esp32: Fix small typo that
swkim101 opened a new pull request #647:
URL: https://github.com/apache/incubator-nuttx-apps/pull/647
## Summary
- Fix https://github.com/apache/incubator-nuttx/issues/3011
## Impact
## Testing
![image](https://user-images.githubusercontent.com/72803908/113467429
hotislandn opened a new pull request #3283:
URL: https://github.com/apache/incubator-nuttx/pull/3283
Signed-off-by: hotislandn
## Summary
This patch adds "memory" for the inlined asm syscalls for RV64GC.
Without this, the compiler will remove some of the memory operations befor
btashton edited a comment on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812790171
The GitHub super linter already can support this which we have enabled. You
can just update the config for that.
It supports flake8 although to be honest I
btashton commented on pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281#issuecomment-812790171
The GitHub super linter already can support this which we have enabled. You
just update the config for that.
It supports flake8 although to be honest I would be f
acassis opened a new pull request #3282:
URL: https://github.com/apache/incubator-nuttx/pull/3282
## Summary
esp32: Fix small typo that will trigger an error when IPv6 is enabled
## Impact
Only ESP32
## Testing
ESP32-Devkit
--
This is an automated message from the Apach
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 87b2d99 Publishing web
cclauss opened a new pull request #3281:
URL: https://github.com/apache/incubator-nuttx/pull/3281
https://flake8.pycqa.org/en/latest/user/error-codes.html
On the flake8 test selection, this PR does _not_ focus on "_style
violations_" (the majority of flake8 error codes that
[__psf/b
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new af3c76b Correct some getopt() log
Ouss4 merged pull request #3280:
URL: https://github.com/apache/incubator-nuttx/pull/3280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
v01d edited a comment on pull request #92:
URL:
https://github.com/apache/incubator-nuttx-testing/pull/92#issuecomment-812690115
Ok, without changing anything to sim it is now around 40m faster in total
(1:56 down to 1:13). This is the current situation:
. This is the current situation:
![image](https://user-images.githu
v01d commented on pull request #92:
URL:
https://github.com/apache/incubator-nuttx-testing/pull/92#issuecomment-812650261
I've selected just one or two board/config per arch for macos.dat and left
sim the same as a test.
I'm not sure if the syntax `///:` works though.
--
This is an
xiaoxiang781216 commented on pull request #3279:
URL: https://github.com/apache/incubator-nuttx/pull/3279#issuecomment-812603728
@jerpelea there is conflict, please rebase your PR again, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
v01d commented on issue #3157:
URL:
https://github.com/apache/incubator-nuttx/issues/3157#issuecomment-812599727
That is useful to avoid interleaved prints from concurrent tasks. The point
is that a call to syslog corresponds to a complete message so multiple calls
should not be used to c
xiaoxiang781216 commented on pull request #3256:
URL: https://github.com/apache/incubator-nuttx/pull/3256#issuecomment-812599457
@anchao please provide a new patch to update g_white_list in tools/nxstyle.c.
--
This is an automated message from the Apache Git Service.
To respond to the mes
xiaoxiang781216 merged pull request #3277:
URL: https://github.com/apache/incubator-nuttx/pull/3277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit b7c451c5a457352c029f440a5e2ed9f2335cdbc5
Author: Alin Jerpelea
AuthorDate: Fri Apr 2 09:22:52 2021 +0200
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from b10c6d6 board/arm/lpc17xx_40xx/mbed: userled defconfig
new 8975a65 net: fix nxstyle errors
ne
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit d3313eeae96f925e447fc3c43d2a607ba120f283
Author: Alin Jerpelea
AuthorDate: Fri Apr 2 08:57:44 2021 +0200
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit ed8e5e971bf83d80f4ac1517e58a9bdd0331c704
Author: Alin Jerpelea
AuthorDate: Fri Apr 2 07:44:54 2021 +0200
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 8975a651971534c1df3e92e8cb21a0d3c3bad514
Author: Alin Jerpelea
AuthorDate: Fri Apr 2 07:28:21 2021 +0200
xiaoxiang781216 commented on pull request #92:
URL:
https://github.com/apache/incubator-nuttx-testing/pull/92#issuecomment-812577590
> If macos.dat takes around 1hr I don't think there's too much gain from
splitting sim which already takes that long and will run mostly in parallel to
the
patacongo commented on issue #3157:
URL:
https://github.com/apache/incubator-nuttx/issues/3157#issuecomment-812576691
> Otherwise I think that using an internal line buffer is the only solution
if these calls will always be made separately to build the message.
Is this relevant? It
v01d commented on issue #3157:
URL:
https://github.com/apache/incubator-nuttx/issues/3157#issuecomment-812573159
If we knew that the "important" message is emitted only in log_writev I
would simply ignore the other two and add a newline.
@donghengqaz can we assume this? This way we can
v01d commented on pull request #92:
URL:
https://github.com/apache/incubator-nuttx-testing/pull/92#issuecomment-812567555
> > @xiaoxiang781216 VM setup time is minimal. It is best to parallelize
jobs.
>
> It isn't true for macOS since we need install all tools from network for
each
patacongo commented on pull request #3272:
URL: https://github.com/apache/incubator-nuttx/pull/3272#issuecomment-812560087
>
>
> @patacongo a fix as you described in #3241 seems to be working in Xtensa.
I'll do more tests and submit a PR.
There is a an issue with stack checki
patacongo commented on pull request #3272:
URL: https://github.com/apache/incubator-nuttx/pull/3272#issuecomment-812558609
@Ouss4 PR #3280 corrects the problem with the NULL pointer dereference (and
makes other getopt() improvements that you won't really care about).
--
This is an automa
patacongo opened a new pull request #3280:
URL: https://github.com/apache/incubator-nuttx/pull/3280
## Summary
1. Null pointer dereference:
- for (ndx = 0; longopts[ndx].name[0] != '\0'; ndx++)
+ for (ndx = 0; longopts[ndx].name != NULL; ndx++)
2. Handle single char
Ouss4 commented on pull request #3272:
URL: https://github.com/apache/incubator-nuttx/pull/3272#issuecomment-812552522
@patacongo a fix as you described in #3241 seems to be working in Xtensa.
I'll do more tests and submit a PR.
--
This is an automated message from the Apache Git Servic
Ouss4 commented on pull request #3272:
URL: https://github.com/apache/incubator-nuttx/pull/3272#issuecomment-812549141
I tried it with esp32-devkitc:nsh, still got a crash at the same line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
patacongo commented on pull request #3272:
URL: https://github.com/apache/incubator-nuttx/pull/3272#issuecomment-812547652
I do see a problem. Could you try changing line
```
- for (ndx = 0; longopts[ndx].name[0] != '\0'; ndx++)
+ for (ndx = 0; longopts[ndx].name != NULL; ndx
patacongo edited a comment on pull request #3272:
URL: https://github.com/apache/incubator-nuttx/pull/3272#issuecomment-812547652
I do see a problem. Could you try changing line
```
- for (ndx = 0; longopts[ndx].name[0] != '\0'; ndx++)
+ for (ndx = 0; longopts[ndx].name != NU
Ouss4 commented on pull request #3272:
URL: https://github.com/apache/incubator-nuttx/pull/3272#issuecomment-812547102
Yes it's `ls` without any argument. Xtensa has a backtrace builtin, here it
is decoded:
```
0x400d3603: xtensa_assert at xtensa_assert.c:93
0x400d36cd: xtensa
patacongo edited a comment on pull request #3272:
URL: https://github.com/apache/incubator-nuttx/pull/3272#issuecomment-812543185
> @patacongo @xiaoxiang781216 this broke Xtensa and RISC-V (at least
ESP32-C3). Running `ls` for instance is crashing.
> Maybe the issue is related to #3241
patacongo commented on pull request #3272:
URL: https://github.com/apache/incubator-nuttx/pull/3272#issuecomment-812543185
> @patacongo @xiaoxiang781216 this broke Xtensa and RISC-V (at least
ESP32-C3). Running `ls` for instance is crashing.
> Maybe the issue is related to #3241
I
Ouss4 commented on pull request #3272:
URL: https://github.com/apache/incubator-nuttx/pull/3272#issuecomment-812541444
@patacongo @xiaoxiang781216 this broke Xtensa and RISC-V (at least
ESP32-C3). Running `ls` for instance is crashing.
Maybe the issue is related to
https://github.com/
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 84d4458 libc/uio: fix typos
add b10c6d6 board/arm/lpc17xx_40xx/mbed: userled defconfig
No new rev
xiaoxiang781216 merged pull request #3274:
URL: https://github.com/apache/incubator-nuttx/pull/3274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
xiaoxiang781216 commented on pull request #3274:
URL: https://github.com/apache/incubator-nuttx/pull/3274#issuecomment-812539467
No problem, you are welcome to joint the community.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 778f050 arch: xtensa: Author Gregory Nutt: update licenses to Apache
add 84d4458 libc/uio: fix typ
xiaoxiang781216 merged pull request #3278:
URL: https://github.com/apache/incubator-nuttx/pull/3278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
jerpelea commented on pull request #3277:
URL: https://github.com/apache/incubator-nuttx/pull/3277#issuecomment-812528835
please ignore the error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jerpelea commented on pull request #3279:
URL: https://github.com/apache/incubator-nuttx/pull/3279#issuecomment-812524450
please ignore the remaining errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
patacongo commented on pull request #646:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/646#issuecomment-812523031
> @patacongo the patch has nxstyle warning need to be resolved.
Fixed. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to
yamt commented on a change in pull request #566:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/566#discussion_r606210446
##
File path: crypto/mbedtls/Makefile
##
@@ -0,0 +1,85 @@
+
+# apps/c
xiaoxiang781216 commented on a change in pull request #566:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/566#discussion_r606208537
##
File path: crypto/mbedtls/Makefile
##
@@ -0,0 +1,85 @@
+###
acassis commented on a change in pull request #3261:
URL: https://github.com/apache/incubator-nuttx/pull/3261#discussion_r606204897
##
File path: arch/risc-v/src/esp32c3/esp32c3_rng.c
##
@@ -0,0 +1,273 @@
+/***
jerpelea opened a new pull request #3279:
URL: https://github.com/apache/incubator-nuttx/pull/3279
## Summary
Several licenses were missed in the initial work
David Sidrane has submitted the ICLA and we can migrate the licenses to
Apache.
Gregory Nutt has submitted the SGA
yamt commented on a change in pull request #566:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/566#discussion_r606178090
##
File path: crypto/mbedtls/Makefile
##
@@ -0,0 +1,85 @@
+
+# apps/c
walbon commented on pull request #3274:
URL: https://github.com/apache/incubator-nuttx/pull/3274#issuecomment-812469887
well, that`s new for me.
I updated and checked if working well, done.
Thank you @xiaoxiang781216
--
This is an automated message from the Apache Git Servi
yamt commented on issue #3157:
URL:
https://github.com/apache/incubator-nuttx/issues/3157#issuecomment-812462038
i think the fundamental problem is that the expected behavior of these
callbacks are not well documented.
i guess the only thing we can do without having too many assumptions
Ouss4 commented on pull request #3277:
URL: https://github.com/apache/incubator-nuttx/pull/3277#issuecomment-812415496
> > @xiaoxiang781216 I am out of ideas howto fix the remaining nxstyle errors
>
> The error is also strange for me:(, anyway, let's merge the copyright fix
first. We
wswsmao opened a new pull request #3278:
URL: https://github.com/apache/incubator-nuttx/pull/3278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
xiaoxiang781216 commented on pull request #3277:
URL: https://github.com/apache/incubator-nuttx/pull/3277#issuecomment-812410262
@jerpelea some error happen here:
https://github.com/apache/incubator-nuttx/pull/3277/checks?check_run_id=2252301357
--
This is an automated message from th
xiaoxiang781216 commented on pull request #3277:
URL: https://github.com/apache/incubator-nuttx/pull/3277#issuecomment-812410053
> @xiaoxiang781216 I am out of ideas howto fix the remaining nxstyle errors
The error is also strange for me:(, anyway, let's merge the copyright fix
first
xiaoxiang781216 merged pull request #3275:
URL: https://github.com/apache/incubator-nuttx/pull/3275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from a930b05 Implement getopt_long() and getopt_long_only()
add 778f050 arch: xtensa: Author Gregory Nu
jerpelea edited a comment on pull request #3277:
URL: https://github.com/apache/incubator-nuttx/pull/3277#issuecomment-812390478
@xiaoxiang781216 I am out of ideas howto fix the remaining nxstyle errors
--
This is an automated message from the Apache Git Service.
To respond to the message
jerpelea commented on pull request #3277:
URL: https://github.com/apache/incubator-nuttx/pull/3277#issuecomment-812390478
@xiaoxiang781216 i am out of ideas howto fix the remaining nxstyle errors
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
jerpelea opened a new pull request #3277:
URL: https://github.com/apache/incubator-nuttx/pull/3277
## Summary
Gregory Nutt has submitted the SGA and we can migrate the licenses to
Apache.
## Impact
NONE
## Testing
NONE
--
This is an automated message from the
76 matches
Mail list logo
