jerpelea commented on pull request #3236:
URL: https://github.com/apache/incubator-nuttx/pull/3236#issuecomment-809952508
@xiaoxiang781216 comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
xiaoxiang781216 commented on pull request #3239:
URL: https://github.com/apache/incubator-nuttx/pull/3239#issuecomment-809948114
@walbon could you fix the following warning:
```
nuttx/boards/arm/lpc17xx_40xx/mbed/src/lpc17_40_appinit.c:37:1: error: Too
many blank lines
nuttx/boards
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from eced277 boards/nucleo-f446re: register button
add a27d5b1 xtensa/esp32: Remove useless pointer che
xiaoxiang781216 merged pull request #3233:
URL: https://github.com/apache/incubator-nuttx/pull/3233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
jerpelea commented on pull request #3235:
URL: https://github.com/apache/incubator-nuttx/pull/3235#issuecomment-809945801
@xiaoxiang781216 please ignore warning: #include outside of 'Included Files'
section
--
This is an automated message from the Apache Git Service.
To respond to the me
xiaoxiang781216 merged pull request #3229:
URL: https://github.com/apache/incubator-nuttx/pull/3229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 29cdf66 mm/mm_heap: fix compile failed when open DEBUG_MM
add ae28e57 boards/Kconfig: fix typo
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 4306910 stm32/hardware/stm32_tim.h: fix comments
add 29cdf66 mm/mm_heap: fix compile failed when o
xiaoxiang781216 merged pull request #3228:
URL: https://github.com/apache/incubator-nuttx/pull/3228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
xiaoxiang781216 merged pull request #3227:
URL: https://github.com/apache/incubator-nuttx/pull/3227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 1c29a2e net/tcp/tcp_send_buffered.c: Fix non-blocking I/O
add 466ceb9 stm32/Kconfig: cosmetics for
xiaoxiang781216 merged pull request #3221:
URL: https://github.com/apache/incubator-nuttx/pull/3221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from f9997bd risc-v/bl602: fix _heap_start not word align
add ef9adcf tcp_send_buffered.c: Remove dead
xiaoxiang781216 commented on pull request #3221:
URL: https://github.com/apache/incubator-nuttx/pull/3221#issuecomment-809941320
Let's merge this trivial patch directly since the break is a known issue and
was fixed by #3220.
--
This is an automated message from the Apache Git Service.
T
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from c82c7b6 sys/stat.h: Add S_IREAD, S_IWRITE and S_IEXEC macro
add f9997bd risc-v/bl602: fix _heap_st
xiaoxiang781216 commented on pull request #3219:
URL: https://github.com/apache/incubator-nuttx/pull/3219#issuecomment-809940358
Let's merge this trivial patch directly since the break is a known issue and
was fixed by https://github.com/apache/incubator-nuttx/pull/3220.
--
This is an au
xiaoxiang781216 merged pull request #3219:
URL: https://github.com/apache/incubator-nuttx/pull/3219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
xiaoxiang781216 merged pull request #637:
URL: https://github.com/apache/incubator-nuttx-apps/pull/637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about t
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new d3c7508 testing/fstest: Add ha
xiaoxiang781216 edited a comment on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809898417
> It is possible to implement task-specific data without introducing the
asymmetries. Consider the following:
>
> 1. Add a pointer like FAR struct libva
xiaoxiang781216 commented on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809898417
> It is possible to implement task-specific data without introducing the
asymmetries. Consider the following:
>
> 1. Add a pointer like FAR struct libvars_s *l
patacongo commented on issue #3241:
URL:
https://github.com/apache/incubator-nuttx/issues/3241#issuecomment-809886959
Hmmm... this is probably not an issue for some architectures:
up_check_stack)_ and friends are only implemented only for ARM, AVR, OR1K,
RISC-V, sim, xtensa. For the oth
yamt opened a new pull request #3242:
URL: https://github.com/apache/incubator-nuttx/pull/3242
## Summary
net/tcp/tcp.h: Remove unused extern g_netdevices
## Impact
## Testing
build tested sim:vpnkit
--
This is an automated message from the Apache Git Service.
patacongo opened a new issue #3241:
URL: https://github.com/apache/incubator-nuttx/issues/3241
It appears that the stack size used in up_create_stack and up_use_stack
includes the size of the TLS data. This seems to be the case in all
architectures except for ARM where the issue has been
btashton commented on pull request #3240:
URL: https://github.com/apache/incubator-nuttx/pull/3240#issuecomment-809845815
This should be done by changing the Kconfig default otherwise someone
creating a new config will have the same issue you reported.
--
This is an automated message fro
swkim101 opened a new pull request #3240:
URL: https://github.com/apache/incubator-nuttx/pull/3240
## Summary
- fix #3011
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
walbon opened a new pull request #3239:
URL: https://github.com/apache/incubator-nuttx/pull/3239
lpc17_40_userleds.c: Adds the support of Userleds driver which
provides a device to manipulate the 4 leds of the board through the
/dev/userleds.
lpc17_40_leds.c: Removes not used de
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from b16d534 stm32/stm32_serial.c: simplify DMA #ifdefs
add c82c7b6 sys/stat.h: Add S_IREAD, S_IWRITE and
acassis merged pull request #3197:
URL: https://github.com/apache/incubator-nuttx/pull/3197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
acassis merged pull request #3222:
URL: https://github.com/apache/incubator-nuttx/pull/3222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 590ee65 Integration of pysimCoder with NUTTX
add 0cca102 stm32: fix USART1 clock for STM32F302
acassis merged pull request #3218:
URL: https://github.com/apache/incubator-nuttx/pull/3218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 63a4807 stm32/stm32_pwm: add interfaces to access RCR register and
add interface to modify TRGO
add
acassis merged pull request #3223:
URL: https://github.com/apache/incubator-nuttx/pull/3223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 05cf8b8 boards/sim: remove dsptest configuration
add 63a4807 stm32/stm32_pwm: add interfaces to acce
acassis merged pull request #3224:
URL: https://github.com/apache/incubator-nuttx/pull/3224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 94ff456 stm32/stm32_adc.c: move maximum number of samples cfg to
Kconfig.
add 05cf8b8 boards/sim: r
acassis merged pull request #3225:
URL: https://github.com/apache/incubator-nuttx/pull/3225
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 1b8a690 sim: only abort sim in assertion if in interrupt context/IDLE
task
add e10a664 stm32/stm32_
patacongo edited a comment on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809779539
> To me both approaches sound reasonable, the second one being decoupled
from pthread (which can be good, unless the functionality to support this ends
up being the
patacongo edited a comment on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809779539
> To me both approaches sound reasonable, the second one being decoupled
from pthread (which can be good, unless the functionality to support this ends
up being the
patacongo edited a comment on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809779539
> To me both approaches sound reasonable, the second one being decoupled
from pthread (which can be good, unless the functionality to support this ends
up being the
patacongo edited a comment on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809779539
> To me both approaches sound reasonable, the second one being decoupled
from pthread (which can be good, unless the functionality to support this ends
up being the
patacongo commented on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809779539
> To me both approaches sound reasonable, the second one being decoupled
from pthread (which can be good, unless the functionality to support this ends
up being the same a
v01d commented on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809759508
> Environment variables (setenv(), getenv()) is another good example of the
model for OS managment of task-specific user data. This is my preferred
technical approach.
S
yamt commented on pull request #3221:
URL: https://github.com/apache/incubator-nuttx/pull/3221#issuecomment-809758623
> @yamt should we merge the small patch?
i feel they are independent each other.
--
This is an automated message from the Apache Git Service.
To respond to the mess
patacongo edited a comment on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809706113
Environment variables (setenv(), getenv()) is another good example of the
model for OS managment of task-specific user data. This is my preferred
technical approac
patacongo edited a comment on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809706113
Environment variables (setenv(), getenv()) is another good example of the
model for OS engagement of task-specific user data. This is my preferred
technical approa
patacongo edited a comment on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809706113
Environment variables (setenv(), getenv()) is another good example of the
model for OS engagement of task-specific user data
--
This is an automated message f
patacongo commented on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809706113
Environment variables (setenv(), getenv()) is another good example of the
model for OS managment of user data
--
This is an automated message from the Apache Git Ser
patacongo commented on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809699196
It is possible to implement task-specific data without introducing the
asymmetries. Consider the following:
1. Add a pointer like FAR struct libvars_s *libvars to t
gustavonihei opened a new pull request #3238:
URL: https://github.com/apache/incubator-nuttx/pull/3238
## Summary
This PR intends to disable the unnecessary SPI device driver from the `nsh`
configuration of ESP32 boards:
- `esp32-devkitc`
- `esp32-ethernet-kit`
- `esp32-wrover-k
patacongo edited a comment on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809675860
>
>
> @xiaoxiang781216 do you have plans to move forward with this issue? would
be good to reach a solution.
My objection to implementing this is that
patacongo edited a comment on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809675860
>
>
> @xiaoxiang781216 do you have plans to move forward with this issue? would
be good to reach a solution.
My objection to implementing this is that
patacongo commented on issue #3168:
URL:
https://github.com/apache/incubator-nuttx/issues/3168#issuecomment-809675860
>
>
> @xiaoxiang781216 do you have plans to move forward with this issue? would
be good to reach a solution.
My objection to implementing this is that I do n
Ouss4 commented on pull request #3190:
URL: https://github.com/apache/incubator-nuttx/pull/3190#issuecomment-809628984
@cwespressif please rebase this branch. There was an issue with an STM32
configuration that seems to be fixed now.
--
This is an automated message from the Apache Git S
davids5 commented on pull request #3237:
URL: https://github.com/apache/incubator-nuttx/pull/3237#issuecomment-809617910
si
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
hartmannathan commented on pull request #3237:
URL: https://github.com/apache/incubator-nuttx/pull/3237#issuecomment-809617772
> LGTM
Race condition! :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hartmannathan commented on pull request #3237:
URL: https://github.com/apache/incubator-nuttx/pull/3237#issuecomment-809617549
Oops looks like duplicated work already done by @jerpelea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
hartmannathan closed pull request #3237:
URL: https://github.com/apache/incubator-nuttx/pull/3237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this s
hartmannathan opened a new pull request #3237:
URL: https://github.com/apache/incubator-nuttx/pull/3237
## Summary
Fix nxstyle errors in arch/arm/src/stm32h7/stm32_otgdev.c.
## Impact
Removes nxstyle errors.
## Testing
nxstyle
--
This is an automated mes
jerpelea opened a new pull request #3236:
URL: https://github.com/apache/incubator-nuttx/pull/3236
## Summary
Gregory Nutt has submitted the SGA and we can migrate the licenses to Apache.
## Impact
NONE
## Testing
NONE
--
This is an automated message from the Ap
jerpelea opened a new pull request #3235:
URL: https://github.com/apache/incubator-nuttx/pull/3235
## Summary
Gregory Nutt has submitted the SGA and we can migrate the licenses to Apache.
## Impact
NONE
## Testing
NONE
--
This is an automated message from the Ap
raiden00pl commented on pull request #3230:
URL: https://github.com/apache/incubator-nuttx/pull/3230#issuecomment-809596054
Here the code on the application side:
1. FOC library -
https://github.com/raiden00pl/incubator-nuttx-apps/commit/e176bfaf827064d4f7e5eaab85a4b384bf1c
2. FOC
raiden00pl commented on pull request #3230:
URL: https://github.com/apache/incubator-nuttx/pull/3230#issuecomment-809593070
> > @acassis Previously, I kept it under drivers/power, but I decide to move
it somewhere else. I was thinking about drivers/motor or drivers/industrial,
but just lea
raiden00pl commented on a change in pull request #3230:
URL: https://github.com/apache/incubator-nuttx/pull/3230#discussion_r603499866
##
File path: include/nuttx/foc/foc.h
##
@@ -0,0 +1,158 @@
+/
+ * i
raiden00pl commented on pull request #3230:
URL: https://github.com/apache/incubator-nuttx/pull/3230#issuecomment-809579973
> * it seems the driver is only responsible to abstract typical FOC hardware
operations, right? So lower half implementations are just expected to provide
motor phase
davids5 commented on a change in pull request #3230:
URL: https://github.com/apache/incubator-nuttx/pull/3230#discussion_r603481774
##
File path: Documentation/components/drivers/character/foc.rst
##
@@ -0,0 +1,48 @@
+
+FOC Driver Interface
+
v01d commented on pull request #3230:
URL: https://github.com/apache/incubator-nuttx/pull/3230#issuecomment-809570712
> @acassis Previously, I kept it under drivers/power, but I decide to move
it somewhere else. I was thinking about drivers/motor or drivers/industrial,
but just leave it un
xiaoxiang781216 commented on a change in pull request #3226:
URL: https://github.com/apache/incubator-nuttx/pull/3226#discussion_r603481879
##
File path: drivers/syslog/syslog_channel.c
##
@@ -44,9 +44,7 @@
* Private Function Prototypes
*
raiden00pl commented on pull request #3230:
URL: https://github.com/apache/incubator-nuttx/pull/3230#issuecomment-809563143
@acassis Previously, I kept it under drivers/power, but I decide to move it
somewhere else. I was thinking about drivers/motor or drivers/industrial, but
just leave i
uLipe commented on a change in pull request #3230:
URL: https://github.com/apache/incubator-nuttx/pull/3230#discussion_r603477296
##
File path: include/nuttx/foc/foc.h
##
@@ -0,0 +1,158 @@
+/
+ * includ
acassis commented on a change in pull request #3230:
URL: https://github.com/apache/incubator-nuttx/pull/3230#discussion_r603467517
##
File path: drivers/Kconfig
##
@@ -130,3 +130,4 @@ source drivers/syslog/Kconfig
source drivers/platform/Kconfig
source drivers/rf/Kconfig
so
raiden00pl commented on pull request #639:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/639#issuecomment-809547707
https://github.com/apache/incubator-nuttx/pull/3224 must be merged first
--
This is an automated message from the Apache Git Service.
To respond to the message,
acassis commented on pull request #3230:
URL: https://github.com/apache/incubator-nuttx/pull/3230#issuecomment-809541635
@uLipe could you please help reviewing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
raiden00pl opened a new pull request #3234:
URL: https://github.com/apache/incubator-nuttx/pull/3234
## Summary
IHM07M1 board: https://www.st.com/en/ecosystems/x-nucleo-ihm07m1.html
IHM08M1 board: https://www.st.com/en/ecosystems/x-nucleo-ihm08m1.html
Depends on https://github.c
acassis commented on pull request #3230:
URL: https://github.com/apache/incubator-nuttx/pull/3230#issuecomment-809536348
@raiden00pl instead creating a drivers/foc I suggest to create a more
generic name inside drivers: drivers/motor and inside it put the foc/
directory. Then we could impl
gustavonihei opened a new pull request #3233:
URL: https://github.com/apache/incubator-nuttx/pull/3233
## Summary
This PR intends to address two issues and bring two small improvements to
the ESP32 SPI driver:
**Bugfixes**:
1) For SPI SNDBLOCK operations, RX Buffer will be NULL
raiden00pl opened a new pull request #3232:
URL: https://github.com/apache/incubator-nuttx/pull/3232
## Summary
This PR adds the lower-half FOC implementation for STM32.
Up to 2 FOC instances supported.
Tested only with 3-phase motors.
Not tested for STM32G4xx yet.
Depends
btashton commented on pull request #591:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/591#issuecomment-809525583
Sorry... A lot of these are repeated and from the original code and so I
searched and must have missed a few. I'll try and update later.
--
This is an automated
gustavonihei commented on pull request #591:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/591#issuecomment-809523960
> > Some of my previous comments were not addressed. Also there some other
minor issues that may be fixed to improve the overall code quality.
>
> Sorry a
gustavonihei commented on a change in pull request #591:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/591#discussion_r603438521
##
File path: examples/lvgldemo/lcddev.c
##
@@ -0,0 +1,197 @@
+/*
gustavonihei commented on a change in pull request #591:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/591#discussion_r603438384
##
File path: examples/lvgldemo/lcddev.c
##
@@ -0,0 +1,197 @@
+/*
gustavonihei commented on a change in pull request #591:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/591#discussion_r603435358
##
File path: examples/lvgldemo/lvgldemo.c
##
@@ -153,16 +172,29 @@ int main(int argc, FAR char *argv[])
lv_init();
- /* Display
raiden00pl opened a new pull request #3231:
URL: https://github.com/apache/incubator-nuttx/pull/3231
## Summary
This PR adds the simulated lower-half FOC device.
Depends on https://github.com/apache/incubator-nuttx/pull/3230
## Impact
## Testing
--
This is
v01d commented on a change in pull request #591:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/591#discussion_r603430909
##
File path: examples/lvgldemo/lvgldemo.c
##
@@ -153,16 +172,29 @@ int main(int argc, FAR char *argv[])
lv_init();
- /* Display interfac
btashton edited a comment on issue #3216:
URL:
https://github.com/apache/incubator-nuttx/issues/3216#issuecomment-809511864
> > I'm wondering if this will require repeating the build but with debug
assertions (and other features) on, for example. Otherwise we may not catch all
errors (onl
btashton commented on issue #3216:
URL:
https://github.com/apache/incubator-nuttx/issues/3216#issuecomment-809511864
> > I'm wondering if this will require repeating the build but with debug
assertions (and other features) on, for example. Otherwise we may not catch all
errors (only those
btashton commented on a change in pull request #591:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/591#discussion_r603423670
##
File path: examples/lvgldemo/lvgldemo.c
##
@@ -153,16 +172,29 @@ int main(int argc, FAR char *argv[])
lv_init();
- /* Display inte
raiden00pl opened a new pull request #3230:
URL: https://github.com/apache/incubator-nuttx/pull/3230
## Summary
This PR adds generic upper-half driver for Field Oriented Control (FOC).
Most logic for this type of devices will be implemented as a lower-half
device.
In the next PRs,
v01d commented on a change in pull request #591:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/591#discussion_r603419396
##
File path: examples/lvgldemo/lvgldemo.c
##
@@ -153,16 +172,29 @@ int main(int argc, FAR char *argv[])
lv_init();
- /* Display interfac
fjpanag commented on a change in pull request #3226:
URL: https://github.com/apache/incubator-nuttx/pull/3226#discussion_r603417101
##
File path: drivers/syslog/syslog_channel.c
##
@@ -44,9 +44,7 @@
* Private Function Prototypes
*
fjpanag commented on a change in pull request #3226:
URL: https://github.com/apache/incubator-nuttx/pull/3226#discussion_r603417101
##
File path: drivers/syslog/syslog_channel.c
##
@@ -44,9 +44,7 @@
* Private Function Prototypes
*
fjpanag commented on a change in pull request #3226:
URL: https://github.com/apache/incubator-nuttx/pull/3226#discussion_r603414103
##
File path: drivers/syslog/syslog_channel.c
##
@@ -44,9 +44,7 @@
* Private Function Prototypes
*
fjpanag commented on a change in pull request #3226:
URL: https://github.com/apache/incubator-nuttx/pull/3226#discussion_r603414103
##
File path: drivers/syslog/syslog_channel.c
##
@@ -44,9 +44,7 @@
* Private Function Prototypes
*
btashton commented on pull request #591:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/591#issuecomment-809492792
> Some of my previous comments were not addressed. Also there some other
minor issues that may be fixed to improve the overall code quality.
Sorry about that.
btashton commented on a change in pull request #591:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/591#discussion_r603408704
##
File path: examples/lvgldemo/lvgldemo.c
##
@@ -153,16 +172,29 @@ int main(int argc, FAR char *argv[])
lv_init();
- /* Display inte
fjpanag commented on a change in pull request #3226:
URL: https://github.com/apache/incubator-nuttx/pull/3226#discussion_r603400585
##
File path: arch/arm/src/armv7-m/arm_itm_syslog.c
##
@@ -106,8 +107,10 @@ static const struct syslog_channel_s g_itm_channel =
*
***
hartmannathan commented on a change in pull request #3198:
URL: https://github.com/apache/incubator-nuttx/pull/3198#discussion_r603394267
##
File path: boards/arm/stm32h7/nucleo-h743zi/scripts/flash.ld
##
@@ -172,9 +172,12 @@ SECTIONS
/* Emit the the D3 power domain sect
hartmannathan commented on a change in pull request #3198:
URL: https://github.com/apache/incubator-nuttx/pull/3198#discussion_r603389785
##
File path: boards/arm/stm32h7/nucleo-h743zi/scripts/flash.ld
##
@@ -172,9 +172,12 @@ SECTIONS
/* Emit the the D3 power domain sect
1 - 100 of 199 matches
Mail list logo
