[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594902175 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_pinmap.h ## @@ -0,0 +1,745 @@ +/***

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594901666 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_rcc.h ## @@ -0,0 +1,867 @@ +/**

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594900877 ## File path: arch/arm/src/stm32l5/stm32l5_lse.c ## @@ -0,0 +1,166 @@ +/***

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594900312 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_pinmap.h ## @@ -0,0 +1,745 @@ +/***

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594899319 ## File path: arch/arm/src/stm32l5/hardware/stm32l5_exti.h ## @@ -0,0 +1,119 @@ +/*

[GitHub] [incubator-nuttx] JanStaschulat commented on issue #2935: Bug: sporadic scheduling does not work for multiple threads

2021-03-15 Thread GitBox
JanStaschulat commented on issue #2935: URL: https://github.com/apache/incubator-nuttx/issues/2935#issuecomment-71119 Will this bug be fixed? This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #611: iperf: plug memory leaks

2021-03-15 Thread GitBox
yamt opened a new pull request #611: URL: https://github.com/apache/incubator-nuttx-apps/pull/611 ## Summary iperf: plug memory leaks ## Impact ## Testing tested locally on an esp32 board This is an automated

[GitHub] [incubator-nuttx] yamt opened a new pull request #3072: Fix typos in IOB Kconfig and comment

2021-03-15 Thread GitBox
yamt opened a new pull request #3072: URL: https://github.com/apache/incubator-nuttx/pull/3072 ## Summary Fix typos in IOB Kconfig and comment ## Impact ## Testing build-tested This is an automated message

[GitHub] [incubator-nuttx] yamt commented on pull request #2063: Fix libcxx for sim/macOS

2021-03-15 Thread GitBox
yamt commented on pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#issuecomment-799950976 > Not yet, but the keypoint for macOS/Linux is same: how to avoid the host startup code initialize NuttX's c++ constructor. > > The approach selected on Linux is to r

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2063: Fix libcxx for sim/macOS

2021-03-15 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#issuecomment-799925357 Not yet, but the keypoint for macOS/Linux is same: how to avoid the host startup code initialize NuttX's c++ constructor. The approach selected on L

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2063: Fix libcxx for sim/macOS

2021-03-15 Thread GitBox
xiaoxiang781216 commented on pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#issuecomment-799925357 Not yet, but the keypoint for macOS/Linux is same: how to avoid the host startup code initialize NuttX's c++ constructor. The approach selected on Linux is to

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-15 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070#discussion_r594823722 ## File path: fs/mmap/fs_mmap.c ## @@ -142,6 +148,30 @@ FAR void *mmap(FAR void *start, size_t length, int prot, int flags, } #endi

[incubator-nuttx] branch master updated (4cde8da -> ecb9e03)

2021-03-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 4cde8da boards/esp32-wrover-kit: Mount tmpfs on bring up new 00d9f81 fs/mmap: Clarify MAP_PRIVATE

[incubator-nuttx] 01/02: fs/mmap: Clarify MAP_PRIVATE dependency on CONFIG_FS_RAMMAP

2021-03-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 00d9f8191954c7e6f90a6c5ba5e20f575b44fe70 Author: Gustavo Henrique Nihei AuthorDate: Mon Mar 15 16:35:30 2021

[incubator-nuttx] branch master updated (8cf752d -> 4cde8da)

2021-03-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 8cf752d nucleo-f446re: refactor bringup logic for consistency with other boards add a3f6a5f board

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3069: fs/mmap: Clarify MAP_PRIVATE dependency on CONFIG_FS_RAMMAP

2021-03-15 Thread GitBox
xiaoxiang781216 merged pull request #3069: URL: https://github.com/apache/incubator-nuttx/pull/3069 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] 02/02: fs/mmap: Update mmap documentation of possible return values

2021-03-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit ecb9e03a7f2a6d1de8327b98495711318b526a53 Author: Gustavo Henrique Nihei AuthorDate: Mon Mar 15 17:26:34 2021

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3071: ESP32: Mount TMPFS on board bring up

2021-03-15 Thread GitBox
xiaoxiang781216 merged pull request #3071: URL: https://github.com/apache/incubator-nuttx/pull/3071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3068: lpc17xx_40xx/mbed : refresh defconfig

2021-03-15 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3068: URL: https://github.com/apache/incubator-nuttx/pull/3068#discussion_r594827055 ## File path: boards/arm/lpc17xx_40xx/mbed/configs/nsh/defconfig ## @@ -20,7 +20,7 @@ CONFIG_ARCH_CHIP="lpc17xx_40xx" CONFIG_ARCH_CHIP_LP

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-15 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070#discussion_r594823722 ## File path: fs/mmap/fs_mmap.c ## @@ -142,6 +148,30 @@ FAR void *mmap(FAR void *start, size_t length, int prot, int flags, } #endi

[GitHub] [incubator-nuttx] donghengqaz commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
donghengqaz commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594822921 ## File path: arch/risc-v/Kconfig ## @@ -45,6 +45,12 @@ config ARCH_CHIP_ESP32C3 select RV32IM_HW_MULDIV select ARCH_VECNOTIRQ

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3065: symtabs: remove leading underscores

2021-03-15 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3065: URL: https://github.com/apache/incubator-nuttx/pull/3065#discussion_r594822726 ## File path: binfmt/Kconfig ## @@ -75,3 +75,11 @@ config SYMTAB_ORDEREDBYNAME the logic can perform faster lookups using

[GitHub] [incubator-nuttx] yamt commented on pull request #2063: Fix libcxx for sim/macOS

2021-03-15 Thread GitBox
yamt commented on pull request #2063: URL: https://github.com/apache/incubator-nuttx/pull/2063#issuecomment-799900011 @xiaoxiang781216 do you have any updates? This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-nuttx] codebje commented on a change in pull request #3065: symtabs: remove leading underscores

2021-03-15 Thread GitBox
codebje commented on a change in pull request #3065: URL: https://github.com/apache/incubator-nuttx/pull/3065#discussion_r594756394 ## File path: binfmt/Kconfig ## @@ -75,3 +75,11 @@ config SYMTAB_ORDEREDBYNAME the logic can perform faster lookups using a binary

[GitHub] [incubator-nuttx] yunkya2 commented on a change in pull request #3067: boards/raspberrypi-pico: Pico Display Pack (ST7789 LCD) support

2021-03-15 Thread GitBox
yunkya2 commented on a change in pull request #3067: URL: https://github.com/apache/incubator-nuttx/pull/3067#discussion_r594744602 ## File path: boards/arm/rp2040/common/src/rp2040_st7789.c ## @@ -0,0 +1,124 @@ +/

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #3071: ESP32: Mount TMPFS on board bring up

2021-03-15 Thread GitBox
gustavonihei opened a new pull request #3071: URL: https://github.com/apache/incubator-nuttx/pull/3071 ## Summary This PR intends to add the functionality of mounting a TMPFS directory on board bring up when CONFIG_FS_TMPFS is enabled. ## Impact New feature, will only take effe

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #3070: fs/mmap: Return EACCES for incompatible file descriptors

2021-03-15 Thread GitBox
gustavonihei opened a new pull request #3070: URL: https://github.com/apache/incubator-nuttx/pull/3070 ## Summary This PR intends to improve `mmap` compliance to OpenGroup specification. The standard expects that `mmap` return EACCES error code when a given file descriptor lacks the p

[GitHub] [incubator-nuttx] gustavonihei opened a new pull request #3069: fs/mmap: Clarify MAP_PRIVATE dependency on CONFIG_FS_RAMMAP

2021-03-15 Thread GitBox
gustavonihei opened a new pull request #3069: URL: https://github.com/apache/incubator-nuttx/pull/3069 ## Summary This MR intends to fix a misleading reported error when `mmap` is called with the MAP_PRIVATE flag and CONFIG_FS_RAMMAP is not enabled. A simple refactor on `fs_mmap.c

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594700502 ## File path: arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.h ## @@ -0,0 +1,242 @@ +/*

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594700399 ## File path: arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.h ## @@ -0,0 +1,242 @@ +/*

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594700324 ## File path: arch/risc-v/src/esp32c3/esp32c3_wifi_adapter.h ## @@ -0,0 +1,242 @@ +/*

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594700129 ## File path: boards/risc-v/esp32c3/esp32c3-devkit/src/esp32c3_bringup.c ## @@ -143,6 +145,15 @@ int esp32c3_bringup(void) } #endif +

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594700037 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594699749 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594699355 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594699263 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594699190 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594697787 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r59469 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594698797 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594698142 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594698354 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594698142 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594697787 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594697787 ## File path: arch/risc-v/src/esp32c3/Kconfig ## @@ -283,4 +297,84 @@ endif # ESP32C3_UART1 endmenu +menu "Real-Time Timer" + depe

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
davids5 commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594491892 ## File path: arch/arm/src/stm32l5/hardware/stm32l5_exti.h ## @@ -0,0 +1,119 @@ +/

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594697180 ## File path: arch/risc-v/Kconfig ## @@ -45,6 +45,12 @@ config ARCH_CHIP_ESP32C3 select RV32IM_HW_MULDIV select ARCH_VECNOTIR

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #3040: riscv/esp32c3: Add ESP32-C3 WLAN netcard driver

2021-03-15 Thread GitBox
gustavonihei commented on a change in pull request #3040: URL: https://github.com/apache/incubator-nuttx/pull/3040#discussion_r594697180 ## File path: arch/risc-v/Kconfig ## @@ -45,6 +45,12 @@ config ARCH_CHIP_ESP32C3 select RV32IM_HW_MULDIV select ARCH_VECNOTIR

[GitHub] [incubator-nuttx] walbon opened a new pull request #3068: lpc17xx_40xx/mbed : refresh defconfig

2021-03-15 Thread GitBox
walbon opened a new pull request #3068: URL: https://github.com/apache/incubator-nuttx/pull/3068 ## Summary Previously the defconfig was setting the toolchain from the buildroot, so if the user follow the steps in the documentation [1], the user will got an error from building step when

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3050: Added support for multiple syslog channels.

2021-03-15 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3050: URL: https://github.com/apache/incubator-nuttx/pull/3050#discussion_r594601995 ## File path: drivers/syslog/syslog_channel.c ## @@ -141,8 +145,14 @@ int syslog_channel(FAR const struct syslog_channel_s *channel)

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #3050: Added support for multiple syslog channels.

2021-03-15 Thread GitBox
fjpanag commented on a change in pull request #3050: URL: https://github.com/apache/incubator-nuttx/pull/3050#discussion_r594583999 ## File path: drivers/syslog/syslog_channel.c ## @@ -141,8 +145,14 @@ int syslog_channel(FAR const struct syslog_channel_s *channel) {

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #3067: boards/raspberrypi-pico: Pico Display Pack (ST7789 LCD) support

2021-03-15 Thread GitBox
acassis commented on a change in pull request #3067: URL: https://github.com/apache/incubator-nuttx/pull/3067#discussion_r594502612 ## File path: boards/arm/rp2040/common/src/rp2040_st7789.c ## @@ -0,0 +1,124 @@ +/

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
davids5 commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594486139 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_pinmap.h ## @@ -0,0 +1,745 @@ +/**

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594484069 ## File path: arch/arm/src/stm32l5/hardware/stm32l5_exti.h ## @@ -0,0 +1,119 @@ +/*

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594482692 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_pinmap.h ## @@ -0,0 +1,745 @@ +/***

[GitHub] [incubator-nuttx] michi-jung commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
michi-jung commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594481677 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_pinmap.h ## @@ -0,0 +1,745 @@ +/***

[incubator-nuttx] branch master updated (13816de -> 8cf752d)

2021-03-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 13816de arch/stm32f7: Fix nxstyle errors add dab6140 nucleo-f302r8: refactor bringup logic for con

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3064: boards: refactor for nucleo-f446re and nucleo-f302r8 boards

2021-03-15 Thread GitBox
xiaoxiang781216 merged pull request #3064: URL: https://github.com/apache/incubator-nuttx/pull/3064 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated: arch/stm32f7: Fix nxstyle errors

2021-03-15 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 13816de arch/stm32f7: Fix nxstyle er

[GitHub] [incubator-nuttx] jerpelea merged pull request #3066: arch/stm32f7: Fix nxstyle errors

2021-03-15 Thread GitBox
jerpelea merged pull request #3066: URL: https://github.com/apache/incubator-nuttx/pull/3066 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] yunkya2 opened a new pull request #3067: boards/raspberrypi-pico: Pico Display Pack (ST7789 LCD) support

2021-03-15 Thread GitBox
yunkya2 opened a new pull request #3067: URL: https://github.com/apache/incubator-nuttx/pull/3067 ## Summary - Add Raspberry Pi Pico Display Pack (ST7789 LCD) support. - Modify ST7789 LCD driver to support X/Y offset and landscape configuration because Display Pack requires them.

[GitHub] [incubator-nuttx] acassis commented on issue #2988: STM32L151 I2C problems

2021-03-15 Thread GitBox
acassis commented on issue #2988: URL: https://github.com/apache/incubator-nuttx/issues/2988#issuecomment-799482697 Yes, you are right @ReimuNotMoe the NuttX i2ctool needs to duplicate the Linux i2ctool. People can see NuttX as a Linux-like for microcontroler! ;-) ---

[GitHub] [incubator-nuttx] ReimuNotMoe edited a comment on issue #2988: STM32L151 I2C problems

2021-03-15 Thread GitBox
ReimuNotMoe edited a comment on issue #2988: URL: https://github.com/apache/incubator-nuttx/issues/2988#issuecomment-799475511 > Hi @ReimuNotMoe I just ordered some MCP23017 modules to test. It is not clear for me what is the expected behavior of the i2ctool dump. I mean the NuttX i

[GitHub] [incubator-nuttx] ReimuNotMoe commented on issue #2988: STM32L151 I2C problems

2021-03-15 Thread GitBox
ReimuNotMoe commented on issue #2988: URL: https://github.com/apache/incubator-nuttx/issues/2988#issuecomment-799475511 > Hi @ReimuNotMoe I just ordered some MCP23017 modules to test. It is not clear for me what is the expected behavior of the i2ctool dump. I mean the NuttX i2ctool

[GitHub] [incubator-nuttx-apps] lukegluke commented on pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n

2021-03-15 Thread GitBox
lukegluke commented on pull request #586: URL: https://github.com/apache/incubator-nuttx-apps/pull/586#issuecomment-799442901 Yes you're right, I see. But as it seemed to me that previously netinit_bringup was also in nsh, so it is another problem. I didn't get deep into history of this i

[GitHub] [incubator-nuttx] michi-jung commented on pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
michi-jung commented on pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#issuecomment-799442242 Hi @acassis, I will try to resolve @davids5's review comments tonight. Once that is done its fine with me to go ahead and merge it. Thanks! -

[GitHub] [incubator-nuttx-apps] acassis commented on pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n

2021-03-15 Thread GitBox
acassis commented on pull request #586: URL: https://github.com/apache/incubator-nuttx-apps/pull/586#issuecomment-799436034 > @acassis I had found it by git blame for that time, but I can't say it to you now. > Why not just moved netinit_bringup() code to main(int argc, FAR char *argv[

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #3066: arch/stm32f7: Fix nxstyle errors

2021-03-15 Thread GitBox
hartmannathan opened a new pull request #3066: URL: https://github.com/apache/incubator-nuttx/pull/3066 ## Summary Fix nxstyle errors in: - arch/arm/include/stm32f7/chip.h - arch/arm/include/stm32f7/irq.h - arch/arm/include/stm32f7/stm32f72xx73xx_irq.h - arch/arm/include/s

[GitHub] [incubator-nuttx-apps] acassis commented on pull request #591: lvgldemo: Add support for lcddev

2021-03-15 Thread GitBox
acassis commented on pull request #591: URL: https://github.com/apache/incubator-nuttx-apps/pull/591#issuecomment-799418267 It is reporting an issue on mkfatfs: ``` In file included from mkfatfs.c:32: mkfatfs.c: In function 'mkfatfs_getgeometry': Error: mkfatfs.c:156:16: error:

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
davids5 commented on a change in pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#discussion_r594316975 ## File path: arch/arm/src/stm32l5/hardware/stm32l562xx_rcc.h ## @@ -0,0 +1,867 @@ +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3065: symtabs: remove leading underscores

2021-03-15 Thread GitBox
xiaoxiang781216 commented on a change in pull request #3065: URL: https://github.com/apache/incubator-nuttx/pull/3065#discussion_r594313483 ## File path: binfmt/Kconfig ## @@ -75,3 +75,11 @@ config SYMTAB_ORDEREDBYNAME the logic can perform faster lookups using

[GitHub] [incubator-nuttx] raiden00pl commented on pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
raiden00pl commented on pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#issuecomment-799398180 I looked through most of the files and LGTM This is an automated message from the Apache Git Service.

[GitHub] [incubator-nuttx] acassis edited a comment on pull request #3055: Integrate nuttx and pysimCoder

2021-03-15 Thread GitBox
acassis edited a comment on pull request #3055: URL: https://github.com/apache/incubator-nuttx/pull/3055#issuecomment-799393209 Hi @robertobucher you didn't need to close the PR, you can use "git rebase -i HEAD~N" to squash the commits (where N is the number of commits you want to modify)

[GitHub] [incubator-nuttx-apps] lukegluke commented on pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n

2021-03-15 Thread GitBox
lukegluke commented on pull request #586: URL: https://github.com/apache/incubator-nuttx-apps/pull/586#issuecomment-799393611 @acassis I had found it by git blame for that time, but I can't say it to you now. Why not just moved netinit_bringup() code to main(int argc, FAR char *argv[])

[GitHub] [incubator-nuttx] acassis commented on pull request #3055: Integrate nuttx and pysimCoder

2021-03-15 Thread GitBox
acassis commented on pull request #3055: URL: https://github.com/apache/incubator-nuttx/pull/3055#issuecomment-799393209 Hi @robertobucher you didn't need to close the PR, you can use "git rebase -1 HEAD~N" to squash the commits (where N is the number of commits you want to modify) -

[GitHub] [incubator-nuttx] codebje opened a new pull request #3065: symtabs: remove leading underscores

2021-03-15 Thread GitBox
codebje opened a new pull request #3065: URL: https://github.com/apache/incubator-nuttx/pull/3065 ## Summary Adds `CONFIG_SYMTAB_DECORATED` to control stripping leading underscores from symbols imported into relocatable objects. ## Impact Allows Elf objects compiled wit

[GitHub] [incubator-nuttx-apps] acassis commented on pull request #586: nshlib: Fix the build break in nsh_telnetd.c when CONFIG_NSH_CONSOLE=n

2021-03-15 Thread GitBox
acassis commented on pull request #586: URL: https://github.com/apache/incubator-nuttx-apps/pull/586#issuecomment-799388395 @lukegluke about #584 do you know which PR broke it? Maybe we could revert the offending PR until we have telnet working with it again.

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #3064: boards: refactor for nucleo-f446re and nucleo-f302r8 boards

2021-03-15 Thread GitBox
raiden00pl opened a new pull request #3064: URL: https://github.com/apache/incubator-nuttx/pull/3064 ## Summary - nucleo-f302r8: refactor bringup logic for consistency with other boards - nucleo-f446re: move clock configuration to board.h for consistency with other boards - nucleo-

[GitHub] [incubator-nuttx] acassis commented on pull request #2974: STM32L5 Architecture Support

2021-03-15 Thread GitBox
acassis commented on pull request #2974: URL: https://github.com/apache/incubator-nuttx/pull/2974#issuecomment-799383248 Hi @michi-jung except from Haltian licensing issue, is there something else missing to merge it? I'm considering to move ahead and later when Haltian submit the SGA we f

[incubator-nuttx-testing] branch master updated: testlist: Remove gapuino and nr5m100-nexys4 from black list

2021-03-15 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git The following commit(s) were added to refs/heads/master by this push: new 400abdc testlist: Remove gapu

[GitHub] [incubator-nuttx-testing] davids5 merged pull request #91: testlist: Remove gapuino and nr5m100-nexys4 from black list

2021-03-15 Thread GitBox
davids5 merged pull request #91: URL: https://github.com/apache/incubator-nuttx-testing/pull/91 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3062: tcp_sendfile.c: Remove an unused copy of CONFIG_NET_TCP_SPLIT_SIZE

2021-03-15 Thread GitBox
xiaoxiang781216 merged pull request #3062: URL: https://github.com/apache/incubator-nuttx/pull/3062 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated: tcp_sendfile.c: Remove an unused copy of CONFIG_NET_TCP_SPLIT_SIZE

2021-03-15 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 4509876 tcp_sendfile.c: Remove an u

[GitHub] [incubator-nuttx] robertobucher opened a new pull request #3063: Integration between nuttx and pysimCoder

2021-03-15 Thread GitBox
robertobucher opened a new pull request #3063: URL: https://github.com/apache/incubator-nuttx/pull/3063 ## Summary First try to integrate pysimCoder and nuttx in order to automatically generate code for control purposes There is a correction in two files by adding "#include "stm32

[GitHub] [incubator-nuttx] robertobucher closed pull request #3055: Integrate nuttx and pysimCoder

2021-03-15 Thread GitBox
robertobucher closed pull request #3055: URL: https://github.com/apache/incubator-nuttx/pull/3055 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [incubator-nuttx-testing] xiaoxiang781216 opened a new pull request #91: testlist: Remove gapuino and nr5m100-nexys4 from black list

2021-03-15 Thread GitBox
xiaoxiang781216 opened a new pull request #91: URL: https://github.com/apache/incubator-nuttx-testing/pull/91 ## Summary since both platform support are removed from mainline ## Impact No, we never build these platform before. ## Testing

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #3055: Integrate nuttx and pysimCoder

2021-03-15 Thread GitBox
xiaoxiang781216 edited a comment on pull request #3055: URL: https://github.com/apache/incubator-nuttx/pull/3055#issuecomment-799284211 @robertobucher it's better to fix the style and copyright issue in the corresponding patch, to avoid the issue still exist in the individual patch. -

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #3055: Integrate nuttx and pysimCoder

2021-03-15 Thread GitBox
xiaoxiang781216 commented on pull request #3055: URL: https://github.com/apache/incubator-nuttx/pull/3055#issuecomment-799284211 @robertobucher it's better to fix the style and copyright issue in the corresponding patch, to avoid the issue exist in the individual patch. --

[GitHub] [incubator-nuttx] yamt opened a new pull request #3062: tcp_sendfile.c: Remove an unused copy of CONFIG_NET_TCP_SPLIT_SIZE

2021-03-15 Thread GitBox
yamt opened a new pull request #3062: URL: https://github.com/apache/incubator-nuttx/pull/3062 ## Summary tcp_sendfile.c: Remove an unused copy of CONFIG_NET_TCP_SPLIT_SIZE ## Impact ## Testing build tested ---