[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #537: testing/irtest: Remove an unused function

2020-12-21 Thread GitBox
xiaoxiang781216 commented on a change in pull request #537: URL: https://github.com/apache/incubator-nuttx-apps/pull/537#discussion_r547121182 ## File path: testing/irtest/cmd.cpp ## @@ -69,20 +69,6 @@ static void print_cmd(const cmd *cmd) printf(")\n"); } -static int pr

[GitHub] [incubator-nuttx] yamt commented on pull request #2111: LIBCXX related fixes

2020-12-21 Thread GitBox
yamt commented on pull request #2111: URL: https://github.com/apache/incubator-nuttx/pull/2111#issuecomment-749399977 > My point is that it's strange why your version still default to c++98. ok. i agree it's strange. maybe apple is more picky about compatibility than the upstream?

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #537: testing/irtest: Remove an unused function

2020-12-21 Thread GitBox
xiaoxiang781216 commented on a change in pull request #537: URL: https://github.com/apache/incubator-nuttx-apps/pull/537#discussion_r547120745 ## File path: testing/irtest/cmd.cpp ## @@ -69,20 +69,6 @@ static void print_cmd(const cmd *cmd) printf(")\n"); } -static int pr

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2111: LIBCXX related fixes

2020-12-21 Thread GitBox
xiaoxiang781216 commented on pull request #2111: URL: https://github.com/apache/incubator-nuttx/pull/2111#issuecomment-749399115 My point is that it's strange why your version still default to c++98. This is an automated mess

[GitHub] [incubator-nuttx] yamt opened a new pull request #2584: esp32_wifi_adapter.c: file mode for open doesn't make sense for O_RDONLY

2020-12-21 Thread GitBox
yamt opened a new pull request #2584: URL: https://github.com/apache/incubator-nuttx/pull/2584 ## Summary Don't bother to specify mode_t for open with O_RDONLY ## Impact ## Testing tested on esp32-devkitc

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #537: testing/irtest: Remove an unused function

2020-12-21 Thread GitBox
yamt commented on a change in pull request #537: URL: https://github.com/apache/incubator-nuttx-apps/pull/537#discussion_r547111796 ## File path: testing/irtest/cmd.cpp ## @@ -69,20 +69,6 @@ static void print_cmd(const cmd *cmd) printf(")\n"); } -static int print_cmd(con

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #536: netinit: Make the default SSID and passphrase empty

2020-12-21 Thread GitBox
xiaoxiang781216 merged pull request #536: URL: https://github.com/apache/incubator-nuttx-apps/pull/536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated: netinit: Make the default SSID and passphrase empty

2020-12-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new f6f99c4 netinit: Make the defa

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #537: testing/irtest: Remove an unused function

2020-12-21 Thread GitBox
xiaoxiang781216 commented on a change in pull request #537: URL: https://github.com/apache/incubator-nuttx-apps/pull/537#discussion_r547110830 ## File path: testing/irtest/cmd.cpp ## @@ -69,20 +69,6 @@ static void print_cmd(const cmd *cmd) printf(")\n"); } -static int pr

[GitHub] [incubator-nuttx] btashton commented on pull request #2582: Replace all wget with curl

2020-12-21 Thread GitBox
btashton commented on pull request #2582: URL: https://github.com/apache/incubator-nuttx/pull/2582#issuecomment-749380955 CI Failure was this github issue https://github.com/actions/upload-artifact/issues/116 but it meant that two of the macOS jobs did not finish so I just restarted it, I

[GitHub] [incubator-nuttx] yamt commented on pull request #2583: wireless/bluetooth/bt_hcicore.c: Fix an unused warning

2020-12-21 Thread GitBox
yamt commented on pull request #2583: URL: https://github.com/apache/incubator-nuttx/pull/2583#issuecomment-749378170 > @yamt Looks like its good with my PR that just merged? yea, i noticed it and closed this pr. This

[GitHub] [incubator-nuttx] btashton commented on pull request #2583: wireless/bluetooth/bt_hcicore.c: Fix an unused warning

2020-12-21 Thread GitBox
btashton commented on pull request #2583: URL: https://github.com/apache/incubator-nuttx/pull/2583#issuecomment-749377088 @yamt Looks like its good with my PR that just merged? This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] btashton commented on pull request #2583: wireless/bluetooth/bt_hcicore.c: Fix an unused warning

2020-12-21 Thread GitBox
btashton commented on pull request #2583: URL: https://github.com/apache/incubator-nuttx/pull/2583#issuecomment-749374627 Shoot the static function should fully go away. It got moved in my last PR to be public. This is an a

[GitHub] [incubator-nuttx] yamt closed pull request #2583: wireless/bluetooth/bt_hcicore.c: Fix an unused warning

2020-12-21 Thread GitBox
yamt closed pull request #2583: URL: https://github.com/apache/incubator-nuttx/pull/2583 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-nuttx] yamt opened a new pull request #2583: wireless/bluetooth/bt_hcicore.c: Fix an unused warning

2020-12-21 Thread GitBox
yamt opened a new pull request #2583: URL: https://github.com/apache/incubator-nuttx/pull/2583 ## Summary This fixes the following warning: bluetooth/bt_hcicore.c:143:12: error: unused function 'bt_send' [-Werror,-Wunused-function] static int bt_send(FAR const struct bt_driver_

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #537: testing/irtest: Remove an unused function

2020-12-21 Thread GitBox
yamt opened a new pull request #537: URL: https://github.com/apache/incubator-nuttx-apps/pull/537 ## Summary testing/irtest: Remove an unused function ## Impact ## Testing build-tested This is an automated

[GitHub] [incubator-nuttx] yamt commented on pull request #2111: LIBCXX related fixes

2020-12-21 Thread GitBox
yamt commented on pull request #2111: URL: https://github.com/apache/incubator-nuttx/pull/2111#issuecomment-749366632 > From this link: > https://stackoverflow.com/questions/21581838/set-as-default-c11-in-clang > clang should target c++11 by default from 6.0.0. what's your point

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2111: LIBCXX related fixes

2020-12-21 Thread GitBox
xiaoxiang781216 commented on pull request #2111: URL: https://github.com/apache/incubator-nuttx/pull/2111#issuecomment-749362128 From this link: https://stackoverflow.com/questions/21581838/set-as-default-c11-in-clang clang should target c++11 by default from 6.0.0. -

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2571: bluetooth: Fix bt_buff lifecycle

2020-12-21 Thread GitBox
xiaoxiang781216 merged pull request #2571: URL: https://github.com/apache/incubator-nuttx/pull/2571 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated: Bluetooth: Fix bt_buff lifecycle

2020-12-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new c694719 Bluetooth: Fix bt_buff life

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2571: bluetooth: Fix bt_buff lifecycle

2020-12-21 Thread GitBox
xiaoxiang781216 commented on pull request #2571: URL: https://github.com/apache/incubator-nuttx/pull/2571#issuecomment-749349786 Sure, let's go to ahead. This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2580: arch & sched: task: Fix up_exit() and nxtask_exit() for SMP

2020-12-21 Thread GitBox
xiaoxiang781216 merged pull request #2580: URL: https://github.com/apache/incubator-nuttx/pull/2580 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated: arch & sched: task: Fix up_exit() and nxtask_exit() for SMP

2020-12-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new ec73a4e arch & sched: task: Fix up_

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #535: wireless/wapi: Fix the usage message

2020-12-21 Thread GitBox
xiaoxiang781216 merged pull request #535: URL: https://github.com/apache/incubator-nuttx-apps/pull/535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated (3040c59 -> e44268c)

2020-12-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 3040c59 Replace all wget with curl add e44268c wireless/wapi: Fix the usage message No new r

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #534: Replace all wget with curl

2020-12-21 Thread GitBox
xiaoxiang781216 merged pull request #534: URL: https://github.com/apache/incubator-nuttx-apps/pull/534 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated (ea5a9a0 -> 3040c59)

2020-12-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from ea5a9a0 interpreters/wamr: Support latest snapshot for main branch add 3040c59 Replace all wg

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #534: Replace all wget with curl

2020-12-21 Thread GitBox
xiaoxiang781216 commented on pull request #534: URL: https://github.com/apache/incubator-nuttx-apps/pull/534#issuecomment-749335008 curl is much better than wget from compatibility perspective: ![image](https://user-images.githubusercontent.com/18066964/102849976-46755100-4453-11eb-8126

[GitHub] [incubator-nuttx] btashton commented on pull request #2574: libs/libc/dumpbuffer: dump buffer enhancement

2020-12-21 Thread GitBox
btashton commented on pull request #2574: URL: https://github.com/apache/incubator-nuttx/pull/2574#issuecomment-749333515 @anchao since this buffer dumping is used on some of the small targets for debugging I am a little worried about what this does to the code size. Do you think we can k

[GitHub] [incubator-nuttx] no1wudi opened a new pull request #2582: Replace all wget with curl

2020-12-21 Thread GitBox
no1wudi opened a new pull request #2582: URL: https://github.com/apache/incubator-nuttx/pull/2582 ## Summary See https://github.com/apache/incubator-nuttx-apps/pull/534 Note: wget in `tools\checkrelease.sh` still here, curl don't ## Impact None ## Testing Tested with s

[incubator-nuttx] branch master updated: boards/sim/sim/sim/src/etc/init.d/rcS: Make it conditional with FS_FAT

2020-12-21 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new d5a1c8c boards/sim/sim/sim/src/etc/i

[GitHub] [incubator-nuttx] btashton merged pull request #2579: boards/sim/sim/sim/src/etc/init.d/rcS: Make it conditional with FS_FAT

2020-12-21 Thread GitBox
btashton merged pull request #2579: URL: https://github.com/apache/incubator-nuttx/pull/2579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #536: netinit: Make the default SSID and passphrase empty

2020-12-21 Thread GitBox
yamt opened a new pull request #536: URL: https://github.com/apache/incubator-nuttx-apps/pull/536 ## Summary * It doesn't make much sense to have the default values for these highly environment-dependent settings. * netutils/netinit/netinit_associate.c calls wpa_driver_wext_as

[GitHub] [incubator-nuttx] btashton merged pull request #2581: tools/mkdeps.c: increase MAX_BUFFER to 8192

2020-12-21 Thread GitBox
btashton merged pull request #2581: URL: https://github.com/apache/incubator-nuttx/pull/2581 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-nuttx] branch master updated: tools/mkdeps.c: increase MAX_BUFFER to 8192

2020-12-21 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 9ee04b5 tools/mkdeps.c: increase MAX

[GitHub] [incubator-nuttx] btashton commented on pull request #2571: bluetooth: Fix bt_buff lifecycle

2020-12-21 Thread GitBox
btashton commented on pull request #2571: URL: https://github.com/apache/incubator-nuttx/pull/2571#issuecomment-749325784 @v01d This is the `sim:bluetooth` config. Looks good to me. ``` NuttShell (NSH) NuttX-10.0.1 nsh> ifconfig bnep0Link encap:UNSPEC at DOWN nsh>

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #535: wireless/wapi: Fix the usage message

2020-12-21 Thread GitBox
yamt opened a new pull request #535: URL: https://github.com/apache/incubator-nuttx-apps/pull/535 ## Summary wireless/wapi: Fix the usage message ## Impact ## Testing confirmed the output locally This is an au

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #2581: tools/mkdeps.c: increase MAX_BUFFER to 8192

2020-12-21 Thread GitBox
GUIDINGLI opened a new pull request #2581: URL: https://github.com/apache/incubator-nuttx/pull/2581 ## Summary tools/mkdeps.c: increase MAX_BUFFER to 8192 Compile may fail when the nuttx folder too long or the compiled file has too long CFLAGS ERROR: CFLAG string is too

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2580: arch & sched: task: Fix up_exit() and nxtask_exit() for SMP

2020-12-21 Thread GitBox
masayuki2009 opened a new pull request #2580: URL: https://github.com/apache/incubator-nuttx/pull/2580 ## Summary - During repeating ostest with sabre-6quad:smp (QEMU), I noticed that pthread_rwlock_test sometimes stops - Finally, I found that nxtask_exit() released a critical

[GitHub] [incubator-nuttx] yamt opened a new pull request #2579: boards/sim/sim/sim/src/etc/init.d/rcS: Make it conditional with FS_FAT

2020-12-21 Thread GitBox
yamt opened a new pull request #2579: URL: https://github.com/apache/incubator-nuttx/pull/2579 ## Summary boards/sim/sim/sim/src/etc/init.d/rcS: Make it conditional with FS_FAT ifdef out the guts of the script because it doesn't make sense without FAT enabled. ## Impact

[incubator-nuttx] branch master updated (16b1a87 -> 93b9ad0)

2020-12-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 16b1a87 xtensa/esp32: Added watcher defconfig add 93b9ad0 sched/Kconfig: Minor grammar fixes in he

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2578: sched/Kconfig: Minor grammar fixes in help text

2020-12-21 Thread GitBox
xiaoxiang781216 merged pull request #2578: URL: https://github.com/apache/incubator-nuttx/pull/2578 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx-apps] no1wudi commented on pull request #534: Replace all wget with curl

2020-12-21 Thread GitBox
no1wudi commented on pull request #534: URL: https://github.com/apache/incubator-nuttx-apps/pull/534#issuecomment-749294322 > please add commit description (the same as the PR message should be ok ) commit message updated

[GitHub] [incubator-nuttx-apps] no1wudi commented on pull request #534: Replace all wget with curl

2020-12-21 Thread GitBox
no1wudi commented on pull request #534: URL: https://github.com/apache/incubator-nuttx-apps/pull/534#issuecomment-749293294 > How about in the windows native environment? Would the user need to install something like: > > ``` > https://curl.se/windows/ > https://develop.zende

[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #534: Replace all wget with curl

2020-12-21 Thread GitBox
no1wudi commented on a change in pull request #534: URL: https://github.com/apache/incubator-nuttx-apps/pull/534#discussion_r546677164 ## File path: canutils/libcanard/Makefile ## @@ -55,7 +55,7 @@ CSRCS = $(LIBCANARD_SRCDIR)$(DELIM)canard.c $(LIBCANARD_DRVDIR)$(DELIM)canard_

[GitHub] [incubator-nuttx] yamt commented on pull request #2111: LIBCXX related fixes

2020-12-21 Thread GitBox
yamt commented on pull request #2111: URL: https://github.com/apache/incubator-nuttx/pull/2111#issuecomment-749289920 > > The only concern is that "CXXFLAGS += -std=c++14 -D_LIBCPP_STD_VER=14", should we keep the default one from gcc/clang? > > ok, let me try to remove it i re

[GitHub] [incubator-nuttx] yamt commented on pull request #2572: spiffs fixes

2020-12-21 Thread GitBox
yamt commented on pull request #2572: URL: https://github.com/apache/incubator-nuttx/pull/2572#issuecomment-749284032 > i guess it makes more sense to have two separate Kconfig for them. i separated them This is an aut

[incubator-nuttx-website] branch asf-site updated: Publishing web: 1d65847df020becad8aaf7f02f01a93bc9e03ba9 docs: 16b1a87da422fcbbb4256af94d2369c2421e14c5

2020-12-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new fbf879a Publishing web

[GitHub] [incubator-nuttx] yamt commented on pull request #2572: spiffs fixes

2020-12-21 Thread GitBox
yamt commented on pull request #2572: URL: https://github.com/apache/incubator-nuttx/pull/2572#issuecomment-749263509 after reading https://github.com/pellepl/spiffs code a bit, i feel the leading slash might not be essential in the on-flash structure. it's probably just how mkspiffs and

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #2578: sched/Kconfig: Minor grammar fixes in help text

2020-12-21 Thread GitBox
hartmannathan opened a new pull request #2578: URL: https://github.com/apache/incubator-nuttx/pull/2578 ## Summary sched/Kconfig: Minor grammar fixes in help text of SCHED_CRITMONITOR and SCHED_CPULOAD. ## Impact None. ## Testing None. --

[GitHub] [incubator-nuttx] btashton commented on pull request #2571: bluetooth: Fix bt_buff lifecycle

2020-12-21 Thread GitBox
btashton commented on pull request #2571: URL: https://github.com/apache/incubator-nuttx/pull/2571#issuecomment-749182449 I did not, but it should be inline with the HCI test since that no longer has the extra conditional buffer free. -

[incubator-nuttx] branch master updated: xtensa/esp32: Added watcher defconfig

2020-12-21 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 16b1a87 xtensa/esp32: Added watch

[incubator-nuttx] branch master updated: arch/stm32: Fix nxstyle errors

2020-12-21 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 78f308f arch/stm32: Fix nxstyle e

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2576: Added watcher defconfig

2020-12-21 Thread GitBox
Ouss4 merged pull request #2576: URL: https://github.com/apache/incubator-nuttx/pull/2576 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2577: arch/stm32: Fix nxstyle errors

2020-12-21 Thread GitBox
Ouss4 merged pull request #2577: URL: https://github.com/apache/incubator-nuttx/pull/2577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] v01d commented on pull request #2571: bluetooth: Fix bt_buff lifecycle

2020-12-21 Thread GitBox
v01d commented on pull request #2571: URL: https://github.com/apache/incubator-nuttx/pull/2571#issuecomment-749115272 Ok, I think I understand the changes, looks OK. Have you also tried `sim:bluetooth`? I think last time the break was found there. -

[incubator-nuttx] branch master updated: stm32g4: Fix incorrect FLASH wait states

2020-12-21 Thread raiden00
This is an automated email from the ASF dual-hosted git repository. raiden00 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 4cefc5c stm32g4: Fix incorrect FLASH

[GitHub] [incubator-nuttx] raiden00pl merged pull request #2570: stm32g4: Fix incorrect FLASH wait states

2020-12-21 Thread GitBox
raiden00pl merged pull request #2570: URL: https://github.com/apache/incubator-nuttx/pull/2570 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2576: Added watcher defconfig

2020-12-21 Thread GitBox
saramonteiro commented on a change in pull request #2576: URL: https://github.com/apache/incubator-nuttx/pull/2576#discussion_r546824145 ## File path: boards/xtensa/esp32/esp32-core/configs/watcher/defconfig ## @@ -0,0 +1,54 @@ +# +# This file is autogenerated: PLEASE DO NOT ED

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #2577: arch/stm32: Fix nxstyle errors

2020-12-21 Thread GitBox
hartmannathan opened a new pull request #2577: URL: https://github.com/apache/incubator-nuttx/pull/2577 ## Summary arch/arm/src/stm32/stm32_dac.h: * Fix nxstyle issues. ## Impact Removes nxstyle errors. ## Testing nxstyle --

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2576: Added watcher defconfig

2020-12-21 Thread GitBox
Ouss4 commented on a change in pull request #2576: URL: https://github.com/apache/incubator-nuttx/pull/2576#discussion_r546773450 ## File path: boards/xtensa/esp32/esp32-core/configs/watcher/defconfig ## @@ -0,0 +1,54 @@ +# +# This file is autogenerated: PLEASE DO NOT EDIT IT.

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2576: Added watcher defconfig

2020-12-21 Thread GitBox
Ouss4 commented on a change in pull request #2576: URL: https://github.com/apache/incubator-nuttx/pull/2576#discussion_r546770338 ## File path: boards/xtensa/esp32/esp32-core/configs/watcher/defconfig ## @@ -0,0 +1,54 @@ +# +# This file is autogenerated: PLEASE DO NOT EDIT IT.

[GitHub] [incubator-nuttx] v01d commented on pull request #2571: bluetooth: Fix bt_buff lifecycle

2020-12-21 Thread GitBox
v01d commented on pull request #2571: URL: https://github.com/apache/incubator-nuttx/pull/2571#issuecomment-749016810 Great. That was quite an involved change, thanks for looking into it. I will hopefully test it (and try to understand it better) later today. ---

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #532: lvgl porting and lvgl demo decoupling

2020-12-21 Thread GitBox
v01d commented on pull request #532: URL: https://github.com/apache/incubator-nuttx-apps/pull/532#issuecomment-749015169 In other words, these functions are mostly designed to be used from the demos so I don't think it is entirely right to just expose them at the library level (when they

[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #534: Replace all wget with curl

2020-12-21 Thread GitBox
patacongo commented on pull request #534: URL: https://github.com/apache/incubator-nuttx-apps/pull/534#issuecomment-749015018 How about in the windows native environment? Would the user need to install something like: https://curl.se/windows/ https://develop.zendesk.com

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #532: lvgl porting and lvgl demo decoupling

2020-12-21 Thread GitBox
v01d commented on pull request #532: URL: https://github.com/apache/incubator-nuttx-apps/pull/532#issuecomment-749014612 I'm not entirely convinced of this change. I see some that some of this code is part of `lv_drivers` repo, although not sure if there are no NuttX specific changes ther

[GitHub] [incubator-nuttx-apps] patacongo commented on pull request #534: Replace all wget with curl

2020-12-21 Thread GitBox
patacongo commented on pull request #534: URL: https://github.com/apache/incubator-nuttx-apps/pull/534#issuecomment-749012896 curl should be added to the required tools in the top-level README.md file. That provides the "getting started" info that people need to know. I am not sure

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #534: Replace all wget with curl

2020-12-21 Thread GitBox
v01d commented on pull request #534: URL: https://github.com/apache/incubator-nuttx-apps/pull/534#issuecomment-749009237 Any other uses of wget anywhere else on NuttX? If not, you could look into removing any reference to wget from documentation. -

[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #534: Replace all wget with curl

2020-12-21 Thread GitBox
jerpelea commented on pull request #534: URL: https://github.com/apache/incubator-nuttx-apps/pull/534#issuecomment-749002721 please add commit description (the same as the PR message should be ok ) This is an automated messa

[GitHub] [incubator-nuttx] acassis merged pull request #2575: Changes in the watchdog auto-monitor menu

2020-12-21 Thread GitBox
acassis merged pull request #2575: URL: https://github.com/apache/incubator-nuttx/pull/2575 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-nuttx] branch master updated: Changes in the watchdog auto-monitor menu

2020-12-21 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 8811214 Changes in the watchdog auto-

[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #2576: xtensa/esp32: Added watcher defconfig

2020-12-21 Thread GitBox
saramonteiro opened a new pull request #2576: URL: https://github.com/apache/incubator-nuttx/pull/2576 ## Summary Adds a ready defconfig to use watcher example merged in with https://github.com/apache/incubator-nuttx-apps/pull/516. ## Impact N/A ## Testing N/A

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #534: Replace all wget with curl

2020-12-21 Thread GitBox
xiaoxiang781216 commented on pull request #534: URL: https://github.com/apache/incubator-nuttx-apps/pull/534#issuecomment-748938692 @no1wudi please do the same replacement in nuttx too. This is an automated message from the

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #534: Replace all wget with curl

2020-12-21 Thread GitBox
xiaoxiang781216 commented on a change in pull request #534: URL: https://github.com/apache/incubator-nuttx-apps/pull/534#discussion_r546668137 ## File path: canutils/libcanard/Makefile ## @@ -55,7 +55,7 @@ CSRCS = $(LIBCANARD_SRCDIR)$(DELIM)canard.c $(LIBCANARD_DRVDIR)$(DELIM

[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #534: Replace all wget with curl

2020-12-21 Thread GitBox
no1wudi opened a new pull request #534: URL: https://github.com/apache/incubator-nuttx-apps/pull/534 ## Summary wget is missing from some system (like macOS), it's better to use curl to simplify build environment. ## Impact None ## Testing Test build on stm32f429i-disco

[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #2302: bluetooth: fix outgoing buffer freeing

2020-12-21 Thread GitBox
xiaoxiang781216 closed pull request #2302: URL: https://github.com/apache/incubator-nuttx/pull/2302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx-apps] branch master updated (f210010 -> ea5a9a0)

2020-12-21 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from f210010 system: enable O_CLOEXEC when openning audio device add ea5a9a0 interpreters/wamr: Su

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2302: bluetooth: fix outgoing buffer freeing

2020-12-21 Thread GitBox
xiaoxiang781216 commented on pull request #2302: URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-748937378 let's call this PR and focus on the new one: https://github.com/apache/incubator-nuttx/pull/2571 ---

[GitHub] [incubator-nuttx] saramonteiro commented on pull request #2575: Changes in the watchdog auto-monitor menu

2020-12-21 Thread GitBox
saramonteiro commented on pull request #2575: URL: https://github.com/apache/incubator-nuttx/pull/2575#issuecomment-748934154 Hey @xiaoxiang781216 The patch that I suggested in the email. Please, if you can, take a look. Thank you! ---

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #533: interpreters/wamr: Support latest snapshot for main branch

2020-12-21 Thread GitBox
xiaoxiang781216 merged pull request #533: URL: https://github.com/apache/incubator-nuttx-apps/pull/533 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #2575: Changes in the watchdog auto-monitor menu

2020-12-21 Thread GitBox
saramonteiro opened a new pull request #2575: URL: https://github.com/apache/incubator-nuttx/pull/2575 ## Summary I have some suggestions for change for the Watchdog Timer Support Menu. 1. The first suggestion is to set the Keep alive interval to depend on the Auto-Monitor cho

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2572: spiffs fixes

2020-12-21 Thread GitBox
xiaoxiang781216 commented on pull request #2572: URL: https://github.com/apache/incubator-nuttx/pull/2572#issuecomment-74489 @btashton and @patacongo should we keep the compatibility(mistake) layer? This is an automated m

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #1503: Change shes related headers

2020-12-21 Thread GitBox
masayuki2009 commented on pull request #1503: URL: https://github.com/apache/incubator-nuttx/pull/1503#issuecomment-748880955 > @masayuki2009 and @jerpelea there still has many files with "Sony Semiconductor" or "Sony Home Entertainment" in nuttx and apps folder, should we change their cop

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1503: Change shes related headers

2020-12-21 Thread GitBox
xiaoxiang781216 commented on pull request #1503: URL: https://github.com/apache/incubator-nuttx/pull/1503#issuecomment-748877897 @masayuki2009 and @jerpelea there still has many files with "Sony Semiconductor" or "Sony Home Entertainment" in nuttx and apps folder, should we change their co

[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch

2020-12-21 Thread GitBox
no1wudi commented on a change in pull request #533: URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546604227 ## File path: interpreters/wamr/Makefile ## @@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx MAINSRC = main.c -PR

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch

2020-12-21 Thread GitBox
xiaoxiang781216 commented on a change in pull request #533: URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546601969 ## File path: interpreters/wamr/Makefile ## @@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx MAINSRC = main

[GitHub] [incubator-nuttx] anchao opened a new pull request #2574: libs/libc/dumpbuffer: dump buffer enhancement

2020-12-21 Thread GitBox
anchao opened a new pull request #2574: URL: https://github.com/apache/incubator-nuttx/pull/2574 ## Summary libs/libc/dumpbuffer: add support to dump the buffer to file descriptor. libs/libc: add lib_dumpvbuffer support libs/libc/dumpbuffer: remove the unnecessary printable char

[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch

2020-12-21 Thread GitBox
no1wudi commented on a change in pull request #533: URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546598242 ## File path: interpreters/wamr/Makefile ## @@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx MAINSRC = main.c -PR

[GitHub] [incubator-nuttx-apps] FASTSHIFT commented on pull request #532: lvgl porting and lvgl demo decoupling and add lvgl file system interface

2020-12-21 Thread GitBox
FASTSHIFT commented on pull request #532: URL: https://github.com/apache/incubator-nuttx-apps/pull/532#issuecomment-748869438 > @FASTSHIFT maybe it's better to split the PR into two. okay This is an automated message

[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch

2020-12-21 Thread GitBox
no1wudi commented on a change in pull request #533: URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546596492 ## File path: interpreters/wamr/Makefile ## @@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx MAINSRC = main.c -PR

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #532: lvgl porting and lvgl demo decoupling and add lvgl file system interface

2020-12-21 Thread GitBox
xiaoxiang781216 commented on pull request #532: URL: https://github.com/apache/incubator-nuttx-apps/pull/532#issuecomment-748868241 @FASTSHIFT maybe it's better to split the PR into two. This is an automated message from the

[GitHub] [incubator-nuttx-apps] no1wudi commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch

2020-12-21 Thread GitBox
no1wudi commented on a change in pull request #533: URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546594382 ## File path: interpreters/wamr/Makefile ## @@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx MAINSRC = main.c -PR

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch

2020-12-21 Thread GitBox
xiaoxiang781216 commented on a change in pull request #533: URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546594247 ## File path: interpreters/wamr/Makefile ## @@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx MAINSRC = main

[GitHub] [incubator-nuttx-apps] Ouss4 commented on a change in pull request #533: interpreters/wamr: Support latest snapshot for main branch

2020-12-21 Thread GitBox
Ouss4 commented on a change in pull request #533: URL: https://github.com/apache/incubator-nuttx-apps/pull/533#discussion_r546590051 ## File path: interpreters/wamr/Makefile ## @@ -32,22 +42,25 @@ VPATH += $(WAMR_UNPACK)/product-mini/platforms/nuttx MAINSRC = main.c -PROG

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2573: esp32: Bump NAME_MAX where CONFIG_ESP32_WIFI_SAVE_PARAM=y

2020-12-21 Thread GitBox
Ouss4 merged pull request #2573: URL: https://github.com/apache/incubator-nuttx/pull/2573 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-nuttx] branch master updated (b1878fe -> 7a9f180)

2020-12-21 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from b1878fe libcxx: Don't remove the downloaded file eagerly add 7a9f180 esp32: Bump NAME_MAX where

[GitHub] [incubator-nuttx-apps] no1wudi opened a new pull request #533: interpreters/wamr: Support latest snapshot for main branch

2020-12-21 Thread GitBox
no1wudi opened a new pull request #533: URL: https://github.com/apache/incubator-nuttx-apps/pull/533 ## Summary Now supports specifying the version number of wamr as main. ## Impact None ## Testing Tested on stm32f429i-disco --

[GitHub] [incubator-nuttx] jerpelea commented on pull request #1503: Change shes related headers

2020-12-21 Thread GitBox
jerpelea commented on pull request #1503: URL: https://github.com/apache/incubator-nuttx/pull/1503#issuecomment-748853598 The SGA has been submitted This is an automated message from the Apache Git Service. To respond to the