anchao commented on pull request #2415:
URL: https://github.com/apache/incubator-nuttx/pull/2415#issuecomment-739136461
Thanks for your comments,
> @anchao - See above what was the verification done to test this?
Hi, @davids5
I have verified the relevant functions of UD
btashton merged pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
btashton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 6aba444 Added: MT29F2G Nand Flash bl
yjdwbj commented on a change in pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#discussion_r536479037
##
File path: atmel_sam4s_xplained_pro_config
##
@@ -0,0 +1,1546 @@
+#
Review comment:
You mean the `arch/arm/src/sam34/Kconfig` file ? B
yjdwbj commented on a change in pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#discussion_r536479037
##
File path: atmel_sam4s_xplained_pro_config
##
@@ -0,0 +1,1546 @@
+#
Review comment:
You mean the `arch/arm/src/sam34/Kconfig` file ? B
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new f687263 Publishing web
Ouss4 merged pull request #2480:
URL: https://github.com/apache/incubator-nuttx/pull/2480
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 607ff94 arch/stm32: Fix nxstyle e
This is an automated email from the ASF dual-hosted git repository.
btashton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 7f9d8f56fbca60e66242a96a6f73baae6f22d1af
Author: Michal Lenc
AuthorDate: Wed Dec 2 23:59:52 2020 +0100
b
btashton commented on pull request #2463:
URL: https://github.com/apache/incubator-nuttx/pull/2463#issuecomment-738940005
Looks good. I have the feather <> teensy adaptor so I was thinking about
trying against the featherwing keyboard that I have a PR to get in
https://www.tindie.com/prod
btashton merged pull request #2463:
URL: https://github.com/apache/incubator-nuttx/pull/2463
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
btashton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 11be65db8bd29a3a518b9025cc52b5a31201cbf9
Author: Michal Lenc
AuthorDate: Wed Dec 2 23:54:34 2020 +0100
b
This is an automated email from the ASF dual-hosted git repository.
btashton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit eabd79f97ba299ae90daee1bfd2410048bafce5f
Author: Michal Lenc
AuthorDate: Thu Dec 3 18:38:39 2020 +0100
b
This is an automated email from the ASF dual-hosted git repository.
btashton pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 4629d5a RX65N USB Host Driver
new 11be65d board/arm/imxrt: Added Teensy-4 BSP based on imxrt1060-ev
This is an automated email from the ASF dual-hosted git repository.
btashton pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 2de4b6838934217ae1df555ba865b77a93636374
Author: Michal Lenc
AuthorDate: Thu Dec 3 18:37:01 2020 +0100
D
xiaoxiang781216 merged pull request #2469:
URL: https://github.com/apache/incubator-nuttx/pull/2469
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
michallenc commented on pull request #2463:
URL: https://github.com/apache/incubator-nuttx/pull/2463#issuecomment-738929602
@btashton I pushed the changes @patacongo and you refered to, thanks!
We have our board designed under Teensy 4.1
(https://gitlab.com/pikron/projects/imxrt-deve
xiaoxiang781216 commented on pull request #2469:
URL: https://github.com/apache/incubator-nuttx/pull/2469#issuecomment-738929748
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, pleas
michallenc commented on a change in pull request #2463:
URL: https://github.com/apache/incubator-nuttx/pull/2463#discussion_r536277302
##
File path: boards/arm/imxrt/teensy-4.x/src/imxrt_autoleds.c
##
@@ -0,0 +1,165 @@
+/*
patacongo commented on issue #2478:
URL:
https://github.com/apache/incubator-nuttx/issues/2478#issuecomment-738921317
> It looks like we also remove these from all the
> |arch/arm//Make.defs| as this will come in via libs now? Is
> there anything special that needs to happen her
btashton commented on a change in pull request #2463:
URL: https://github.com/apache/incubator-nuttx/pull/2463#discussion_r536268491
##
File path: boards/arm/imxrt/teensy-4.x/include/board.h
##
@@ -0,0 +1,311 @@
+/
davids5 commented on pull request #2477:
URL: https://github.com/apache/incubator-nuttx/pull/2477#issuecomment-738920185
@fjpanag We need to scope the naming and use composition. Looking at it from
A board has one (or many) CPU that have each a voltage. If we assume the multi
Soc of the sa
hartmannathan opened a new pull request #2480:
URL: https://github.com/apache/incubator-nuttx/pull/2480
## Summary
arch/arm/src/stm32/stm32_eth.h:
* Fix nxstyle errors.
## Impact
Removes nxstyle errors.
## Testing
nxstyle
--
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 064de6e include/nuttx/sensors/hts221.h: Fix nxstyle errors.
add a5e00ac include/sys/wait.h: Modify
xiaoxiang781216 merged pull request #2476:
URL: https://github.com/apache/incubator-nuttx/pull/2476
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hartmannathan commented on pull request #2479:
URL: https://github.com/apache/incubator-nuttx/pull/2479#issuecomment-738915742
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please l
acassis merged pull request #2479:
URL: https://github.com/apache/incubator-nuttx/pull/2479
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 4eb2b32310e405ed425fdc0f42cc7668d43a01a8
Author: Abdelatif Guettouche
AuthorDate: Fri Dec 4 16:44:58 2020 +000
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 064de6e140a920ac779c761fc4a60a452a05430b
Author: Abdelatif Guettouche
AuthorDate: Fri Dec 4 16:50:47 2020 +000
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from a59062f xtensa/esp32: Optimize IRAM usage based on esp-idf
new 4eb2b32 include/nuttx/sensors/hts221.
acassis merged pull request #2474:
URL: https://github.com/apache/incubator-nuttx/pull/2474
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new a59062f xtensa/esp32: Optimize IRAM u
btashton commented on pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#issuecomment-738914372
Once you have removed the extra file this looks good. Thanks for fixing
that issue and adding the additional support.
davids5 commented on pull request #2415:
URL: https://github.com/apache/incubator-nuttx/pull/2415#issuecomment-738914131
@anchao - See above what was the verification done to test this?
This is an automated message from the A
btashton commented on a change in pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#discussion_r536259949
##
File path: atmel_sam4s_xplained_pro_config
##
@@ -0,0 +1,1546 @@
+#
Review comment:
@yjdwbj Looks like the file snuck in. Can you rem
btashton commented on a change in pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#discussion_r536259949
##
File path: atmel_sam4s_xplained_pro_config
##
@@ -0,0 +1,1546 @@
+#
Review comment:
@yjdwbj Looks like the file slipped in by accident
btashton commented on issue #2478:
URL:
https://github.com/apache/incubator-nuttx/issues/2478#issuecomment-738911174
I started making this fix, and had a couple questions.
It looks like we also remove these from all the `arch/arm//Make.defs`
as this will come in via libs now? Is th
patacongo commented on issue #2478:
URL:
https://github.com/apache/incubator-nuttx/issues/2478#issuecomment-738891131
Also noted by @xiaoxiang781216
arch/arm/src/armv7-m/gnu/arm_setjmp.S
arch/arm/src/armv8-m/arm_setjmp.S
arch/sim/src/sim/up_setjmp32.S
arch/s
Ouss4 opened a new pull request #2479:
URL: https://github.com/apache/incubator-nuttx/pull/2479
## Summary
Forward reference `i2c_master_s` to avoid declaring it inside the
parameters' list.
## Impact
Fix a warning
## Testing
An ESP32 board with an HTS221 sensor.
-
patacongo commented on a change in pull request #2470:
URL: https://github.com/apache/incubator-nuttx/pull/2470#discussion_r536209846
##
File path: arch/risc-v/src/common/riscv_setjmp.S
##
@@ -0,0 +1,83 @@
+###
patacongo commented on a change in pull request #2470:
URL: https://github.com/apache/incubator-nuttx/pull/2470#discussion_r536209846
##
File path: arch/risc-v/src/common/riscv_setjmp.S
##
@@ -0,0 +1,83 @@
+###
yjdwbj commented on pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#issuecomment-738869002
> @yjdwbj can you run sleep 10 on the nsh and measure that time to make sure
it's at least approximately 10sec. I just want to make sure that the ticks
duration is correc
xiaoxiang781216 commented on a change in pull request #2470:
URL: https://github.com/apache/incubator-nuttx/pull/2470#discussion_r536202983
##
File path: arch/risc-v/src/common/riscv_setjmp.S
##
@@ -0,0 +1,83 @@
+#
patacongo commented on pull request #2463:
URL: https://github.com/apache/incubator-nuttx/pull/2463#issuecomment-738859711
After running indent.sh, I do the following:
# Run the indent tool on the file. This requires manual fixups
# including removing the bogus blank l
btashton commented on pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#issuecomment-738852977
@yjdwbj can you run sleep 10 on the nsh and measure that time to make sure
it's at least approximately 10sec. I just want to make sure that the ticks
duration is correc
btashton commented on pull request #2463:
URL: https://github.com/apache/incubator-nuttx/pull/2463#issuecomment-738851644
@michallenc if you want to take a pass at the comments Greg made that would
be great and then I think we can merge this in.
I did see a couple comments in the boa
patacongo opened a new issue #2478:
URL: https://github.com/apache/incubator-nuttx/issues/2478
PR #2470 introduced RISC-V generial setjmp/longjmp for RISC-V.
Unfortunately the file arch/risc-v/src/common/riscv_setjmp.S was place in the
incorrect location.
Application code many not
patacongo commented on pull request #2415:
URL: https://github.com/apache/incubator-nuttx/pull/2415#issuecomment-738817826
>
>
> @patacongo - Would you please see it this looks correct to you?
I don't see anything incorrect but I cannot verify that it is correct by
looking at
patacongo commented on a change in pull request #2470:
URL: https://github.com/apache/incubator-nuttx/pull/2470#discussion_r536134839
##
File path: arch/risc-v/src/common/riscv_setjmp.S
##
@@ -0,0 +1,83 @@
+###
patacongo commented on a change in pull request #2470:
URL: https://github.com/apache/incubator-nuttx/pull/2470#discussion_r536134351
##
File path: arch/risc-v/src/common/riscv_setjmp.S
##
@@ -0,0 +1,83 @@
+###
patacongo commented on pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#issuecomment-738808771
>
>
> @btashton Hi, When I disabled the `CONFIG_SYSTEMTICK_EXTCLK`, and keep the
`CONFIG_WDT_DISABLE_ON_RESET=y` the board works is fine. Please to review this
patacongo commented on pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#issuecomment-738804687
> @yjdwbj the change to `up_udelay` is incorrect as I mentioned. The driver
should be using `nxsig_usleep`. I understand that when you used the usleep
command at the `
patacongo commented on pull request #2463:
URL: https://github.com/apache/incubator-nuttx/pull/2463#issuecomment-738801757
> @patacongo Do you have any other concerns?
There is really too much to review here any any real detail. I did spot a
few stylistic things which you may or may
patacongo commented on a change in pull request #2463:
URL: https://github.com/apache/incubator-nuttx/pull/2463#discussion_r536114220
##
File path: boards/arm/imxrt/teensy-4.x/README.txt
##
@@ -0,0 +1,177 @@
+README
+==
+
+ This README file provides information about the p
raiden00pl commented on pull request #2473:
URL: https://github.com/apache/incubator-nuttx/pull/2473#issuecomment-738791558
@hartmannathan
I think this is a similar situation to the STM32L1 case where we are dealing
with a modified version of ADCv1.
In the case of STM32G4 we have
fjpanag commented on pull request #2477:
URL: https://github.com/apache/incubator-nuttx/pull/2477#issuecomment-738764844
These are the boards that I have marked that they need the new definition to
be added:
* clicker2-stm32
* stm32f411e-disco
* olimex-stm32-e407
* stm3240g-
fjpanag commented on pull request #2477:
URL: https://github.com/apache/incubator-nuttx/pull/2477#issuecomment-738764034
Also, at this point I am tempted to add either:
```
#ifndef STM32_VIN
#define STM32_VIN 3.3
#endif
```
or
```
#ifndef STM32_VIN
#error "
fjpanag opened a new pull request #2477:
URL: https://github.com/apache/incubator-nuttx/pull/2477
## Summary
On STM32F2xx & STM32F4xx there is configuration for the FLASH wait cycles.
This configuration depends both on system clock, and the MCU voltage input.
Previously the code a
acassis merged pull request #2470:
URL: https://github.com/apache/incubator-nuttx/pull/2470
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 4078548 risc-v: Introduce basic setjm
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 3bb9a42 xtensa/esp32: Refactor ESP32
acassis merged pull request #2294:
URL: https://github.com/apache/incubator-nuttx/pull/2294
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
davids5 commented on pull request #2473:
URL: https://github.com/apache/incubator-nuttx/pull/2473#issuecomment-738757339
@hartmannathan.
Here is what I would do. I would have a look at some of the new chips ref
manuals and see if the the IP is used there as well. (this was the case
yjdwbj commented on pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#issuecomment-738686402
@btashton Hi, When I disabled the `CONFIG_SYSTEMTICK_EXTCLK`, and keep the
`CONFIG_WDT_DISABLE_ON_RESET=y` the board works is fine. Please to review this
code again.
yjdwbj edited a comment on pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#issuecomment-738657045
@btashton According your mentioned maybe it's the tick timer problem. I
checked the originally `nsh config`, I found the `CONFIG_SYSTEMTICK_EXTCLK=y`
as default.
michallenc commented on a change in pull request #2463:
URL: https://github.com/apache/incubator-nuttx/pull/2463#discussion_r535950979
##
File path: boards/arm/imxrt/teensy-4.x/Kconfig
##
@@ -0,0 +1,36 @@
+#
+# For a description of the syntax of this configuration file,
+# see
yjdwbj commented on pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#issuecomment-738657045
@btashton According your mentioned maybe it's the tick timer problem. I
checked the originally `nsh config`, I found the `CONFIG_SYSTEMTICK_EXTCLK=y`
as default. I fou
btashton commented on pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#issuecomment-738652538
> > You had also mentioned that the board resets several seconds after boot,
this is likely because of the watchdog timer WTAUTO fuse. You might want to
enable `CONFIG_
yjdwbj commented on pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#issuecomment-738648836
> You had also mentioned that the board resets several seconds after boot,
this is likely because of the watchdog timer WTAUTO fuse. You might want to
enable `CONFIG_WDT_
btashton commented on a change in pull request #2470:
URL: https://github.com/apache/incubator-nuttx/pull/2470#discussion_r535925312
##
File path: arch/risc-v/include/setjmp.h
##
@@ -0,0 +1,54 @@
+/
+ *
no1wudi commented on a change in pull request #2470:
URL: https://github.com/apache/incubator-nuttx/pull/2470#discussion_r535919090
##
File path: arch/risc-v/include/setjmp.h
##
@@ -0,0 +1,54 @@
+/
+ *
btashton commented on pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#issuecomment-738640112
You had also mentioned that the board resets several seconds after boot,
this is likely because of the watchdog timer WTAUTO fuse. You might want to
enable `CONFIG_WDT
yjdwbj commented on pull request #2464:
URL: https://github.com/apache/incubator-nuttx/pull/2464#issuecomment-738633399
> > I need someone help, at the `arm-05` run testing report a lot of repeat
info like below:
> > ```shell
> > HEAD detached at pull/2464/merge
> > Changes not sta
btashton commented on a change in pull request #2470:
URL: https://github.com/apache/incubator-nuttx/pull/2470#discussion_r535907958
##
File path: arch/risc-v/include/setjmp.h
##
@@ -0,0 +1,54 @@
+/
+ *
btashton commented on a change in pull request #2470:
URL: https://github.com/apache/incubator-nuttx/pull/2470#discussion_r535907958
##
File path: arch/risc-v/include/setjmp.h
##
@@ -0,0 +1,54 @@
+/
+ *
75 matches
Mail list logo
