[incubator-nuttx] 01/02: Documentation/quickstart/debugging.rst: rewrite JTAG/OpenOCD section

2020-10-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit b482cbdd0474ea7f23bc4abbdb47e6504ca0d35e Author: Diego Herranz AuthorDate: Sun Oct 18 22:48:28 2020 +0100

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2031: Documentation/quickstart/debugging.rst: rewrite JTAG/OpenOCD section

2020-10-20 Thread GitBox
xiaoxiang781216 merged pull request #2031: URL: https://github.com/apache/incubator-nuttx/pull/2031 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (271016a -> 345f2a7)

2020-10-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 271016a kinetis: Make kinetis_i2c_sem_wait_noncancelable optional new b482cbd Documentation/quicks

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2031: Documentation/quickstart/debugging.rst: rewrite JTAG/OpenOCD section

2020-10-20 Thread GitBox
xiaoxiang781216 commented on pull request #2031: URL: https://github.com/apache/incubator-nuttx/pull/2031#issuecomment-713323616 So, the copyright concern get resolved, let's merge it! This is an automated message from the Ap

[incubator-nuttx] 02/02: Documentation/quickstart/debugging.rst: fix NuttX capitalisation

2020-10-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 345f2a77313cef5e91bfb1e308be6256266a7f63 Author: Diego Herranz AuthorDate: Mon Oct 19 07:31:44 2020 +0100

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2049: Added support for resolution configuration. Added option to start or not the conversion when opening ADC device.

2020-10-20 Thread GitBox
xiaoxiang781216 commented on pull request #2049: URL: https://github.com/apache/incubator-nuttx/pull/2049#issuecomment-713322360 @daniel-p-carvalho could you squash PR into one or two patch? This is an automated message from

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1767: To better access host tty interface on sim platform

2020-10-20 Thread GitBox
xiaoxiang781216 commented on pull request #1767: URL: https://github.com/apache/incubator-nuttx/pull/1767#issuecomment-713321001 Sure, the custom baud rate is used for many embeded case. This is an automated message from the

[incubator-nuttx] 01/02: freedom-k64f: Add I2C to demo image

2020-10-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 17e624eae41ea5e3eda657b47cd1f8b74013aa0c Author: Philippe Coval AuthorDate: Tue Oct 20 11:36:45 2020 +0200

[incubator-nuttx] branch master updated (19f7a24 -> 271016a)

2020-10-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 19f7a24 boards: sabre-6quad: Update smp/defconfig new 17e624e freedom-k64f: Add I2C to demo image

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2047: freedom-k64f: Add I2C to demo image

2020-10-20 Thread GitBox
xiaoxiang781216 merged pull request #2047: URL: https://github.com/apache/incubator-nuttx/pull/2047 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] 02/02: kinetis: Make kinetis_i2c_sem_wait_noncancelable optional

2020-10-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 271016a3ade7a38787f7660b9265ce332c2e94e6 Author: Philippe Coval AuthorDate: Tue Oct 20 20:50:52 2020 +0200

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-10-20 Thread GitBox
masayuki2009 commented on pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042#issuecomment-713282854 @xiaoxiang781216 Thanks for merging. This is an automated message from the Apache Git Servi

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-10-20 Thread GitBox
xiaoxiang781216 merged pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (d8d1991 -> 19f7a24)

2020-10-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from d8d1991 Add SCHED_INSTRUMENTATION_HIRES support add 56a0815 arch: imx6: Fix style warnings in chip

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042#discussion_r508972569 ## File path: arch/arm/src/cxd56xx/cxd56_irq.c ## @@ -115,17 +112,17 @@ static uint64_t g_intstack_alloc[INTSTACK_ALLOC >> 3]; const ui

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-10-20 Thread GitBox
masayuki2009 commented on a change in pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042#discussion_r508968677 ## File path: arch/arm/src/cxd56xx/cxd56_irq.c ## @@ -115,17 +112,17 @@ static uint64_t g_intstack_alloc[INTSTACK_ALLOC >> 3]; const uint3

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042#discussion_r508955103 ## File path: arch/arm/src/cxd56xx/cxd56_irq.c ## @@ -115,17 +112,17 @@ static uint64_t g_intstack_alloc[INTSTACK_ALLOC >> 3]; const ui

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2000: sched: Call up_[use|create]_stack after nxtask_setup_scheduler

2020-10-20 Thread GitBox
masayuki2009 commented on pull request #2000: URL: https://github.com/apache/incubator-nuttx/pull/2000#issuecomment-713245966 LGTM This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-nuttx] YuuichiNakamura commented on pull request #2050: Documentation: Fix broken links in the documents

2020-10-20 Thread GitBox
YuuichiNakamura commented on pull request #2050: URL: https://github.com/apache/incubator-nuttx/pull/2050#issuecomment-713237067 Oops... #2045 contains the same fixes. I'll withdraw this PR. This is an automated message from

[GitHub] [incubator-nuttx] YuuichiNakamura closed pull request #2050: Documentation: Fix broken links in the documents

2020-10-20 Thread GitBox
YuuichiNakamura closed pull request #2050: URL: https://github.com/apache/incubator-nuttx/pull/2050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] YuuichiNakamura opened a new pull request #2050: Documentation: Fix broken links in the documents

2020-10-20 Thread GitBox
YuuichiNakamura opened a new pull request #2050: URL: https://github.com/apache/incubator-nuttx/pull/2050 ## Summary I have found some broken links in the latest documents and fixed them. ## Impact ## Testing

[GitHub] [incubator-nuttx] daniel-p-carvalho commented on pull request #2009: Added STM32L432KC DAC support.

2020-10-20 Thread GitBox
daniel-p-carvalho commented on pull request #2009: URL: https://github.com/apache/incubator-nuttx/pull/2009#issuecomment-713236187 @patacongo I've created the STM32L4 common driver directory trying to replicate the one in STM32 boards directory. It builds and seems to work fine but the bui

[incubator-nuttx-website] branch asf-site updated: Publishing web: feb249977349f687d40e57cfe5f0d39e5c5c71f9 docs: d8d19911ef416948efc9fc41a6695a2a601fb7e3

2020-10-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 3b1e674 Publishing web

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-10-20 Thread GitBox
masayuki2009 commented on a change in pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042#discussion_r508901781 ## File path: arch/arm/src/cxd56xx/cxd56_irq.c ## @@ -115,17 +112,17 @@ static uint64_t g_intstack_alloc[INTSTACK_ALLOC >> 3]; const uint3

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2049: Added support for resolution configuration. Added option to start or not the conversion when opening ADC device.

2020-10-20 Thread GitBox
acassis commented on a change in pull request #2049: URL: https://github.com/apache/incubator-nuttx/pull/2049#discussion_r508880434 ## File path: arch/arm/src/stm32l4/stm32l4_adc.c ## @@ -1291,10 +1331,11 @@ static int adc_setup(FAR struct adc_dev_s *dev) adc_putreg(priv, ST

[GitHub] [incubator-nuttx] daniel-p-carvalho commented on a change in pull request #2049: Added support for resolution configuration. Added option to start or not the conversion when opening ADC devic

2020-10-20 Thread GitBox
daniel-p-carvalho commented on a change in pull request #2049: URL: https://github.com/apache/incubator-nuttx/pull/2049#discussion_r508761483 ## File path: arch/arm/src/stm32l4/stm32l4_adc.c ## @@ -1291,10 +1331,11 @@ static int adc_setup(FAR struct adc_dev_s *dev) adc_putre

[incubator-nuttx-apps] branch master updated: Add SCHED_INSTRUMENTATION_HIRES support

2020-10-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 954c90b Add SCHED_INSTRUMENTAT

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #435: Add SCHED_INSTRUMENTATION_HIRES support

2020-10-20 Thread GitBox
xiaoxiang781216 merged pull request #435: URL: https://github.com/apache/incubator-nuttx-apps/pull/435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] ghn-certi commented on a change in pull request #2049: Added support for resolution configuration. Added option to start or not the conversion when opening ADC device.

2020-10-20 Thread GitBox
ghn-certi commented on a change in pull request #2049: URL: https://github.com/apache/incubator-nuttx/pull/2049#discussion_r508712063 ## File path: arch/arm/src/stm32l4/stm32l4_adc.c ## @@ -1291,10 +1331,11 @@ static int adc_setup(FAR struct adc_dev_s *dev) adc_putreg(priv,

[incubator-nuttx-apps] branch master updated: system/sched_note: Change DRIVER_NOTE to DRIVER_NOTERAM

2020-10-20 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 58aa886 system/sched_note: C

[GitHub] [incubator-nuttx-apps] Ouss4 merged pull request #423: system/sched_note: Change DRIVER_NOTE to DRIVER_NOTERAM

2020-10-20 Thread GitBox
Ouss4 merged pull request #423: URL: https://github.com/apache/incubator-nuttx-apps/pull/423 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2047: freedom-k64f: Add I2C to demo image

2020-10-20 Thread GitBox
xiaoxiang781216 commented on pull request #2047: URL: https://github.com/apache/incubator-nuttx/pull/2047#issuecomment-712998298 @rzr, there is compiler warning need to resolve: ``` 2020-10-20T15:39:12.1865721Z ##[error]chip/kinetis_i2c.c:375:3: error: 'kinetis_i2c_sem_wait_noncancela

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #436: Add note_syscall args support

2020-10-20 Thread GitBox
xiaoxiang781216 merged pull request #436: URL: https://github.com/apache/incubator-nuttx-apps/pull/436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated: Add note_syscall args support

2020-10-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new ef2758c Add note_syscall args

[incubator-nuttx] branch master updated (e1b9c27 -> d8d1991)

2020-10-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from e1b9c27 Update trace command document add d8d1991 Add SCHED_INSTRUMENTATION_HIRES support No new

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2043: Add SCHED_INSTRUMENTATION_HIRES support

2020-10-20 Thread GitBox
xiaoxiang781216 merged pull request #2043: URL: https://github.com/apache/incubator-nuttx/pull/2043 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (897b61b -> e1b9c27)

2020-10-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 897b61b build: Change .external_dummy to dummy add 87a7c03 Add note_syscall args support add

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2044: Add note_syscall args support

2020-10-20 Thread GitBox
xiaoxiang781216 merged pull request #2044: URL: https://github.com/apache/incubator-nuttx/pull/2044 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] davids5 commented on pull request #1767: To better access host tty interface on sim platform

2020-10-20 Thread GitBox
davids5 commented on pull request #1767: URL: https://github.com/apache/incubator-nuttx/pull/1767#issuecomment-712937780 @xiaoxiang781216 & @Donny9 - thank you! @xiaoxiang781216. I it is not just PX4 use case. It is more things NuttX would be used for: Like profibus, radios, RS-48

[GitHub] [incubator-nuttx] davids5 commented on pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
davids5 commented on pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#issuecomment-712931723 @AlexanderVasiljev - Great, I glad that works. Can you please squash this and force push it? This is an

[GitHub] [incubator-nuttx] btashton commented on pull request #2045: Documentation: Misc fixups for broken links, errors, warnings

2020-10-20 Thread GitBox
btashton commented on pull request #2045: URL: https://github.com/apache/incubator-nuttx/pull/2045#issuecomment-712927293 > Besides the command I added this LGTM Thanks I'll rebase this to resolve the merge conflict and fix the heading level. ---

[GitHub] [incubator-nuttx] daniel-p-carvalho opened a new pull request #2049: Added support for resolution configuration. Added option to start or not the conversion when opening ADC device.

2020-10-20 Thread GitBox
daniel-p-carvalho opened a new pull request #2049: URL: https://github.com/apache/incubator-nuttx/pull/2049 Added option to start or not the conversion when opening ADC device. ## Summary ## Impact ## Testing

[GitHub] [incubator-nuttx] Donny9 commented on pull request #1767: To better access host tty interface on sim platform

2020-10-20 Thread GitBox
Donny9 commented on pull request #1767: URL: https://github.com/apache/incubator-nuttx/pull/1767#issuecomment-712892207 > > > @davids5 so PX4 use other baud rate? @Donny9 please add back the custorm baud rate like other OS done. yes, i do tomorrow. -

[GitHub] [incubator-nuttx] Donny9 edited a comment on pull request #2039: driver/sensor: add unified management for sensor

2020-10-20 Thread GitBox
Donny9 edited a comment on pull request #2039: URL: https://github.com/apache/incubator-nuttx/pull/2039#issuecomment-712888956 > > > Regarding either driver or application buffer control, I think it is more important to let the application control it since the lower driver does not

[GitHub] [incubator-nuttx] Donny9 commented on pull request #2039: driver/sensor: add unified management for sensor

2020-10-20 Thread GitBox
Donny9 commented on pull request #2039: URL: https://github.com/apache/incubator-nuttx/pull/2039#issuecomment-712888956 > > > Regarding either driver or application buffer control, I think it is more important to let the application control it since the lower driver does not necess

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1767: To better access host tty interface on sim platform

2020-10-20 Thread GitBox
xiaoxiang781216 commented on pull request #1767: URL: https://github.com/apache/incubator-nuttx/pull/1767#issuecomment-712884921 @davids5 so PX4 use other baud rate? @Donny9 please add back the custorm baud rate like other OS done. -

[GitHub] [incubator-nuttx] AlexanderVasiljev commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
AlexanderVasiljev commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508541640 ## File path: drivers/serial/serial.c ## @@ -1771,7 +1771,18 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_rese

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
davids5 commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508536838 ## File path: drivers/serial/serial.c ## @@ -1771,7 +1771,18 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_reset_sem(FAR

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
davids5 commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508536838 ## File path: drivers/serial/serial.c ## @@ -1771,7 +1771,18 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_reset_sem(FAR

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
davids5 commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508536838 ## File path: drivers/serial/serial.c ## @@ -1771,7 +1771,18 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_reset_sem(FAR

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2043: Add SCHED_INSTRUMENTATION_HIRES support

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2043: URL: https://github.com/apache/incubator-nuttx/pull/2043#discussion_r508522931 ## File path: sched/sched/sched_note.c ## @@ -28,6 +28,9 @@ #include #include #include +#ifdef CONFIG_SCHED_INSTRUMENTATION_HIRES R

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2043: Add SCHED_INSTRUMENTATION_HIRES support

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2043: URL: https://github.com/apache/incubator-nuttx/pull/2043#discussion_r508522931 ## File path: sched/sched/sched_note.c ## @@ -28,6 +28,9 @@ #include #include #include +#ifdef CONFIG_SCHED_INSTRUMENTATION_HIRES R

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2044: Add note_syscall args support

2020-10-20 Thread GitBox
xiaoxiang781216 commented on pull request #2044: URL: https://github.com/apache/incubator-nuttx/pull/2044#issuecomment-712865983 LGTM. This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-nuttx] v01d commented on pull request #1661: Start implementing BTPROTO_HCI socket support

2020-10-20 Thread GitBox
v01d commented on pull request #1661: URL: https://github.com/apache/incubator-nuttx/pull/1661#issuecomment-712855569 Thanks, I know you've been busy with the release and that is quite appreciated so I didn't wanted to bother you in the mean time. We can do as you suggest. If you reb

[GitHub] [incubator-nuttx] v01d commented on pull request #2039: driver/sensor: add unified management for sensor

2020-10-20 Thread GitBox
v01d commented on pull request #2039: URL: https://github.com/apache/incubator-nuttx/pull/2039#issuecomment-712853051 Regarding either driver or application buffer control, I think it is more important to let the application control it since the lower driver does not necessarily know how t

[incubator-nuttx] branch master updated (fde7c2b -> 897b61b)

2020-10-20 Thread protobits
This is an automated email from the ASF dual-hosted git repository. protobits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from fde7c2b xtensa/tools: Updated makefile to download the IDF stable version add 897b61b build: Chan

[GitHub] [incubator-nuttx] v01d merged pull request #2032: build: Change .external_dummy to dummy

2020-10-20 Thread GitBox
v01d merged pull request #2032: URL: https://github.com/apache/incubator-nuttx/pull/2032 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2045: Documentation: Misc fixups for broken links, errors, warnings

2020-10-20 Thread GitBox
v01d commented on a change in pull request #2045: URL: https://github.com/apache/incubator-nuttx/pull/2045#discussion_r508492005 ## File path: Documentation/applications/nsh/commands.rst ## @@ -2,8 +2,10 @@ Commands Review comment: This should a different hea

[GitHub] [incubator-nuttx] AlexanderVasiljev commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
AlexanderVasiljev commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508487710 ## File path: drivers/serial/serial.c ## @@ -1771,7 +1771,18 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_rese

[incubator-nuttx] branch master updated (89c9855 -> fde7c2b)

2020-10-20 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 89c9855 esp32: Fix a few #endif comments add fde7c2b xtensa/tools: Updated makefile to download

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2048: xtensa/tools: Updated makefile to download the IDF stable version

2020-10-20 Thread GitBox
Ouss4 merged pull request #2048: URL: https://github.com/apache/incubator-nuttx/pull/2048 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
davids5 commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508453024 ## File path: drivers/serial/serial.c ## @@ -1771,7 +1771,18 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_reset_sem(FAR

[GitHub] [incubator-nuttx] saramonteiro opened a new pull request #2048: xtensa/tools: Updated makefile to download the IDF stable version

2020-10-20 Thread GitBox
saramonteiro opened a new pull request #2048: URL: https://github.com/apache/incubator-nuttx/pull/2048 ## Summary This commit only changes the version of IDF download at tools/esp32/Makefile. It changes from the latest to stable. ## Impact Avoid issues regarding nonstab

[GitHub] [incubator-nuttx] jerpelea commented on pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
jerpelea commented on pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#issuecomment-712768536 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-nuttx] branch master updated (2956b85 -> 89c9855)

2020-10-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 2956b85 Fix nxstyle warning add 89c9855 esp32: Fix a few #endif comments No new revisions were ad

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2046: esp32: Fix a few #endif comments

2020-10-20 Thread GitBox
xiaoxiang781216 merged pull request #2046: URL: https://github.com/apache/incubator-nuttx/pull/2046 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] AlexanderVasiljev commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
AlexanderVasiljev commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508397416 ## File path: drivers/serial/serial.c ## @@ -1761,7 +1771,7 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_reset

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
davids5 commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508388032 ## File path: drivers/serial/serial.c ## @@ -1761,7 +1771,7 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_reset_sem(FAR u

[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #2040: arch: serial: fix all TCGETS retrieving zero baud rate

2020-10-20 Thread GitBox
davids5 edited a comment on pull request #2040: URL: https://github.com/apache/incubator-nuttx/pull/2040#issuecomment-712748961 @xiaoxiang781216 @btashton - thank you for fixing this. Unfortunately I do not think we are done, it is not enough, There is a bigger problem with the #17

[GitHub] [incubator-nuttx] davids5 commented on pull request #2040: arch: serial: fix all TCGETS retrieving zero baud rate

2020-10-20 Thread GitBox
davids5 commented on pull request #2040: URL: https://github.com/apache/incubator-nuttx/pull/2040#issuecomment-712748961 @xiaoxiang781216 @btashton - thank you for fixing this. Unfortunately I do not think we are done, it is not enough, There is a bigger problem with the #1767 chan

[GitHub] [incubator-nuttx] davids5 edited a comment on pull request #1767: To better access host tty interface on sim platform

2020-10-20 Thread GitBox
davids5 edited a comment on pull request #1767: URL: https://github.com/apache/incubator-nuttx/pull/1767#issuecomment-712746236 No. Unfortunately hat is not enough, There is a bigger problem with this change. With this change NuttX can not support any baud rate. This will break many real

[GitHub] [incubator-nuttx] davids5 commented on pull request #1767: To better access host tty interface on sim platform

2020-10-20 Thread GitBox
davids5 commented on pull request #1767: URL: https://github.com/apache/incubator-nuttx/pull/1767#issuecomment-712746236 No. Unfortunately hat is not enough, There is a bigger problem with this change. With this change NuttX can not support any baud rate. This will break many real works

[GitHub] [incubator-nuttx] AlexanderVasiljev commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
AlexanderVasiljev commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508368799 ## File path: drivers/serial/serial.c ## @@ -1761,7 +1771,7 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_reset

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-10-20 Thread GitBox
Ouss4 commented on a change in pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042#discussion_r508313462 ## File path: arch/arm/src/cxd56xx/cxd56_irq.c ## @@ -115,17 +112,17 @@ static uint64_t g_intstack_alloc[INTSTACK_ALLOC >> 3]; const uint32_t g_c

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-10-20 Thread GitBox
masayuki2009 commented on a change in pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042#discussion_r508312426 ## File path: arch/arm/src/cxd56xx/cxd56_irq.c ## @@ -115,17 +112,17 @@ static uint64_t g_intstack_alloc[INTSTACK_ALLOC >> 3]; const uint3

[GitHub] [incubator-nuttx] AlexanderVasiljev commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
AlexanderVasiljev commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508311774 ## File path: drivers/serial/serial.c ## @@ -1761,7 +1771,7 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_reset

[GitHub] [incubator-nuttx] yamt opened a new pull request #2046: esp32: Fix a few #endif comments

2020-10-20 Thread GitBox
yamt opened a new pull request #2046: URL: https://github.com/apache/incubator-nuttx/pull/2046 ## Summary esp32: Fix a few #endif comments ## Impact only comments ## Testing i guess the CI is enough. This i

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508351392 ## File path: drivers/serial/serial.c ## @@ -1761,7 +1771,7 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_reset_s

[GitHub] [incubator-nuttx] AlexanderVasiljev commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
AlexanderVasiljev commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508307715 ## File path: drivers/serial/serial.c ## @@ -1761,7 +1771,7 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_reset

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508328623 ## File path: drivers/serial/serial.c ## @@ -1761,7 +1771,7 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_reset_s

[incubator-nuttx] branch master updated (d5c6bfe -> 2956b85)

2020-10-20 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from d5c6bfe arch: Add custom arch chip build support add eb4121c Change all 'Nuttx' to 'NuttX' add

[incubator-nuttx] branch master updated (d5c6bfe -> 2956b85)

2020-10-20 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from d5c6bfe arch: Add custom arch chip build support add eb4121c Change all 'Nuttx' to 'NuttX' add

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #436: Add note_syscall args support

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #436: URL: https://github.com/apache/incubator-nuttx-apps/pull/436#discussion_r508325937 ## File path: system/trace/trace_dump.c ## @@ -451,8 +454,35 @@ static int trace_dump_one(FAR FILE *out, } t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042#discussion_r508339111 ## File path: arch/arm/src/cxd56xx/cxd56_irq.c ## @@ -115,17 +112,17 @@ static uint64_t g_intstack_alloc[INTSTACK_ALLOC >> 3]; const ui

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042#discussion_r508339111 ## File path: arch/arm/src/cxd56xx/cxd56_irq.c ## @@ -115,17 +112,17 @@ static uint64_t g_intstack_alloc[INTSTACK_ALLOC >> 3]; const ui

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042#discussion_r508339111 ## File path: arch/arm/src/cxd56xx/cxd56_irq.c ## @@ -115,17 +112,17 @@ static uint64_t g_intstack_alloc[INTSTACK_ALLOC >> 3]; const ui

[incubator-nuttx] branch master updated (d5c6bfe -> 2956b85)

2020-10-20 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from d5c6bfe arch: Add custom arch chip build support add eb4121c Change all 'Nuttx' to 'NuttX' add

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2043: Add SCHED_INSTRUMENTATION_HIRES support

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2043: URL: https://github.com/apache/incubator-nuttx/pull/2043#discussion_r508322454 ## File path: sched/Kconfig ## @@ -990,6 +990,14 @@ config SCHED_INSTRUMENTATION_IRQHANDLER void sched_note_irqh

[GitHub] [incubator-nuttx] AlexanderVasiljev commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
AlexanderVasiljev commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508340681 ## File path: drivers/serial/serial.c ## @@ -1761,7 +1771,7 @@ void uart_connected(FAR uart_dev_t *dev, bool connected) void uart_reset

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042#discussion_r508339111 ## File path: arch/arm/src/cxd56xx/cxd56_irq.c ## @@ -115,17 +112,17 @@ static uint64_t g_intstack_alloc[INTSTACK_ALLOC >> 3]; const ui

[GitHub] [incubator-nuttx] btashton merged pull request #2033: Change all 'Nuttx' to 'NuttX;

2020-10-20 Thread GitBox
btashton merged pull request #2033: URL: https://github.com/apache/incubator-nuttx/pull/2033 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2033: Change all 'Nuttx' to 'NuttX;

2020-10-20 Thread GitBox
btashton commented on a change in pull request #2033: URL: https://github.com/apache/incubator-nuttx/pull/2033#discussion_r508319386 ## File path: Documentation/applications/nsh/commands.rst ## @@ -736,7 +736,7 @@ at for the existing file or directory, . This implementation i

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2044: Add note_syscall args support

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2044: URL: https://github.com/apache/incubator-nuttx/pull/2044#discussion_r508319024 ## File path: sched/Kconfig ## @@ -1009,6 +1009,7 @@ config SCHED_INSTRUMENTATION_FILTER_DEFAULT_MODE Bit 0 = Enab

[incubator-nuttx] branch master updated (d5c6bfe -> 2956b85)

2020-10-20 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from d5c6bfe arch: Add custom arch chip build support add eb4121c Change all 'Nuttx' to 'NuttX' add

[incubator-nuttx] branch master updated (d5c6bfe -> 2956b85)

2020-10-20 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from d5c6bfe arch: Add custom arch chip build support add eb4121c Change all 'Nuttx' to 'NuttX' add

[GitHub] [incubator-nuttx] btashton opened a new pull request #2045: Documentation: Misc fixups for broken links, errors, warnings

2020-10-20 Thread GitBox
btashton opened a new pull request #2045: URL: https://github.com/apache/incubator-nuttx/pull/2045 ## Summary Misc fixups for broken links, errors, warnings There are still more bad links were things are referenced by anchors instead of refs that will need to be fixed. ##

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2032: build: Change .external_dummy to dummy

2020-10-20 Thread GitBox
Ouss4 commented on pull request #2032: URL: https://github.com/apache/incubator-nuttx/pull/2032#issuecomment-712692619 @v01d please merge if you don't have any concerns. This is an automated message from the Apache Git Servi

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2036: serial: break from read after closing

2020-10-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2036: URL: https://github.com/apache/incubator-nuttx/pull/2036#discussion_r508330738 ## File path: drivers/serial/serial.c ## @@ -854,6 +854,16 @@ static ssize_t uart_read(FAR struct file *filep, FAR char *buffer, size_t b

[GitHub] [incubator-nuttx] Donny9 closed pull request #2039: driver/sensor: add unified management for sensor

2020-10-20 Thread GitBox
Donny9 closed pull request #2039: URL: https://github.com/apache/incubator-nuttx/pull/2039 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] Donny9 commented on pull request #2039: driver/sensor: add unified management for sensor

2020-10-20 Thread GitBox
Donny9 commented on pull request #2039: URL: https://github.com/apache/incubator-nuttx/pull/2039#issuecomment-712681721 > > > > > > I also like the idea of unifying interfaces and reducing the need to repeat it across each sensor. But I worry if this is really a general sensor solu

  1   2   >