xiaoxiang781216 commented on pull request #1829:
URL: https://github.com/apache/incubator-nuttx/pull/1829#issuecomment-695157610
The real change look reasonable:
```
/*
* A Wireless Event. Contains basically the same data as the ioctl...
*/
#define IW_EV_LEN(field) \
xiaoxiang781216 commented on a change in pull request #385:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/385#discussion_r491262420
##
File path: Makefile
##
@@ -152,13 +156,12 @@ endif # CONFIG_BUILD_KERNEL
dirlinks:
$(Q) $(MAKE) -C platform dirlinks TOPDI
xiaoxiang781216 commented on pull request #384:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/384#issuecomment-695156155
@v01d should we merge this PR? We can create a new issue to track the
problem of application structure.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from b8fa1e5 time/tm: add "tm_zone" member into tm
add 9241725 fs/munmap: export the symbols to avoid b
xiaoxiang781216 merged pull request #1821:
URL: https://github.com/apache/incubator-nuttx/pull/1821
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit bf8446e235c8767f2da656ae2d0490d58f294d4e
Author: chao.an
AuthorDate: Mon Sep 14 19:57:24 2020 +0800
sch
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 9241725 fs/munmap: export the symbols to avoid build break on C++
syntax
new bf8446e sched/task:
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit e0aa7c6d811c084760806dbc8a7e5b7ce811e000
Author: liuhaitao
AuthorDate: Tue Sep 15 12:11:56 2020 +0800
s
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 614ac5b libs/libc/unistd: Implement pipe2(2) syscall
add b8fa1e5 time/tm: add "tm_zone" member int
xiaoxiang781216 merged pull request #1823:
URL: https://github.com/apache/incubator-nuttx/pull/1823
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 merged pull request #1826:
URL: https://github.com/apache/incubator-nuttx/pull/1826
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 8f52d45 timers/watchdog: configable keep alive interval
add 614ac5b libs/libc/unistd: Implement pi
xiaoxiang781216 merged pull request #1818:
URL: https://github.com/apache/incubator-nuttx/pull/1818
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 merged pull request #1822:
URL: https://github.com/apache/incubator-nuttx/pull/1822
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 78005a4 sys/epoll: include-able from C++ files
add 8f52d45 timers/watchdog: configable keep alive
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 78005a4 sys/epoll: include-able fro
xiaoxiang781216 merged pull request #1820:
URL: https://github.com/apache/incubator-nuttx/pull/1820
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 merged pull request #1840:
URL: https://github.com/apache/incubator-nuttx/pull/1840
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 45a8de8 include/poll: add POLLPRI f
xiaoxiang781216 commented on pull request #1840:
URL: https://github.com/apache/incubator-nuttx/pull/1840#issuecomment-695154142
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, pleas
Ouss4 merged pull request #1842:
URL: https://github.com/apache/incubator-nuttx/pull/1842
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 4ceb8ef tiva: tiva_sysctrl.h: Fix nxstyle warnings
add 7910b58 RX65N Defconfig Modification
No
Ouss4 merged pull request #1845:
URL: https://github.com/apache/incubator-nuttx/pull/1845
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from bcb6c30 CONTRIBUTING.md: Minor grammar fixes.
add 4ceb8ef tiva: tiva_sysctrl.h: Fix nxstyle warn
btashton commented on issue #1844:
URL:
https://github.com/apache/incubator-nuttx/issues/1844#issuecomment-695068342
@TA1DB We are doing some serious work trying to improve the state of the
documentation around getting started. So I would love to help get you going
and maybe we can buil
v01d merged pull request #1846:
URL: https://github.com/apache/incubator-nuttx/pull/1846
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
This is an automated email from the ASF dual-hosted git repository.
protobits pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from f92e964 Fix coding style issues
add bcb6c30 CONTRIBUTING.md: Minor grammar fixes.
No new revision
hartmannathan opened a new pull request #1846:
URL: https://github.com/apache/incubator-nuttx/pull/1846
## Summary
CONTRIBUTING.md:
* Replace "you" with "your"
* Replace "this" with "these"
* Add one period
## Impact
Text only. No functional chan
hartmannathan opened a new pull request #1845:
URL: https://github.com/apache/incubator-nuttx/pull/1845
## Summary
arch/arm/src/tiva/tiva_sysctrl.h:
* Fix nxstyle warnings. No functional changes.
## Impact
Removes nxstyle warnings.
## Testing
nxs
v01d commented on pull request #1834:
URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-695039290
Does anyone want to give this a try? It will not work for now for files
under arch/ boards/ (since these were submodules). I'll try to fix that later.
I also added a
patacongo commented on pull request #1834:
URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-695020031
> Sure, if you can push them somewhere I'll try to make use of them. Read
access is enough.
You can find all four repositories here: https://github.com/nuttx
v01d commented on a change in pull request #1843:
URL: https://github.com/apache/incubator-nuttx/pull/1843#discussion_r491110240
##
File path: tools/Config.mk
##
@@ -458,7 +458,8 @@ define CLEAN
endef
else
define CLEAN
- $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp
+
anchao commented on a change in pull request #1843:
URL: https://github.com/apache/incubator-nuttx/pull/1843#discussion_r491106203
##
File path: tools/Config.mk
##
@@ -458,7 +458,8 @@ define CLEAN
endef
else
define CLEAN
- $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp
+
v01d edited a comment on pull request #1834:
URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-695002596
That's strange, it should output the contents of the file. I'm not sure what
that output is. But at least it does not give an error.
Sure, if you can push them som
v01d commented on pull request #1834:
URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-695002596
That's strange, it should output the contents of the file. I'm not sure what
that output is. But at least it does not give an error.
Sure, if you can push them somewhere
patacongo commented on pull request #1834:
URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-695001673
>
>
> Are these git repos or just snapshots of the contents? If these are
repositories, could you for example try to do: `git cat-file -p
029a72b36baa4f7c58f05
v01d commented on pull request #1834:
URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694999888
Are these git repos or just snapshots of the contents? If these are
repositories, could you for example try to do: `git cat-file -p
029a72b36baa4f7c58f0553692a3af193980ace5
patacongo commented on pull request #1834:
URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694992288
> I still don't know what will we do with files which existed in submodules.
@gregory-nutt do you remember if at the very beginning (where "beginning" is a
commit whic
v01d commented on a change in pull request #1843:
URL: https://github.com/apache/incubator-nuttx/pull/1843#discussion_r491089510
##
File path: tools/Config.mk
##
@@ -458,7 +458,8 @@ define CLEAN
endef
else
define CLEAN
- $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp
+
v01d commented on a change in pull request #1843:
URL: https://github.com/apache/incubator-nuttx/pull/1843#discussion_r491089349
##
File path: tools/Config.mk
##
@@ -458,7 +458,8 @@ define CLEAN
endef
else
define CLEAN
- $(Q) rm -f *$(OBJEXT) *$(LIBEXT) *~ .*.swp
+
TA1DB opened a new issue #1844:
URL: https://github.com/apache/incubator-nuttx/issues/1844
Hi,
I'm new to Nuttx. I want to make experiments with a board having (or
possible to add easily) a display, keypad and network connection; by this way I
want to learn nuttx, develop applicatio
anchao commented on pull request #395:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/395#issuecomment-694974907
Hi @v01d ,
I uploaded a pull request on
https://github.com/apache/incubator-nuttx/pull/1843
please review again
--
anchao opened a new pull request #1843:
URL: https://github.com/apache/incubator-nuttx/pull/1843
## Summary
make/clean: clean the OBJ directly if declare in subdirectory
Discussion on https://github.com/apache/incubator-nuttx-apps/pull/395
Signed-off-by: chao.an
v01d commented on pull request #1834:
URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694966840
PS: We will have to slowly build the email -> realname mapping. Maybe
everyone can look for themselves in git logs and add all possible emails. The
mapping should go to the
v01d commented on pull request #395:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/395#issuecomment-694965875
What I'm suggesting is not a hack, it is actually the safest approach
(remove $(OBJS), not just any .o in current directory). Please try it.
--
v01d commented on pull request #1834:
URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694965201
Once I get this completed with the missing features I mentioned, I think we
should test it over different files and try to validate the whole detection
process to gain conf
v01d edited a comment on pull request #1834:
URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694964116
I managed to add quite a few features today, I'm now checking detected
authors against ICLAs using Apache JSON files. I'm first trying to match the
name to these JSO
v01d commented on pull request #1834:
URL: https://github.com/apache/incubator-nuttx/pull/1834#issuecomment-694964116
I managed to add quite a few features today, I'm now checking detected
authors against ICLAs using Apache JSON files. I'm first trying to match the
name to these JSONs and
anchao commented on pull request #395:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/395#issuecomment-694962891
Emm Seriously, I don't really want to put this hack on the main line.
This kind of processing will make the NUTTX repo seems weird I think if
nuttx mainline k
v01d commented on pull request #395:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/395#issuecomment-694952602
I understand completely and your analysis is correct. I agree that VPATH is
problematic and that whole "use the path to build object name" only complicates
it. We shoul
anchao edited a comment on pull request #395:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/395#issuecomment-694942015
Hi @v01d,
Yes, thanks for review, totally agree with you!
Let me first introduce the cause of this issue first,
In some open source projects, we
anchao commented on pull request #395:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/395#issuecomment-694942015
Hi @v01d,
Yes, thanks for review, totally agree with you!
Let me first introduce the cause of this issue first,
In some open source projects, we often
Bhindhiya opened a new pull request #1842:
URL: https://github.com/apache/incubator-nuttx/pull/1842
## Summary
Rearranged the defconfig files of RX65N GR-ROSE and RX65N RSK-2MB boards
(netsnsh and nsh configurations).
Removed the undefined Kconfig in defconfig files.
Modified R
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 1473c68 nRF52: Add hooks for missing SPI register callbacks
new 1efbb4c Fix build errors when usin
xiaoxiang781216 merged pull request #1835:
URL: https://github.com/apache/incubator-nuttx/pull/1835
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit 1efbb4c114880a6ffa2181f9a326389ae282da42
Author: Augusto Fraga Giachero
AuthorDate: Thu Sep 17 15:54:37 2020
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
commit f92e9641cdcc76264af2bb48375241f3b2844d9b
Author: Augusto Fraga Giachero
AuthorDate: Fri Sep 18 09:43:17 2020
v01d commented on pull request #395:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/395#issuecomment-694867598
It is possible that once you do this change, some leftover .o will remain
after a clean (since right now the CLEAN target
simply removes all .o files instead of look
xiaoxiang781216 commented on pull request #395:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/395#issuecomment-694864796
Yes, I think too.
This is an automated message from the Apache Git Service.
To respond to th
v01d commented on pull request #395:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/395#issuecomment-694861664
This feel a bit hackish. Shouldn't CLEAN take care of this?
I think I know why this is needed: if you declare SRCS inside subdirectories
from a Makefile.defs in anoth
Palmitoxico commented on pull request #1835:
URL: https://github.com/apache/incubator-nuttx/pull/1835#issuecomment-694850414
Should be fixed now.
This is an automated message from the Apache Git Service.
To respond to the mes
Palmitoxico commented on pull request #1835:
URL: https://github.com/apache/incubator-nuttx/pull/1835#issuecomment-694837474
Oh I'll fix that. It is my fault though (I'm the original author of this
file).
This is an automate
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 1473c68 nRF52: Add hooks for missin
xiaoxiang781216 merged pull request #1839:
URL: https://github.com/apache/incubator-nuttx/pull/1839
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 closed pull request #1813:
URL: https://github.com/apache/incubator-nuttx/pull/1813
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 commented on pull request #1813:
URL: https://github.com/apache/incubator-nuttx/pull/1813#issuecomment-694787593
Let's close this PR now, since the problem is already fixed by 1817
This is an automated message
yamt commented on pull request #1817:
URL: https://github.com/apache/incubator-nuttx/pull/1817#issuecomment-69421
@GUIDINGLI
env.sh is to be sourced to set up PATH to prebuilt binaries.
like:
. $prebuilt/env.sh
as far as i know, it isn't used for the ci.
--
slorquet commented on pull request #1841:
URL: https://github.com/apache/incubator-nuttx/pull/1841#issuecomment-694775687
Yes, makes sense. Thanks for the poke.
There was only one commented use in our codebase, so no impact.
--
yamt merged pull request #1817:
URL: https://github.com/apache/incubator-nuttx/pull/1817
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
This is an automated email from the ASF dual-hosted git repository.
yamamoto pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new a983025 SIM in MacOS: make MacOS lin
fjpanag commented on pull request #1841:
URL: https://github.com/apache/incubator-nuttx/pull/1841#issuecomment-694774952
Sorry for not making it clear. The feature is fully usable. There is
absolutely no impact on current code.
It is just the interface removed, that allows users to b
davids5 commented on pull request #1841:
URL: https://github.com/apache/incubator-nuttx/pull/1841#issuecomment-694775368
@slorquet Sorry. I should have pointed it out, It it was in the other
thread:
>Luckily this function is not used anywhere now. Core over-drive is handled
directl
slorquet edited a comment on issue #1568:
URL:
https://github.com/apache/incubator-nuttx/issues/1568#issuecomment-694772173
edit --- got useful explanations of why this function is now useless.
This is an automated message f
slorquet edited a comment on pull request #1841:
URL: https://github.com/apache/incubator-nuttx/pull/1841#issuecomment-694773971
If the feature is usable some other way, then I have no concern with the
removal of this function
However it was not clear initially wether removing this f
slorquet commented on pull request #1841:
URL: https://github.com/apache/incubator-nuttx/pull/1841#issuecomment-694773971
If the feature is usable some other way, then I have no concern with the
removal of this function
However it was not clear initially wether removing this function
davids5 merged pull request #1841:
URL: https://github.com/apache/incubator-nuttx/pull/1841
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 7554eed input: STMPE811 GPIO interrupt bug fixes
add b0b5f87 Removed broken overdrive function in ST
fjpanag commented on pull request #1841:
URL: https://github.com/apache/incubator-nuttx/pull/1841#issuecomment-694773537
@slorquet No, this is not what you think.
If your board runs on 180MHz, overdrive is automatically enabled in
`stm32f40xxx_rcc.c`.
This is for toggling overdriv
davids5 commented on pull request #1841:
URL: https://github.com/apache/incubator-nuttx/pull/1841#issuecomment-694773426
> I may have added this, is it why I was tagged?
>
Yes. Thank you for responding.
> it can be removed, it was only used for a time, but not successfully
slorquet edited a comment on pull request #1841:
URL: https://github.com/apache/incubator-nuttx/pull/1841#issuecomment-694771484
I may have added this, is it why I was tagged?
it can be removed, it was only used for a time, but not successfully IIRC.
But why not try to make thi
slorquet edited a comment on issue #1568:
URL:
https://github.com/apache/incubator-nuttx/issues/1568#issuecomment-694772173
Is this function really broken or hard to use?
it has some benefit, it allows stm32f4 to run at 180 Mhz instead of being
restricted to lower speed. If I unders
slorquet commented on issue #1568:
URL:
https://github.com/apache/incubator-nuttx/issues/1568#issuecomment-694772173
Is this function really broken or hard to use?
it has some benefit, it allows stm32f4 to run at 180 Mhz instead of being
restricted to lower speed. If I understand co
slorquet commented on pull request #1841:
URL: https://github.com/apache/incubator-nuttx/pull/1841#issuecomment-694771484
I may have added this, is it why I was tagged?
it can be removed, it was only used for a time, but not successfully IIRC.
But why not try to make this work
davids5 commented on pull request #1841:
URL: https://github.com/apache/incubator-nuttx/pull/1841#issuecomment-694770015
> @davids5, I've never used overdrive mode, probably you want to mentioned
somebody else?
Ok no worries, I only asked because you are on the blame.
` is broken.
It violates the sequence defined by ST, and generally it seems that it is
not fixable due to very strange
Donny9 opened a new pull request #1840:
URL: https://github.com/apache/incubator-nuttx/pull/1840
#Summary
POLLPRI
There is some exceptional condition on the file descriptor.
Possibilities include:
* There is out-of-band data on a TCP socket (see tcp(7)).
GUIDINGLI edited a comment on pull request #1817:
URL: https://github.com/apache/incubator-nuttx/pull/1817#issuecomment-694714243
@yamt
I have add the objcopy PATH to env.sh at:
https://github.com/apache/incubator-nuttx-testing/pull/64
ln -s /usr/local/opt/binutils/bin/objcopy
GUIDINGLI commented on pull request #1817:
URL: https://github.com/apache/incubator-nuttx/pull/1817#issuecomment-694714243
@yamt
I have add the objcopy PATH to env.sh at:
https://github.com/apache/incubator-nuttx-testing/pull/64
But how to use env.sh ?
This I have seen y
anchao commented on a change in pull request #395:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/395#discussion_r490752461
##
File path: Application.mk
##
@@ -238,6 +238,7 @@ depend:: .depend
clean::
$(call CLEAN)
+ $(Q) rm -f $(wildcard $(foreach o
92 matches
Mail list logo
