[GitHub] [incubator-nuttx] anchao edited a comment on pull request #1291: socket/SOL: sync the SOL index with linux

2020-06-28 Thread GitBox
anchao edited a comment on pull request #1291: URL: https://github.com/apache/incubator-nuttx/pull/1291#issuecomment-650964575 > ok. sync with IPPROTO_ makes sense. > actually, shouldn't we just remove all SOL_ constants except SOL_SOCKET, and use IPPROTO_ constants instead? Done,

[GitHub] [incubator-nuttx] anchao commented on pull request #1291: socket/SOL: sync the SOL index with linux

2020-06-28 Thread GitBox
anchao commented on pull request #1291: URL: https://github.com/apache/incubator-nuttx/pull/1291#issuecomment-650964575 > ok. sync with IPPROTO_ makes sense. > actually, shouldn't we just remove all SOL_ constants except SOL_SOCKET, and use IPPROTO_ constants instead? Done, please

[GitHub] [incubator-nuttx] anchao opened a new pull request #1320: net/sockopt: change the socket option style from Linux to BSD

2020-06-28 Thread GitBox
anchao opened a new pull request #1320: URL: https://github.com/apache/incubator-nuttx/pull/1320 ## Summary net/sockopt: change the socket option style from Linux to BSD ``` Linux Programmer's Manual ... IP(7) ... NOTES ... Using the SOL_IP socket opti

[GitHub] [incubator-nuttx-apps] anchao opened a new pull request #311: net/sockopt: change the socket option style from Linux to BSD

2020-06-28 Thread GitBox
anchao opened a new pull request #311: URL: https://github.com/apache/incubator-nuttx-apps/pull/311 ## Summary net/sockopt: change the socket option style from Linux to BSD ``` Linux Programmer's Manual ... IP(7) ... NOTES ... Using the SOL_IP socket op

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1280: Implement fseeko and ftello

2020-06-28 Thread GitBox
xiaoxiang781216 edited a comment on pull request #1280: URL: https://github.com/apache/incubator-nuttx/pull/1280#issuecomment-650952843 Yes, off_t define to int is strange, the better type is long at least. This is an automat

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1280: Implement fseeko and ftello

2020-06-28 Thread GitBox
xiaoxiang781216 commented on pull request #1280: URL: https://github.com/apache/incubator-nuttx/pull/1280#issuecomment-650952843 Yes, off_t define to int is strange, the better type is long. This is an automated message from

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1319: Revert "sched/sched_releasetcb.c: Handle custom stack allocations.

2020-06-28 Thread GitBox
xiaoxiang781216 opened a new pull request #1319: URL: https://github.com/apache/incubator-nuttx/pull/1319 ## Summary Since up_release_stack auto detect whether the memory come from builtin heap ``` if (ttype == TCB_FLAG_TTYPE_KERNEL) { if (kmm_heapmember(dtcb->stack_allo

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1318: nxsched_release_tcb: Should release stack in kernel build too

2020-06-28 Thread GitBox
xiaoxiang781216 opened a new pull request #1318: URL: https://github.com/apache/incubator-nuttx/pull/1318 otherwise the memory can't be reused util the process exit Signed-off-by: Xiang Xiao ## Summary ## Impact ## Testing --

[incubator-nuttx] branch master updated (095e492 -> 676a2b7)

2020-06-28 Thread yamamoto
This is an automated email from the ASF dual-hosted git repository. yamamoto pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 095e492 libc: Replace nuttx/lib/math.h with math.h add 676a2b7 stdio.h: Implement fseeko and ftello

[GitHub] [incubator-nuttx] yamt merged pull request #1280: Implement fseeko and ftello

2020-06-28 Thread GitBox
yamt merged pull request #1280: URL: https://github.com/apache/incubator-nuttx/pull/1280 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-nuttx] yamt commented on pull request #1291: socket/SOL: sync the SOL index with linux

2020-06-28 Thread GitBox
yamt commented on pull request #1291: URL: https://github.com/apache/incubator-nuttx/pull/1291#issuecomment-650911121 ok. sync with IPPROTO_ makes sense. actually, shouldn't we just remove all SOL_ constants except SOL_SOCKET, and use IPPROTO_ constants instead? ---

[incubator-nuttx] branch master updated: libc: Replace nuttx/lib/math.h with math.h

2020-06-28 Thread jerpelea
This is an automated email from the ASF dual-hosted git repository. jerpelea pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 095e492 libc: Replace nuttx/lib/math

[GitHub] [incubator-nuttx] jerpelea merged pull request #1312: libc: Replace nuttx/lib/math.h with math.h

2020-06-28 Thread GitBox
jerpelea merged pull request #1312: URL: https://github.com/apache/incubator-nuttx/pull/1312 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] anchao opened a new pull request #1317: sched/task: unify task initialization

2020-06-28 Thread GitBox
anchao opened a new pull request #1317: URL: https://github.com/apache/incubator-nuttx/pull/1317 ## Summary sched/task: unify task initialization sched/task_init: change the stack pointer type to (void *) ## Impact nxthread_create() nxtask_init() ## Testing ./t

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #310: cxxtest: Should check CONFIG_CXX_EXCEPTION instead of CONFIG_UCLIBCXX…

2020-06-28 Thread GitBox
xiaoxiang781216 opened a new pull request #310: URL: https://github.com/apache/incubator-nuttx-apps/pull/310 …_EXCEPTION ## Summary because user may use libcxx which just define CONFIG_LIBCXX_EXCEPTION ## Impact No functionality change. ## Testing ---

[incubator-nuttx] branch master updated: tools/nxstyle: Support the white list

2020-06-28 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new b2f3a4b tools/nxstyle: Support th

[GitHub] [incubator-nuttx] Ouss4 merged pull request #1309: tools/nxstyle: Support the white list

2020-06-28 Thread GitBox
Ouss4 merged pull request #1309: URL: https://github.com/apache/incubator-nuttx/pull/1309 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] Ouss4 closed issue #1235: nxstyle should not complain on _Exit

2020-06-28 Thread GitBox
Ouss4 closed issue #1235: URL: https://github.com/apache/incubator-nuttx/issues/1235 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-nuttx] btashton commented on pull request #1316: mm: Do not memcopy more than oldsize when realloc

2020-06-28 Thread GitBox
btashton commented on pull request #1316: URL: https://github.com/apache/incubator-nuttx/pull/1316#issuecomment-650809996 @patacongo could you take a look at this and make sure I did not miss something. It looks correct to me but it is a critical component. --

[GitHub] [incubator-nuttx] btashton opened a new pull request #1316: mm: Do not memcopy more than oldsize when realloc

2020-06-28 Thread GitBox
btashton opened a new pull request #1316: URL: https://github.com/apache/incubator-nuttx/pull/1316 ## Summary When realloc up from a mem area to a larger one where a new node is needed. The the larger memory region is copied from the source this can both leak data as well as cause m

[GitHub] [incubator-nuttx] patacongo commented on issue #1263: pthread cleanup callbacks execute in user mode.

2020-06-28 Thread GitBox
patacongo commented on issue #1263: URL: https://github.com/apache/incubator-nuttx/issues/1263#issuecomment-650806116 Related: pthread-specific data destructors are not currently implemented. They need to be and when they are, these destructors must also run in user-mode, in the context

[GitHub] [incubator-nuttx] acassis merged pull request #1310: stm32l4 RCC: configure flash wait states early

2020-06-28 Thread GitBox
acassis merged pull request #1310: URL: https://github.com/apache/incubator-nuttx/pull/1310 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-nuttx] branch master updated: stm32l4 RCC: configure flash wait states early, otherwise execution is corrupted when clock is increased before that

2020-06-28 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 861f80e stm32l4 RCC: configure flash

[GitHub] [incubator-nuttx] acassis commented on pull request #1310: stm32l4 RCC: configure flash wait states early

2020-06-28 Thread GitBox
acassis commented on pull request #1310: URL: https://github.com/apache/incubator-nuttx/pull/1310#issuecomment-650789079 Ok, I think you explained it better here than in the code. BTW, let's to merge it now. This is an autom

[GitHub] [incubator-nuttx] v01d commented on pull request #1310: stm32l4 RCC: configure flash wait states early

2020-06-28 Thread GitBox
v01d commented on pull request #1310: URL: https://github.com/apache/incubator-nuttx/pull/1310#issuecomment-650775072 I think the explanation I left in the code in the form of a comment serves to remind the importance of why that code should not be moved. -

[GitHub] [incubator-nuttx] acassis commented on pull request #1310: stm32l4 RCC: configure flash wait states early

2020-06-28 Thread GitBox
acassis commented on pull request #1310: URL: https://github.com/apache/incubator-nuttx/pull/1310#issuecomment-650760491 Good finding Matias! I think it should be a good idea to include the above Summary into the commit itself because people looking the repository will not see it unless he

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1315: Only build gnu_unwind_find_exidx for ARM archecture

2020-06-28 Thread GitBox
xiaoxiang781216 opened a new pull request #1315: URL: https://github.com/apache/incubator-nuttx/pull/1315 ## Summary since it's ARM specific and the code to libs/libc/machine/arm/ ## Impact No functionality change ## Testing -

[GitHub] [incubator-nuttx] GUIDINGLI opened a new pull request #1314: update risc-v rv32im

2020-06-28 Thread GitBox
GUIDINGLI opened a new pull request #1314: URL: https://github.com/apache/incubator-nuttx/pull/1314 ## Summary ## Impact ## Testing This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1313: cxx: Remove CONFIG_NET guard from [get|set]hostname

2020-06-28 Thread GitBox
xiaoxiang781216 opened a new pull request #1313: URL: https://github.com/apache/incubator-nuttx/pull/1313 since these two functions is always implemented now ## Summary ## Impact No functionality change ## Testing