[GitHub] [inlong] hejiay commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

hejiay commented on code in PR #8095: URL: https://github.com/apache/inlong/pull/8095#discussion_r1208411380 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -51,49 +53,81

[GitHub] [inlong] hejiay commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

hejiay commented on code in PR #8095: URL: https://github.com/apache/inlong/pull/8095#discussion_r1208411858 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -51,49 +53,81

[GitHub] [inlong] healchow opened a new pull request, #8104: [INLONG-8103][CI] Format the order of imports by the spotless plugin

healchow opened a new pull request, #8104: URL: https://github.com/apache/inlong/pull/8104 ### Prepare a Pull Request - Fixes #8103 ### Motivation Format the order of imports by the spotless plugin. ### Modifications Execute the command `mvn spotless:apply`

[GitHub] [inlong] hejiay commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

hejiay commented on code in PR #8095: URL: https://github.com/apache/inlong/pull/8095#discussion_r1208414903 ## inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/sink/TableChange.java: ## @@ -177,9 +177,80 @@ public String toString() { final class Dele

[GitHub] [inlong] healchow commented on a diff in pull request #8100: [INLONG-8098][Manager] Support Inlong user permission control

healchow commented on code in PR #8100: URL: https://github.com/apache/inlong/pull/8100#discussion_r1208420472 ## inlong-manager/manager-dao/src/main/resources/mappers/UserRoleEntityMapper.xml: ## Review Comment: Is the table name `user_role` or `tenant_user_role`? T

[GitHub] [inlong] healchow commented on a diff in pull request #8100: [INLONG-8098][Manager] Support Inlong user permission control

healchow commented on code in PR #8100: URL: https://github.com/apache/inlong/pull/8100#discussion_r1208421170 ## inlong-manager/manager-dao/src/main/resources/mappers/UserRoleEntityMapper.xml: ## Review Comment: I see that the table name is `tenant_user_role`, so your comm

[GitHub] [inlong] lordcheng10 commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

lordcheng10 commented on code in PR #8095: URL: https://github.com/apache/inlong/pull/8095#discussion_r1208768400 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -51,49 +5

[GitHub] [inlong] gong commented on a diff in pull request #8096: [INLONG-8092][Sort] Support all database and multiple tables transmission for Hive

gong commented on code in PR #8096: URL: https://github.com/apache/inlong/pull/8096#discussion_r1208776632 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/hive/src/main/java/org/apache/inlong/sort/hive/HiveTableSink.java: ## @@ -170,23 +188,50 @@ private DataStreamSin

[GitHub] [inlong] gong commented on pull request #8104: [INLONG-8103][CI] Format the order of imports by the spotless plugin

gong commented on PR #8104: URL: https://github.com/apache/inlong/pull/8104#issuecomment-1566418340 Too many style change, why not format code when change old code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [inlong] yunqingmoswu opened a new pull request, #8105: [INLONG-7853][Sort] Add common handle for schema-change in sink

yunqingmoswu opened a new pull request, #8105: URL: https://github.com/apache/inlong/pull/8105 ### Prepare a Pull Request *(Change the title refer to the following example)* - Title Example: [INLONG-7853][Sort] Add common handle for schema-change in sink *(The following *XYZ

[GitHub] [inlong] gong commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

gong commented on code in PR #8095: URL: https://github.com/apache/inlong/pull/8095#discussion_r1208796949 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -42,7 +44,7 @@ p

[GitHub] [inlong] hejiay commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

hejiay commented on code in PR #8095: URL: https://github.com/apache/inlong/pull/8095#discussion_r1208799987 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -51,49 +53,81

[GitHub] [inlong] hejiay commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

hejiay commented on code in PR #8095: URL: https://github.com/apache/inlong/pull/8095#discussion_r1208800947 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -42,7 +44,7 @@

[GitHub] [inlong] healchow commented on pull request #8104: [INLONG-8103][CI] Format the order of imports by the spotless plugin

healchow commented on PR #8104: URL: https://github.com/apache/inlong/pull/8104#issuecomment-1566448032 > Too many style change, why not format code when change old code. @gong This code format is restricted on Maven's spotless plugin, and all submissions must match this format to pas

[GitHub] [inlong] gong commented on a diff in pull request #8105: [INLONG-7853][Sort] Add common handle for schema-change in sink

gong commented on code in PR #8105: URL: https://github.com/apache/inlong/pull/8105#discussion_r1208801911 ## inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/util/SchemaChangeUtils.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [inlong] gong commented on a diff in pull request #8105: [INLONG-7853][Sort] Add common handle for schema-change in sink

gong commented on code in PR #8105: URL: https://github.com/apache/inlong/pull/8105#discussion_r1208839366 ## inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/util/SchemaChangeUtils.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [inlong] gong commented on a diff in pull request #8105: [INLONG-7853][Sort] Add common handle for schema-change in sink

gong commented on code in PR #8105: URL: https://github.com/apache/inlong/pull/8105#discussion_r1208845988 ## inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/util/SchemaChangeUtils.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [inlong] healchow merged pull request #8104: [INLONG-8103][CI] Format the order of imports by the spotless plugin

healchow merged PR #8104: URL: https://github.com/apache/inlong/pull/8104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apa

[GitHub] [inlong] gong commented on a diff in pull request #8105: [INLONG-7853][Sort] Add common handle for schema-change in sink

gong commented on code in PR #8105: URL: https://github.com/apache/inlong/pull/8105#discussion_r1208853226 ## inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/util/SchemaChangeUtils.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [inlong] lordcheng10 commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

lordcheng10 commented on code in PR #8095: URL: https://github.com/apache/inlong/pull/8095#discussion_r1208768400 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -51,49 +5

[GitHub] [inlong] hnrainll opened a new pull request, #8109: [INLONG-8108][DataProxy] WorkflowApprover API Permissions Optimization

hnrainll opened a new pull request, #8109: URL: https://github.com/apache/inlong/pull/8109 ### Prepare a Pull Request - Fixes #8108 ### Motivation WorkflowApprover API can be accessed with too many permissions ### Modifications WorkflowApproverController A