[GitHub] [inlong] EMsnap commented on a diff in pull request #7943: [INLONG-7940][Manager] Use pulsar subscriptions and specify subscription offset in pulsar connector

2023-05-07 Thread via GitHub
EMsnap commented on code in PR #7943: URL: https://github.com/apache/inlong/pull/7943#discussion_r1186967231 ## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/ExtractNodeUtils.java: ## @@ -246,7 +246,9 @@ public static PulsarExtractNode creat

[GitHub] [inlong] Yizhou-Yang commented on a diff in pull request #7924: [INLONG-7900][Sort] Support partition by primary key when upsert single table of Kafka

2023-05-07 Thread via GitHub
Yizhou-Yang commented on code in PR #7924: URL: https://github.com/apache/inlong/pull/7924#discussion_r1186972911 ## inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/partitioner/PrimaryKeyPartitioner.java: ## Review Comment: updating this pr, the

[GitHub] [inlong] EMsnap commented on pull request #7943: [INLONG-7940][Manager] Use pulsar subscriptions and specify subscription offset in pulsar connector

2023-05-07 Thread via GitHub
EMsnap commented on PR #7943: URL: https://github.com/apache/inlong/pull/7943#issuecomment-1537652941 wait for https://github.com/apache/inlong/pull/7937 to be merged first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [inlong] thexiay merged pull request #7878: [INLONG-7831][Sort] Using spilling disk map to reduce memory loss for buffer per parititon data

2023-05-07 Thread via GitHub
thexiay merged PR #7878: URL: https://github.com/apache/inlong/pull/7878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apac

[inlong] branch master updated (bb45659e1 -> 5678f5446)

2023-05-07 Thread thexia
This is an automated email from the ASF dual-hosted git repository. thexia pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git from bb45659e1 [INLONG-7958][Sort] Fix MongoDB's schema becomes unordered after extracting the row data (#7960) add 5

[GitHub] [inlong] dockerzhang merged pull request #7937: [INLONG-7936][Manager] Support issued pulsar subscriptions to sort

2023-05-07 Thread via GitHub
dockerzhang merged PR #7937: URL: https://github.com/apache/inlong/pull/7937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.

[inlong] branch master updated (5678f5446 -> 2431f2f39)

2023-05-07 Thread dockerzhang
This is an automated email from the ASF dual-hosted git repository. dockerzhang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git from 5678f5446 [INLONG-7831][Sort] Using spilling disk map to reduce memory loss for buffer per parititon data (#7878

[GitHub] [inlong] gong commented on pull request #7943: [INLONG-7940][Sort] Use pulsar subscriptions and specify subscription offset in pulsar connector

2023-05-07 Thread via GitHub
gong commented on PR #7943: URL: https://github.com/apache/inlong/pull/7943#issuecomment-1537694696 @EMsnap This feature just can be used when pulsar admin api is supportted. Maybe, for without pulsar admin api situation, inlong manager can't distribute new params to support this feature.

[GitHub] [inlong] EMsnap commented on pull request #7943: [INLONG-7940][Sort] Use pulsar subscriptions and specify subscription offset in pulsar connector

2023-05-07 Thread via GitHub
EMsnap commented on PR #7943: URL: https://github.com/apache/inlong/pull/7943#issuecomment-1537697741 > @EMsnap This feature just can be used when pulsar admin api is supportted. Maybe, for without pulsar admin api situation, inlong manager can't distribute new params to support this featur

[GitHub] [inlong] lordcheng10 commented on a diff in pull request #7905: [INLONG-7903][Sort] Kafka sink supports fixed partition strategy

2023-05-07 Thread via GitHub
lordcheng10 commented on code in PR #7905: URL: https://github.com/apache/inlong/pull/7905#discussion_r1187038416 ## inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java: ## @@ -187,7 +190,21 @@ public final class Constants {

[GitHub] [inlong] lordcheng10 commented on a diff in pull request #7905: [INLONG-7903][Sort] Kafka sink supports fixed partition strategy

2023-05-07 Thread via GitHub
lordcheng10 commented on code in PR #7905: URL: https://github.com/apache/inlong/pull/7905#discussion_r1187039732 ## inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java: ## @@ -187,7 +190,21 @@ public final class Constants {

[GitHub] [inlong] EMsnap merged pull request #7943: [INLONG-7940][Sort] Use pulsar subscriptions and specify subscription offset in pulsar connector

2023-05-07 Thread via GitHub
EMsnap merged PR #7943: URL: https://github.com/apache/inlong/pull/7943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.apach

[inlong] branch master updated: [INLONG-7940][Sort] Use pulsar subscriptions and specify subscription offset in pulsar connector (#7943)

2023-05-07 Thread zirui
This is an automated email from the ASF dual-hosted git repository. zirui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git The following commit(s) were added to refs/heads/master by this push: new 13909ba19 [INLONG-7940][Sort] Use pulsar subscrip

[GitHub] [inlong] lordcheng10 commented on a diff in pull request #7905: [INLONG-7903][Sort] Kafka sink supports fixed partition strategy

2023-05-07 Thread via GitHub
lordcheng10 commented on code in PR #7905: URL: https://github.com/apache/inlong/pull/7905#discussion_r1187069427 ## inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/Constants.java: ## @@ -187,7 +190,21 @@ public final class Constants {