[GitHub] [inlong] healchow commented on a diff in pull request #7274: [INLONG-7273][Manager] Support creating table in Kudu cluster

2023-01-27 Thread via GitHub
healchow commented on code in PR #7274: URL: https://github.com/apache/inlong/pull/7274#discussion_r1089157319 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/sink/kudu/KuduResourceClient.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to th

[GitHub] [inlong] healchow commented on a diff in pull request #7270: [INLONG-7065][Manager] Support register and manage the resource of Kudu sink

2023-01-27 Thread via GitHub
healchow commented on code in PR #7270: URL: https://github.com/apache/inlong/pull/7270#discussion_r1089162774 ## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/node/kudu/KuduDataNodeInfo.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software

[GitHub] [inlong] healchow commented on a diff in pull request #7253: [INLONG-7249][Sort] JDBC accurate dirty data archive and metric calculation

2023-01-27 Thread via GitHub
healchow commented on code in PR #7253: URL: https://github.com/apache/inlong/pull/7253#discussion_r1089170890 ## inlong-sort/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/internal/TableMetricStatementExecutor.java: ## @@ -0,0 +1,172 @@ +/* + * Licensed to the A

[GitHub] [inlong] Yizhou-Yang commented on pull request #7148: [INLONG-7146][Sort] Adjust dirty data multiple sink archive strategy

2023-01-27 Thread via GitHub
Yizhou-Yang commented on PR #7148: URL: https://github.com/apache/inlong/pull/7148#issuecomment-1407280878 this should be seperated into 3 different bugfix patches and should be further optimized. will close this pr later and make it into 3 different prs -- This is an automated message