Re: [PR] [INLONG-11494][Sort] Add Kafka connector on Flink 1.18 [inlong]

2024-11-25 Thread via GitHub
aloyszhang merged PR #11501: URL: https://github.com/apache/inlong/pull/11501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong

Re: [PR] [INLONG-11494][Sort] Add Kafka connector on Flink 1.18 [inlong]

2024-11-24 Thread via GitHub
vernedeng commented on code in PR #11501: URL: https://github.com/apache/inlong/pull/11501#discussion_r1855785041 ## inlong-sort/sort-flink/sort-flink-v1.18/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/source/KafkaSource.java: ## @@ -0,0 +1,258 @@ +/* + * Lic

Re: [PR] [INLONG-11494][Sort] Add Kafka connector on Flink 1.18 [inlong]

2024-11-20 Thread via GitHub
PeterZh6 commented on PR #11501: URL: https://github.com/apache/inlong/pull/11501#issuecomment-2488102023 > Please ref to [inlong/licenses/inlong-sort-connectors/LICENSE](https://github.com/apache/inlong/blob/master/licenses/inlong-sort-connectors/LICENSE), you should add the copied files t

Re: [PR] [INLONG-11494][Sort] Add Kafka connector on Flink 1.18 [inlong]

2024-11-20 Thread via GitHub
aloyszhang commented on PR #11501: URL: https://github.com/apache/inlong/pull/11501#issuecomment-2487931396 Please ref to [inlong/licenses/inlong-sort-connectors/LICENSE](https://github.com/apache/inlong/blob/master/licenses/inlong-sort-connectors/LICENSE), you should add the copied files t

Re: [PR] [INLONG-11494][Sort] Add Kafka connector on Flink 1.18 [inlong]

2024-11-19 Thread via GitHub
aloyszhang commented on PR #11501: URL: https://github.com/apache/inlong/pull/11501#issuecomment-2485366955 please add license if there are some copied codes from other project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [INLONG-11494][Sort] Add Kafka connector on Flink 1.18 [inlong]

2024-11-19 Thread via GitHub
PeterZh6 commented on PR #11501: URL: https://github.com/apache/inlong/pull/11501#issuecomment-2485530735 > please add license if there are some copied codes from other project. Thanks for the reminder! All the copied codes are from [flink-connector-kafka](https://github.com/apache

Re: [PR] [INLONG-11494][Sort] Add Kafka connector on Flink 1.18 [inlong]

2024-11-15 Thread via GitHub
PeterZh6 commented on PR #11501: URL: https://github.com/apache/inlong/pull/11501#issuecomment-2479017992 Sink function of this connector not tested yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to