Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-28 Thread via GitHub
dockerzhang merged PR #10700: URL: https://github.com/apache/inlong/pull/10700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlon

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-25 Thread via GitHub
xxsc0529 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1692597076 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialect.java: ## @@ -0,0 +1,239 @@ +/* + *

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-25 Thread via GitHub
EMsnap commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1692585083 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialect.java: ## @@ -0,0 +1,239 @@ +/* + * Li

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-25 Thread via GitHub
XiaoYou201 commented on PR #10700: URL: https://github.com/apache/inlong/pull/10700#issuecomment-2251897514 LGTM~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-25 Thread via GitHub
xxsc0529 commented on PR #10700: URL: https://github.com/apache/inlong/pull/10700#issuecomment-2251877737 > > > please add test result with real data from any source to oceanbase > > > > > > What kind of test data is needed and where to put it > > You can refer to inlong-so

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-24 Thread via GitHub
XiaoYou201 commented on PR #10700: URL: https://github.com/apache/inlong/pull/10700#issuecomment-2249561835 > > please add test result with real data from any source to oceanbase > > What kind of test data is needed and where to put it You can refer to inlong-sort/sort-end-to-e

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-24 Thread via GitHub
XiaoYou201 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1690880917 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialect.java: ## @@ -0,0 +1,244 @@ +/* +

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-24 Thread via GitHub
XiaoYou201 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1690877425 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialect.java: ## @@ -0,0 +1,244 @@ +/* +

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-24 Thread via GitHub
XiaoYou201 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1690876562 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialectFactory.java: ## @@ -0,0 +1,31 @@

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
xxsc0529 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1689188362 ## inlong-sort/sort-core/src/test/java/org/apache/inlong/sort/parser/MySqlExtractNodeToOceanBaseLoadNodeTest.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
xxsc0529 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1689185398 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialect.java: ## @@ -0,0 +1,244 @@ +/* + *

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
xxsc0529 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1689186281 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialectFactory.java: ## Review Comment:

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
xxsc0529 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1689184031 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialect.java: ## @@ -0,0 +1,244 @@ +/* + *

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
xxsc0529 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1689183278 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialectFactory.java: ## @@ -0,0 +1,31 @@ +/

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
xxsc0529 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1689176575 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialect.java: ## @@ -0,0 +1,244 @@ +/* + *

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
xxsc0529 commented on PR #10700: URL: https://github.com/apache/inlong/pull/10700#issuecomment-2246954120 > please add test result with real data from any source to oceanbase What kind of test data is needed and where to put it -- This is an automated message from the Apache Git Ser

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
XiaoYou201 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1689058825 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialect.java: ## @@ -0,0 +1,244 @@ +/* +

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
XiaoYou201 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1689058944 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialect.java: ## @@ -0,0 +1,244 @@ +/* +

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
XiaoYou201 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1689057755 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialect.java: ## @@ -0,0 +1,244 @@ +/* +

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
XiaoYou201 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1689055233 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialectFactory.java: ## @@ -0,0 +1,31 @@

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
XiaoYou201 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1689054104 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/jdbc/src/main/java/org/apache/inlong/sort/jdbc/dialect/jdbc/JdbcDialectFactory.java: ## Review Comment:

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
EMsnap commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1689051827 ## inlong-sort/sort-core/src/test/java/org/apache/inlong/sort/parser/MySqlExtractNodeToOceanBaseLoadNodeTest.java: ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apache S

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
xxsc0529 commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1688989272 ## inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/extract/OceanBaseExtractNode.java: ## @@ -0,0 +1,336 @@ +/* + * Licensed to the Apache S

Re: [PR] [INLONG-10704][Sort] Sort Add Oceanbase Support [inlong]

2024-07-23 Thread via GitHub
vernedeng commented on code in PR #10700: URL: https://github.com/apache/inlong/pull/10700#discussion_r1687828964 ## inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/extract/OceanBaseExtractNode.java: ## @@ -0,0 +1,336 @@ +/* + * Licensed to the Apache