Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-08-01 Thread via GitHub
dockerzhang merged PR #10735: URL: https://github.com/apache/inlong/pull/10735 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlon

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-31 Thread via GitHub
dockerzhang commented on PR #10735: URL: https://github.com/apache/inlong/pull/10735#issuecomment-2260148505 @haifxu @justinwwhuang PTAL, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-30 Thread via GitHub
zoy0 commented on PR #10735: URL: https://github.com/apache/inlong/pull/10735#issuecomment-2259538263 > please rebase the master to resolve conflicting files done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-30 Thread via GitHub
aloyszhang commented on PR #10735: URL: https://github.com/apache/inlong/pull/10735#issuecomment-2259507082 please rebase the master to resolve conflicting files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-30 Thread via GitHub
zoy0 commented on code in PR #10735: URL: https://github.com/apache/inlong/pull/10735#discussion_r1697792839 ## inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/SQLServerSource.java: ## @@ -17,66 +17,180 @@ package org.apache.inlong.agent.plugin

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-30 Thread via GitHub
dockerzhang commented on PR #10735: URL: https://github.com/apache/inlong/pull/10735#issuecomment-2257824149 @zoy0 please click `resolve` if you fixed the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-30 Thread via GitHub
justinwwhuang commented on code in PR #10735: URL: https://github.com/apache/inlong/pull/10735#discussion_r1696566145 ## inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/SQLServerSource.java: ## @@ -17,66 +17,180 @@ package org.apache.inlong.age

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-30 Thread via GitHub
justinwwhuang commented on code in PR #10735: URL: https://github.com/apache/inlong/pull/10735#discussion_r1696566145 ## inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/SQLServerSource.java: ## @@ -17,66 +17,180 @@ package org.apache.inlong.age

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-30 Thread via GitHub
zoy0 commented on code in PR #10735: URL: https://github.com/apache/inlong/pull/10735#discussion_r1696471913 ## inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/task/SQLServerTask.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-30 Thread via GitHub
zoy0 commented on code in PR #10735: URL: https://github.com/apache/inlong/pull/10735#discussion_r1696459899 ## inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/SQLServerSource.java: ## @@ -17,66 +17,180 @@ package org.apache.inlong.agent.plugin

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-30 Thread via GitHub
zoy0 commented on PR #10735: URL: https://github.com/apache/inlong/pull/10735#issuecomment-2257648846 > 运行“mvn spotless:apply”来修复这些违规行为。 done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-30 Thread via GitHub
justinwwhuang commented on code in PR #10735: URL: https://github.com/apache/inlong/pull/10735#discussion_r1696444835 ## inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/SQLServerSource.java: ## @@ -17,66 +17,180 @@ package org.apache.inlong.age

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-30 Thread via GitHub
justinwwhuang commented on code in PR #10735: URL: https://github.com/apache/inlong/pull/10735#discussion_r1696441363 ## inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/task/SQLServerTask.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software

Re: [PR] [INLONG-10289][Agent] Update the SQLServer Source [inlong]

2024-07-30 Thread via GitHub
dockerzhang commented on PR #10735: URL: https://github.com/apache/inlong/pull/10735#issuecomment-2257623734 Run 'mvn spotless:apply' to fix these violations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo