aloyszhang merged PR #10727:
URL: https://github.com/apache/inlong/pull/10727
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong
qy-liuhuo commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1696366855
##
inlong-agent/agent-plugins/src/test/java/org/apache/inlong/agent/plugin/sources/TestMqttReader.java:
##
@@ -106,13 +107,13 @@ public void setUp() throws Exception
justinwwhuang commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1696365462
##
inlong-agent/agent-plugins/src/test/java/org/apache/inlong/agent/plugin/sources/TestMqttReader.java:
##
@@ -106,13 +107,13 @@ public void setUp() throws Excep
qy-liuhuo commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1696284375
##
inlong-agent/agent-plugins/src/test/java/org/apache/inlong/agent/plugin/sources/TestMqttReader.java:
##
@@ -106,13 +107,13 @@ public void setUp() throws Exception
justinwwhuang commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1696177032
##
inlong-agent/agent-plugins/src/test/java/org/apache/inlong/agent/plugin/sources/TestMqttReader.java:
##
@@ -106,13 +107,13 @@ public void setUp() throws Excep
justinwwhuang commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1696164512
##
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/MqttSource.java:
##
@@ -54,60 +50,76 @@ private List splitSqlJob(String topics
qy-liuhuo commented on PR #10727:
URL: https://github.com/apache/inlong/pull/10727#issuecomment-2255874275
> > I have fixed these issues, please review again, thank you!
>
> please click `resolve` if you fix the comment, thanks.
okļ¼thanks
--
This is an automated message from
dockerzhang commented on PR #10727:
URL: https://github.com/apache/inlong/pull/10727#issuecomment-2255864356
> I have fixed these issues, please review again, thank you!
please click `resolve` if you fix the comment, thanks.
--
This is an automated message from the Apache Git Servic
qy-liuhuo commented on PR #10727:
URL: https://github.com/apache/inlong/pull/10727#issuecomment-2255089171
I have fixed these issues, please review again, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
aloyszhang commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1694632543
##
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/reader/MqttReader.java:
##
@@ -147,6 +137,7 @@ public void deliveryComplete(IMqtt
aloyszhang commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1694630633
##
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/reader/MqttReader.java:
##
@@ -88,22 +77,22 @@ public MqttReader(String topic) {
aloyszhang commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1694630633
##
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/reader/MqttReader.java:
##
@@ -88,22 +77,22 @@ public MqttReader(String topic) {
aloyszhang commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1694628418
##
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/MqttSource.java:
##
@@ -20,63 +20,57 @@
import org.apache.inlong.agent.conf.Inst
vernedeng commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1694563205
##
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/task/MqttTask.java:
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation
vernedeng commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1694562488
##
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/task/MqttTask.java:
##
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation
vernedeng commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1694561750
##
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/reader/MqttReader.java:
##
@@ -246,4 +237,26 @@ public void destroy() {
vernedeng commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1694560301
##
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/MqttSource.java:
##
@@ -87,27 +81,51 @@ protected String getThreadName() {
vernedeng commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1694559483
##
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/MqttSource.java:
##
@@ -20,63 +20,57 @@
import org.apache.inlong.agent.conf.Insta
vernedeng commented on code in PR #10727:
URL: https://github.com/apache/inlong/pull/10727#discussion_r1694558122
##
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sources/MqttSource.java:
##
@@ -20,63 +20,57 @@
import org.apache.inlong.agent.conf.Insta
19 matches
Mail list logo
