Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
EMsnap commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1529615263 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/test/java/org/apache/inlong/sort/redis/RedisTableTest.java: ## @@ -0,0 +1,622 @@ +/* + * Licensed to

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
EMsnap commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1529610943 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/test/java/org/apache/inlong/sort/redis/RedisTableTest.java: ## @@ -0,0 +1,622 @@ +/* + * Licensed to

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
XiaoYou201 commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1528408728 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/common/handler/InlongJedisConfigHandler.java: ## @@ -0,0 +

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
XiaoYou201 commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1528407874 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/pom.xml: ## @@ -0,0 +1,176 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
XiaoYou201 commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1528407502 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/common/config/RedisDataType.java: ## @@ -0,0 +1,52 @@ +/*

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
aloyszhang commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1528327113 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/common/handler/InlongJedisConfigHandler.java: ## @@ -0,0 +

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
aloyszhang commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1528322815 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/common/config/RedisLookupOptions.java: ## @@ -0,0 +1,129 @

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
aloyszhang commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1528322815 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/common/config/RedisLookupOptions.java: ## @@ -0,0 +1,129 @

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
aloyszhang commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1528320907 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/pom.xml: ## @@ -0,0 +1,176 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
aloyszhang commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1528315770 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/pom.xml: ## @@ -43,6 +43,8 @@ hbase hudi kafka +redis + Review Comment:

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
aloyszhang commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1528312373 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/common/config/RedisDataType.java: ## @@ -0,0 +1,52 @@ +/*

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
XiaoYou201 commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1528204801 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/sink/RedisDynamicTableSink.java: ## @@ -0,0 +1,203 @@ +/*

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-18 Thread via GitHub
EMsnap commented on code in PR #9836: URL: https://github.com/apache/inlong/pull/9836#discussion_r1528064540 ## inlong-sort/sort-flink/sort-flink-v1.15/sort-connectors/redis/src/main/java/org/apache/inlong/sort/redis/sink/RedisDynamicTableSink.java: ## @@ -0,0 +1,203 @@ +/* + *

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-17 Thread via GitHub
EMsnap commented on PR #9836: URL: https://github.com/apache/inlong/pull/9836#issuecomment-2002759383 Please fix your uts and build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [INLONG-9835][Sort] Add Redis connector on flink 1.15 [inlong]

2024-03-17 Thread via GitHub
dockerzhang commented on PR #9836: URL: https://github.com/apache/inlong/pull/9836#issuecomment-2002755614 @XiaoYou201 please add more details about this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov