Re: [PR] [INLONG-9791][Sort] Return null instead of throwing an exception when deserialization by type fails [inlong]

2024-03-07 Thread via GitHub
baomingyu commented on code in PR #9792: URL: https://github.com/apache/inlong/pull/9792#discussion_r1517227915 ## inlong-sort/sort-formats/format-rowdata/format-rowdata-base/src/main/java/org/apache/inlong/sort/formats/base/DefaultDeserializationSchema.java: ## @@ -110,7 +125,7

Re: [PR] [INLONG-9791][Sort] Return null instead of throwing an exception when deserialization by type fails [inlong]

2024-03-07 Thread via GitHub
baomingyu commented on code in PR #9792: URL: https://github.com/apache/inlong/pull/9792#discussion_r1517227453 ## inlong-sort/sort-formats/format-rowdata/format-rowdata-json/src/main/java/org/apache/inlong/sort/formats/json/JsonRowDataDeserializationSchema.java: ## @@ -104,13 +

Re: [PR] [INLONG-9791][Sort] Return null instead of throwing an exception when deserialization by type fails [inlong]

2024-03-07 Thread via GitHub
aloyszhang commented on code in PR #9792: URL: https://github.com/apache/inlong/pull/9792#discussion_r1517221979 ## inlong-sort/sort-formats/format-rowdata/format-rowdata-csv/src/main/java/org/apache/inlong/sort/formats/csv/CsvRowDataDeserializationSchema.java: ## @@ -241,12 +24

Re: [PR] [INLONG-9791][Sort] Return null instead of throwing an exception when deserialization by type fails [inlong]

2024-03-07 Thread via GitHub
aloyszhang commented on code in PR #9792: URL: https://github.com/apache/inlong/pull/9792#discussion_r1517221328 ## inlong-sort/sort-formats/format-rowdata/format-rowdata-json/src/main/java/org/apache/inlong/sort/formats/json/JsonRowDataDeserializationSchema.java: ## @@ -104,13

Re: [PR] [INLONG-9791][Sort] Return null instead of throwing an exception when deserialization by type fails [inlong]

2024-03-07 Thread via GitHub
aloyszhang commented on code in PR #9792: URL: https://github.com/apache/inlong/pull/9792#discussion_r1517220312 ## inlong-sort/sort-formats/format-common/src/main/java/org/apache/inlong/sort/formats/inlongmsg/NoOpFailureHandler.java: ## @@ -27,6 +27,12 @@ public class NoOpFailu

Re: [PR] [INLONG-9791][Sort] Return null instead of throwing an exception when deserialization by type fails [inlong]

2024-03-07 Thread via GitHub
aloyszhang commented on code in PR #9792: URL: https://github.com/apache/inlong/pull/9792#discussion_r1517220151 ## inlong-sort/sort-formats/format-common/src/main/java/org/apache/inlong/sort/formats/inlongmsg/IgnoreFailureHandler.java: ## @@ -27,6 +27,11 @@ public class IgnoreF

Re: [PR] [INLONG-9791][Sort] Return null instead of throwing an exception when deserialization by type fails [inlong]

2024-03-07 Thread via GitHub
aloyszhang commented on code in PR #9792: URL: https://github.com/apache/inlong/pull/9792#discussion_r1517214815 ## inlong-sort/sort-formats/format-rowdata/format-rowdata-base/src/main/java/org/apache/inlong/sort/formats/base/DefaultDeserializationSchema.java: ## @@ -110,7 +125,

Re: [PR] [INLONG-9788][Sort] Supports data parse that contains delimiters in kv and csv data format [inlong]

2024-03-07 Thread via GitHub
aloyszhang commented on PR #9789: URL: https://github.com/apache/inlong/pull/9789#issuecomment-1985096882 > New tests test new scenarios,whether to put it in the inventory will be adjusted later. Make sense to me. We can unify the UT later. -- This is an automated message from the

Re: [PR] [INLONG-9788][Sort] Supports data parse that contains delimiters in kv and csv data format [inlong]

2024-03-07 Thread via GitHub
baomingyu commented on PR #9789: URL: https://github.com/apache/inlong/pull/9789#issuecomment-1985043216 > > All existing tests are tests of data in kv and csv formats that combine expected rules. The new ones are scenarios that can parse data in kv and csv formats that do not comply with t

Re: [PR] [INLONG-9735][Manager] Change the Spring version 5.3.27 to 5.3.32 [inlong]

2024-03-07 Thread via GitHub
dockerzhang commented on PR #9790: URL: https://github.com/apache/inlong/pull/9790#issuecomment-1985020939 @XiaoYou201 thanks for your contribution, but please update the version in the license file at the same time, thanks. -- This is an automated message from the Apache Git Service. To

[I] [Improve][Doc] Remove historical version documents [inlong-website]

2024-03-07 Thread via GitHub
bluewang opened a new issue, #928: URL: https://github.com/apache/inlong-website/issues/928 ### Description _No response_ ### Are you willing to submit PR? - [X] Yes, I am willing to submit a PR! ### Code of Conduct - [X] I agree to follow this project's [Co

Re: [PR] [INLONG-9788][Sort] Supports data parse that contains delimiters in kv and csv data format [inlong]

2024-03-07 Thread via GitHub
baomingyu commented on code in PR #9789: URL: https://github.com/apache/inlong/pull/9789#discussion_r1517088758 ## inlong-sort/sort-formats/format-common/src/main/java/org/apache/inlong/sort/formats/util/StringUtils.java: ## @@ -450,11 +489,11 @@ public static String[][] splitCs

[PR] [INLONG-9791][Sort] Return null instead of throwing an exception when deserialization by type fails [inlong]

2024-03-07 Thread via GitHub
baomingyu opened a new pull request, #9792: URL: https://github.com/apache/inlong/pull/9792 … deserialization by type fails - Fixes #9791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [INLONG-9788][Sort] Supports data parse that contains delimiters in kv and csv data format [inlong]

2024-03-07 Thread via GitHub
aloyszhang commented on PR #9789: URL: https://github.com/apache/inlong/pull/9789#issuecomment-1984929970 > All existing tests are tests of data in kv and csv formats that combine expected rules. The new ones are scenarios that can parse data in kv and csv formats that do not comply with th

Re: [PR] [INLONG-9788][Sort] Supports data parse that contains delimiters in kv and csv data format [inlong]

2024-03-07 Thread via GitHub
baomingyu commented on PR #9789: URL: https://github.com/apache/inlong/pull/9789#issuecomment-1984926600 > I found that we already have several tests for `splitKv` or `splitCsv` > > https://github.com/apache/inlong/blob/master/inlong-sort/sort-formats/format-rowdata/format-rowdata-kv/

Re: [PR] [INLONG-9788][Sort] Supports data parse that contains delimiters in kv and csv data format [inlong]

2024-03-07 Thread via GitHub
aloyszhang commented on PR #9789: URL: https://github.com/apache/inlong/pull/9789#issuecomment-1984919436 I found that we already have several tests for `splitKv` or `splitCsv` https://github.com/apache/inlong/blob/master/inlong-sort/sort-formats/format-rowdata/format-rowdata-kv/src/test

Re: [PR] [INLONG-9788][Sort] Supports data parse that contains delimiters in kv and csv data format [inlong]

2024-03-07 Thread via GitHub
aloyszhang commented on code in PR #9789: URL: https://github.com/apache/inlong/pull/9789#discussion_r1517067221 ## inlong-sort/sort-formats/format-common/src/test/java/org/apache/inlong/sort/formats/common/StringUtilsTest.java: ## @@ -0,0 +1,97 @@ +package org.apache.inlong.sor

Re: [PR] [INLONG-9788][Sort] Supports data parse that contains delimiters in kv and csv data format [inlong]

2024-03-07 Thread via GitHub
aloyszhang commented on code in PR #9789: URL: https://github.com/apache/inlong/pull/9789#discussion_r1517064943 ## inlong-sort/sort-formats/format-common/src/main/java/org/apache/inlong/sort/formats/util/StringUtils.java: ## @@ -450,11 +489,11 @@ public static String[][] splitC

[PR] [INLONG-9735][Manager] Change the Spring version 5.3.27 to 5.3.32 [inlong]

2024-03-07 Thread via GitHub
XiaoYou201 opened a new pull request, #9790: URL: https://github.com/apache/inlong/pull/9790 ### Prepare a Pull Request - [INLONG-9735][Manager] Spring Web vulnerable to Open Redirect or Server Side Request Forgery - Fixes #9735 ### Motivation Applic

[PR] [INLONG-9788][Sort] Supports data parse that contains delimiters in kv and csv data format [inlong]

2024-03-07 Thread via GitHub
baomingyu opened a new pull request, #9789: URL: https://github.com/apache/inlong/pull/9789 - Fixes #9788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [I] [Improve][Manager] Spring Web vulnerable to Open Redirect or Server Side Request Forgery [inlong]

2024-03-07 Thread via GitHub
XiaoYou201 commented on issue #9735: URL: https://github.com/apache/inlong/issues/9735#issuecomment-1983267694 I would like to work on this issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

(inlong) branch master updated: [INLONG-9774][Sort] Support rowdata way of sort InLong message tlog-kv format (#9780)

2024-03-07 Thread dockerzhang
This is an automated email from the ASF dual-hosted git repository. dockerzhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git The following commit(s) were added to refs/heads/master by this push: new 29574c04cf [INLONG-9774][Sort] Support rowd

Re: [PR] [INLONG-9774][Sort] Support rowdata way of sort InLong message tlog-kv format [inlong]

2024-03-07 Thread via GitHub
dockerzhang merged PR #9780: URL: https://github.com/apache/inlong/pull/9780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.

(inlong) branch master updated: [INLONG-9783][Sort] Add compatibility processing of tid to streamId changes in the message deserialization base class (#9785)

2024-03-07 Thread dockerzhang
This is an automated email from the ASF dual-hosted git repository. dockerzhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git The following commit(s) were added to refs/heads/master by this push: new 03933e4072 [INLONG-9783][Sort] Add compatib

Re: [PR] [INLONG-9783][Sort] Add compatibility processing of tid to streamId changes in the message deserialization base class [inlong]

2024-03-07 Thread via GitHub
dockerzhang merged PR #9785: URL: https://github.com/apache/inlong/pull/9785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.