nsivabalan commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2762430714
hey can you post comparison of compaction commit metadata from 0.15.0 and w/
this patch side by side. I am concerned no how we missed "numWrites" in the
previous round.
--
This
linliu-code commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2762917191
https://github.com/user-attachments/assets/7b591ea3-b350-4435-9113-60aa5a4f2082";
/>
https://github.com/user-attachments/assets/9ee1c90c-024b-4cd5-b6ae-18c5344d6b13";
/>
https://
codope merged PR #13047:
URL: https://github.com/apache/hudi/pull/13047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.
hudi-bot commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2763302788
## CI report:
* ef730f2f3e2bff9e4946b260b956500fcb4e8f51 Azure:
[SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=4541)
hudi-bot commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2763302279
## CI report:
* ef730f2f3e2bff9e4946b260b956500fcb4e8f51 UNKNOWN
Bot commands
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run th
hudi-bot commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2763153430
## CI report:
* 7b446c67365ea8073d4ee9a268bc446e6b5a0335 UNKNOWN
* 81e9e5c456416b45e254407b9ac2660114124fc0 UNKNOWN
* ef730f2f3e2bff9e4946b260b956500fcb4e8f51 Azure:
[CANC
hudi-bot commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2763144877
## CI report:
* 7b446c67365ea8073d4ee9a268bc446e6b5a0335 UNKNOWN
* 81e9e5c456416b45e254407b9ac2660114124fc0 UNKNOWN
* a1243dc67b0348ef481b64b635441185bf40f936 Azure:
[SUCC
yihua commented on code in PR #13047:
URL: https://github.com/apache/hudi/pull/13047#discussion_r2019727386
##
hudi-common/src/main/java/org/apache/hudi/common/table/read/PositionBasedFileGroupRecordBuffer.java:
##
@@ -246,14 +245,22 @@ protected boolean hasNextBaseRecord(T base
hudi-bot commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2763140636
## CI report:
* 7b446c67365ea8073d4ee9a268bc446e6b5a0335 UNKNOWN
* 81e9e5c456416b45e254407b9ac2660114124fc0 UNKNOWN
* a1243dc67b0348ef481b64b635441185bf40f936 Azure:
[SUCC
nsivabalan opened a new pull request, #13055:
URL: https://github.com/apache/hudi/pull/13055
### Change Logs
This number was not properly added since by default the position-based
buffer does not collect these metrics properly.
### Impact
Fixed it.
### Risk level
linliu-code commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2762833288
0.15.0 stats:
`{"partitionToWriteStats": {"map": {"san_francisco": [{"fileId": {"string":
"a8f36eff-d8d1-44ca-8644-a36ae51224a3-0"}, "path": {"string":
"san_francisco/a8f36eff-d
linliu-code commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2762672215
> hey can you post comparison of compaction commit metadata from 0.15.0 and
w/ this patch side by side. I am concerned on how we missed "numWrites" in the
previous round.
Sure.
linliu-code commented on code in PR #13047:
URL: https://github.com/apache/hudi/pull/13047#discussion_r2017746196
##
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/HoodieSparkFileGroupReaderBasedMergeHandle.java:
##
@@ -283,6 +283,10 @@ public List close() {
hudi-bot commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2759972361
## CI report:
* 7b446c67365ea8073d4ee9a268bc446e6b5a0335 UNKNOWN
* 81e9e5c456416b45e254407b9ac2660114124fc0 UNKNOWN
* a1243dc67b0348ef481b64b635441185bf40f936 Azure:
[SUCC
hudi-bot commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2759886011
## CI report:
* 7b446c67365ea8073d4ee9a268bc446e6b5a0335 UNKNOWN
* 81e9e5c456416b45e254407b9ac2660114124fc0 UNKNOWN
* a1243dc67b0348ef481b64b635441185bf40f936 Azure:
[PEND
hudi-bot commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2759868032
## CI report:
* 7b446c67365ea8073d4ee9a268bc446e6b5a0335 UNKNOWN
* 81e9e5c456416b45e254407b9ac2660114124fc0 UNKNOWN
* a1243dc67b0348ef481b64b635441185bf40f936 UNKNOWN
yihua commented on code in PR #13047:
URL: https://github.com/apache/hudi/pull/13047#discussion_r2017740704
##
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/HoodieSparkFileGroupReaderBasedMergeHandle.java:
##
@@ -283,6 +283,10 @@ public List close() {
wri
hudi-bot commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2759788276
## CI report:
* 7b446c67365ea8073d4ee9a268bc446e6b5a0335 UNKNOWN
* 81e9e5c456416b45e254407b9ac2660114124fc0 UNKNOWN
Bot commands
@hudi-bot supports the followi
hudi-bot commented on PR #13047:
URL: https://github.com/apache/hudi/pull/13047#issuecomment-2759785156
## CI report:
* 7b446c67365ea8073d4ee9a268bc446e6b5a0335 UNKNOWN
Bot commands
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run th
linliu-code opened a new pull request, #13047:
URL: https://github.com/apache/hudi/pull/13047
### Change Logs
This number was not properly added since
1. it is not copied from FG reader read stats.
2. for position-based buffer, it is not collected at all.
### Impact
20 matches
Mail list logo
