Re: [PR] [#6712] feat(core): Support user event to Gravitino server [gravitino]

2025-03-28 Thread via GitHub
Abyss-lord commented on PR #6746: URL: https://github.com/apache/gravitino/pull/6746#issuecomment-2760443601 Hi @FANNG1 , I've completed the code updates and would appreciate your review of the PR when you have a moment. Here's a summary of the commits: 1. remove useless construct method.

Re: [PR] [#6693] improvement(authz): Support to rename Hive table in the Ranger authz plugin [gravitino]

2025-03-28 Thread via GitHub
jerqi commented on code in PR #6770: URL: https://github.com/apache/gravitino/pull/6770#discussion_r2018105013 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java: ## @@ -665,8 +690,43 @@ public Boolea

Re: [PR] [#6693] improvement(authz): Support to rename Hive table in the Ranger authz plugin [gravitino]

2025-03-28 Thread via GitHub
jerqi commented on code in PR #6770: URL: https://github.com/apache/gravitino/pull/6770#discussion_r2018108535 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java: ## @@ -761,18 +772,36 @@ public Boolean o

(gravitino) branch main updated: [#5202] feat(client-python): Support Column and its default value part1 (#6542)

2025-03-28 Thread liuxun
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 2668aaf2bd [#5202] feat(client-python): Support C

Re: [PR] [#5202] feat(client-python): Support Column and its default value part1 [gravitino]

2025-03-28 Thread via GitHub
xunliu merged PR #6542: URL: https://github.com/apache/gravitino/pull/6542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [I] [Improvement] Supports get Fileset schema location in the AuthorizationUtils [gravitino]

2025-03-28 Thread via GitHub
yuqi1129 closed issue #6133: [Improvement] Supports get Fileset schema location in the AuthorizationUtils URL: https://github.com/apache/gravitino/issues/6133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [#6693] improvement(authz): Support to rename Hive table in the Ranger authz plugin [gravitino]

2025-03-28 Thread via GitHub
jerqi commented on code in PR #6770: URL: https://github.com/apache/gravitino/pull/6770#discussion_r2018108296 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java: ## @@ -735,18 +735,29 @@ public Boolean o

Re: [PR] [#6525] feat: Support update comment operations for model alteration [gravitino]

2025-03-28 Thread via GitHub
TEOTEO520 commented on PR #6718: URL: https://github.com/apache/gravitino/pull/6718#issuecomment-2760681751 > In the meantime, I would suggest you to split this PR to several small PRs. > > > 1. Add ModelChange API interface for comment modification > > 2. Implement comment update l

Re: [PR] [#6693] improvement(authz): Support to rename Hive table in the Ranger authz plugin [gravitino]

2025-03-28 Thread via GitHub
xunliu commented on code in PR #6770: URL: https://github.com/apache/gravitino/pull/6770#discussion_r2018047084 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java: ## @@ -761,18 +772,36 @@ public Boolean

Re: [PR] [#6693] improvement(authz): Support to rename Hive table in the Ranger authz plugin [gravitino]

2025-03-28 Thread via GitHub
jerqi commented on code in PR #6770: URL: https://github.com/apache/gravitino/pull/6770#discussion_r2018533590 ## api/src/main/java/org/apache/gravitino/authorization/MetadataObjectChange.java: ## @@ -41,6 +41,19 @@ static MetadataObjectChange rename( return new RenameMetad

Re: [PR] [#6693] improvement(authz): Support to rename Hive table in the Ranger authz plugin [gravitino]

2025-03-28 Thread via GitHub
yuqi1129 commented on code in PR #6770: URL: https://github.com/apache/gravitino/pull/6770#discussion_r2018572075 ## api/src/main/java/org/apache/gravitino/authorization/MetadataObjectChange.java: ## @@ -100,7 +117,8 @@ public boolean equals(Object o) { if (o == null || g

Re: [PR] [#6744] improvment(core): Batch get metadata objects for TagMetaService [gravitino]

2025-03-28 Thread via GitHub
jerryshao commented on code in PR #6752: URL: https://github.com/apache/gravitino/pull/6752#discussion_r2019460309 ## core/src/main/java/org/apache/gravitino/storage/relational/mapper/provider/base/TableColumnBaseSQLProvider.java: ## @@ -132,4 +132,37 @@ public String selectColu

Re: [PR] [#6744] improvment(core): Batch get metadata objects for TagMetaService [gravitino]

2025-03-28 Thread via GitHub
jerryshao commented on code in PR #6752: URL: https://github.com/apache/gravitino/pull/6752#discussion_r2019454955 ## core/src/main/java/org/apache/gravitino/storage/relational/mapper/TableColumnMapper.java: ## @@ -71,4 +71,7 @@ Long selectColumnIdByTableIdAndName( @SelectP

[I] [Subtask] Enable the Gravitino Cli to carry a token when requesting the Gravitino Server for metadata authorization. [gravitino]

2025-03-28 Thread via GitHub
hdygxsj opened a new issue, #6793: URL: https://github.com/apache/gravitino/issues/6793 ### Describe the subtask Enable the Gravitino Cli to carry a token when requesting the Gravitino Server for metadata authorization. ### Parent issue #6762 -- This is an automated m

Re: [PR] [#6777] fix(server,authn): Fix use catalog and show databases failed with krb cluster issue [gravitino]

2025-03-28 Thread via GitHub
jerqi commented on code in PR #6778: URL: https://github.com/apache/gravitino/pull/6778#discussion_r2018445992 ## server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosAuthenticator.java: ## @@ -171,13 +169,7 @@ private Principal retrievePrincipalFromTok

[I] [Subtask] Enable the Spark Connector to carry a token when requesting the Gravitino Server for metadata authorization. [gravitino]

2025-03-28 Thread via GitHub
hdygxsj opened a new issue, #6791: URL: https://github.com/apache/gravitino/issues/6791 ### Describe the subtask Enable the Spark Connector to carry a token when requesting the Gravitino Server for metadata authorization. ### Parent issue #6762 -- This is an automated

[I] [Subtask] Enable the Trino Connector to carry a token when requesting the Gravitino Server for metadata authorization. [gravitino]

2025-03-28 Thread via GitHub
hdygxsj opened a new issue, #6792: URL: https://github.com/apache/gravitino/issues/6792 ### Describe the subtask Enable the Trino Connector to carry a token when requesting the Gravitino Server for metadata authorization. ### Parent issue #6762 -- This is an automate

[I] [Subtask] Enable the Flink Connector to carry a token when requesting the Gravitino Server for metadata authorization. [gravitino]

2025-03-28 Thread via GitHub
hdygxsj opened a new issue, #6790: URL: https://github.com/apache/gravitino/issues/6790 ### Describe the subtask Enable the Flink Connector to carry a token when requesting the Gravitino Server for metadata authorization. ### Parent issue #6762 -- This is an automate

[PR] [#5202] feat(client-python): Support Column and its default value part1 - Column [gravitino]

2025-03-28 Thread via GitHub
tsungchih opened a new pull request, #6795: URL: https://github.com/apache/gravitino/pull/6795 ### What changes were proposed in this pull request? This is first part (totally 4 planned) of implementation to the following classes from Java to support Column and its default val

Re: [PR] [#6744] improvment(core): Batch get metadata objects for TagMetaService [gravitino]

2025-03-28 Thread via GitHub
jerryshao commented on code in PR #6752: URL: https://github.com/apache/gravitino/pull/6752#discussion_r2019471108 ## core/src/main/java/org/apache/gravitino/storage/relational/service/MetadataObjectService.java: ## @@ -389,6 +261,51 @@ public static Map getTableObjectsFullName

Re: [PR] [#6234] feat(core): Support rename operations for model alteration [gravitino]

2025-03-28 Thread via GitHub
jerryshao commented on code in PR #6765: URL: https://github.com/apache/gravitino/pull/6765#discussion_r2019424462 ## catalogs/catalog-model/src/main/java/org/apache/gravitino/catalog/model/ModelCatalogOperations.java: ## @@ -141,7 +143,8 @@ public Model registerModel(NameIdenti

[I] [Bug report] use catalog and show databases failed with krb cluster [gravitino]

2025-03-28 Thread via GitHub
granewang opened a new issue, #6777: URL: https://github.com/apache/gravitino/issues/6777 ### Version main branch ### Describe what's wrong After running kinit with a keytab, executing the spark-sql command with the following configurations: spark-sql -v --conf spark.p

[PR] [#6777] fix(server,authn): Fix use catalog and show databases failed with krb cluster issue [gravitino]

2025-03-28 Thread via GitHub
granewang opened a new pull request, #6778: URL: https://github.com/apache/gravitino/pull/6778 ### What changes were proposed in this pull request? Fix use catalog and show databases failed with krb cluster issue ### Why are the changes needed? Fix: #6777 ### Doe

Re: [PR] [#6777] fix(server,authn): Fix use catalog and show databases failed with krb cluster issue [gravitino]

2025-03-28 Thread via GitHub
granewang commented on PR #6778: URL: https://github.com/apache/gravitino/pull/6778#issuecomment-2760851220 @jerqi Hi Sir, could you please review this PR when you have time?Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[PR] [SIP] feat(core): Support lineage framework in Gravitino [gravitino]

2025-03-28 Thread via GitHub
FANNG1 opened a new pull request, #6782: URL: https://github.com/apache/gravitino/pull/6782 ### What changes were proposed in this pull request? Support lineage framework in Gravitino ### Why are the changes needed? (Please clarify why the changes are needed. For instance

Re: [PR] [#6777] fix(server,authn): Fix use catalog and show databases failed with krb cluster issue [gravitino]

2025-03-28 Thread via GitHub
jerqi commented on code in PR #6778: URL: https://github.com/apache/gravitino/pull/6778#discussion_r2018445992 ## server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosAuthenticator.java: ## @@ -171,13 +169,7 @@ private Principal retrievePrincipalFromTok

Re: [PR] [#6693] improvement(authz): Support to rename Hive table in the Ranger authz plugin [gravitino]

2025-03-28 Thread via GitHub
jerqi commented on PR #6770: URL: https://github.com/apache/gravitino/pull/6770#issuecomment-2761076481 All comments are addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [#6712] feat(core): Support user event to Gravitino server [gravitino]

2025-03-28 Thread via GitHub
FANNG1 commented on code in PR #6746: URL: https://github.com/apache/gravitino/pull/6746#discussion_r2018048152 ## core/src/main/java/org/apache/gravitino/listener/api/info/UserInfo.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [#6712] feat(core): Support user event to Gravitino server [gravitino]

2025-03-28 Thread via GitHub
FANNG1 commented on code in PR #6746: URL: https://github.com/apache/gravitino/pull/6746#discussion_r2018048633 ## core/src/main/java/org/apache/gravitino/listener/api/info/UserInfo.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [#6712] feat(core): Support user event to Gravitino server [gravitino]

2025-03-28 Thread via GitHub
FANNG1 commented on PR #6746: URL: https://github.com/apache/gravitino/pull/6746#issuecomment-2760422562 Could you add grant & revoke roles event for user too? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [#6712] feat(core): Support user event to Gravitino server [gravitino]

2025-03-28 Thread via GitHub
Abyss-lord commented on PR #6746: URL: https://github.com/apache/gravitino/pull/6746#issuecomment-2760431906 > Could you add grant & revoke roles event for user too? I add these two event in role-related event. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [#6693] improvement(authz): Support to rename Hive table in the Ranger authz plugin [gravitino]

2025-03-28 Thread via GitHub
jerqi commented on code in PR #6770: URL: https://github.com/apache/gravitino/pull/6770#discussion_r2018210493 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java: ## @@ -665,8 +690,43 @@ public Boolea

Re: [PR] [#6525] feat: Support update comment operations for model alteration [gravitino]

2025-03-28 Thread via GitHub
TEOTEO520 commented on PR #6718: URL: https://github.com/apache/gravitino/pull/6718#issuecomment-2760682693 > @TEOTEO520 can you please make the CI pass. OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR