FourFriends commented on PR #6690:
URL: https://github.com/apache/gravitino/pull/6690#issuecomment-2727317650
@jerqi please review this pull request, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
danhuawang commented on code in PR #6599:
URL: https://github.com/apache/gravitino/pull/6599#discussion_r1997837425
##
LICENSE:
##
@@ -305,6 +305,10 @@
./authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/reference/VXUser.java
.
unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1997839206
##
clients/filesystem-fuse/src/fuse_api_handle_debug.rs:
##
@@ -0,0 +1,829 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
danhuawang commented on code in PR #6599:
URL: https://github.com/apache/gravitino/pull/6599#discussion_r1997838036
##
dev/charts/gravitino/Chart.yaml:
##
@@ -0,0 +1,38 @@
+#
Review Comment:
Yes, it's created by `helm create my-chart` automately.
--
This is an automated
unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1997840855
##
clients/filesystem-fuse/src/main.rs:
##
@@ -193,6 +213,33 @@ fn main() -> Result<(), i32> {
path.to_string_lossy().to_string()
};
danhuawang commented on code in PR #6599:
URL: https://github.com/apache/gravitino/pull/6599#discussion_r1997841191
##
dev/charts/gravitino/README.md:
##
@@ -0,0 +1,118 @@
+
+# gravitino
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1997838305
##
clients/filesystem-fuse/src/fuse_api_handle_debug.rs:
##
@@ -0,0 +1,829 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
danhuawang commented on code in PR #6599:
URL: https://github.com/apache/gravitino/pull/6599#discussion_r1997851602
##
dev/charts/gravitino/README.md:
##
@@ -0,0 +1,118 @@
+
+# gravitino
+
+Gravitino is a high-performance, geo-distributed, and federated metadata lake.
It manage
danhuawang commented on code in PR #6599:
URL: https://github.com/apache/gravitino/pull/6599#discussion_r1997862708
##
dev/charts/gravitino/values.yaml:
##
@@ -0,0 +1,208 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreement
jerqi commented on PR #6690:
URL: https://github.com/apache/gravitino/pull/6690#issuecomment-2727950644
Could you add a ut for this fix? Because this is a fix, we need a ut to
prevent others to modify this again by mistake.
--
This is an automated message from the Apache Git Service.
To r
Abyss-lord commented on PR #6688:
URL: https://github.com/apache/gravitino/pull/6688#issuecomment-2727819904
@FANNG1 I’ve finished updating the code. Please take a look at the PR again
when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the mess
sunxiaojian opened a new pull request, #6691:
URL: https://github.com/apache/gravitino/pull/6691
### What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
### Why are the changes needed?
(Please clarify why
xunliu commented on PR #6542:
URL: https://github.com/apache/gravitino/pull/6542#issuecomment-2727771138
hi @tsungchih
I noticed this PR has two Gravitino entities (Column and Tag),
Can you split the Tag parts code to another PR?
--
This is an automated message from the Apache Git S
Abyss-lord commented on PR #6689:
URL: https://github.com/apache/gravitino/pull/6689#issuecomment-2727795922
@yuqi1129 I’ve finished updating the code. Please take a look at the PR
again when you have time. My update is as follows
1. set queue size from 100 to 500
--
This is an aut
tsungchih commented on PR #6542:
URL: https://github.com/apache/gravitino/pull/6542#issuecomment-2727732365
@xunliu @tengqm Could you please help with review of this PR when you are
available? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
jerqi commented on PR #6690:
URL: https://github.com/apache/gravitino/pull/6690#issuecomment-2727945199
> ### Why are the changes needed?
> Fix: #(6682) #6682
>
Could you fix the description?
This is ok.
```
Fix: #6682
```
--
This is an automated message from the
danhuawang commented on code in PR #6599:
URL: https://github.com/apache/gravitino/pull/6599#discussion_r1997861346
##
dev/charts/gravitino/templates/NOTES.txt:
##
@@ -0,0 +1,19 @@
+{{- /*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor l
mchades commented on code in PR #6657:
URL: https://github.com/apache/gravitino/pull/6657#discussion_r1997862300
##
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/jdbc/mysql/MySQLDataTypeTransformer.java:
##
@@ -45,18 +45,36 @@ public
danhuawang commented on code in PR #6599:
URL: https://github.com/apache/gravitino/pull/6599#discussion_r1997859428
##
dev/charts/gravitino/README.md:
##
@@ -0,0 +1,118 @@
+
+# gravitino
+
+Gravitino is a high-performance, geo-distributed, and federated metadata lake.
It manage
predator4ann commented on code in PR #6657:
URL: https://github.com/apache/gravitino/pull/6657#discussion_r1997891614
##
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/jdbc/mysql/MySQLDataTypeTransformer.java:
##
@@ -55,24 +55,54 @@ pu
sunxiaojian commented on PR #6691:
URL: https://github.com/apache/gravitino/pull/6691#issuecomment-2728079389
@FANNG1 PTAL，thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
tsungchih commented on PR #6542:
URL: https://github.com/apache/gravitino/pull/6542#issuecomment-2728069257
> hi @tsungchih I noticed this PR has two Gravitino entities (Column and
Tag), Can you split the Tag parts code to another PR?
Sure, np.
--
This is an automated message from
predator4ann commented on code in PR #6657:
URL: https://github.com/apache/gravitino/pull/6657#discussion_r1997890846
##
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/jdbc/mysql/MySQLDataTypeTransformer.java:
##
@@ -45,18 +45,36 @@ pu
FANNG1 commented on PR #6691:
URL: https://github.com/apache/gravitino/pull/6691#issuecomment-2728376009
@sunxiaojian thanks for the PR, have you test the cases in which user and
password are encoded in uri in real environment?
--
This is an automated message from the Apache Git Service.
24 matches
Mail list logo
