Abyss-lord commented on PR #6686:
URL: https://github.com/apache/gravitino/pull/6686#issuecomment-2723853092
@justinmclean @jerryshao I’ve finished updating the code. Please take a look
at the PR again when you have time. This commit is as follows:
1. add auxlib dir to package during comp
jerryshao commented on PR #6524:
URL: https://github.com/apache/gravitino/pull/6524#issuecomment-2724257792
@TEOTEO520 are you still working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
FANNG1 commented on code in PR #6543:
URL: https://github.com/apache/gravitino/pull/6543#discussion_r1995362822
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/jdbc/JdbcPropertiesConverter.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Softw
FANNG1 commented on code in PR #6688:
URL: https://github.com/apache/gravitino/pull/6688#discussion_r1995376299
##
docs/gravitino-server-config.md:
##
@@ -118,17 +118,17 @@ Gravitino triggers a pre-event before the operation, a
post-event after the comp
# Post-event
-|
FANNG1 commented on PR #6688:
URL: https://github.com/apache/gravitino/pull/6688#issuecomment-2724388678
LGTM except minor comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
Abyss-lord commented on PR #6689:
URL: https://github.com/apache/gravitino/pull/6689#issuecomment-2724175195
@yuqi1129 I’ve finished updating the code. Please take a look at the PR
again when you have time. My update is as follows
1. Set the number of core threads and queue size.
2. S
yuqi1129 commented on code in PR #6689:
URL: https://github.com/apache/gravitino/pull/6689#discussion_r1995269285
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java:
##
@@ -73,18 +77,27 @@
import org.apache.hadoop.fs.FileSt
yuqi1129 commented on code in PR #6689:
URL: https://github.com/apache/gravitino/pull/6689#discussion_r1995174757
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java:
##
@@ -73,18 +77,23 @@
import org.apache.hadoop.fs.FileSt
Abyss-lord commented on PR #6689:
URL: https://github.com/apache/gravitino/pull/6689#issuecomment-2723877817
@yuqi1129 I’ve finished updating the code. Please take a look at the PR
again when you have time. I make thread pool static and remove shutdown logic
in finally block.
--
This is
predator4ann commented on code in PR #6657:
URL: https://github.com/apache/gravitino/pull/6657#discussion_r1988398069
##
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/jdbc/mysql/MySQLDataTypeTransformer.java:
##
@@ -45,18 +45,36 @@ pu
tengqm commented on PR #6659:
URL: https://github.com/apache/gravitino/pull/6659#issuecomment-2724736100
> Hi @tengqm Thanks a lot for your work, greatly appreciated.
>
> I think we'd better avoid heavily rewriting the doc content as the
starting point, my concern is that heavily rewr
hdygxsj commented on code in PR #6543:
URL: https://github.com/apache/gravitino/pull/6543#discussion_r1995586459
##
flink-connector/flink/src/test/java/org/apache/gravitino/flink/connector/jdbc/AbstractJdbcPropertiesConverter.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apa
jerryshao commented on PR #6659:
URL: https://github.com/apache/gravitino/pull/6659#issuecomment-2724209921
Hi @tengqm Thanks a lot for your work, greatly appreciated.
I think we'd better avoid heavily rewriting the doc content as the starting
point, my concern is that heavily rewriti
13 matches
Mail list logo
