Re: [PR] [Minor] Update unknowntpo's organization due to career change in MAINTAINERS.md [gravitino]

justinmclean commented on PR #6572: URL: https://github.com/apache/gravitino/pull/6572#issuecomment-2692532849 Please revert this change. The MAINTAINERS.md files exist for historical legal reasons and alterations should not be made to it. -- This is an automated message from the Apache G

Re: [PR] [#75]: add CI check for playground [gravitino-playground]

unknowntpo commented on code in PR #111: URL: https://github.com/apache/gravitino-playground/pull/111#discussion_r1976415351 ## init/common/init_metalake_catalog.sh: ## @@ -35,9 +38,12 @@ if echo "$response" | grep -q "\"code\":0"; then true else # Create Hive catalog fo

Re: [PR] [#75]: add CI check for playground [gravitino-playground]

danhuawang commented on code in PR #111: URL: https://github.com/apache/gravitino-playground/pull/111#discussion_r1976245610 ## init/common/init_metalake_catalog.sh: ## @@ -35,9 +38,12 @@ if echo "$response" | grep -q "\"code\":0"; then true else # Create Hive catalog fo

Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

unknowntpo commented on code in PR #5905: URL: https://github.com/apache/gravitino/pull/5905#discussion_r1976515011 ## clients/filesystem-fuse/src/fuse_api_handle_debug.rs: ## @@ -0,0 +1,871 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976542001 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CatalogAudit.java: ## @@ -53,12 +53,20 @@ public void handle() { result = client.loadCatalo

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

Brijeshthummar02 commented on PR #6573: URL: https://github.com/apache/gravitino/pull/6573#issuecomment-2692560838 @justinmclean @tengqm tried to fix and resolve as suggested can just go through it ones also removed what i feel is not needed. -- This is an automated message from the Apach

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976543674 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CatalogAudit.java: ## @@ -53,20 +53,15 @@ public void handle() { result = client.loadCatalo

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976544094 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java: ## @@ -48,53 +47,57 @@ public ListColumns( this.table = table; } - /*

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976544253 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListFilesetProperties.java: ## @@ -60,27 +60,28 @@ public ListFilesetProperties( @Override p

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976543782 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogProperties.java: ## @@ -49,31 +48,19 @@ public ListCatalogProperties(CommandContext con

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on PR #6573: URL: https://github.com/apache/gravitino/pull/6573#issuecomment-2692565430 The CI is failing as we use spotless to make sure the code has consistent formatting. You'll need to run `./gradlew :clients:cli:spotlessApply` and check in the changes to fix this

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976544253 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListFilesetProperties.java: ## @@ -60,27 +60,28 @@ public ListFilesetProperties( @Override p

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

Brijeshthummar02 commented on PR #6573: URL: https://github.com/apache/gravitino/pull/6573#issuecomment-2692571973 @justinmclean i can not run ./gradlew :clients:cli:spotlessApply as i am using java 21 and it req java 17. -- This is an automated message from the Apache Git Service. To res

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

Brijeshthummar02 commented on PR #6573: URL: https://github.com/apache/gravitino/pull/6573#issuecomment-2692579596 @justinmclean as you see build is successful.  -- T

Re: [PR] [Minor] Update unknowntpo's organization due to career change in MAINTAINERS.md [gravitino]

unknowntpo commented on PR #6572: URL: https://github.com/apache/gravitino/pull/6572#issuecomment-2692545875 > Please revert this change. The MAINTAINERS.md files exist for historical legal reasons and alterations should not be made to it. @justinmclean Thank for reminding me, I didn'

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

tengqm commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976537689 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CatalogAudit.java: ## @@ -53,12 +53,20 @@ public void handle() { result = client.loadCatalog(this

Re: [PR] [#5202] feat(client-python): Support Column and its default value part1 [gravitino]

tsungchih commented on PR #6542: URL: https://github.com/apache/gravitino/pull/6542#issuecomment-2692554655 Looked into the failed messages in CI. It showed that `gravitino.exceptions.base.InternalError: HDFS container startup failed!`. But I can successfully pass tests by running `./gradle

Re: [PR] [#6536] improvement: Create Ranger service if service is absent [gravitino]

tengqm commented on code in PR #6575: URL: https://github.com/apache/gravitino/pull/6575#discussion_r1976539692 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationPlugin.java: ## @@ -91,9 +94,42 @@ protected RangerAu

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976526614 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CatalogAudit.java: ## @@ -53,12 +53,20 @@ public void handle() { result = client.loadCatalo

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976526960 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogProperties.java: ## @@ -50,18 +50,30 @@ public ListCatalogProperties(CommandContext con

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976527048 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java: ## @@ -59,10 +59,42 @@ public void handle() { } catch (NoSuchTableException

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976526544 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CatalogAudit.java: ## @@ -53,12 +53,20 @@ public void handle() { result = client.loadCatalo

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976526554 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CatalogAudit.java: ## @@ -53,12 +53,20 @@ public void handle() { result = client.loadCatalo

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976526468 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CatalogAudit.java: ## @@ -53,12 +53,20 @@ public void handle() { result = client.loadCatalo

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976526892 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogProperties.java: ## @@ -50,18 +50,30 @@ public ListCatalogProperties(CommandContext con

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976527807 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogProperties.java: ## @@ -50,18 +50,30 @@ public ListCatalogProperties(CommandContext con

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976527910 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListFilesetProperties.java: ## @@ -59,21 +60,40 @@ public ListFilesetProperties( @Override p

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976528101 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListSchemaProperties.java: ## @@ -54,10 +54,16 @@ public ListSchemaProperties( /** List the pro

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976528041 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListMetalakeProperties.java: ## @@ -45,18 +45,20 @@ public ListMetalakeProperties(CommandContext c

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976528306 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTopicProperties.java: ## @@ -65,16 +65,28 @@ public void handle() { try { Gravitin

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976528627 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/TableAudit.java: ## @@ -48,15 +53,26 @@ public TableAudit( /** Displays the audit information o

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976528306 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTopicProperties.java: ## @@ -65,16 +65,28 @@ public void handle() { try { Gravitin

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976528789 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/TopicDetails.java: ## @@ -58,24 +58,27 @@ public TopicDetails( /** Displays the details of a to

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976526614 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CatalogAudit.java: ## @@ -53,12 +53,20 @@ public void handle() { result = client.loadCatalo

Re: [PR] refactor(cli): Improve CLI commands with better error handling and output formatting [gravitino]

justinmclean commented on code in PR #6573: URL: https://github.com/apache/gravitino/pull/6573#discussion_r1976528101 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListSchemaProperties.java: ## @@ -54,10 +54,16 @@ public ListSchemaProperties( /** List the pro

Re: [PR] [#75]: add CI check for playground [gravitino-playground]

unknowntpo commented on code in PR #111: URL: https://github.com/apache/gravitino-playground/pull/111#discussion_r1976404681 ## init/common/init_metalake_catalog.sh: ## @@ -78,9 +90,12 @@ if echo "$response" | grep -q "\"code\":0"; then true else # Create Iceberg catalog

Re: [PR] [#75]: add CI check for playground [gravitino-playground]

unknowntpo commented on code in PR #111: URL: https://github.com/apache/gravitino-playground/pull/111#discussion_r1976406954 ## init/jupyter/init.sh: ## @@ -17,10 +17,7 @@ # under the License. # -if [ -z "$RANGER_ENABLE" ]; then - cp -r /tmp/gravitino/*.ipynb /home/jovyan

Re: [PR] [#75]: add CI check for playground [gravitino-playground]

unknowntpo commented on code in PR #111: URL: https://github.com/apache/gravitino-playground/pull/111#discussion_r1976407749 ## init/common/init_metalake_catalog.sh: ## @@ -35,9 +38,12 @@ if echo "$response" | grep -q "\"code\":0"; then true else # Create Hive catalog fo