(gravitino) branch main updated: [#6097] improve(CLI): Add --quiet option to the Gravitino CLI (#6447)

2025-02-13 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new cdc5f8fdc0 [#6097] improve(CLI): Add --quiet opt

Re: [PR] [#6097] improve(CLI): Add --quiet option to the Gravitino CLI [gravitino]

2025-02-13 Thread via GitHub
justinmclean merged PR #6447: URL: https://github.com/apache/gravitino/pull/6447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [I] [Improvement] Add --quiet option to the Gravition CLI [gravitino]

2025-02-13 Thread via GitHub
justinmclean closed issue #6097: [Improvement] Add --quiet option to the Gravition CLI URL: https://github.com/apache/gravitino/issues/6097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] [FEATURE] Support table format output for Audit command [gravitino]

2025-02-13 Thread via GitHub
waukin commented on issue #5746: URL: https://github.com/apache/gravitino/issues/5746#issuecomment-2658146979 Hi @Abyss-lord, sure you can work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] [#6450] fix(web): fix authentication.type issue [gravitino]

2025-02-13 Thread via GitHub
LauraXia123 opened a new pull request, #6452: URL: https://github.com/apache/gravitino/pull/6452 ### What changes were proposed in this pull request? authentication.type of catalog property should send correct request to server ### Why are the changes needed? N/A F

Re: [PR] [#6449] improve(CLI): Refactor getAuth method in CLI [gravitino]

2025-02-13 Thread via GitHub
justinmclean commented on code in PR #6451: URL: https://github.com/apache/gravitino/pull/6451#discussion_r1955489055 ## clients/cli/src/main/java/org/apache/gravitino/cli/MetalakeCommandHandler.java: ## @@ -56,7 +56,7 @@ public MetalakeCommandHandler( public void handle() {

Re: [PR] [#6449] improve(CLI): Refactor getAuth method in CLI [gravitino]

2025-02-13 Thread via GitHub
justinmclean commented on code in PR #6451: URL: https://github.com/apache/gravitino/pull/6451#discussion_r1955488417 ## clients/cli/src/main/java/org/apache/gravitino/cli/ColumnCommandHandler.java: ## @@ -66,7 +66,7 @@ public ColumnCommandHandler( @Override protected void

Re: [PR] [#6449] improve(CLI): Refactor getAuth method in CLI [gravitino]

2025-02-13 Thread via GitHub
justinmclean commented on code in PR #6451: URL: https://github.com/apache/gravitino/pull/6451#discussion_r1955488209 ## clients/cli/src/main/java/org/apache/gravitino/cli/CatalogCommandHandler.java: ## @@ -64,7 +64,7 @@ public CatalogCommandHandler( @Override protected vo

Re: [I] [Subtask] Refactor getAuth method in CLI [gravitino]

2025-02-13 Thread via GitHub
justinmclean closed issue #6449: [Subtask] Refactor getAuth method in CLI URL: https://github.com/apache/gravitino/issues/6449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [#6449] improve(CLI): Refactor getAuth method in CLI [gravitino]

2025-02-13 Thread via GitHub
justinmclean commented on code in PR #6451: URL: https://github.com/apache/gravitino/pull/6451#discussion_r1955536501 ## clients/cli/src/main/java/org/apache/gravitino/cli/CatalogCommandHandler.java: ## @@ -64,7 +64,7 @@ public CatalogCommandHandler( @Override protected vo

Re: [PR] [#6449] improve(CLI): Refactor getAuth method in CLI [gravitino]

2025-02-13 Thread via GitHub
justinmclean merged PR #6451: URL: https://github.com/apache/gravitino/pull/6451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

(gravitino) branch main updated (cdc5f8fdc0 -> 300c79b005)

2025-02-13 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from cdc5f8fdc0 [#6097] improve(CLI): Add --quiet option to the Gravitino CLI (#6447) add 300c79b005 [#6449] improv

Re: [I] [FEATURE] Support table format output for Audit command [gravitino]

2025-02-13 Thread via GitHub
justinmclean commented on issue #5746: URL: https://github.com/apache/gravitino/issues/5746#issuecomment-2658245393 It would be best to keep the conversation here, as that aligns with ASF values of openness and transparency. -- This is an automated message from the Apache Git Service. To

Re: [PR] [#5901] feat(core): support tag event to Gravitino server [gravitino]

2025-02-13 Thread via GitHub
TungYuChiang commented on PR #5998: URL: https://github.com/apache/gravitino/pull/5998#issuecomment-2658288492 > Could you rebase the code, add tag related event(include tag failure event and tag pre event) to the document, https://github.com/apache/gravitino/blob/main/docs/gravitino-server

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-13 Thread via GitHub
LauraXia123 commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2658107413 @Pranaykarvi Hi, the nameRegex rules should be consistent with the back end `nameRegex = /^\w[\w/=-]{0,63}$/`, and the description should be changed as well. Thanks -- This is an

Re: [I] [FEATURE] Support table format output for Audit command [gravitino]

2025-02-13 Thread via GitHub
Abyss-lord commented on issue #5746: URL: https://github.com/apache/gravitino/issues/5746#issuecomment-2658110048 i would like to work on it. could you plz give me two tasks? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [#6449] improve(CLI): Refactor getAuth method in CLI [gravitino]

2025-02-13 Thread via GitHub
Abyss-lord commented on PR #6451: URL: https://github.com/apache/gravitino/pull/6451#issuecomment-2658111599 Hi @justinmclean , could you please review this PR when you have time? I’d really appreciate your feedback. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] [#6449] improve(CLI): Refactor getAuth method in CLI [gravitino]

2025-02-13 Thread via GitHub
justinmclean commented on code in PR #6451: URL: https://github.com/apache/gravitino/pull/6451#discussion_r1955488853 ## clients/cli/src/main/java/org/apache/gravitino/cli/FilesetCommandHandler.java: ## @@ -66,7 +66,7 @@ public FilesetCommandHandler( @Override protected vo

Re: [PR] [#6449] improve(CLI): Refactor getAuth method in CLI [gravitino]

2025-02-13 Thread via GitHub
justinmclean commented on code in PR #6451: URL: https://github.com/apache/gravitino/pull/6451#discussion_r1955489055 ## clients/cli/src/main/java/org/apache/gravitino/cli/MetalakeCommandHandler.java: ## @@ -56,7 +56,7 @@ public MetalakeCommandHandler( public void handle() {

Re: [PR] [#6449] improve(CLI): Refactor getAuth method in CLI [gravitino]

2025-02-13 Thread via GitHub
justinmclean commented on code in PR #6451: URL: https://github.com/apache/gravitino/pull/6451#discussion_r1955489309 ## clients/cli/src/main/java/org/apache/gravitino/cli/OwnerCommandHandler.java: ## @@ -66,7 +66,7 @@ public OwnerCommandHandler( @Override protected void h

Re: [PR] [#6449] improve(CLI): Refactor getAuth method in CLI [gravitino]

2025-02-13 Thread via GitHub
Abyss-lord commented on code in PR #6451: URL: https://github.com/apache/gravitino/pull/6451#discussion_r1955490736 ## clients/cli/src/main/java/org/apache/gravitino/cli/CatalogCommandHandler.java: ## @@ -64,7 +64,7 @@ public CatalogCommandHandler( @Override protected void

Re: [PR] [#2780] Improvement(server,core): Move tree lock from rest api to the corresponding implementation to minimize tree lock range. [gravitino]

2025-02-13 Thread via GitHub
jerqi commented on code in PR #2873: URL: https://github.com/apache/gravitino/pull/2873#discussion_r1955673107 ## core/src/main/java/org/apache/gravitino/authorization/AccessControlManager.java: ## @@ -57,44 +61,68 @@ public AccessControlManager(EntityStore store, IdGenerator i

Re: [PR] [#2780] Improvement(server,core): Move tree lock from rest api to the corresponding implementation to minimize tree lock range. [gravitino]

2025-02-13 Thread via GitHub
jerqi commented on code in PR #2873: URL: https://github.com/apache/gravitino/pull/2873#discussion_r1955681653 ## core/src/main/java/org/apache/gravitino/authorization/AccessControlManager.java: ## @@ -57,44 +61,68 @@ public AccessControlManager(EntityStore store, IdGenerator i

Re: [PR] [#2780] Improvement(server,core): Move tree lock from rest api to the corresponding implementation to minimize tree lock range. [gravitino]

2025-02-13 Thread via GitHub
yuqi1129 commented on code in PR #2873: URL: https://github.com/apache/gravitino/pull/2873#discussion_r1955686033 ## core/src/main/java/org/apache/gravitino/authorization/AccessControlManager.java: ## @@ -57,44 +61,68 @@ public AccessControlManager(EntityStore store, IdGenerator

Re: [PR] [#2780] Improvement(server,core): Move tree lock from rest api to the corresponding implementation to minimize tree lock range. [gravitino]

2025-02-13 Thread via GitHub
yuqi1129 commented on code in PR #2873: URL: https://github.com/apache/gravitino/pull/2873#discussion_r1955688848 ## core/src/main/java/org/apache/gravitino/authorization/AccessControlManager.java: ## @@ -143,42 +199,60 @@ public Role createRole( Map properties, Li

Re: [PR] [#6326] improve(CLI): Make CLI more extendable and maintainable. [gravitino]

2025-02-13 Thread via GitHub
justinmclean commented on PR #6327: URL: https://github.com/apache/gravitino/pull/6327#issuecomment-2657965889 Closing as this has been completed in other PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[I] [Bug report] Web page can't send correct request to Gravitino server when creating catalogs [gravitino]

2025-02-13 Thread via GitHub
yuqi1129 opened a new issue, #6450: URL: https://github.com/apache/gravitino/issues/6450 ### Version main branch ### Describe what's wrong When I try to create a Hadoop catalog and add a properties `authentication.type = kerberos` in the web page as follows https:

Re: [I] [FEATURE] Support table format output for Audit command [gravitino]

2025-02-13 Thread via GitHub
Abyss-lord commented on issue #5746: URL: https://github.com/apache/gravitino/issues/5746#issuecomment-2658397703 > > > Hi [@Abyss-lord](https://github.com/Abyss-lord), sure you can work on it. > > > > > > May I have your email, I have some to discuss. > > Hi [@Abyss-lord](

Re: [I] [Bug report] Wrong log format codes [gravitino]

2025-02-13 Thread via GitHub
aryanmahawar205 commented on issue #6429: URL: https://github.com/apache/gravitino/issues/6429#issuecomment-2656462599 > [@aryanmahawar205](https://github.com/aryanmahawar205) can you please leave a message here, so I can assign this issue to you. hey @jerryshao thanks for merging the

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-13 Thread via GitHub
mchades commented on code in PR #6400: URL: https://github.com/apache/gravitino/pull/6400#discussion_r1954220535 ## web/web/src/lib/utils/regex.js: ## @@ -17,9 +17,9 @@ * under the License. */ -export const nameRegex = /^\w[\w]{0,63}$/ +export const nameRegex = /^[a-zA-Z_]

Re: [PR] [#6078] feat(core): Support model event to Gravitino server [gravitino]

2025-02-13 Thread via GitHub
tengqm commented on code in PR #6129: URL: https://github.com/apache/gravitino/pull/6129#discussion_r1954233105 ## core/src/main/java/org/apache/gravitino/listener/ModelEventDispatcher.java: ## @@ -0,0 +1,400 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[I] [Improvement] web ui adds the operations for Ranger authorization management on the page [gravitino]

2025-02-13 Thread via GitHub
lifangyu opened a new issue, #6453: URL: https://github.com/apache/gravitino/issues/6453 ### What would you like to be improved? The system adds operations on Ranger authorization management to help users experience and understand unified rights functions ### How should we impr

Re: [I] [FEATURE] Support table format output for Audit command [gravitino]

2025-02-13 Thread via GitHub
Abyss-lord commented on issue #5746: URL: https://github.com/apache/gravitino/issues/5746#issuecomment-2658185065 > Hi [@Abyss-lord](https://github.com/Abyss-lord), sure you can work on it. May I have your email, I have some to discuss. -- This is an automated message from the Apach

Re: [PR] [#2780] Improvement(server,core): Move tree lock from rest api to the corresponding implementation to minimize tree lock range. [gravitino]

2025-02-13 Thread via GitHub
yuqi1129 commented on code in PR #2873: URL: https://github.com/apache/gravitino/pull/2873#discussion_r1955695147 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -589,124 +627,137 @@ public void disableCatalog(NameIdentifier ident) throws NoSuchCat

Re: [PR] [#2780] Improvement(server,core): Move tree lock from rest api to the corresponding implementation to minimize tree lock range. [gravitino]

2025-02-13 Thread via GitHub
yuqi1129 commented on code in PR #2873: URL: https://github.com/apache/gravitino/pull/2873#discussion_r1955698759 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -466,115 +485,134 @@ public void testConnection( String comment, Map prop

Re: [PR] [#2780] Improvement(server,core): Move tree lock from rest api to the corresponding implementation to minimize tree lock range. [gravitino]

2025-02-13 Thread via GitHub
mchades commented on code in PR #2873: URL: https://github.com/apache/gravitino/pull/2873#discussion_r1955695627 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -466,115 +485,134 @@ public void testConnection( String comment, Map prope

Re: [PR] [#6326] improve(CLI): Make CLI more extendable and maintainable. [gravitino]

2025-02-13 Thread via GitHub
justinmclean closed pull request #6327: [#6326] improve(CLI): Make CLI more extendable and maintainable. URL: https://github.com/apache/gravitino/pull/6327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [FEATURE] Support table format output for Audit command [gravitino]

2025-02-13 Thread via GitHub
waukin commented on issue #5746: URL: https://github.com/apache/gravitino/issues/5746#issuecomment-2658329272 > > Hi [@Abyss-lord](https://github.com/Abyss-lord), sure you can work on it. > > May I have your email, I have some to discuss. Hi @Abyss-lord, We can discuss here. Or

[PR] [#6238] Improve performance when roles is bound to many metadata. [gravitino]

2025-02-13 Thread via GitHub
FourFriends opened a new pull request, #6455: URL: https://github.com/apache/gravitino/pull/6455 ### What changes were proposed in this pull request? fix issue https://github.com/apache/gravitino/issues/6238 improve performance when a single role is bound to many metadata.

Re: [PR] [#2780] Improvement(server,core): Move tree lock from rest api to the corresponding implementation to minimize tree lock range. [gravitino]

2025-02-13 Thread via GitHub
yuqi1129 commented on code in PR #2873: URL: https://github.com/apache/gravitino/pull/2873#discussion_r1955658840 ## core/src/main/java/org/apache/gravitino/authorization/AccessControlManager.java: ## @@ -57,44 +61,68 @@ public AccessControlManager(EntityStore store, IdGenerator

Re: [PR] [#6238] Improve performance when roles is bound to many metadata. [gravitino]

2025-02-13 Thread via GitHub
FourFriends commented on PR #6455: URL: https://github.com/apache/gravitino/pull/6455#issuecomment-2658458838 In xiaomi company, we find when roles is bounded to many securable objects, then get role is very slow, so we try so solve get role function. -- This is an automated message from

Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

2025-02-13 Thread via GitHub
diqiu50 commented on PR #5905: URL: https://github.com/apache/gravitino/pull/5905#issuecomment-2658474034 I want to show the logs after running the gvfs-fuse with command: ``` ./target/debug/gvfs-fuse mount target/gvfs gvfs://fileset/test/c1/s1/fileset1 -c conf/gvfs_fuse.toml -f -d 1

Re: [PR] [#6238] Improve get role performance when roles is bound to many metadata. [gravitino]

2025-02-13 Thread via GitHub
jerqi commented on code in PR #6455: URL: https://github.com/apache/gravitino/pull/6455#discussion_r1955660178 ## core/src/test/java/org/apache/gravitino/storage/relational/service/TestRoleMetaService.java: ## @@ -240,22 +241,29 @@ void insertRole() throws IOException {