Re: [I] [Bug report] Wrong log format codes [gravitino]

2025-02-11 Thread via GitHub
NazaninAnsarii commented on issue #6429: URL: https://github.com/apache/gravitino/issues/6429#issuecomment-2650551417 i would like to work on it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-11 Thread via GitHub
jerryshao commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2650701118 @LauraXia123 , can you please help to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [MINOR] docs: Fix the description of `Multi-engine support` in `overview.md` [gravitino]

2025-02-11 Thread via GitHub
LuciferYang commented on PR #6439: URL: https://github.com/apache/gravitino/pull/6439#issuecomment-2650709754 Thanks @jerryshao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [#6361] feat(paimon):Support specifying primary keys during create paimon table by flink [gravitino]

2025-02-11 Thread via GitHub
hdygxsj commented on code in PR #6362: URL: https://github.com/apache/gravitino/pull/6362#discussion_r1950845159 ## flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/BaseCatalog.java: ## @@ -554,28 +554,31 @@ protected CatalogBaseTable toFlinkTable

Re: [PR] [MINOR] docs: Fix the description of `Multi-engine support` in `overview.md` [gravitino]

2025-02-11 Thread via GitHub
LuciferYang commented on PR #6439: URL: https://github.com/apache/gravitino/pull/6439#issuecomment-2650480352 Thanks @jerqi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(gravitino) branch main updated: [MINOR] docs: Fix the description of `Multi-engine support` in `overview.md` (#6439)

2025-02-11 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new e7ab4414ea [MINOR] docs: Fix the description of `M

Re: [PR] [MINOR] docs: Fix the description of `Multi-engine support` in `overview.md` [gravitino]

2025-02-11 Thread via GitHub
jerryshao merged PR #6439: URL: https://github.com/apache/gravitino/pull/6439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#6421] improve(CLI): Add user and group command context CLI [gravitino]

2025-02-11 Thread via GitHub
Abyss-lord commented on PR #6437: URL: https://github.com/apache/gravitino/pull/6437#issuecomment-2650163565 @justinmclean ,I’ve finished updating the code. Please take a look at the PR again when you have time. -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] [#6423] improve(CLI): Add tags command context CLI [gravitino]

2025-02-11 Thread via GitHub
Abyss-lord commented on PR #6435: URL: https://github.com/apache/gravitino/pull/6435#issuecomment-2650164798 @justinmclean , I’ve finished updating the code. Please take a look at the PR again when you have time. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] [#6422] improve(CLI): Add roles and owner command context CLI [gravitino]

2025-02-11 Thread via GitHub
Abyss-lord commented on PR #6438: URL: https://github.com/apache/gravitino/pull/6438#issuecomment-2650236342 Hi @justinmclean , could you please review this PR when you have time? I’d really appreciate your feedback. -- This is an automated message from the Apache Git Service. To respond

[PR] [MINOR] docs: Fix the description of `Multi-engine support` in `overview.md` [gravitino]

2025-02-11 Thread via GitHub
LuciferYang opened a new pull request, #6439: URL: https://github.com/apache/gravitino/pull/6439 ### What changes were proposed in this pull request? This PR fixes the description of the `Multi-engine support` section in `overview.md`, as Gravitino now supports connectors for Apache Spark

Re: [PR] [MINOR] docs: Fix the description of `Multi-engine support` in `overview.md` [gravitino]

2025-02-11 Thread via GitHub
LuciferYang commented on code in PR #6439: URL: https://github.com/apache/gravitino/pull/6439#discussion_r1950496109 ## docs/overview.md: ## @@ -60,8 +60,9 @@ Gravitino supports different query engines to access the metadata. Currently, it [Trino](https://trino.io/), users can

Re: [PR] [#6361] feat(paimon):Support specifying primary keys during create paimon table by flink [gravitino]

2025-02-11 Thread via GitHub
FANNG1 commented on PR #6362: URL: https://github.com/apache/gravitino/pull/6362#issuecomment-2652426982 @hdygxsj could you check the CI failures? @tengqm any other comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [#6424] improve(CLI): Refactor getURL in CLI and add context to simple commands. [gravitino]

2025-02-11 Thread via GitHub
Abyss-lord commented on PR #6440: URL: https://github.com/apache/gravitino/pull/6440#issuecomment-2652536846 Hi @justinmclean , could you please review this PR when you have time? I’d really appreciate your feedback. -- This is an automated message from the Apache Git Service. To respond

[I] [Improvement] Fix Web UI compliance with ASF licensing [gravitino]

2025-02-11 Thread via GitHub
justinmclean opened a new issue, #6441: URL: https://github.com/apache/gravitino/issues/6441 ### What would you like to be improved? The CC-By-4.0 license is a bit problematic [1]. As described in LEGAL-678 [2] Can I Use Lite can only be used where it is a compile-time or developer

Re: [I] [Improvement] Fix Web UI compliance with ASF licensing [gravitino]

2025-02-11 Thread via GitHub
justinmclean commented on issue #6441: URL: https://github.com/apache/gravitino/issues/6441#issuecomment-2652719070 Note caniuse-lite 1.0.30001639 is a production dependency of next 14.2.21. It is also a developer dependency of autoprefixer 10.4.19. -- This is an automated message from th

Re: [PR] [#6424] improve(CLI): Refactor getURL in CLI and add context to simple commands. [gravitino]

2025-02-11 Thread via GitHub
Abyss-lord commented on PR #6440: URL: https://github.com/apache/gravitino/pull/6440#issuecomment-2652778149 > Thanks, it looks good to me @justinmclean Should we move `getAuth` method from CommandHandler to CommandContext, auth mode should also be immutable, WDYT? -- This is an au

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-11 Thread via GitHub
Pranaykarvi commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2652805234 > I read the `keyRegex` carefully and made sure it already supports hyphens. The issue #6399 is about the fileset name. And you need to update the `nameRegex` and `nameRegexDesc` re

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-11 Thread via GitHub
LauraXia123 commented on code in PR #6400: URL: https://github.com/apache/gravitino/pull/6400#discussion_r1952072388 ## web/web/src/app/metalakes/metalake/rightContent/CreateFilesetDialog.js: ## @@ -72,7 +73,13 @@ const schema = yup.object().shape({ propItems: yup.array().of(

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-11 Thread via GitHub
LauraXia123 commented on code in PR #6400: URL: https://github.com/apache/gravitino/pull/6400#discussion_r1952073118 ## web/web/src/lib/utils/regex.js: ## @@ -17,9 +17,11 @@ * under the License. */ -export const nameRegex = /^\w[\w]{0,63}$/ +export const nameRegex = /^[a-z

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-11 Thread via GitHub
Pranaykarvi commented on code in PR #6400: URL: https://github.com/apache/gravitino/pull/6400#discussion_r1952078519 ## web/web/src/app/metalakes/metalake/rightContent/CreateFilesetDialog.js: ## @@ -72,7 +73,13 @@ const schema = yup.object().shape({ propItems: yup.array().of(

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-11 Thread via GitHub
LauraXia123 commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2652826684 Thank you for your contribution. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-11 Thread via GitHub
Pranaykarvi commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2652826214 @LauraXia123 can u check now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

(gravitino) branch main updated: [#6423] improve(CLI): Add tags command context CLI (#6435)

2025-02-11 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 734993e1bf [#6423] improve(CLI): Add tags comman

Re: [I] Add user and group command context CLI [gravitino]

2025-02-11 Thread via GitHub
justinmclean closed issue #6421: Add user and group command context CLI URL: https://github.com/apache/gravitino/issues/6421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [#6421] improve(CLI): Add user and group command context CLI [gravitino]

2025-02-11 Thread via GitHub
justinmclean merged PR #6437: URL: https://github.com/apache/gravitino/pull/6437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

(gravitino) branch main updated: [#6421] improve(CLI): Add user and group command context CLI (#6437)

2025-02-11 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 67f25efb26 [#6421] improve(CLI): Add user and gr

Re: [I] Add user and group command context CLI [gravitino]

2025-02-11 Thread via GitHub
justinmclean closed issue #6421: Add user and group command context CLI URL: https://github.com/apache/gravitino/issues/6421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(gravitino) branch main updated: [#6422] improve(CLI): Add roles and owner command context CLI (#6438)

2025-02-11 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 423d311ccb [#6422] improve(CLI): Add roles and o

Re: [PR] [#6422] improve(CLI): Add roles and owner command context CLI [gravitino]

2025-02-11 Thread via GitHub
justinmclean merged PR #6438: URL: https://github.com/apache/gravitino/pull/6438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [I] Add roles and owner command context CLI [gravitino]

2025-02-11 Thread via GitHub
justinmclean closed issue #6422: Add roles and owner command context CLI URL: https://github.com/apache/gravitino/issues/6422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-11 Thread via GitHub
LauraXia123 commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2652581461 @Pranaykarvi Hi,you can update the `keyRegex ` which from `@/lib/utils/regex` is ok. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [#6424] improve(CLI): Refactor getURL in CLI and add context to simple commands. [gravitino]

2025-02-11 Thread via GitHub
justinmclean commented on code in PR #6440: URL: https://github.com/apache/gravitino/pull/6440#discussion_r1951931548 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ClientVersion.java: ## @@ -44,6 +44,6 @@ public void handle() { } catch (Exception exp) {

Re: [PR] [#6424] improve(CLI): Refactor getURL in CLI and add context to simple commands. [gravitino]

2025-02-11 Thread via GitHub
justinmclean commented on code in PR #6440: URL: https://github.com/apache/gravitino/pull/6440#discussion_r1951930374 ## clients/cli/src/main/java/org/apache/gravitino/cli/CommandContext.java: ## @@ -19,42 +19,41 @@ package org.apache.gravitino.cli; +import com.google.commo

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-11 Thread via GitHub
Pranaykarvi commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2652605772 > @Pranaykarvi Hi,you can update the `keyRegex ` which from `@/lib/utils/regex` is ok. @LauraXia123 I made the changes in the regex file -- This is an automated message fr

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-11 Thread via GitHub
LauraXia123 commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2652607739 I read the `keyRegex` carefully and made sure it already supports hyphens. The issue #6399 is about the fileset name. -- This is an automated message from the Apache Git Service.

Re: [I] [Bug report] UI should allow hyphen in fileset name [gravitino]

2025-02-11 Thread via GitHub
mchades commented on issue #6399: URL: https://github.com/apache/gravitino/issues/6399#issuecomment-2652608174 > only fileset name or all the catalog name? all catalogs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [#6424] improve(CLI): Refactor getURL in CLI and add context to simple commands. [gravitino]

2025-02-11 Thread via GitHub
Abyss-lord commented on PR #6440: URL: https://github.com/apache/gravitino/pull/6440#issuecomment-2652625735 Hi @justinmclean ,I’ve finished updating the code. Please take a look at the PR again when you have time. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Add tags command context CLI [gravitino]

2025-02-11 Thread via GitHub
justinmclean closed issue #6423: Add tags command context CLI URL: https://github.com/apache/gravitino/issues/6423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] [#6423] improve(CLI): Add tags command context CLI [gravitino]

2025-02-11 Thread via GitHub
justinmclean merged PR #6435: URL: https://github.com/apache/gravitino/pull/6435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [I] Add tags command context CLI [gravitino]

2025-02-11 Thread via GitHub
justinmclean closed issue #6423: Add tags command context CLI URL: https://github.com/apache/gravitino/issues/6423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [I] Add roles and owner command context CLI [gravitino]

2025-02-11 Thread via GitHub
justinmclean closed issue #6422: Add roles and owner command context CLI URL: https://github.com/apache/gravitino/issues/6422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [#6361] feat(paimon):Support specifying primary keys during create paimon table by flink [gravitino]

2025-02-11 Thread via GitHub
FANNG1 commented on PR #6362: URL: https://github.com/apache/gravitino/pull/6362#issuecomment-2652376661 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] [#2780] Improvement(server,core): Move tree lock from rest api to the corresponding implementation to minimize tree lock range. [gravitino]

2025-02-11 Thread via GitHub
jerryshao commented on code in PR #2873: URL: https://github.com/apache/gravitino/pull/2873#discussion_r1952091523 ## core/src/main/java/org/apache/gravitino/authorization/AccessControlManager.java: ## @@ -57,44 +61,68 @@ public AccessControlManager(EntityStore store, IdGenerato

Re: [PR] [#2780] Improvement(server,core): Move tree lock from rest api to the corresponding implementation to minimize tree lock range. [gravitino]

2025-02-11 Thread via GitHub
jerryshao commented on PR #2873: URL: https://github.com/apache/gravitino/pull/2873#issuecomment-2652862012 @mchades can you please help to review the `CatalogManager` part, this part is a bit complex after you introduced the in use mechanism. @jerqi can you please review access contr

Re: [PR] [#6399] Added validation to fileset dialog [gravitino]

2025-02-11 Thread via GitHub
jerryshao commented on PR #6400: URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2652885790 CI is now broken because of the upstream bug, I will merge this when the CI is fixed. Thanks @Pranaykarvi for your contribution. Thanks @LauraXia123 for your review. -- This is an