Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899947390 ## clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java: ## @@ -21,118 +21,8 @@ package org.apache.gravitino.cli; import java.util.Map; -imp

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899947692 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -494,6 +496,42 @@ private void handleTableCommand() { } } + /** Handl

Re: [PR] [#6049] fix(bundles): Fix scheme gs not found problem [gravitino]

2024-12-30 Thread via GitHub
FANNG1 commented on PR #6050: URL: https://github.com/apache/gravitino/pull/6050#issuecomment-2566175447 Could you explain the reason? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] [#5950] feat(catalog-model): Add integration tests for model API [gravitino]

2024-12-30 Thread via GitHub
jerryshao opened a new pull request, #6051: URL: https://github.com/apache/gravitino/pull/6051 ### What changes were proposed in this pull request? This PR adds the integration tests for model API to make sure it works as expected. ### Why are the changes needed? To have

Re: [PR] [#6042] refactor: Use callback to delete the privilege of catalog [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on code in PR #6045: URL: https://github.com/apache/gravitino/pull/6045#discussion_r1899951197 ## core/src/main/java/org/apache/gravitino/hook/CatalogHookDispatcher.java: ## @@ -126,8 +126,20 @@ public boolean dropCatalog(NameIdentifier ident) { @Override

Re: [PR] [#6007] fix: fix hadoop catalog entity name limitation [gravitino]

2024-12-30 Thread via GitHub
jerryshao merged PR #6040: URL: https://github.com/apache/gravitino/pull/6040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Bug report] The character “/” is illegal character, but it is not banned in fileset create and update API. [gravitino]

2024-12-30 Thread via GitHub
jerryshao closed issue #6007: [Bug report] The character “/” is illegal character, but it is not banned in fileset create and update API. URL: https://github.com/apache/gravitino/issues/6007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

(gravitino) branch main updated (9a5fef924 -> 924a1b1ba)

2024-12-30 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from 9a5fef924 [#5831] fix(CLI): Fix CLi gives unexpected output when input tag set command (#5897) add 924a1b1ba [#6

Re: [PR] [#5872] feat(client): Add model management Java client API [gravitino]

2024-12-30 Thread via GitHub
jerryshao merged PR #6003: URL: https://github.com/apache/gravitino/pull/6003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Subtask]Implement the Java client API for model catalog. [gravitino]

2024-12-30 Thread via GitHub
jerryshao closed issue #5872: [Subtask]Implement the Java client API for model catalog. URL: https://github.com/apache/gravitino/issues/5872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

(gravitino) branch main updated (924a1b1ba -> 0c516e26a)

2024-12-30 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from 924a1b1ba [#6007] fix: fix hadoop catalog entity name limitation (#6040) add 0c516e26a [#5872] feat(client): Add

Re: [I] [Subtask]Implement the Java client API for model catalog. [gravitino]

2024-12-30 Thread via GitHub
jerryshao closed issue #5872: [Subtask]Implement the Java client API for model catalog. URL: https://github.com/apache/gravitino/issues/5872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [#3515] feat(flink-connector): Support flink iceberg catalog [gravitino]

2024-12-30 Thread via GitHub
sunxiaojian commented on code in PR #5914: URL: https://github.com/apache/gravitino/pull/5914#discussion_r1899447128 ## flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/iceberg/GravitinoIcebergCatalogFactory.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to t

[PR] [#6088] fix(doc): Remove the unnecessary CONTRIBUTING file [gravitino]

2024-12-30 Thread via GitHub
jerryshao opened a new pull request, #6039: URL: https://github.com/apache/gravitino/pull/6039 ### What changes were proposed in this pull request? Remove the unnecessary `CONTRIBUTING` file under `.github` folder. ### Why are the changes needed? It's not necessary to add

[PR] [#6007] fix: fix hadoop catalog entity name limitation [gravitino]

2024-12-30 Thread via GitHub
mchades opened a new pull request, #6040: URL: https://github.com/apache/gravitino/pull/6040 ### What changes were proposed in this pull request? - limit '/' in schema name and fileset name for hadoop catalog - fix name encode issue when create schema, table, fileset and topic

[PR] [SIP] support gcs credential permission for fileset operations [gravitino]

2024-12-30 Thread via GitHub
FANNG1 opened a new pull request, #6041: URL: https://github.com/apache/gravitino/pull/6041 ### What changes were proposed in this pull request? (Please outline the changes and how this PR fixes the issue.) ### Why are the changes needed? (Please clarify why the c

Re: [PR] [#6088] fix(doc): Remove the unnecessary CONTRIBUTING file [gravitino]

2024-12-30 Thread via GitHub
jerqi commented on code in PR #6039: URL: https://github.com/apache/gravitino/pull/6039#discussion_r1899470926 ## clients/client-python/gravitino/dto/requests/model_version_link_request.py: ## @@ -59,7 +59,7 @@ def validate(self): for alias in self._aliases or []:

Re: [PR] [#6088] fix(doc): Remove the unnecessary CONTRIBUTING file [gravitino]

2024-12-30 Thread via GitHub
jerryshao commented on code in PR #6039: URL: https://github.com/apache/gravitino/pull/6039#discussion_r1899472957 ## clients/client-python/gravitino/dto/requests/model_version_link_request.py: ## @@ -59,7 +59,7 @@ def validate(self): for alias in self._aliases or []:

Re: [PR] [#5982] feat (gvfs-fuse): Implement Gravitino fileset file system [gravitino]

2024-12-30 Thread via GitHub
diqiu50 commented on code in PR #5984: URL: https://github.com/apache/gravitino/pull/5984#discussion_r1899878227 ## clients/filesystem-fuse/src/config.rs: ## @@ -0,0 +1,330 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] [#118] Remove hello world after check [gravitino-playground]

2024-12-30 Thread via GitHub
xunliu merged PR #119: URL: https://github.com/apache/gravitino-playground/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

(gravitino-playground) branch main updated: [#118] Remove hello world after check (#119)

2024-12-30 Thread liuxun
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino-playground.git The following commit(s) were added to refs/heads/main by this push: new 137f3e3 [#118] Remove hello world aft

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
jerryshao commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899879134 ## clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java: ## @@ -21,118 +21,8 @@ package org.apache.gravitino.cli; import java.util.Map; -

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
jerryshao commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899879134 ## clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java: ## @@ -21,118 +21,8 @@ package org.apache.gravitino.cli; import java.util.Map; -

Re: [PR] [#6030] fix(CLI): Fix Setting the same tags multiple times in the Gravitino CLi gives unexpected output [gravitino]

2024-12-30 Thread via GitHub
justinmclean commented on PR #6037: URL: https://github.com/apache/gravitino/pull/6037#issuecomment-2566059059 Tags already act like this: - The tags on an object is maintained as a set, i.e. no duplicated items are allowed. - When updating the tags on an object, the set of new tags is

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899873777 ## clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java: ## @@ -21,118 +21,8 @@ package org.apache.gravitino.cli; import java.util.Map; -imp

Re: [PR] [#5982] feat (gvfs-fuse): Implement Gravitino fileset file system [gravitino]

2024-12-30 Thread via GitHub
FANNG1 commented on code in PR #5984: URL: https://github.com/apache/gravitino/pull/5984#discussion_r1899875460 ## clients/filesystem-fuse/src/config.rs: ## @@ -0,0 +1,330 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agree

Re: [PR] [MINOR] docs: Update MAINTAINERS [gravitino]

2024-12-30 Thread via GitHub
Abyss-lord closed pull request #6038: [MINOR] docs: Update MAINTAINERS URL: https://github.com/apache/gravitino/pull/6038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] [Subtask] Add get and list CLI commands for Model [gravitino]

2024-12-30 Thread via GitHub
Abyss-lord commented on issue #5961: URL: https://github.com/apache/gravitino/issues/5961#issuecomment-2566065056 @justinmclean What should the output of the get command look like? just output model name? -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [#5872] feat(client): Add model management Java client API [gravitino]

2024-12-30 Thread via GitHub
jerryshao commented on code in PR #6003: URL: https://github.com/apache/gravitino/pull/6003#discussion_r1899880419 ## clients/client-java/src/main/java/org/apache/gravitino/client/GenericModelCatalog.java: ## @@ -0,0 +1,330 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] [#5872] feat(client): Add model management Java client API [gravitino]

2024-12-30 Thread via GitHub
jerryshao commented on code in PR #6003: URL: https://github.com/apache/gravitino/pull/6003#discussion_r1899881796 ## clients/client-java/src/main/java/org/apache/gravitino/client/GenericModelCatalog.java: ## @@ -0,0 +1,330 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] [#6027] improvement(CLI): fix Gravitino CLI get wrong catalogName [gravitino]

2024-12-30 Thread via GitHub
Abyss-lord commented on PR #6048: URL: https://github.com/apache/gravitino/pull/6048#issuecomment-2566097694 @justinmclean @tengqm , could you please review this PR when you have time? I’d really appreciate your feedback. -- This is an automated message from the Apache Git Service. To res

(gravitino) branch branch-gvfs-fuse-dev updated: [#5982] feat (gvfs-fuse): Implement Gravitino fileset file system (#5984)

2024-12-30 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a commit to branch branch-gvfs-fuse-dev in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-gvfs-fuse-dev by this push: new 8dcc7b887 [#5982]

Re: [PR] [#5982] feat (gvfs-fuse): Implement Gravitino fileset file system [gravitino]

2024-12-30 Thread via GitHub
FANNG1 merged PR #5984: URL: https://github.com/apache/gravitino/pull/5984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [PR] [#6042] refactor: Use callback to delete the privilege of catalog [gravitino]

2024-12-30 Thread via GitHub
jerqi commented on code in PR #6045: URL: https://github.com/apache/gravitino/pull/6045#discussion_r1899881003 ## core/src/main/java/org/apache/gravitino/hook/CatalogHookDispatcher.java: ## @@ -126,8 +126,20 @@ public boolean dropCatalog(NameIdentifier ident) { @Override p

Re: [I] [Subtask] Implement the Gravitino fileset file system in gvfs fuse [gravitino]

2024-12-30 Thread via GitHub
FANNG1 closed issue #5982: [Subtask] Implement the Gravitino fileset file system in gvfs fuse URL: https://github.com/apache/gravitino/issues/5982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [#6007] fix: fix hadoop catalog entity name limitation [gravitino]

2024-12-30 Thread via GitHub
mchades commented on code in PR #6040: URL: https://github.com/apache/gravitino/pull/6040#discussion_r1899891595 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogCapability.java: ## @@ -31,4 +31,19 @@ public CapabilityResult managedStorag

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
VigneshSK17 commented on PR #6047: URL: https://github.com/apache/gravitino/pull/6047#issuecomment-2566084085 > Looks good, but you need to update the help text and CLI documentation. ahh knew I forgot something. Will add shortly. -- This is an automated message from the Apache Git

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
VigneshSK17 commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899886331 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -494,6 +496,42 @@ private void handleTableCommand() { } } + /**

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
VigneshSK17 commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899886300 ## clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java: ## @@ -21,118 +21,8 @@ package org.apache.gravitino.cli; import java.util.Map;

Re: [PR] [#6007] fix: fix hadoop catalog entity name limitation [gravitino]

2024-12-30 Thread via GitHub
mchades commented on code in PR #6040: URL: https://github.com/apache/gravitino/pull/6040#discussion_r1899891179 ## catalogs/catalog-hadoop/src/test/java/org/apache/gravitino/catalog/hadoop/integration/test/HadoopCatalogIT.java: ## @@ -301,12 +288,34 @@ public void testExternalF

[PR] Add cool9850311 to Maintainers list [gravitino]

2024-12-30 Thread via GitHub
cool9850311 opened a new pull request, #6046: URL: https://github.com/apache/gravitino/pull/6046 What changes were proposed in this pull request? Add cool9850311 to Maintainers list Why are the changes needed? N/A Does this PR introduce any user-facing change? N/A

[PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
VigneshSK17 opened a new pull request, #6047: URL: https://github.com/apache/gravitino/pull/6047 ### What changes were proposed in this pull request? The audit command is one of the commands suggested by @justinmclean as part of adding Model entity support for the CLI. Also inc

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
VigneshSK17 commented on PR #6047: URL: https://github.com/apache/gravitino/pull/6047#issuecomment-2565957483 @justinmclean Could you please review this? I was a bit unclear on what the ModelAudit command should be auditing, please let me know if there's more functionality I've yet to

Re: [PR] [#6027] improvement(CLI): fix Gravitino CLI get wrong catalogName [gravitino]

2024-12-30 Thread via GitHub
justinmclean commented on code in PR #6048: URL: https://github.com/apache/gravitino/pull/6048#discussion_r1899900423 ## clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java: ## @@ -73,10 +73,7 @@ public String getMetalakeName() { } } -// Extract th

Re: [I] [Bug report] MySQL table's audit info is empty after user Alice rename the table [gravitino]

2024-12-30 Thread via GitHub
jerqi commented on issue #5986: URL: https://github.com/apache/gravitino/issues/5986#issuecomment-2565464860 The behaviour is expected now. So I will close this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Bug report] MySQL table's audit info is empty after user Alice rename the table [gravitino]

2024-12-30 Thread via GitHub
jerqi closed issue #5986: [Bug report] MySQL table's audit info is empty after user Alice rename the table URL: https://github.com/apache/gravitino/issues/5986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [Subtask] support basic table DDl and DML operations for paimon spark connector [gravitino]

2024-12-30 Thread via GitHub
jerryshao closed issue #4717: [Subtask] support basic table DDl and DML operations for paimon spark connector URL: https://github.com/apache/gravitino/issues/4717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] [Improvement] add OSS support for IcebergRESTService docker image [gravitino]

2024-12-30 Thread via GitHub
FANNG1 commented on issue #5779: URL: https://github.com/apache/gravitino/issues/5779#issuecomment-2565193902 Hi @TungYuChiang is there any progress? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [MINOR] docs: Update MAINTAINERS [gravitino]

2024-12-30 Thread via GitHub
jerryshao commented on PR #6038: URL: https://github.com/apache/gravitino/pull/6038#issuecomment-2565210017 Hi @Abyss-lord The maintainer list is the contributor list before incubating. Since we're now an incubating project in ASF, so we don't maintain and add new contributors to the mainta

(gravitino) branch main updated: [#5889] feat(client-python): Add model management Python API (#6009)

2024-12-30 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 6b72225ef [#5889] feat(client-python): Add model m

Re: [I] [Subtask] Implement the Python client API for model catalog. [gravitino]

2024-12-30 Thread via GitHub
jerryshao closed issue #5889: [Subtask] Implement the Python client API for model catalog. URL: https://github.com/apache/gravitino/issues/5889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] [Subtask] Implement the Python client API for model catalog. [gravitino]

2024-12-30 Thread via GitHub
jerryshao closed issue #5889: [Subtask] Implement the Python client API for model catalog. URL: https://github.com/apache/gravitino/issues/5889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [#5889] feat(client-python): Add model management Python API [gravitino]

2024-12-30 Thread via GitHub
jerryshao merged PR #6009: URL: https://github.com/apache/gravitino/pull/6009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Improvement] Support enum catalog provider name [gravitino]

2024-12-30 Thread via GitHub
jerryshao closed issue #5704: [Improvement] Support enum catalog provider name URL: https://github.com/apache/gravitino/issues/5704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] [#6022] Output the failed logs to gravatino.log file [gravitino]

2024-12-30 Thread via GitHub
Aireed opened a new pull request, #6043: URL: https://github.com/apache/gravitino/pull/6043 ### What changes were proposed in this pull request? move `server.initialize()` to try-catch block, so we can get the exception and output the exception to log file ### Why are the

Re: [PR] [#5982] feat (gvfs-fuse): Implement Gravitino fileset file system [gravitino]

2024-12-30 Thread via GitHub
diqiu50 commented on code in PR #5984: URL: https://github.com/apache/gravitino/pull/5984#discussion_r1899492238 ## clients/filesystem-fuse/src/config.rs: ## @@ -0,0 +1,330 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] [#5982] feat (gvfs-fuse): Implement Gravitino fileset file system [gravitino]

2024-12-30 Thread via GitHub
diqiu50 commented on code in PR #5984: URL: https://github.com/apache/gravitino/pull/5984#discussion_r1899492918 ## clients/filesystem-fuse/src/gvfs_fuse.rs: ## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license a

Re: [I] [Improvement] Improve iceberg rest catalog service [gravitino]

2024-12-30 Thread via GitHub
yulongfufu commented on issue #6034: URL: https://github.com/apache/gravitino/issues/6034#issuecomment-2565369978 > Yes, there are a bunch of things we can do to differentiate from the traditional HMS-based Iceberg catalog, do you have any plan about what you would do in the next step 😄 ?

Re: [PR] [#5982] feat (gvfs-fuse): Implement Gravitino fileset file system [gravitino]

2024-12-30 Thread via GitHub
diqiu50 commented on code in PR #5984: URL: https://github.com/apache/gravitino/pull/5984#discussion_r1899492315 ## clients/filesystem-fuse/src/config.rs: ## @@ -0,0 +1,330 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2024-12-30 Thread via GitHub
yuqi1129 commented on PR #5974: URL: https://github.com/apache/gravitino/pull/5974#issuecomment-2565392008 > @FANNG1 , Please help to solve the problem about token permission for OSS and S3, besides, GCS token for Java client seems to have some problems, please see: #6028 solved --

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2024-12-30 Thread via GitHub
yuqi1129 commented on PR #5974: URL: https://github.com/apache/gravitino/pull/5974#issuecomment-2565410047 > Do you plan to support the static credential like `S3SecretKey` and some storage properties not included in the credential like `s3-region` in the new PR? The currently PR als

[I] [Improvement] optimization tree lock when drop and load Table/Schema [gravitino]

2024-12-30 Thread via GitHub
xunliu opened a new issue, #6044: URL: https://github.com/apache/gravitino/issues/6044 ### What would you like to be improved? Gravitino uses a Write and Read lock in the load and drop Table/Schema RESTful interface, It's very heart and easy to lock race. ### How should we impr

Re: [PR] [#6007] fix: fix hadoop catalog entity name limitation [gravitino]

2024-12-30 Thread via GitHub
jerryshao commented on code in PR #6040: URL: https://github.com/apache/gravitino/pull/6040#discussion_r1899519783 ## catalogs/catalog-hadoop/src/test/java/org/apache/gravitino/catalog/hadoop/integration/test/HadoopCatalogIT.java: ## @@ -301,12 +288,34 @@ public void testExterna

[PR] [#6042] refactor: Use callback to delete the privilege of catalog [gravitino]

2024-12-30 Thread via GitHub
jerqi opened a new pull request, #6045: URL: https://github.com/apache/gravitino/pull/6045 ### What changes were proposed in this pull request? Use callback to delete the privilege of catalog ### Why are the changes needed? Fix: #6042 ### Does this PR introduce _an

Re: [I] [Bug report] When the authentication is configured to Kerberos, the server fails to start and hangs. [gravitino]

2024-12-30 Thread via GitHub
jerryshao closed issue #6022: [Bug report] When the authentication is configured to Kerberos, the server fails to start and hangs. URL: https://github.com/apache/gravitino/issues/6022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] [Improvement] Remove useless `CONTRIBUTING.md` [gravitino]

2024-12-30 Thread via GitHub
jerryshao closed issue #6008: [Improvement] Remove useless `CONTRIBUTING.md` URL: https://github.com/apache/gravitino/issues/6008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#6088] fix(doc): Remove the unnecessary CONTRIBUTING file [gravitino]

2024-12-30 Thread via GitHub
jerryshao merged PR #6039: URL: https://github.com/apache/gravitino/pull/6039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Bug report] When the authentication is configured to Kerberos, the server fails to start and hangs. [gravitino]

2024-12-30 Thread via GitHub
jerryshao closed issue #6022: [Bug report] When the authentication is configured to Kerberos, the server fails to start and hangs. URL: https://github.com/apache/gravitino/issues/6022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

(gravitino) branch main updated: [#6088] fix(doc): Remove the unnecessary CONTRIBUTING file (#6039)

2024-12-30 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 827327632 [#6088] fix(doc): Remove the unnecessary

(gravitino) branch main updated: [#6022] refactor: Output the failed logs to `gravitino-server.log` file (#6043)

2024-12-30 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new c47e845c2 [#6022] refactor: Output the failed logs

Re: [PR] [#6022] refactor: Output the failed logs to `gravitino-server.log` file [gravitino]

2024-12-30 Thread via GitHub
jerryshao merged PR #6043: URL: https://github.com/apache/gravitino/pull/6043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#6007] fix: fix hadoop catalog entity name limitation [gravitino]

2024-12-30 Thread via GitHub
jerryshao commented on PR #6040: URL: https://github.com/apache/gravitino/pull/6040#issuecomment-2566113415 Should we also update the Python client to encode the path? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [#5536] Improvement(client-python): reportUndefinedVariable warning in types.py [gravitino]

2024-12-30 Thread via GitHub
xunliu commented on PR #6001: URL: https://github.com/apache/gravitino/pull/6001#issuecomment-2566195854 hi @orenccl Yes, we can delete them in the source codes. ``` // No usage and class type def as_table_catalog(self) -> "TableCatalog": def as_topic_catalog(self) -> "TopicCa

Re: [PR] [SIP] Fix OSS token privilege [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on code in PR #6029: URL: https://github.com/apache/gravitino/pull/6029#discussion_r1899868114 ## bundles/aliyun/src/main/java/org/apache/gravitino/oss/credential/OSSTokenProvider.java: ## @@ -166,6 +168,7 @@ private String createPolicy(Set readLocations, Set w

Re: [I] [Subtask] [spark-connector] support JDBC catalog [gravitino]

2024-12-30 Thread via GitHub
dataageek commented on issue #1572: URL: https://github.com/apache/gravitino/issues/1572#issuecomment-2566050367 hi @FANNG1 @caican00 This would be a fantastic feature. If the Spark connector supports reading data using the registered Gravitino JDBC catalog, it would allow direct data r

Re: [I] [Improvement] Refactor the validation logic in the handle methods [gravitino]

2024-12-30 Thread via GitHub
justinmclean commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2566045500 Still need to add a validate() method to commands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [#6030] fix(CLI): Fix Setting the same tags multiple times in the Gravitino CLi gives unexpected output [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on PR #6037: URL: https://github.com/apache/gravitino/pull/6037#issuecomment-2566047755 Some more thoughts on this ... Maybe we should tighten the check when adding or updating the tags on an entity. There should be a protocol, somewhere in the docs and the code. For e

Re: [I] [Improvement] Add Support for Inspecting Tables in Datalake Formats like Iceberg [gravitino]

2024-12-30 Thread via GitHub
dataageek commented on issue #4798: URL: https://github.com/apache/gravitino/issues/4798#issuecomment-2566047525 hi @FANNG1, thanks, I can use the underlying Iceberg JDBC catalog. It would be beneficial if the Gravitino Spark connector supports adding all registered JDBC catalogs (Iceberg j

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
justinmclean commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899833853 ## clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java: ## @@ -21,118 +21,8 @@ package org.apache.gravitino.cli; import java.util.Map

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
justinmclean commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899834380 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -494,6 +496,42 @@ private void handleTableCommand() { } } + /**

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
justinmclean commented on PR #6047: URL: https://github.com/apache/gravitino/pull/6047#issuecomment-2565988150 Looks good, but you need to update the help text and CLI documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [#6030] fix(CLI): Fix Setting the same tags multiple times in the Gravitino CLi gives unexpected output [gravitino]

2024-12-30 Thread via GitHub
justinmclean commented on code in PR #6037: URL: https://github.com/apache/gravitino/pull/6037#discussion_r1899841131 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/TagEntity.java: ## @@ -102,4 +110,33 @@ public void handle() { System.out.println(entity +

Re: [PR] [#6030] fix(CLI): Fix Setting the same tags multiple times in the Gravitino CLi gives unexpected output [gravitino]

2024-12-30 Thread via GitHub
justinmclean commented on code in PR #6037: URL: https://github.com/apache/gravitino/pull/6037#discussion_r189983 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/TagEntity.java: ## @@ -102,4 +110,33 @@ public void handle() { System.out.println(entity +

Re: [PR] [#6030] fix(CLI): Fix Setting the same tags multiple times in the Gravitino CLi gives unexpected output [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on code in PR #6037: URL: https://github.com/apache/gravitino/pull/6037#discussion_r1899847773 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/TagEntity.java: ## @@ -102,4 +110,33 @@ public void handle() { System.out.println(entity + " now

Re: [PR] Add cool9850311 to Maintainers list [gravitino]

2024-12-30 Thread via GitHub
justinmclean closed pull request #6046: Add cool9850311 to Maintainers list URL: https://github.com/apache/gravitino/pull/6046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] Add cool9850311 to Maintainers list [gravitino]

2024-12-30 Thread via GitHub
justinmclean commented on PR #6046: URL: https://github.com/apache/gravitino/pull/6046#issuecomment-2566016335 The maintainer's list exists for historical and legal reasons and pre-dates Gravitino's entry as an incubating project at the ASF, and as such, no changes should be made to it. -

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899855900 ## clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java: ## @@ -21,118 +21,8 @@ package org.apache.gravitino.cli; import java.util.Map; -imp

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899855668 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -494,6 +496,42 @@ private void handleTableCommand() { } } + /** Handl

Re: [PR] [#6042] refactor: Use callback to delete the privilege of catalog [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on code in PR #6045: URL: https://github.com/apache/gravitino/pull/6045#discussion_r1899858815 ## core/src/main/java/org/apache/gravitino/hook/CatalogHookDispatcher.java: ## @@ -126,8 +126,20 @@ public boolean dropCatalog(NameIdentifier ident) { @Override

Re: [PR] [SIP] support gcs credential permission for fileset operations [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on PR #6041: URL: https://github.com/apache/gravitino/pull/6041#issuecomment-2566029620 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
justinmclean commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899860534 ## clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java: ## @@ -21,118 +21,8 @@ package org.apache.gravitino.cli; import java.util.Map

Re: [PR] [#5962] feat(client): added audit cli command model [gravitino]

2024-12-30 Thread via GitHub
justinmclean commented on code in PR #6047: URL: https://github.com/apache/gravitino/pull/6047#discussion_r1899860953 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -494,6 +496,42 @@ private void handleTableCommand() { } } + /**

Re: [PR] [#5831] fix(CLI): Fix CLi gives unexpected output when input tag set command [gravitino]

2024-12-30 Thread via GitHub
justinmclean merged PR #5897: URL: https://github.com/apache/gravitino/pull/5897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [I] [Improvement] Setting a tag property in the Gravitino CLi gives unexpected output [gravitino]

2024-12-30 Thread via GitHub
justinmclean closed issue #5831: [Improvement] Setting a tag property in the Gravitino CLi gives unexpected output URL: https://github.com/apache/gravitino/issues/5831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

(gravitino) branch main updated: [#5831] fix(CLI): Fix CLi gives unexpected output when input tag set command (#5897)

2024-12-30 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 9a5fef924 [#5831] fix(CLI): Fix CLi gives unexpe

Re: [PR] [#5872] feat(client): Add model management Java client API [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on code in PR #6003: URL: https://github.com/apache/gravitino/pull/6003#discussion_r1899860387 ## clients/client-java/src/main/java/org/apache/gravitino/client/GenericModelCatalog.java: ## @@ -0,0 +1,330 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] [#6007] fix: fix hadoop catalog entity name limitation [gravitino]

2024-12-30 Thread via GitHub
tengqm commented on code in PR #6040: URL: https://github.com/apache/gravitino/pull/6040#discussion_r1899865040 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogCapability.java: ## @@ -31,4 +31,19 @@ public CapabilityResult managedStorage

Re: [PR] [#5872] feat(client): Add model management Java client API [gravitino]

2024-12-30 Thread via GitHub
mchades commented on code in PR #6003: URL: https://github.com/apache/gravitino/pull/6003#discussion_r1899904882 ## clients/client-java/src/main/java/org/apache/gravitino/client/GenericModelVersion.java: ## Review Comment: Will IT be added in the next PR? -- This is an

Re: [PR] [#6007] fix: fix hadoop catalog entity name limitation [gravitino]

2024-12-30 Thread via GitHub
mchades commented on PR #6040: URL: https://github.com/apache/gravitino/pull/6040#issuecomment-2566125754 > Should we also update the Python client to encode the path? yeah, added -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] [#5950] feat(catalog-model): Add integration tests for model API [gravitino]

2024-12-30 Thread via GitHub
jerryshao commented on code in PR #6051: URL: https://github.com/apache/gravitino/pull/6051#discussion_r1899970010 ## catalogs/catalog-model/src/test/java/org/apache/gravtitino/catalog/model/integration/test/ModelCatalogOperationsIT.java: ## @@ -0,0 +1,371 @@ +/* + * Licensed to

  1   2   >