Re: [PR] [#5985] improvement(CLI): Fix role command that supports handling multiple values [gravitino]

2024-12-26 Thread via GitHub
Abyss-lord commented on PR #5988: URL: https://github.com/apache/gravitino/pull/5988#issuecomment-2562291323 Hi @justinmclean , I’ve finished updating the code. Please take a look at the PR again when you have time. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] [#5585] improvement(bundles): Refactor bundle jars and provide core jars that does not contains hadoop-{aws,gcp,aliyun,azure} [gravitino]

2024-12-26 Thread via GitHub
jerryshao commented on code in PR #5806: URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897794542 ## docs/hadoop-catalog.md: ## @@ -10,10 +10,8 @@ license: "This software is licensed under the Apache License version 2." Hadoop catalog is a fileset catalog th

Re: [PR] [#5585] improvement(bundles): Refactor bundle jars and provide core jars that does not contains hadoop-{aws,gcp,aliyun,azure} [gravitino]

2024-12-26 Thread via GitHub
yuqi1129 commented on code in PR #5806: URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897797038 ## docs/hadoop-catalog.md: ## @@ -10,10 +10,8 @@ license: "This software is licensed under the Apache License version 2." Hadoop catalog is a fileset catalog tha

Re: [PR] [#5993][FOLLOWUP] Make some methods public [gravitino]

2024-12-26 Thread via GitHub
xunliu merged PR #6002: URL: https://github.com/apache/gravitino/pull/6002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

[PR] [#5872] feat(client): Add model management Java client API [gravitino]

2024-12-26 Thread via GitHub
jerryshao opened a new pull request, #6003: URL: https://github.com/apache/gravitino/pull/6003 ### What changes were proposed in this pull request? This PR adds the Java client API for model management. ### Why are the changes needed? This is a part of work of model manag

Re: [PR] [#5585] improvement(bundles): Refactor bundle jars and provide core jars that does not contains hadoop-{aws,gcp,aliyun,azure} [gravitino]

2024-12-26 Thread via GitHub
yuqi1129 commented on code in PR #5806: URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897797038 ## docs/hadoop-catalog.md: ## @@ -10,10 +10,8 @@ license: "This software is licensed under the Apache License version 2." Hadoop catalog is a fileset catalog tha

Re: [PR] [#5585] improvement(bundles): Refactor bundle jars and provide core jars that does not contains hadoop-{aws,gcp,aliyun,azure} [gravitino]

2024-12-26 Thread via GitHub
jerryshao commented on code in PR #5806: URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897798539 ## docs/hadoop-catalog.md: ## @@ -52,7 +50,7 @@ Apart from the above properties, to access fileset like HDFS, S3, GCS, OSS or cu | `s3-access-key-id`|

Re: [PR] [#5585] improvement(bundles): Refactor bundle jars and provide core jars that does not contains hadoop-{aws,gcp,aliyun,azure} [gravitino]

2024-12-26 Thread via GitHub
jerryshao commented on code in PR #5806: URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897799368 ## docs/how-to-use-gvfs.md: ## @@ -77,16 +77,15 @@ Apart from the above properties, to access fileset like S3, GCS, OSS and custom | `s3-access-key-id`

Re: [PR] [#5585] improvement(bundles): Refactor bundle jars and provide core jars that does not contains hadoop-{aws,gcp,aliyun,azure} [gravitino]

2024-12-26 Thread via GitHub
yuqi1129 commented on code in PR #5806: URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897801797 ## docs/hadoop-catalog.md: ## @@ -10,10 +10,8 @@ license: "This software is licensed under the Apache License version 2." Hadoop catalog is a fileset catalog tha

Re: [PR] [#5585] improvement(bundles): Refactor bundle jars and provide core jars that does not contains hadoop-{aws,gcp,aliyun,azure} [gravitino]

2024-12-26 Thread via GitHub
yuqi1129 commented on code in PR #5806: URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897801797 ## docs/hadoop-catalog.md: ## @@ -10,10 +10,8 @@ license: "This software is licensed under the Apache License version 2." Hadoop catalog is a fileset catalog tha

Re: [PR] [#5989] The credential type of ADLSTokenCredentialProvider is not equal to the credential type of ADLSTokenCredential [gravitino]

2024-12-26 Thread via GitHub
tengqm commented on PR #5990: URL: https://github.com/apache/gravitino/pull/5990#issuecomment-2562473280 Nice cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [#5987] improvement: Add more configurations for the config API [gravitino]

2024-12-26 Thread via GitHub
jerqi commented on PR #5999: URL: https://github.com/apache/gravitino/pull/5999#issuecomment-2562474621 @tengqm Do you have other suggestion? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] [FEATURE] Support LDAP Authentication [gravitino]

2024-12-26 Thread via GitHub
jerqi commented on issue #6006: URL: https://github.com/apache/gravitino/issues/6006#issuecomment-2562539102 It's great to support LDAP authentication. Do you have an interest to take over this work? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897814886 ## catalogs/catalog-common/src/main/java/org/apache/gravitino/credential/CredentialConstants.java: ## @@ -22,6 +22,8 @@ public class CredentialConstants { public s

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
orenccl commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897808881 ## core/src/main/java/org/apache/gravitino/credential/config/CredentialConfig.java: ## @@ -21,22 +21,68 @@ import com.google.common.collect.ImmutableMap; import j

Re: [I] [Improvement] add OSS support for IcebergRESTService docker image [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on issue #5779: URL: https://github.com/apache/gravitino/issues/5779#issuecomment-2562693546 sure, please go ahead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] [#6012] feat (gvfs-fuse): Support a Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2024-12-26 Thread via GitHub
diqiu50 opened a new pull request, #6013: URL: https://github.com/apache/gravitino/pull/6013 ### What changes were proposed in this pull request? Support a Gravitino S3 fileset filesystem operation in gvfs fuse, implemented by OpenDal ### Why are the changes needed? Fix

[I] [Bug report] The character “/” is illegal character, but it is not banned in fileset create and update API. [gravitino]

2024-12-26 Thread via GitHub
danhuawang opened a new issue, #6007: URL: https://github.com/apache/gravitino/issues/6007 ### Version main branch ### Describe what's wrong Currently, fileset name can be created or renamed to "ok/test2" . But “/” is illegal character in fileset name . ### Erro

Re: [I] [FEATURE] Support LDAP Authentication [gravitino]

2024-12-26 Thread via GitHub
nqvuong1998 commented on issue #6006: URL: https://github.com/apache/gravitino/issues/6006#issuecomment-2562413422 cc @yuqi1129 @FANNG1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
jerryshao commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897804768 ## catalogs/catalog-common/src/main/java/org/apache/gravitino/credential/CredentialConstants.java: ## @@ -22,6 +22,8 @@ public class CredentialConstants { publi

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
jerryshao commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897808033 ## core/src/main/java/org/apache/gravitino/credential/CredentialCache.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897883598 ## core/src/test/java/org/apache/gravitino/credential/TestCredentialCacheKey.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897884068 ## catalogs/catalog-common/src/main/java/org/apache/gravitino/credential/CredentialConstants.java: ## @@ -22,6 +22,8 @@ public class CredentialConstants { public s

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on PR #5995: URL: https://github.com/apache/gravitino/pull/5995#issuecomment-2562602347 @jerryshao @orenccl @tengqm please help to review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[I] [Bug report] Cannot get custom config in custom catalog-backend [gravitino]

2024-12-26 Thread via GitHub
liangyouze opened a new issue, #6005: URL: https://github.com/apache/gravitino/issues/6005 ### Version main branch ### Describe what's wrong Cannot get custom config in custom catalog-backend from dynamic-config-provider ### Error message and/or stacktrace

Re: [I] [Improvement] MODIFY_TABLE should contain the privilege to select table [gravitino]

2024-12-26 Thread via GitHub
jerqi commented on issue #6011: URL: https://github.com/apache/gravitino/issues/6011#issuecomment-2562672540 cc @xunliu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [Subtask] Implement an in-memory file system for testing and validating the FUSE framework. [gravitino]

2024-12-26 Thread via GitHub
diqiu50 closed issue #5886: [Subtask] Implement an in-memory file system for testing and validating the FUSE framework. URL: https://github.com/apache/gravitino/issues/5886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] [Subtask] Implement a common filesystem layer to simplify real filesystem implementations [gravitino]

2024-12-26 Thread via GitHub
diqiu50 closed issue #5877: [Subtask] Implement a common filesystem layer to simplify real filesystem implementations URL: https://github.com/apache/gravitino/issues/5877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [I] [Improvement] add OSS support for IcebergRESTService docker image [gravitino]

2024-12-26 Thread via GitHub
TungYuChiang commented on issue #5779: URL: https://github.com/apache/gravitino/issues/5779#issuecomment-2562672842 May I take this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897884176 ## core/src/main/java/org/apache/gravitino/credential/config/CredentialConfig.java: ## @@ -21,22 +21,68 @@ import com.google.common.collect.ImmutableMap; import ja

Re: [PR] [#5585] improvement(bundles): Refactor bundle jars and provide core jars that does not contains hadoop-{aws,gcp,aliyun,azure} [gravitino]

2024-12-26 Thread via GitHub
yuqi1129 commented on PR #5806: URL: https://github.com/apache/gravitino/pull/5806#issuecomment-2562618054 > Since our bundled jar does not actually bundle anything, I would rethink the jar/module name, take aws as an example: > > * aws: jar without aws and hadoop dependencies. > *

[PR] [#5889] feat(client-python): Add model management Python API [gravitino]

2024-12-26 Thread via GitHub
jerryshao opened a new pull request, #6009: URL: https://github.com/apache/gravitino/pull/6009 ### What changes were proposed in this pull request? This PR proposes to add Python client API for model management. ### Why are the changes needed? This is part of work to supp

Re: [PR] [#5987] improvement: Add more configurations for the config API [gravitino]

2024-12-26 Thread via GitHub
tengqm commented on PR #5999: URL: https://github.com/apache/gravitino/pull/5999#issuecomment-2562632081 > @tengqm Do you have other suggestion? LGTM, although I was thinking of a JSON type configuration file for this purpose. -- This is an automated message from the Apache Git

Re: [PR] [#5987] improvement: Add more configurations for the config API [gravitino]

2024-12-26 Thread via GitHub
jerqi commented on PR #5999: URL: https://github.com/apache/gravitino/pull/5999#issuecomment-2562640718 > > @tengqm Do you have other suggestion? > > LGTM, although I was thinking of a JSON type configuration file for this purpose. We can expose more config options

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
tengqm commented on PR #5995: URL: https://github.com/apache/gravitino/pull/5995#issuecomment-2562638241 Overall LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [#5987] improvement: Add more configurations for the config API [gravitino]

2024-12-26 Thread via GitHub
mchades merged PR #5999: URL: https://github.com/apache/gravitino/pull/5999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

Re: [I] [Improvement] support 'gravitino.authorization.enable' value in '/configs' api [gravitino]

2024-12-26 Thread via GitHub
mchades closed issue #5987: [Improvement] support 'gravitino.authorization.enable' value in '/configs' api URL: https://github.com/apache/gravitino/issues/5987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [Improvement] support 'gravitino.authorization.enable' value in '/configs' api [gravitino]

2024-12-26 Thread via GitHub
mchades closed issue #5987: [Improvement] support 'gravitino.authorization.enable' value in '/configs' api URL: https://github.com/apache/gravitino/issues/5987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

(gravitino) branch main updated: [#5987] improvement: Add more configurations for the config API (#5999)

2024-12-26 Thread mchades
This is an automated email from the ASF dual-hosted git repository. mchades pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new ba8df392c6 [#5987] improvement: Add more configu

Re: [PR] [#5902] feat: Add tag failure event to Gravitino server [gravitino]

2024-12-26 Thread via GitHub
xunliu commented on PR #5944: URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2562645309 hi @FANNG1 Please help review this PR, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [#5192] [Feature] Support Catalog Operation DDL for paimon-catalog [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on PR #5818: URL: https://github.com/apache/gravitino/pull/5818#issuecomment-2562769361 > Is there anything else that needs to be fixed @FANNG1 Sorry, I'm working on the issues to release 0.8, didn't have enough time to review this PR these days. -- This is an auto

Re: [PR] [#3515] feat(flink-connector): Support flink iceberg catalog [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on code in PR #5914: URL: https://github.com/apache/gravitino/pull/5914#discussion_r1896596310 ## docs/flink-connector/flink-catalog-iceberg.md: ## @@ -0,0 +1,83 @@ +--- +title: "Flink connector Iceberg catalog" +slug: /flink-connector/flink-catalog-iceberg +key

Re: [PR] [#3515] feat(flink-connector): Support flink iceberg catalog [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on PR #5914: URL: https://github.com/apache/gravitino/pull/5914#issuecomment-2562771463 Hi, @sunxiaojian , Sorry for the delay, I'm working on the issues to release 0.8, may doesn't have enough time to review this PR these days. -- This is an automated message from the Ap

Re: [PR] [#5585] improvement(bundles): Refactor bundle jars and provide core jars that does not contains hadoop-{aws,gcp,aliyun,azure} [gravitino]

2024-12-26 Thread via GitHub
yuqi1129 commented on PR #5806: URL: https://github.com/apache/gravitino/pull/5806#issuecomment-2562460198 > Since our bundled jar does not actually bundle anything. To a certain extent, it did bundle something like credential vending(contains all jars needed to provide credential ser

Re: [PR] [#5536] Improvement(client-python): reportUndefinedVariable warning in types.py [gravitino]

2024-12-26 Thread via GitHub
jerryshao commented on PR #6001: URL: https://github.com/apache/gravitino/pull/6001#issuecomment-2562469499 Is it possible to add a lint check for such kind of Python warning in pyintrc? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[I] [Improvement] Architecture picture should be updated [gravitino]

2024-12-26 Thread via GitHub
jerqi opened a new issue, #6010: URL: https://github.com/apache/gravitino/issues/6010 ### What would you like to be improved? Architecture picture should be updated https://github.com/apache/gravitino/blob/main/docs/assets/gravitino-model-arch.png First, we should add schema.

Re: [I] [Improvement] Architecture picture should be updated [gravitino]

2024-12-26 Thread via GitHub
jerqi commented on issue #6010: URL: https://github.com/apache/gravitino/issues/6010#issuecomment-2562658436 cc @jerryshao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
jerryshao commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897902069 ## core/src/main/java/org/apache/gravitino/credential/CredentialCache.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]

2024-12-26 Thread via GitHub
waukin commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2562758155 > You can leave the existing method as `output(catalogs)` and just have that method output "No catalogs exist." if null is passed into it. I’ve kept the existing method as `ou

Re: [PR] [#5901] feat(core): support tag event to Gravitino server [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on PR #5998: URL: https://github.com/apache/gravitino/pull/5998#issuecomment-2562758704 will review the PR until #5944 is merged for some duplicated logic, please wait for a while. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [I] [Subtask] Propose a draft design to add Hbase JDBC Catalog Support [gravitino]

2024-12-26 Thread via GitHub
flaming-archer commented on issue #6020: URL: https://github.com/apache/gravitino/issues/6020#issuecomment-2562905575 Here is the design document. Please feel free to leave your comments. https://docs.google.com/document/d/10KFe0ubyBzYoI_Csqw5vstdBJvAoVYZ2T7irk0BeoQE/edit?usp=sharing

[I] [Subtask] Propose a draft design to add Hbase JDBC Catalog Support [gravitino]

2024-12-26 Thread via GitHub
flaming-archer opened a new issue, #6020: URL: https://github.com/apache/gravitino/issues/6020 ### Describe the subtask Propose a draft design to add Hbase JDBC Catalog Support ### Parent issue https://github.com/apache/gravitino/issues/6019 -- This is an automated

Re: [I] [Feature] Support Hbase catalog [gravitino]

2024-12-26 Thread via GitHub
flaming-archer closed issue #5865: [Feature] Support Hbase catalog URL: https://github.com/apache/gravitino/issues/5865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] [Feature] Support Clickhouse catalog [gravitino]

2024-12-26 Thread via GitHub
flaming-archer commented on issue #3888: URL: https://github.com/apache/gravitino/issues/3888#issuecomment-2562910741 closed due to https://github.com/apache/gravitino/issues/6017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] [Feature] Support Hbase catalog [gravitino]

2024-12-26 Thread via GitHub
flaming-archer commented on issue #5865: URL: https://github.com/apache/gravitino/issues/5865#issuecomment-2562910186 closed due to https://github.com/apache/gravitino/issues/6019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[I] [Improvement] Refactor CLI output methods for no data hints [gravitino]

2024-12-26 Thread via GitHub
waukin opened a new issue, #6014: URL: https://github.com/apache/gravitino/issues/6014 ### What would you like to be improved? In the `ListMetalakes` and `ListCatalogs` methods, if no data is returned, the CLI should provide a hint, such as "No metalakes exist." Currently, the implem

Re: [I] [Improvement] Refactor CLI output methods for no data hints [gravitino]

2024-12-26 Thread via GitHub
waukin commented on issue #6014: URL: https://github.com/apache/gravitino/issues/6014#issuecomment-2562704506 I am working on this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] [#6014] refactor: CLI output methods for no data hints [gravitino]

2024-12-26 Thread via GitHub
waukin opened a new pull request, #6015: URL: https://github.com/apache/gravitino/pull/6015 ### What changes were proposed in this pull request? In the `ListMetalakes` and `ListCatalogs` methods, retain the use of `output(metalakes)` and `output(catalogs)`. If metalakes or c

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897933562 ## core/src/main/java/org/apache/gravitino/credential/CredentialCache.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897933562 ## core/src/main/java/org/apache/gravitino/credential/CredentialCache.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [#5536] Improvement(client-python): reportUndefinedVariable warning in types.py [gravitino]

2024-12-26 Thread via GitHub
orenccl commented on PR #6001: URL: https://github.com/apache/gravitino/pull/6001#issuecomment-2562883570 @jerryshao I think currently pylint can not detect forward reference https://peps.python.org/pep-0484/#forward-references -- This is an automated message from the Apache Git Ser

Re: [PR] [#5585] improvement(bundles): Refactor bundle jars and provide core jars that does not contains hadoop-{aws,gcp,aliyun,azure} [gravitino]

2024-12-26 Thread via GitHub
jerryshao commented on PR #5806: URL: https://github.com/apache/gravitino/pull/5806#issuecomment-2562400221 Since our bundled jar does not actually bundle anything, I would rethink the jar/module name, take aws as an example: - aws: jar without aws and hadoop dependencies. - aws-bu

Re: [PR] [#5985] improvement(CLI): Fix role command that supports handling multiple values [gravitino]

2024-12-26 Thread via GitHub
tengqm commented on code in PR #5988: URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897848602 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -762,6 +775,12 @@ protected void handleRoleCommand() { } } + private

Re: [I] [Bug report] IRCS cannot get AKSK via dynamic-config-provider [gravitino]

2024-12-26 Thread via GitHub
liangyouze closed issue #6000: [Bug report] IRCS cannot get AKSK via dynamic-config-provider URL: https://github.com/apache/gravitino/issues/6000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
orenccl commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897826816 ## core/src/test/java/org/apache/gravitino/credential/TestCredentialCacheKey.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[I] [Improvement] Remove useless `CONTRIBUTING.md` [gravitino]

2024-12-26 Thread via GitHub
jerqi opened a new issue, #6008: URL: https://github.com/apache/gravitino/issues/6008 ### What would you like to be improved? In the directory `.github`, there is an extra CONTRIBUTING.md. ### How should we improve? We should remove this file -- This is an automated me

[I] [Improvement] consider the cross time zone problems for credential [gravitino]

2024-12-26 Thread via GitHub
FANNG1 opened a new issue, #6016: URL: https://github.com/apache/gravitino/issues/6016 ### What would you like to be improved? credential use epoch time to represent expire time, could it works well when Gravitino server and client side locates in different time zone regions? #

Re: [PR] [#4398] feat(core): support credential cache for Gravitino server [gravitino]

2024-12-26 Thread via GitHub
jerryshao commented on code in PR #5995: URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897946356 ## core/src/main/java/org/apache/gravitino/credential/CredentialCache.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[PR] [#ISSUE-5993][FOLLOWUP] Make some methods public [gravitino]

2024-12-26 Thread via GitHub
jerqi opened a new pull request, #6002: URL: https://github.com/apache/gravitino/pull/6002 ### What changes were proposed in this pull request? Make some methods public, let some classes to reuse some methods. ### Why are the changes needed? This is a follow-up PR.

Re: [I] [Improvement] Sample command in CLI document may report error [gravitino]

2024-12-26 Thread via GitHub
justinmclean commented on issue #5541: URL: https://github.com/apache/gravitino/issues/5541#issuecomment-2562309559 Perhaps, but they can also try out the command and see what it does, and that's how most people learn. The text would be "Some basic information about a metalake, like its nam

Re: [I] [Subtask] Authentication and authorization support for Iceberg REST server [gravitino]

2024-12-26 Thread via GitHub
nqvuong1998 commented on issue #4063: URL: https://github.com/apache/gravitino/issues/4063#issuecomment-2562326301 Hi @FANNG1 , any updates for this task? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] [Subtask] Authentication and authorization support for Iceberg REST server [gravitino]

2024-12-26 Thread via GitHub
nqvuong1998 commented on issue #4063: URL: https://github.com/apache/gravitino/issues/4063#issuecomment-2562329191 The Graviton Iceberg REST service would benefit from supporting the following features: - Authentication: Integration with LDAP and OAuth2 (e.g., Client Credentials Flow

Re: [I] [Subtask] Propose a draft design to add ClickHouse JDBC Catalog Support [gravitino]

2024-12-26 Thread via GitHub
flaming-archer commented on issue #6018: URL: https://github.com/apache/gravitino/issues/6018#issuecomment-2562902404 Here is the design document. Please feel free to leave your comments. https://docs.google.com/document/d/1oj1oG_PzVBX_ngRzacupG9lshnH7UjDsso1c6LrhFog/edit?usp=sharing

[I] [EPIC] Support Hbase catalog [gravitino]

2024-12-26 Thread via GitHub
flaming-archer opened a new issue, #6019: URL: https://github.com/apache/gravitino/issues/6019 ### Describe the proposal [Apache](https://www.apache.org/) [HBase®](https://hbase.apache.org/) is the [Hadoop](https://hadoop.apache.org/) database, a distributed, scalable, big data store

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2024-12-26 Thread via GitHub
tengqm commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1898152704 ## clients/filesystem-fuse/conf/gvfs_fuse.toml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2024-12-26 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1898216648 ## clients/filesystem-fuse/src/gravitino_client.rs: ## @@ -0,0 +1,277 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor li

Re: [PR] [#5982] feat (gvfs-fuse): Implement Gravitino fileset file system [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on code in PR #5984: URL: https://github.com/apache/gravitino/pull/5984#discussion_r1898333523 ## clients/filesystem-fuse/src/gvfs_fileset_fs.rs: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor lice

Re: [PR] [#5982] feat (gvfs-fuse): Implement Gravitino fileset file system [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on code in PR #5984: URL: https://github.com/apache/gravitino/pull/5984#discussion_r1898328151 ## clients/filesystem-fuse/src/gravitino_client.rs: ## @@ -0,0 +1,277 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor lic

Re: [PR] [#5902] feat: Add tag failure event to Gravitino server [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on code in PR #5944: URL: https://github.com/apache/gravitino/pull/5944#discussion_r1898338425 ## core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagFailureEvent.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] [#5902] feat: Add tag failure event to Gravitino server [gravitino]

2024-12-26 Thread via GitHub
FANNG1 commented on PR #5944: URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2563431271 Could you add related document in `gravitino-server-config.md`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] [Subtask] Add audit CLI command for Model [gravitino]

2024-12-26 Thread via GitHub
VigneshSK17 commented on issue #5962: URL: https://github.com/apache/gravitino/issues/5962#issuecomment-2563160833 No worries, definitely make sure to enjoy your time off! I did have a question about this command. Should this audit command also be auditing the ModelVersion, not do so,

Re: [PR] [#5536] Improvement(client-python): reportUndefinedVariable warning in types.py [gravitino]

2024-12-26 Thread via GitHub
orenccl commented on PR #6001: URL: https://github.com/apache/gravitino/pull/6001#issuecomment-2563309985 Sure, I will update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [#5585] improvement(bundles): Refactor bundle jars and provide core jars that does not contains hadoop-{aws,gcp,aliyun,azure} [gravitino]

2024-12-26 Thread via GitHub
yuqi1129 commented on code in PR #5806: URL: https://github.com/apache/gravitino/pull/5806#discussion_r1898259764 ## docs/how-to-use-gvfs.md: ## @@ -77,16 +77,15 @@ Apart from the above properties, to access fileset like S3, GCS, OSS and custom | `s3-access-key-id`

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2024-12-26 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1898185731 ## clients/filesystem-fuse/src/config.rs: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2024-12-26 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1898216993 ## clients/filesystem-fuse/src/gravitino_client.rs: ## @@ -0,0 +1,277 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor li

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2024-12-26 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1898217225 ## clients/filesystem-fuse/src/gvfs_fuse.rs: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license a

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2024-12-26 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1898216870 ## clients/filesystem-fuse/src/gravitino_client.rs: ## @@ -0,0 +1,277 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor li

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2024-12-26 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1898218949 ## clients/filesystem-fuse/src/open_dal_filesystem.rs: ## @@ -0,0 +1,269 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2024-12-26 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1898218180 ## clients/filesystem-fuse/src/main.rs: ## @@ -16,18 +16,32 @@ * specific language governing permissions and limitations * under the License. */ +use fuse3::Err

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2024-12-26 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1898220362 ## clients/filesystem-fuse/conf/gvfs_fuse.toml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agree

Re: [PR] [#5536] Improvement(client-python): reportUndefinedVariable warning in types.py [gravitino]

2024-12-26 Thread via GitHub
jerryshao commented on PR #6001: URL: https://github.com/apache/gravitino/pull/6001#issuecomment-2563285454 I see, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [#5536] Improvement(client-python): reportUndefinedVariable warning in types.py [gravitino]

2024-12-26 Thread via GitHub
jerryshao commented on PR #6001: URL: https://github.com/apache/gravitino/pull/6001#issuecomment-2563285824 Can you please check all the python codes to see if there's similar issue in other files, I think we can fix it all in this PR. -- This is an automated message from the Apache Git S

[I] [Bug report] When the authentication is configured to Kerberos, the server fails to start and hangs. [gravitino]

2024-12-26 Thread via GitHub
Aireed opened a new issue, #6022: URL: https://github.com/apache/gravitino/issues/6022 ### Version main branch ### Describe what's wrong The service did not start properly. ### Error message and/or stacktrace gravitino-server.log: ``` 2024-12-27 1

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2024-12-26 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1898220290 ## clients/filesystem-fuse/conf/gvfs_fuse.toml: ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agree

[PR] [#5968] fix(server-common): The owner of the catalog is incorrect when using Basic Auth and Password is empty [gravitino]

2024-12-26 Thread via GitHub
frankvicky opened a new pull request, #6023: URL: https://github.com/apache/gravitino/pull/6023 ### Why are the changes needed? Current implementation of `SimpleAuthenticator` doesn't comply with HTTP Basic Authentication specification, which allows username-only or username with empty p

Re: [PR] [#5968] fix(server-common): The owner of the catalog is incorrect when using Basic Auth and Password is empty [gravitino]

2024-12-26 Thread via GitHub
frankvicky commented on PR #6023: URL: https://github.com/apache/gravitino/pull/6023#issuecomment-2563290844 Hi @jerqi Could you please take a look ? Many thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [#5968] fix(server-common): The owner of the catalog is incorrect when using Basic Auth and Password is empty [gravitino]

2024-12-26 Thread via GitHub
jerqi commented on PR #6023: URL: https://github.com/apache/gravitino/pull/6023#issuecomment-2563293656 Could you add more cases? like`user1:`,`:password`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse [gravitino]

2024-12-26 Thread via GitHub
diqiu50 commented on code in PR #6013: URL: https://github.com/apache/gravitino/pull/6013#discussion_r1898191633 ## clients/filesystem-fuse/src/config.rs: ## @@ -0,0 +1,324 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agre

Re: [PR] [#6014] refactor: CLI output methods for no data hints [gravitino]

2024-12-26 Thread via GitHub
tengqm commented on PR #6015: URL: https://github.com/apache/gravitino/pull/6015#issuecomment-2563179429 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] [#5889] feat(client-python): Add model management Python API [gravitino]

2024-12-26 Thread via GitHub
tengqm commented on code in PR #6009: URL: https://github.com/apache/gravitino/pull/6009#discussion_r1898161883 ## clients/client-python/gravitino/client/generic_model_catalog.py: ## @@ -0,0 +1,534 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

  1   2   >