Re: [I] [Subtask] add fileset pre event to Gravitino server [gravitino]

2024-11-21 Thread via GitHub
TungYuChiang commented on issue #5548: URL: https://github.com/apache/gravitino/issues/5548#issuecomment-2491151562 Hi @FANNG1 , I’m sorry for the delay. I’ve been quite busy this week, but I will make sure to complete it by this weekend. Thank you for your understanding! -- This i

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on PR #5627: URL: https://github.com/apache/gravitino/pull/5627#issuecomment-2491157851 suggest adding basic check for code style and common errors in ci ``` cargo fmt --all -- --check cargo clippy --all-targets --all-features --workspace -- -D warn

Re: [PR] [#5336] feat(auth-ranger): Remove MANAGED_BY_GRAVITINO limit and compatible for existing ranger policy [gravitino]

2024-11-21 Thread via GitHub
theoryxu commented on code in PR #5629: URL: https://github.com/apache/gravitino/pull/5629#discussion_r1851867253 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java: ## @@ -142,7 +144,7 @@ void addPolicyItem(RangerPol

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851975498 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contrib

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851981721 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
xloya commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851925369 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

Re: [PR] [#5336] feat(auth-ranger): Remove MANAGED_BY_GRAVITINO limit and compatible for existing ranger policy [gravitino]

2024-11-21 Thread via GitHub
theoryxu commented on code in PR #5629: URL: https://github.com/apache/gravitino/pull/5629#discussion_r1851936397 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java: ## @@ -480,8 +505,8 @@ protected void updatePolicyO

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851913594 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contrib

Re: [PR] [#5556] feat(iceberg) support audit framework for Iceberg REST server [gravitino]

2024-11-21 Thread via GitHub
jerryshao merged PR #5580: URL: https://github.com/apache/gravitino/pull/5580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Improvement] integrate audit log framework for Iceberg REST server [gravitino]

2024-11-21 Thread via GitHub
jerryshao closed issue #5556: [Improvement] integrate audit log framework for Iceberg REST server URL: https://github.com/apache/gravitino/issues/5556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

(gravitino) branch main updated: [#4362] feat(web): Add GitHub stars and forks number for WebUI (#5567)

2024-11-21 Thread liuxun
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new af259c3a6 [#4362] feat(web): Add GitHub stars and

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851957061 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1852034056 ## clients/filesystem-fuse/check_rust_env.sh: ## @@ -0,0 +1,43 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
diqiu50 commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1853187380 ## clients/filesystem-fuse/check_rust_env.sh: ## @@ -0,0 +1,45 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

(gravitino) branch main updated: [#5637] Add CLI unit tests to check if the right command has been called. (#5638)

2024-11-21 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 67d316d04 [#5637] Add CLI unit tests to check if t

Re: [I] [Improvement] Add more CLI command unit tests [gravitino]

2024-11-21 Thread via GitHub
jerryshao closed issue #5637: [Improvement] Add more CLI command unit tests URL: https://github.com/apache/gravitino/issues/5637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#5637] Add CLI unit tests to check if the right command has been called. [gravitino]

2024-11-21 Thread via GitHub
jerryshao merged PR #5638: URL: https://github.com/apache/gravitino/pull/5638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#5637] Add CLI unit tests to check if the right command has been called. [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5638: URL: https://github.com/apache/gravitino/pull/5638#discussion_r1853390470 ## clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java: ## @@ -0,0 +1,423 @@ +/* Methods used for testing - basically a seam where we can se

Re: [I] [Improvement] Remove TestFetchFileUtils test to reduce test failures [gravitino]

2024-11-21 Thread via GitHub
jerryshao closed issue #5642: [Improvement] Remove TestFetchFileUtils test to reduce test failures URL: https://github.com/apache/gravitino/issues/5642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

(gravitino) branch main updated: [#5642] test: disable TestFetchFileUtils test to reduce test failures (#5644)

2024-11-21 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 6641141c0 [#5642] test: disable TestFetchFileUtils

Re: [I] [Improvement] Remove TestFetchFileUtils test to reduce test failures [gravitino]

2024-11-21 Thread via GitHub
jerryshao closed issue #5642: [Improvement] Remove TestFetchFileUtils test to reduce test failures URL: https://github.com/apache/gravitino/issues/5642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [#5642] test: disable TestFetchFileUtils test to reduce test failures [gravitino]

2024-11-21 Thread via GitHub
jerryshao merged PR #5644: URL: https://github.com/apache/gravitino/pull/5644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Improvement] Add more CLI command unit tests [gravitino]

2024-11-21 Thread via GitHub
jerryshao closed issue #5637: [Improvement] Add more CLI command unit tests URL: https://github.com/apache/gravitino/issues/5637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#5556] feat(iceberg) support audit framework for Iceberg REST server [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on PR #5580: URL: https://github.com/apache/gravitino/pull/5580#issuecomment-2490401329 @FANNG1 Please fix the conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] [Improvement] Display sort order for tables in the Gravitino CLI [gravitino]

2024-11-21 Thread via GitHub
justinmclean commented on issue #5279: URL: https://github.com/apache/gravitino/issues/5279#issuecomment-2490405592 Thanks for offering to help. If you need any assistance or have any questions, just ask. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [#5454] feat(web): different data table column types are supported depending on the provider [gravitino]

2024-11-21 Thread via GitHub
orenccl commented on PR #5636: URL: https://github.com/apache/gravitino/pull/5636#issuecomment-2490340313 @LauraXia123 Thank you for reviewing this. Please approve it at your convenience. 🙇‍♂️ -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on PR #5627: URL: https://github.com/apache/gravitino/pull/5627#issuecomment-2490276898 @FANNG1 can you please help to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1851506565 ## clients/filesystem-fuse/check_rust_env.sh: ## @@ -0,0 +1,45 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

Re: [PR] [#4362] feat(web): Add GitHub stars and forks number for WebUI [gravitino]

2024-11-21 Thread via GitHub
LauraXia123 commented on PR #5567: URL: https://github.com/apache/gravitino/pull/5567#issuecomment-2490465749 Thank you very much for your contribution. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [#5550] feat(core): add partition pre event to Gravitino event [gravitino]

2024-11-21 Thread via GitHub
tengqm commented on code in PR #5590: URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851716384 ## core/src/main/java/org/apache/gravitino/listener/api/event/PartitionPreEvent.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] [#5507] feat(python): Support Azure blob storage for GVFS python client [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5538: URL: https://github.com/apache/gravitino/pull/5538#discussion_r1851690479 ## clients/client-python/tests/integration/test_gvfs_with_abs.py: ## @@ -0,0 +1,373 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

Re: [PR] [#5556] feat(iceberg) support audit framework for Iceberg REST server [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5580: URL: https://github.com/apache/gravitino/pull/5580#discussion_r1851722175 ## core/src/main/java/org/apache/gravitino/audit/v2/CompatibilityUtils.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [#5556] feat(iceberg) support audit framework for Iceberg REST server [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5580: URL: https://github.com/apache/gravitino/pull/5580#discussion_r1851724509 ## core/src/main/java/org/apache/gravitino/listener/api/event/OperationStatus.java: ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [#5556] feat(iceberg) support audit framework for Iceberg REST server [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5580: URL: https://github.com/apache/gravitino/pull/5580#discussion_r1851731973 ## core/src/main/java/org/apache/gravitino/audit/v2/CompatibilityUtils.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [I] [Subtask] support Aliyun oss credential provider [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on issue #5625: URL: https://github.com/apache/gravitino/issues/5625#issuecomment-2490496585 > > This feature is scheduled to be included in version 0.8, which is set to be released by the end of December. Would this timeline work for you? > > OK,no problem , a month

Re: [PR] [#5631] Add test cases for other supported catalogs in Trino Cascading [gravitino]

2024-11-21 Thread via GitHub
danhuawang commented on code in PR #5632: URL: https://github.com/apache/gravitino/pull/5632#discussion_r1851403170 ## trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryIT.java: ## @@ -131,6 +132,23 @@ public void runO

Re: [PR] [#4362] feat(web): Add GitHub stars and forks number for WebUI [gravitino]

2024-11-21 Thread via GitHub
xunliu merged PR #5567: URL: https://github.com/apache/gravitino/pull/5567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [I] [FEATURE] Add github logo, stars number and forks number for UI [gravitino]

2024-11-21 Thread via GitHub
xunliu closed issue #4362: [FEATURE] Add github logo, stars number and forks number for UI URL: https://github.com/apache/gravitino/issues/4362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [#5556] feat(iceberg) support audit framework for Iceberg REST server [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5580: URL: https://github.com/apache/gravitino/pull/5580#discussion_r1851634885 ## core/src/main/java/org/apache/gravitino/audit/v2/CompatibilityUtils.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] [#5550] feat(core): add partition pre event to Gravitino event [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5590: URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851596611 ## core/src/main/java/org/apache/gravitino/listener/api/event/PartitionPreEvent.java: ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1851503453 ## clients/filesystem-fuse/Cargo.toml: ## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] [#5557] improvement(CI): Add some docs and tests about how to use ADLS in Hive [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on PR #5558: URL: https://github.com/apache/gravitino/pull/5558#issuecomment-2490343660 Do you need to update the PR based on #5630 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Subtask] support Aliyun oss credential provider [gravitino]

2024-11-21 Thread via GitHub
sunxiaojian commented on issue #5625: URL: https://github.com/apache/gravitino/issues/5625#issuecomment-2490441876 > This feature is scheduled to be included in version 0.8, which is set to be released by the end of December. Would this timeline work for you? OK,no problem , a month s

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
tengqm commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1851496401 ## clients/gvfs-fuse/check_rust_env.sh: ## @@ -0,0 +1,48 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licens

Re: [PR] [#5637] Add CLI unit tests to check if the right command has been called. [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on PR #5638: URL: https://github.com/apache/gravitino/pull/5638#issuecomment-2490270382 Yeah, I'm fine with the current direction, please add more tests to cover all the options/flags as possible as we can. -- This is an automated message from the Apache Git Service. T

Re: [I] [Subtask] support Aliyun oss credential provider [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on issue #5625: URL: https://github.com/apache/gravitino/issues/5625#issuecomment-2490351295 > @FANNG1 Can assign it to me This feature is scheduled to be included in version 0.8, which is set to be released by the end of December. Would this timeline work for you?

Re: [PR] [#5454] feat(web): different data table column types are supported depending on the provider [gravitino]

2024-11-21 Thread via GitHub
xunliu merged PR #5636: URL: https://github.com/apache/gravitino/pull/5636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

(gravitino) branch main updated: [#5454] feat(web): different data table column types are supported depending on the provider (#5636)

2024-11-21 Thread liuxun
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 85e9918ac [#5454] feat(web): different data table

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1852023763 ## clients/filesystem-fuse/Cargo.toml: ## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [PR] [#5336] feat(auth-ranger): Remove MANAGED_BY_GRAVITINO limit and compatible for existing ranger policy [gravitino]

2024-11-21 Thread via GitHub
theoryxu commented on code in PR #5629: URL: https://github.com/apache/gravitino/pull/5629#discussion_r1851866974 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java: ## @@ -252,8 +269,16 @@ protected boolean checkRang

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1852082386 ## clients/filesystem-fuse/Cargo.toml: ## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [PR] [#5556] feat(iceberg) support audit framework for Iceberg REST server [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5580: URL: https://github.com/apache/gravitino/pull/5580#discussion_r1851843599 ## core/src/main/java/org/apache/gravitino/audit/v2/CompatibilityUtils.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [I] [Improvement] Remove `RocksDBKvBackend` and related code & dependencies from code base. [gravitino]

2024-11-21 Thread via GitHub
pithecuse527 commented on issue #5633: URL: https://github.com/apache/gravitino/issues/5633#issuecomment-2490859856 I have a few questions as I go through the code. 1. Is this issue related to https://github.com/apache/gravitino/issues/2290? (Is this why we need to remove the RocksD

Re: [PR] [#5550] feat(core): add partition pre event to Gravitino event [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5590: URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851910770 ## core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851910781 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851914627 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on PR #5612: URL: https://github.com/apache/gravitino/pull/5612#issuecomment-2490812438 @xunliu @shaofengshi @FANNG1 @yuqi1129 @mchades @diqiu50 can you please also help to review? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [#5550] feat(core): add partition pre event to Gravitino event [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5590: URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851848929 ## core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#5550] feat(core): add partition pre event to Gravitino event [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5590: URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851848929 ## core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#5336] feat(auth-ranger): Remove MANAGED_BY_GRAVITINO limit and compatible for existing ranger policy [gravitino]

2024-11-21 Thread via GitHub
theoryxu commented on code in PR #5629: URL: https://github.com/apache/gravitino/pull/5629#discussion_r1851849765 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java: ## @@ -385,7 +411,6 @@ protected RangerPolicy crea

Re: [PR] [#5336] feat(auth-ranger): Remove MANAGED_BY_GRAVITINO limit and compatible for existing ranger policy [gravitino]

2024-11-21 Thread via GitHub
theoryxu commented on code in PR #5629: URL: https://github.com/apache/gravitino/pull/5629#discussion_r1851849765 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java: ## @@ -385,7 +411,6 @@ protected RangerPolicy crea

Re: [PR] [#5336] feat(auth-ranger): Remove MANAGED_BY_GRAVITINO limit and compatible for existing ranger policy [gravitino]

2024-11-21 Thread via GitHub
theoryxu commented on code in PR #5629: URL: https://github.com/apache/gravitino/pull/5629#discussion_r1851960937 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java: ## @@ -154,8 +156,8 @@ void addPolicyItem(RangerPol

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
diqiu50 commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1851989715 ## clients/filesystem-fuse/check_rust_env.sh: ## @@ -0,0 +1,45 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] [#5550] feat(core): add partition pre event to Gravitino event [gravitino]

2024-11-21 Thread via GitHub
tengqm commented on code in PR #5590: URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851900160 ## core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
xloya commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851682137 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851984387 ## api/src/main/java/org/apache/gravitino/model/ModelCatalog.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or mo

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
tengqm commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1852073811 ## clients/filesystem-fuse/check_rust_env.sh: ## @@ -0,0 +1,45 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
jerqi commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1848157026 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

Re: [PR] [#5550] feat(core): add partition pre event to Gravitino event [gravitino]

2024-11-21 Thread via GitHub
tengqm commented on code in PR #5590: URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851434652 ## core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1852029740 ## clients/filesystem-fuse/Cargo.toml: ## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-21 Thread via GitHub
waukin commented on code in PR #5606: URL: https://github.com/apache/gravitino/pull/5606#discussion_r1852220285 ## clients/cli/src/main/java/org/apache/gravitino/cli/CommandLineOutputs.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-21 Thread via GitHub
waukin commented on code in PR #5606: URL: https://github.com/apache/gravitino/pull/5606#discussion_r1852220285 ## clients/cli/src/main/java/org/apache/gravitino/cli/CommandLineOutputs.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [#5452] Improvement(web): add REST catalog backend for Iceberg catalog [gravitino]

2024-11-21 Thread via GitHub
LauraXia123 commented on PR #5635: URL: https://github.com/apache/gravitino/pull/5635#issuecomment-2490653669 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [#5336] feat(auth-ranger): Remove MANAGED_BY_GRAVITINO limit and compatible for existing ranger policy [gravitino]

2024-11-21 Thread via GitHub
theoryxu commented on code in PR #5629: URL: https://github.com/apache/gravitino/pull/5629#discussion_r1851936397 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java: ## @@ -480,8 +505,8 @@ protected void updatePolicyO

Re: [I] [Subtask] add fileset pre event to Gravitino server [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on issue #5548: URL: https://github.com/apache/gravitino/issues/5548#issuecomment-2491193539 @TungYuChiang this is just a notice ping, please take your time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [I] [Subtask] add fileset pre event to Gravitino server [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on issue #5548: URL: https://github.com/apache/gravitino/issues/5548#issuecomment-2491041241 @TungYuChiang is there any process? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851957061 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more cont

Re: [PR] [#5550] feat(core): add partition pre event to Gravitino event [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on PR #5590: URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2491037993 @LiuQhahah as #5580 is merged first, could you rebase the code and add more work: 1. add operationType method to all specific partition event. ``` @Override public Operat

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
xloya commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1852002594 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
xloya commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851996831 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
xloya commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851993208 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851996670 ## api/src/main/java/org/apache/gravitino/model/ModelCatalog.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
diqiu50 commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1851487256 ## settings.gradle.kts: ## @@ -47,7 +47,8 @@ include( "clients:filesystem-hadoop3", "clients:filesystem-hadoop3-runtime", "clients:client-python", - "client

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
xloya commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1851928380 ## api/src/main/java/org/apache/gravitino/model/Model.java: ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-21 Thread via GitHub
waukin commented on code in PR #5606: URL: https://github.com/apache/gravitino/pull/5606#discussion_r1852220285 ## clients/cli/src/main/java/org/apache/gravitino/cli/CommandLineOutputs.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [#5455] feat(web): disable to update the reserved fields of table properties [gravitino]

2024-11-21 Thread via GitHub
tengqm commented on code in PR #5643: URL: https://github.com/apache/gravitino/pull/5643#discussion_r1853143890 ## web/web/src/lib/utils/initial.js: ## @@ -570,10 +566,64 @@ const relationalColumnTypeMap = { ] } -export const getRelationalColumnTypeMap = catalog => { +expo

Re: [I] [Subtask] Add event listener support for Tag system. [gravitino]

2024-11-21 Thread via GitHub
xunliu commented on issue #4309: URL: https://github.com/apache/gravitino/issues/4309#issuecomment-2492791012 hi @amazingLychee Thank you for your interest in this issue. I already assign it to you. :-) -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [I] [Subtask] Add event listener support for Tag system. [gravitino]

2024-11-21 Thread via GitHub
amazingLychee commented on issue #4309: URL: https://github.com/apache/gravitino/issues/4309#issuecomment-2492788856 Hi @jerryshao, can I take this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
FANNG1 commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1853227496 ## clients/filesystem-fuse/Cargo.toml: ## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. Se

Re: [I] [Subtask] Add event listener support for Tag system. [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on issue #4309: URL: https://github.com/apache/gravitino/issues/4309#issuecomment-2492791717 > Hi @jerryshao, can I take this? Please go ahead. Thanks @amazingLychee . -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] [5201]Implement expressions in python client [gravitino]

2024-11-21 Thread via GitHub
SophieTech88 opened a new pull request, #5646: URL: https://github.com/apache/gravitino/pull/5646 ### What changes were proposed in this pull request? Implement expression in java, including: - Expression.java - FunctionExpression.java - NamedReference.java - UnparsedExpression

Re: [PR] [#5550] feat(core): add partition pre event to Gravitino event [gravitino]

2024-11-21 Thread via GitHub
LiuQhahah commented on PR #5590: URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2492976776 > @LiuQhahah as #5580 is merged first, could you rebase the code and add more work: > > 1. add operationType method to all specific partition event. > > ``` > @Overr

Re: [PR] [#5506] feat(CLI): Table formatted output [gravitino]

2024-11-21 Thread via GitHub
waukin commented on code in PR #5606: URL: https://github.com/apache/gravitino/pull/5606#discussion_r1852220285 ## clients/cli/src/main/java/org/apache/gravitino/cli/CommandLineOutputs.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [#5600] feat(API): Add Java API definition for ML model in Gravitino [gravitino]

2024-11-21 Thread via GitHub
mchades commented on code in PR #5612: URL: https://github.com/apache/gravitino/pull/5612#discussion_r1853238696 ## api/src/main/java/org/apache/gravitino/model/ModelCatalog.java: ## @@ -0,0 +1,118 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] [#5637] Add CLI unit tests to check if the right command has been called. [gravitino]

2024-11-21 Thread via GitHub
justinmclean commented on code in PR #5638: URL: https://github.com/apache/gravitino/pull/5638#discussion_r1853279611 ## clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java: ## @@ -0,0 +1,423 @@ +/* Methods used for testing - basically a seam where we can

Re: [PR] [#5626] feat (gvfs-fuse): Set up a submodule project for the Gvfs-fuse [gravitino]

2024-11-21 Thread via GitHub
jerryshao commented on code in PR #5627: URL: https://github.com/apache/gravitino/pull/5627#discussion_r1853260440 ## clients/filesystem-fuse/Cargo.toml: ## @@ -0,0 +1,34 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

Re: [PR] [#5637] Add CLI unit tests to check if the right command has been called. [gravitino]

2024-11-21 Thread via GitHub
justinmclean commented on code in PR #5638: URL: https://github.com/apache/gravitino/pull/5638#discussion_r1853264072 ## clients/cli/src/main/java/org/apache/gravitino/cli/TestableCommandLine.java: ## @@ -0,0 +1,423 @@ +/* Methods used for testing - basically a seam where we can

[PR] [#5633] remove the key-value storage backend logic [gravitino]

2024-11-21 Thread via GitHub
pithecuse527 opened a new pull request, #5645: URL: https://github.com/apache/gravitino/pull/5645 ### What changes were proposed in this pull request? Remove Key-Value storage backend storage implementations ### Why are the changes needed? Fix: #5633 ### Does t

Re: [PR] [#5637] Add CLI unit tests to check if the right command has been called. [gravitino]

2024-11-21 Thread via GitHub
justinmclean commented on code in PR #5638: URL: https://github.com/apache/gravitino/pull/5638#discussion_r1853264176 ## clients/cli/src/test/java/org/apache/gravitino/cli/TestCatalogCommands.java: ## @@ -0,0 +1,293 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

[PR] update sidebar for version 0.7.0 [gravitino-site]

2024-11-21 Thread via GitHub
LauraXia123 opened a new pull request, #37: URL: https://github.com/apache/gravitino-site/pull/37 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

  1   2   >