caican00 commented on code in PR #5092:
URL: https://github.com/apache/gravitino/pull/5092#discussion_r1800568074
##
docs/lakehouse-paimon-catalog.md:
##
@@ -22,38 +22,40 @@ Builds with Apache Paimon `0.8.0`.
### Catalog capabilities
-- Works as a catalog proxy, supporting
caican00 opened a new pull request, #5136:
URL: https://github.com/apache/gravitino/pull/5136
### What changes were proposed in this pull request?
Support kerberos auth for Paimon HiveCatalog.
### Why are the changes needed?
Fix: https://github.com/apache/gravitino/issues
xxzhky opened a new issue, #5137:
URL: https://github.com/apache/gravitino/issues/5137
### Version
0.6.0
### Describe what's wrong
Gravitino catalog
configProperties td {white-space:nowrap;border:1px solid
#dee0e3;font-size:10pt
yuqi1129 commented on PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#issuecomment-2413069338
@jerryshao
The code has been updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jerqi commented on issue #4831:
URL: https://github.com/apache/gravitino/issues/4831#issuecomment-2413076236
For access control API, I will change some 404 code to 400. More details you
can see https://github.com/apache/gravitino/issues/5105
--
This is an automated message from the Apache
FANNG1 commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1800987291
##
core/src/main/java/org/apache/gravitino/audit/FileAuditWriter.java:
##
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1801108915
##
clients/filesystem-hadoop3/build.gradle.kts:
##
@@ -71,6 +75,11 @@ tasks.build {
dependsOn("javadoc")
}
+tasks.compileJava {
Review Comment:
Why do we
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1801125699
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java:
##
@@ -119,26 +125,35 @@ public void initialize(
M
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1801119181
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogPropertiesMetadata.java:
##
@@ -34,6 +36,21 @@ public class HadoopCatalogP
yuqi1129 commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1801124561
##
clients/filesystem-hadoop3/build.gradle.kts:
##
@@ -71,6 +75,11 @@ tasks.build {
dependsOn("javadoc")
}
+tasks.compileJava {
Review Comment:
This module
FANNG1 commented on code in PR #5127:
URL: https://github.com/apache/gravitino/pull/5127#discussion_r1801127715
##
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/operation/JdbcTableOperations.java:
##
@@ -168,6 +168,15 @@ protected JdbcTable.Builder
jerryshao commented on PR #4996:
URL: https://github.com/apache/gravitino/pull/4996#issuecomment-2413298239
Please address the conflicts here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jerqi opened a new pull request, #5144:
URL: https://github.com/apache/gravitino/pull/5144
### What changes were proposed in this pull request?
Error code optimization about access control API
### Why are the changes needed?
Fix: #5105
### Does this PR introduce _
jerryshao commented on PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#issuecomment-2413271699
@FANNG1 can you please do another round of review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
coolderli commented on PR #4819:
URL: https://github.com/apache/gravitino/pull/4819#issuecomment-2413356596
@FANNG1 @mchades I have addressed the comment. Please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
FANNG1 commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1801040725
##
core/src/main/java/org/apache/gravitino/audit/SimpleAuditLog.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
FANNG1 opened a new pull request, #5147:
URL: https://github.com/apache/gravitino/pull/5147
### What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
### Why are the changes needed?
(Please clarify why the c
mchades commented on PR #4819:
URL: https://github.com/apache/gravitino/pull/4819#issuecomment-2413161057
This is not a minor change, could you plz create a new subtask issue of
#4513 to record this?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
yuqi1129 commented on code in PR #4996:
URL: https://github.com/apache/gravitino/pull/4996#discussion_r1800653954
##
trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryITBase.java:
##
@@ -68,14 +68,17 @@ public class Tr
coolderli commented on code in PR #4819:
URL: https://github.com/apache/gravitino/pull/4819#discussion_r1800654345
##
flink-connector/flink-runtime/build.gradle.kts:
##
@@ -67,6 +66,11 @@ publishing {
}
}
+tasks.register("copy") {
Review Comment:
OK
--
This is an a
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800657095
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java:
##
@@ -119,26 +125,28 @@ public void initialize(
M
FANNG1 commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1800978054
##
core/src/main/java/org/apache/gravitino/audit/AuditLogWriter.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
yuqi1129 commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1801226391
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java:
##
@@ -119,26 +125,35 @@ public void initialize(
Ma
jerqi closed pull request #5144: [#5105] improvement(server,client): Error code
optimization about access control API
URL: https://github.com/apache/gravitino/pull/5144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jerqi commented on PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#issuecomment-2413422271
`pluginized` -> `plugable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
jerqi closed pull request #5144: [#5105] improvement(server,client): Error code
optimization about access control API
URL: https://github.com/apache/gravitino/pull/5144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
FANNG1 closed issue #5145: [Subtask] Shrink flink-runtime connector binary
package size
URL: https://github.com/apache/gravitino/issues/5145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
FANNG1 closed issue #5145: [Subtask] Shrink flink-runtime connector binary
package size
URL: https://github.com/apache/gravitino/issues/5145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
This is an automated email from the ASF dual-hosted git repository.
fanng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new f0e7f3675 [#5145] improvement(flink-connector): Sh
FANNG1 merged PR #4819:
URL: https://github.com/apache/gravitino/pull/4819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
xxzhky opened a new issue, #5138:
URL: https://github.com/apache/gravitino/issues/5138
### What would you like to be improved?
Gravitino
connector td {white-space:nowrap;border:1px solid
#dee0e3;font-size:10pt;font-style:normal;font-weight:no
FANNG1 commented on code in PR #4819:
URL: https://github.com/apache/gravitino/pull/4819#discussion_r1800634840
##
flink-connector/flink-runtime/build.gradle.kts:
##
@@ -67,6 +66,11 @@ publishing {
}
}
+tasks.register("copy") {
Review Comment:
please remove this
--
FANNG1 commented on PR #4819:
URL: https://github.com/apache/gravitino/pull/4819#issuecomment-2413146975
LGTM except one comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
LauraXia123 opened a new issue, #5140:
URL: https://github.com/apache/gravitino/issues/5140
### Describe the proposal
Add support for create/edit/delete schema
### Task list
rt
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
coolderli closed pull request #4819: [MINOR] Shrink the flink-connector-runtime
lib size from 84MB to 16MB
URL: https://github.com/apache/gravitino/pull/4819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
yuqi1129 commented on issue #5097:
URL: https://github.com/apache/gravitino/issues/5097#issuecomment-2413113760
This issue is duplicated with #5019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
jerryshao commented on code in PR #5127:
URL: https://github.com/apache/gravitino/pull/5127#discussion_r1800927829
##
catalogs/catalog-jdbc-postgresql/src/main/java/org/apache/gravitino/catalog/postgresql/operation/PostgreSqlTableOperations.java:
##
@@ -108,6 +108,17 @@ protecte
FANNG1 commented on PR #5134:
URL: https://github.com/apache/gravitino/pull/5134#issuecomment-2413566111
@jerryshao , it's ready for review now, please help to review when you are
free, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new e9acd15a8 [#5112] feat(core): support pre event fo
itsaviu commented on issue #4605:
URL: https://github.com/apache/gravitino/issues/4605#issuecomment-2413153131
@justinmclean , The changes has been merged to master we can close this
issue, Thanks
cc: @yuqi1129
--
This is an automated message from the Apache Git Service.
To respond to
mchades commented on code in PR #4996:
URL: https://github.com/apache/gravitino/pull/4996#discussion_r1800622096
##
trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryITBase.java:
##
@@ -68,14 +68,17 @@ public class Tri
mchades commented on code in PR #4996:
URL: https://github.com/apache/gravitino/pull/4996#discussion_r1800657782
##
trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryITBase.java:
##
@@ -68,14 +68,17 @@ public class Tri
yuqi1129 closed issue #5097: [Improvement] Use the plugin storage framework for
GVFS client
URL: https://github.com/apache/gravitino/issues/5097
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
jerryshao merged PR #5110:
URL: https://github.com/apache/gravitino/pull/5110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
jerryshao closed issue #5112: [Improvement] Add pre event to event listeners
URL: https://github.com/apache/gravitino/issues/5112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jerryshao merged PR #5078:
URL: https://github.com/apache/gravitino/pull/5078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
jerryshao closed issue #4867: [Subtask] Design and implement the column storage
layout for columns.
URL: https://github.com/apache/gravitino/issues/4867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
justinmclean closed issue #5132: [Bug report] Display users Java API on
playground fails
URL: https://github.com/apache/gravitino/issues/5132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
justinmclean closed issue #4605: [Improvement] Possble null pointer exception
in DorisTableOperations.java
URL: https://github.com/apache/gravitino/issues/4605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
yuqi1129 commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802424734
##
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java:
##
@@ -125,6 +132,10 @@ public void initialize(UR
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802363915
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/fs/FileSystemUtils.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Fo
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802413137
##
docs/hadoop-catalog.md:
##
@@ -25,16 +25,19 @@ Hadoop 3. If there's any compatibility issue, please create
an [issue](https://g
Besides the [common catalog
lisancao commented on code in PR #5117:
URL: https://github.com/apache/gravitino/pull/5117#discussion_r1802247505
##
clients/cli/errors.sh:
##
@@ -0,0 +1,63 @@
+#!/bin/bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreemen
jerqi commented on code in PR #5127:
URL: https://github.com/apache/gravitino/pull/5127#discussion_r1802261172
##
core/src/main/java/org/apache/gravitino/catalog/EntityCombinedTable.java:
##
@@ -128,6 +128,14 @@ public boolean imported() {
return imported;
}
+ public
mchades opened a new issue, #5152:
URL: https://github.com/apache/gravitino/issues/5152
### Version
main branch
### Describe what's wrong
OB catalog UTs failed on Mac
### Error message and/or stacktrace
The OB Docker log can be found:
> [ERROR] OBD-10
lisancao commented on code in PR #5117:
URL: https://github.com/apache/gravitino/pull/5117#discussion_r1802247718
##
clients/cli/errors.sh:
##
@@ -0,0 +1,63 @@
+#!/bin/bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreemen
unfixa1 commented on issue #5152:
URL: https://github.com/apache/gravitino/issues/5152#issuecomment-2415639042
This can be fixed by modifying the code in
org.apache.gravitino.integration.test.container.BaseContainer :
this.container =
new GenericContainer<>(requireNonNull(image, "i
FANNG1 closed pull request #5147: [SIP] support Iceberg event listener
URL: https://github.com/apache/gravitino/pull/5147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
mchades commented on issue #5152:
URL: https://github.com/apache/gravitino/issues/5152#issuecomment-2415666256
> In addition, you should use [Servbay](servbay.com) to check your
development environment, which is more useful than Docker on Mac.
Hi @unfixa1 , can you exp
FANNG1 commented on issue #4028:
URL: https://github.com/apache/gravitino/issues/4028#issuecomment-2415672611
https://github.com/apache/gravitino/pull/5110 adds the basic pre event
framework, but Gravitino doesn't dispatch actual pre event to the event bus.
related issues tracked in #5049
FANNG1 commented on PR #5002:
URL: https://github.com/apache/gravitino/pull/5002#issuecomment-2415676696
@jerryshao please help to review when you have time, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
yuqi1129 commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802325120
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/fs/FileSystemUtils.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Fou
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802362158
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogPropertiesMetadata.java:
##
@@ -44,8 +62,24 @@ public class HadoopCatalogP
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802263646
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/fs/FileSystemProvider.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software
yuqi1129 commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r180238
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java:
##
@@ -742,4 +752,25 @@ private boolean checkSingleFile(Fi
yuqi1129 commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802324737
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/fs/FileSystemUtils.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Fou
yuqi1129 commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802325120
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/fs/FileSystemUtils.java:
##
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Fou
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802395715
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/fs/FileSystemUtils.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Fo
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802397515
##
catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/fs/FileSystemUtils.java:
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the Apache Software Fo
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802404867
##
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java:
##
@@ -125,6 +132,10 @@ public void initialize(U
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802412338
##
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystemConfiguration.java:
##
@@ -32,6 +35,18 @@ class Graviti
jerryshao commented on code in PR #5020:
URL: https://github.com/apache/gravitino/pull/5020#discussion_r1802392106
##
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java:
##
@@ -125,6 +132,10 @@ public void initialize(U
justinmclean commented on code in PR #5117:
URL: https://github.com/apache/gravitino/pull/5117#discussion_r1802426110
##
clients/cli/errors.sh:
##
@@ -0,0 +1,63 @@
+#!/bin/bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agre
jerqi commented on PR #5127:
URL: https://github.com/apache/gravitino/pull/5127#issuecomment-2415831995
Column order may be important, too. `A int, B int` is different from `B int,
A int`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
danhuawang opened a new issue, #5150:
URL: https://github.com/apache/gravitino/issues/5150
### Version
main branch
### Describe what's wrong
**The gravitino type in trino-connector doc is the Java Type description**
https://github.com/user-attachments/assets/980e7712-5
SeanAverS opened a new pull request, #5149:
URL: https://github.com/apache/gravitino/pull/5149
### What changes were proposed in this pull request?
- Link to documentation website
### Why are the changes needed?
- Link to documentation website instead of document
justinmclean opened a new issue, #5148:
URL: https://github.com/apache/gravitino/issues/5148
### Version
main branch
### Describe what's wrong
When calling `associateTags` with an unknown tag, the tag will not be added
to the entity and no error occurs. I would expect a
77 matches
Mail list logo
