Re: [PR] [#4953] feat(hudi-catalog): add Hudi catalog IT and enable module [gravitino]

2024-10-12 Thread via GitHub
jerryshao merged PR #4965: URL: https://github.com/apache/gravitino/pull/4965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Subtask] add IT and enable module for Hudi catalog [gravitino]

2024-10-12 Thread via GitHub
jerryshao closed issue #4953: [Subtask] add IT and enable module for Hudi catalog URL: https://github.com/apache/gravitino/issues/4953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

(gravitino) branch main updated: [#4953] feat(hudi-catalog): add Hudi catalog IT and enable module (#4965)

2024-10-12 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new cc277566b [#4953] feat(hudi-catalog): add Hudi cat

Re: [PR] [#4867] feat(core): Add storage support for columns in Gravitino [gravitino]

2024-10-12 Thread via GitHub
jerryshao commented on PR #5078: URL: https://github.com/apache/gravitino/pull/5078#issuecomment-2408521985 > > I feel like it is not that easy to validate if the column is deleted or not through entity store interface, because we columns cannot managed directly through this interface, it i

Re: [I] [Improvement] Execution flow of drop a role [gravitino]

2024-10-12 Thread via GitHub
jerqi closed issue #4509: [Improvement] Execution flow of drop a role URL: https://github.com/apache/gravitino/issues/4509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] [Bug report] Incorrect Parsing of array<> Data Type in Database Metadata [gravitino]

2024-10-12 Thread via GitHub
lsyulong commented on issue #5098: URL: https://github.com/apache/gravitino/issues/5098#issuecomment-2408850954 Hello, has anyone submitted a PR to fix this issue? I would like to give it a try. Can you assign it to me? If you encounter any problems, feel free to communicate with you at any

Re: [PR] [#4953] feat(hudi-catalog): add Hudi catalog IT and enable module [gravitino]

2024-10-12 Thread via GitHub
mchades commented on code in PR #4965: URL: https://github.com/apache/gravitino/pull/4965#discussion_r1797622083 ## catalogs/catalog-lakehouse-hudi/build.gradle.kts: ## @@ -115,12 +110,29 @@ dependencies { testImplementation(libs.hadoop2.auth) { exclude("*") } + test

Re: [PR] [#4951] improvement(test): Reduce fields shares between different IT to make AbstractIT more independent. [gravitino]

2024-10-12 Thread via GitHub
yuqi1129 commented on code in PR #4996: URL: https://github.com/apache/gravitino/pull/4996#discussion_r1797624956 ## integration-test-common/src/test/java/org/apache/gravitino/integration/test/util/AbstractIT.java: ## @@ -58,61 +58,61 @@ import org.apache.gravitino.server.web.J

Re: [PR] [#4951] improvement(test): Reduce fields shares between different IT to make AbstractIT more independent. [gravitino]

2024-10-12 Thread via GitHub
yuqi1129 commented on code in PR #4996: URL: https://github.com/apache/gravitino/pull/4996#discussion_r1797625045 ## integration-test-common/src/test/java/org/apache/gravitino/integration/test/util/AbstractIT.java: ## @@ -248,15 +248,8 @@ public static String startAndInitMySQLBa

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-12 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1797720606 ## clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-12 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1797720541 ## clients/cli/build.gradle.kts: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreement

Re: [I] [Improvement] README.md should refer the link to our doc website but not doc's source directory [gravitino]

2024-10-12 Thread via GitHub
yuqi1129 commented on issue #5109: URL: https://github.com/apache/gravitino/issues/5109#issuecomment-2408772436 > Hi, > > > > I'm interested on working on this. Could I please be assigned? Thanks. Sure,please go ahead. -- This is an automated message from the Apache

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-12 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1797720606 ## clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-12 Thread via GitHub
justinmclean commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1797720606 ## clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [I] [Improvement] README.md should refer the link to our doc website but not doc's source directory [gravitino]

2024-10-12 Thread via GitHub
SeanAverS commented on issue #5109: URL: https://github.com/apache/gravitino/issues/5109#issuecomment-2408680452 Hi, I'm interested on working on this. Could I please be assigned? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [#5071] Improvement (test): Add integration tests for Trino cascading queries [gravitino]

2024-10-12 Thread via GitHub
diqiu50 commented on code in PR #5073: URL: https://github.com/apache/gravitino/pull/5073#discussion_r1797626917 ## .github/workflows/trino-integration-test.yml: ## @@ -76,7 +76,7 @@ jobs: - name: Package Gravitino run: | - ./gradlew compileDistributio

Re: [PR] [#5071] Improvement (test): Add integration tests for Trino cascading queries [gravitino]

2024-10-12 Thread via GitHub
diqiu50 commented on code in PR #5073: URL: https://github.com/apache/gravitino/pull/5073#discussion_r1797615808 ## trino-connector/integration-test/trino-test-tools/trino-cascading-env/init/trino-local/config/catalog/trino.properties: ## @@ -0,0 +1,21 @@ +# +# Licensed to the A

Re: [PR] [#4867] feat(core): Add storage support for columns in Gravitino [gravitino]

2024-10-12 Thread via GitHub
xloya commented on PR #5078: URL: https://github.com/apache/gravitino/pull/5078#issuecomment-2408458762 > I feel like it is not that easy to validate if the column is deleted or not through entity store interface, because we columns cannot managed directly through this interface, it is hand

Re: [PR] [#3920] feat(catalog-lakehouse-paimon): Support jdbc backend for Paimon Catalog [gravitino]

2024-10-12 Thread via GitHub
caican00 commented on code in PR #5087: URL: https://github.com/apache/gravitino/pull/5087#discussion_r1797634852 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonCatalogPropertiesMetadata.java: ## @@ -46,14 +46,26 @@ public

Re: [PR] [#3920] feat(catalog-lakehouse-paimon): Support jdbc backend for Paimon Catalog [gravitino]

2024-10-12 Thread via GitHub
caican00 commented on code in PR #5087: URL: https://github.com/apache/gravitino/pull/5087#discussion_r1797634852 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonCatalogPropertiesMetadata.java: ## @@ -46,14 +46,26 @@ public

Re: [PR] [#4953] feat(hudi-catalog): add Hudi catalog IT and enable module [gravitino]

2024-10-12 Thread via GitHub
mchades commented on code in PR #4965: URL: https://github.com/apache/gravitino/pull/4965#discussion_r1797632676 ## server/src/main/java/org/apache/gravitino/server/GravitinoServer.java: ## @@ -119,6 +120,7 @@ protected void configure() { register(JsonParseExceptionMapper.c

[PR] [#5120] improvement(docs): Add the document of metadata object ownership [gravitino]

2024-10-12 Thread via GitHub
jerqi opened a new pull request, #5123: URL: https://github.com/apache/gravitino/pull/5123 ### What changes were proposed in this pull request? Add the document of metadata object ownership ### Why are the changes needed? Fix: #5120 ### Does this PR introduce _any_

Re: [PR] [#3920] feat(catalog-lakehouse-paimon): Support jdbc backend for Paimon Catalog [gravitino]

2024-10-12 Thread via GitHub
caican00 commented on code in PR #5087: URL: https://github.com/apache/gravitino/pull/5087#discussion_r1797642532 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/utils/CatalogUtils.java: ## @@ -121,6 +123,17 @@ private static void

Re: [PR] [#3920] feat(catalog-lakehouse-paimon): Support jdbc backend for Paimon Catalog [gravitino]

2024-10-12 Thread via GitHub
caican00 commented on PR #5087: URL: https://github.com/apache/gravitino/pull/5087#issuecomment-2408476354 > @caican00 , some minor comments, and could you add related document? @FANNG1 please review again, thanks -- This is an automated message from the Apache Git Service. To respo

Re: [PR] [#3920] feat(catalog-lakehouse-paimon): Support jdbc backend for Paimon Catalog [gravitino]

2024-10-12 Thread via GitHub
FANNG1 commented on code in PR #5087: URL: https://github.com/apache/gravitino/pull/5087#discussion_r1797643075 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonCatalogPropertiesMetadata.java: ## @@ -46,14 +46,26 @@ public cl

Re: [PR] [#3920] feat(catalog-lakehouse-paimon): Support jdbc backend for Paimon Catalog [gravitino]

2024-10-12 Thread via GitHub
FANNG1 commented on code in PR #5087: URL: https://github.com/apache/gravitino/pull/5087#discussion_r1797643309 ## catalogs/catalog-lakehouse-paimon/build.gradle.kts: ## @@ -122,12 +122,14 @@ dependencies { testImplementation(libs.junit.jupiter.api) testImplementation(libs

Re: [PR] [#4953] feat(hudi-catalog): add Hudi catalog IT and enable module [gravitino]

2024-10-12 Thread via GitHub
mchades commented on code in PR #4965: URL: https://github.com/apache/gravitino/pull/4965#discussion_r1797630170 ## catalogs/catalog-lakehouse-hudi/build.gradle.kts: ## @@ -138,3 +150,60 @@ dependencies { testRuntimeOnly("org.apache.hudi:hudi-spark$sparkVersion-bundle_$scala

Re: [PR] [#3973] improvement(core):support audit log [gravitino]

2024-10-12 Thread via GitHub
FANNG1 commented on PR #4575: URL: https://github.com/apache/gravitino/pull/4575#issuecomment-2408453321 > I kind of agree with @hanwxx , AuditLog and event are two things, we don't have to use interface to put them together. Using a converter to bridge them together without hard combinatio

Re: [PR] [#3920] feat(catalog-lakehouse-paimon): Support jdbc backend for Paimon Catalog [gravitino]

2024-10-12 Thread via GitHub
caican00 commented on code in PR #5087: URL: https://github.com/apache/gravitino/pull/5087#discussion_r1797640061 ## catalogs/catalog-lakehouse-paimon/build.gradle.kts: ## @@ -122,12 +122,14 @@ dependencies { testImplementation(libs.junit.jupiter.api) testImplementation(li