Re: [PR] feat(oceanbase-catalog): Support schema operations for OceanBase JDBC catalog. [gravitino]

2024-10-08 Thread via GitHub
jerryshao commented on PR #5013: URL: https://github.com/apache/gravitino/pull/5013#issuecomment-2401177868 @mchades can you please move forward this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] feat(oceanbase-catalog): Support schema operations for OceanBase JDBC catalog. [gravitino]

2024-10-08 Thread via GitHub
mchades merged PR #5013: URL: https://github.com/apache/gravitino/pull/5013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

Re: [I] [Subtask] Support schema operations for OceanBase JDBC catalog [gravitino]

2024-10-08 Thread via GitHub
mchades closed issue #4990: [Subtask] Support schema operations for OceanBase JDBC catalog URL: https://github.com/apache/gravitino/issues/4990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

(gravitino) branch main updated: feat(oceanbase-catalog): Support schema operations for OceanBase JDBC catalog. (#5013)

2024-10-08 Thread mchades
This is an automated email from the ASF dual-hosted git repository. mchades pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 437c41b0b feat(oceanbase-catalog): Support schem

Re: [I] [Subtask] Support schema operations for OceanBase JDBC catalog [gravitino]

2024-10-08 Thread via GitHub
mchades closed issue #4990: [Subtask] Support schema operations for OceanBase JDBC catalog URL: https://github.com/apache/gravitino/issues/4990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [#4938]feat(lakehouse-paimon): Support S3 filesystem for Paimon catalog. [gravitino]

2024-10-08 Thread via GitHub
yuqi1129 commented on code in PR #4939: URL: https://github.com/apache/gravitino/pull/4939#discussion_r1792765848 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonCatalogPropertiesMetadata.java: ## @@ -61,6 +68,12 @@ public c

Re: [PR] [#4938]feat(lakehouse-paimon): Support S3 filesystem for Paimon catalog. [gravitino]

2024-10-08 Thread via GitHub
yuqi1129 commented on code in PR #4939: URL: https://github.com/apache/gravitino/pull/4939#discussion_r1792771182 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/utils/CatalogUtils.java: ## @@ -120,4 +121,37 @@ private static void

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-08 Thread via GitHub
yuqi1129 commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1792676870 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/FileSystemProvider.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerqi commented on code in PR #5021: URL: https://github.com/apache/gravitino/pull/5021#discussion_r1792701347 ## core/src/main/java/org/apache/gravitino/authorization/PermissionManager.java: ## @@ -373,11 +377,302 @@ User revokeRolesFromUser(String metalake, List roles, String

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerqi commented on code in PR #5021: URL: https://github.com/apache/gravitino/pull/5021#discussion_r1792697675 ## core/src/main/java/org/apache/gravitino/authorization/PermissionManager.java: ## @@ -373,11 +377,302 @@ User revokeRolesFromUser(String metalake, List roles, String

Re: [PR] [#50] Add support for helm chart [gravitino-playground]

2024-10-08 Thread via GitHub
jerqi commented on PR #56: URL: https://github.com/apache/gravitino-playground/pull/56#issuecomment-2401162247 > > Could he create a file set using location `file:/tmp/gravitino/data/pdfs`? > > @jerqi sorry for the late reply, I set the storage_location to: > > ``` > storag

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerryshao commented on code in PR #5021: URL: https://github.com/apache/gravitino/pull/5021#discussion_r1792690100 ## core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java: ## @@ -309,10 +324,8 @@ private static void checkCatalogType( NameIdentifie

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerqi commented on code in PR #5021: URL: https://github.com/apache/gravitino/pull/5021#discussion_r1792715565 ## core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java: ## @@ -309,10 +324,8 @@ private static void checkCatalogType( NameIdentifier ca

Re: [PR] [#3758] Improvement(PyGVFS): Support OAuth2 authentication in Python GVFS [gravitino]

2024-10-08 Thread via GitHub
jerqi commented on code in PR #5030: URL: https://github.com/apache/gravitino/pull/5030#discussion_r1792719168 ## docs/how-to-use-gvfs.md: ## @@ -538,7 +542,7 @@ print(documents) ### Authentication -Currently, Gravitino Virtual File System in Python only supports one kind o

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerryshao commented on PR #5021: URL: https://github.com/apache/gravitino/pull/5021#issuecomment-2401196388 @jerqi the cherry-pick is failed, please do it manually against branch-0.6. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [#3758] Improvement(PyGVFS): Support OAuth2 authentication in Python GVFS [gravitino]

2024-10-08 Thread via GitHub
xloya commented on code in PR #5030: URL: https://github.com/apache/gravitino/pull/5030#discussion_r1792736506 ## docs/how-to-use-gvfs.md: ## @@ -538,7 +542,7 @@ print(documents) ### Authentication -Currently, Gravitino Virtual File System in Python only supports one kind o

[PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerqi opened a new pull request, #5069: URL: https://github.com/apache/gravitino/pull/5069 ### What changes were proposed in this pull request? Supports to grant or revoke privileges for a role ### Why are the changes needed? Fix: #4903 ### Does this PR introduce _any_ us

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerqi commented on code in PR #5021: URL: https://github.com/apache/gravitino/pull/5021#discussion_r1792698008 ## core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java: ## @@ -265,14 +268,26 @@ public static void checkSecurableObject(String metalake, Met

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerqi commented on code in PR #5021: URL: https://github.com/apache/gravitino/pull/5021#discussion_r1792698722 ## core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java: ## @@ -309,10 +324,8 @@ private static void checkCatalogType( NameIdentifier ca

Re: [PR] [#4951] improvement(test): Reduce fields shares between different IT to make AbstractIT more independent. [gravitino]

2024-10-08 Thread via GitHub
jerryshao commented on PR #4996: URL: https://github.com/apache/gravitino/pull/4996#issuecomment-240114 Ping @mchades . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerqi commented on code in PR #5021: URL: https://github.com/apache/gravitino/pull/5021#discussion_r1792695482 ## core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java: ## @@ -160,6 +167,89 @@ public void insertRole(RoleEntity roleEntity, boolea

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerqi commented on code in PR #5021: URL: https://github.com/apache/gravitino/pull/5021#discussion_r1792695792 ## core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java: ## @@ -160,6 +167,89 @@ public void insertRole(RoleEntity roleEntity, boolea

Re: [PR] [#50] Add support for helm chart [gravitino-playground]

2024-10-08 Thread via GitHub
danhuawang commented on PR #56: URL: https://github.com/apache/gravitino-playground/pull/56#issuecomment-2401157641 > > Could he create a file set using location `file:/tmp/gravitino/data/pdfs`? > > @jerqi sorry for the late reply, I set the storage_location to: > > ``` > s

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
yuqi1129 commented on code in PR #5021: URL: https://github.com/apache/gravitino/pull/5021#discussion_r1792684840 ## core/src/main/java/org/apache/gravitino/authorization/PermissionManager.java: ## @@ -373,11 +377,302 @@ User revokeRolesFromUser(String metalake, List roles, Str

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-08 Thread via GitHub
jerryshao commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1792729192 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/fs/LocalFileSystemProvider.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [#4938]feat(lakehouse-paimon): Support S3 filesystem for Paimon catalog. [gravitino]

2024-10-08 Thread via GitHub
yuqi1129 commented on code in PR #4939: URL: https://github.com/apache/gravitino/pull/4939#discussion_r1792792971 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/filesystem/FileSystemType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed

Re: [PR] [#4938]feat(lakehouse-paimon): Support S3 filesystem for Paimon catalog. [gravitino]

2024-10-08 Thread via GitHub
yuqi1129 commented on code in PR #4939: URL: https://github.com/apache/gravitino/pull/4939#discussion_r1792789572 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/filesystem/FileSystemType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-08 Thread via GitHub
yuqi1129 commented on PR #5020: URL: https://github.com/apache/gravitino/pull/5020#issuecomment-2401267221 > refactor the client side GravitinoVirtualFileSystem to also leverage this interface to make the fs pluggable I will use another PR to refactor the Java client for the fileset.

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-08 Thread via GitHub
jerryshao commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1792745595 ## common/src/main/java/org/apache/gravitino/credential/Credential.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [#4938]feat(lakehouse-paimon): Support S3 filesystem for Paimon catalog. [gravitino]

2024-10-08 Thread via GitHub
yuqi1129 commented on code in PR #4939: URL: https://github.com/apache/gravitino/pull/4939#discussion_r1792794936 ## catalogs/catalog-lakehouse-paimon/src/test/java/org/apache/gravitino/catalog/lakehouse/paimon/integration/test/CatalogPaimonBaseIT.java: ## @@ -882,8 +887,30 @@ p

Re: [PR] [TEST] Add integration tests for Trino cascading queries [gravitino]

2024-10-08 Thread via GitHub
diqiu50 closed pull request #5062: [TEST] Add integration tests for Trino cascading queries URL: https://github.com/apache/gravitino/pull/5062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] [TEST] Add integration tests for Trino cascading queries [gravitino]

2024-10-08 Thread via GitHub
diqiu50 opened a new pull request, #5062: URL: https://github.com/apache/gravitino/pull/5062 ### What changes were proposed in this pull request? (Please outline the changes and how this PR fixes the issue.) ### Why are the changes needed? (Please clarify why the

Re: [PR] [#4938]feat(lakehouse-paimon): Support S3 filesystem for Paimon catalog. [gravitino]

2024-10-08 Thread via GitHub
yuqi1129 commented on code in PR #4939: URL: https://github.com/apache/gravitino/pull/4939#discussion_r1792927041 ## catalogs/catalog-lakehouse-paimon/src/test/java/org/apache/gravitino/catalog/lakehouse/paimon/integration/test/CatalogPaimonBaseIT.java: ## @@ -882,8 +887,30 @@ p

Re: [PR] [TEST] Add integration tests for Trino cascading queries [gravitino]

2024-10-08 Thread via GitHub
diqiu50 closed pull request #5062: [TEST] Add integration tests for Trino cascading queries URL: https://github.com/apache/gravitino/pull/5062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] [TEST] Add integration tests for Trino cascading queries [gravitino]

2024-10-08 Thread via GitHub
diqiu50 opened a new pull request, #5073: URL: https://github.com/apache/gravitino/pull/5073 ### What changes were proposed in this pull request? (Please outline the changes and how this PR fixes the issue.) ### Why are the changes needed? (Please clarify why the

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-08 Thread via GitHub
FANNG1 commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1792961793 ## common/src/main/java/org/apache/gravitino/credential/Credential.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-08 Thread via GitHub
FANNG1 commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1792973195 ## core/src/main/java/org/apache/gravitino/credential/CredentialProviderFactory.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) und

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-08 Thread via GitHub
jerryshao commented on PR #5020: URL: https://github.com/apache/gravitino/pull/5020#issuecomment-2401191917 I'm OK with the interface design, please polish the code to make it ready to review, also refactor the client side GravitinoVirtualFileSystem to also leverage this interface to make t

Re: [I] [Improvement] Supports to grant and revoke privilege for a role [gravitino]

2024-10-08 Thread via GitHub
jerryshao closed issue #4903: [Improvement] Supports to grant and revoke privilege for a role URL: https://github.com/apache/gravitino/issues/4903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(gravitino) branch main updated: [#4903] feat(core,server): Support to grant or revoke privileges for a role (#5021)

2024-10-08 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 75ec8aed8 [#4903] feat(core,server): Support to gr

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerryshao merged PR #5021: URL: https://github.com/apache/gravitino/pull/5021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Improvement] Supports to grant and revoke privilege for a role [gravitino]

2024-10-08 Thread via GitHub
jerryshao closed issue #4903: [Improvement] Supports to grant and revoke privilege for a role URL: https://github.com/apache/gravitino/issues/4903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [#4938]feat(lakehouse-paimon): Support S3 filesystem for Paimon catalog. [gravitino]

2024-10-08 Thread via GitHub
yuqi1129 commented on code in PR #4939: URL: https://github.com/apache/gravitino/pull/4939#discussion_r1792906310 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/filesystem/FileSystemType.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed

Re: [PR] [#4938]feat(lakehouse-paimon): Support S3 filesystem for Paimon catalog. [gravitino]

2024-10-08 Thread via GitHub
yuqi1129 commented on code in PR #4939: URL: https://github.com/apache/gravitino/pull/4939#discussion_r1792906720 ## docs/lakehouse-paimon-catalog.md: ## @@ -30,16 +30,19 @@ Builds with Apache Paimon `0.8.0`. ### Catalog properties -| Property name

(gravitino) branch branch-0.6 updated: [#4903] feat(core,server): Support to grant or revoke privileges for a role (#5069)

2024-10-08 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch branch-0.6 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.6 by this push: new 34649ad64 [#4903] feat(core,server): S

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerryshao merged PR #5069: URL: https://github.com/apache/gravitino/pull/5069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch main updated: [#3758] Improvement(PyGVFS): Support OAuth2 authentication in Python GVFS (#5030)

2024-10-08 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new ce22323f3 [#3758] Improvement(PyGVFS): Support OAu

Re: [I] [Improvement] Support OAuth2 auth in PyGVFS [gravitino]

2024-10-08 Thread via GitHub
jerryshao closed issue #3758: [Improvement] Support OAuth2 auth in PyGVFS URL: https://github.com/apache/gravitino/issues/3758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [#3758] Improvement(PyGVFS): Support OAuth2 authentication in Python GVFS [gravitino]

2024-10-08 Thread via GitHub
jerryshao merged PR #5030: URL: https://github.com/apache/gravitino/pull/5030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Improvement] Support OAuth2 auth in PyGVFS [gravitino]

2024-10-08 Thread via GitHub
jerryshao closed issue #3758: [Improvement] Support OAuth2 auth in PyGVFS URL: https://github.com/apache/gravitino/issues/3758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerryshao commented on code in PR #5021: URL: https://github.com/apache/gravitino/pull/5021#discussion_r1792053828 ## core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java: ## @@ -160,6 +167,89 @@ public void insertRole(RoleEntity roleEntity, bo

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerryshao commented on code in PR #5021: URL: https://github.com/apache/gravitino/pull/5021#discussion_r1792055377 ## core/src/main/java/org/apache/gravitino/storage/relational/service/RoleMetaService.java: ## @@ -160,6 +167,89 @@ public void insertRole(RoleEntity roleEntity, bo

Re: [PR] [#4903] feat(core,server): Support to grant or revoke privileges for a role [gravitino]

2024-10-08 Thread via GitHub
jerryshao commented on PR #5021: URL: https://github.com/apache/gravitino/pull/5021#issuecomment-2400113513 Generally LGTM, @yuqi1129 can you please take another look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

(gravitino) branch main updated: [#4370]feat(iceberg): support view interface for Iceberg REST server (#4937)

2024-10-08 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 13d1684dd [#4370]feat(iceberg): support view inter

(gravitino) branch main updated: [#4280] improvement(PyGVFS): Refactor the `getFileLocation` logic in the Python GVFS (#5026)

2024-10-08 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new dd1a93007 [#4280] improvement(PyGVFS): Refactor th