[PR] [#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method [gravitino]

2024-09-20 Thread via GitHub
jerryshao opened a new pull request, #4978: URL: https://github.com/apache/gravitino/pull/4978 ### What changes were proposed in this pull request? put the check code into the code block Utils.doAs. ### Why are the changes needed? Fix: #4960 ### Does this PR intro

(gravitino) branch cherry-pick-branch-0.6-b0c4b117c55b14c5cc972d9ec5069dc3238b7197 deleted (was a5afac5d6)

2024-09-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch cherry-pick-branch-0.6-b0c4b117c55b14c5cc972d9ec5069dc3238b7197 in repository https://gitbox.apache.org/repos/asf/gravitino.git was a5afac5d6 [#4743]fix(trino-connector): Fix the default pre

(gravitino) branch justinmclean-patch-3 deleted (was 1fff10ba2)

2024-09-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch justinmclean-patch-3 in repository https://gitbox.apache.org/repos/asf/gravitino.git was 1fff10ba2 Update how-to-build.md The revisions that were on this branch are still contained in other

(gravitino) branch justinmclean-patch-2 deleted (was 824c97f9c)

2024-09-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch justinmclean-patch-2 in repository https://gitbox.apache.org/repos/asf/gravitino.git was 824c97f9c Update README.md for clarity The revisions that were on this branch are still contained in

(gravitino) branch justinmclean-patch-4 deleted (was 2a9378b78)

2024-09-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch justinmclean-patch-4 in repository https://gitbox.apache.org/repos/asf/gravitino.git was 2a9378b78 Minor English changes. The revisions that were on this branch are still contained in other

(gravitino) branch cherry-pick-branch-0.6-a6a69cc9fcb88a0ea069711e1b7711da598e1f7c deleted (was 57c2a1734)

2024-09-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch cherry-pick-branch-0.6-a6a69cc9fcb88a0ea069711e1b7711da598e1f7c in repository https://gitbox.apache.org/repos/asf/gravitino.git was 57c2a1734 [#4812] fix(core): Make ensure the schema exists

(gravitino) branch cherry-pick-branch-0.6-a0cb17450ce90bd6fe8684563c891fc6bb6c4c43 deleted (was a973e9637)

2024-09-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch cherry-pick-branch-0.6-a0cb17450ce90bd6fe8684563c891fc6bb6c4c43 in repository https://gitbox.apache.org/repos/asf/gravitino.git was a973e9637 [#4758] correct Iceberg document location is i

(gravitino) branch justinmclean-patch-5 deleted (was f78c721ad)

2024-09-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch justinmclean-patch-5 in repository https://gitbox.apache.org/repos/asf/gravitino.git was f78c721ad [MINOR] fix link The revisions that were on this branch are still contained in other refere

Re: [PR] [#4278] feat(filesystem): Refactor the `getFileLocation` logics in hadoop GVFS [gravitino]

2024-09-20 Thread via GitHub
xloya commented on code in PR #4320: URL: https://github.com/apache/gravitino/pull/4320#discussion_r1768310821 ## clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java: ## @@ -65,8 +69,10 @@ public class GravitinoVirtualF

Re: [PR] [#4278] feat(filesystem): Refactor the `getFileLocation` logics in hadoop GVFS [gravitino]

2024-09-20 Thread via GitHub
xloya commented on code in PR #4320: URL: https://github.com/apache/gravitino/pull/4320#discussion_r1768310821 ## clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java: ## @@ -65,8 +69,10 @@ public class GravitinoVirtualF

Re: [PR] [#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method [gravitino]

2024-09-20 Thread via GitHub
jerqi closed pull request #4971: [#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method URL: https://github.com/apache/gravitino/pull/4971 -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] fix(authorization-ranger):the descr field of ranger table x_group is not null [gravitino]

2024-09-20 Thread via GitHub
xunliu commented on PR #4975: URL: https://github.com/apache/gravitino/pull/4975#issuecomment-2363728893 hi @yangyuxia Thank you for your report on this issue. But Gravitino has integration test the here: https://github.com/apache/gravitino/blob/main/authorizations/authorization-range

[PR] [apache#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method [gravitino]

2024-09-20 Thread via GitHub
yangyuxia opened a new pull request, #4971: URL: https://github.com/apache/gravitino/pull/4971 ### What changes were proposed in this pull request? put the check code into the code block Utils.doAs. ### Why are the changes needed? Fix: #4960 ### Does this PR intro

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768262255 ## core/src/main/java/org/apache/gravitino/EntityStore.java: ## @@ -55,15 +55,19 @@ public interface EntityStore extends Closeable { * Note. Depends on the isol

Re: [PR] [#4278] feat(filesystem): Refactor the `getFileLocation` logics in hadoop GVFS [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on code in PR #4320: URL: https://github.com/apache/gravitino/pull/4320#discussion_r1766911569 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -369,11 +373,51 @@ public String getFileLocation(Na

Re: [PR] [#4278] feat(filesystem): Refactor the `getFileLocation` logics in hadoop GVFS [gravitino]

2024-09-20 Thread via GitHub
xloya commented on code in PR #4320: URL: https://github.com/apache/gravitino/pull/4320#discussion_r1768330455 ## clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java: ## @@ -381,51 +339,66 @@ NameIdentifier extractIdent

Re: [PR] [#4973] improvement(client-java/server): Clear `CallerContext` in Java Client and Server when call `getFileLocation` finally [gravitino]

2024-09-20 Thread via GitHub
xloya closed pull request #4974: [#4973] improvement(client-java/server): Clear `CallerContext` in Java Client and Server when call `getFileLocation` finally URL: https://github.com/apache/gravitino/pull/4974 -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768276103 ## core/src/main/java/org/apache/gravitino/authorization/UserGroupManager.java: ## @@ -109,6 +113,25 @@ User getUser(String metalake, String user) throws NoSuchUse

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768280437 ## core/src/main/java/org/apache/gravitino/EntityStore.java: ## @@ -55,15 +55,19 @@ public interface EntityStore extends Closeable { * Note. Depends on the isolatio

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768280437 ## core/src/main/java/org/apache/gravitino/EntityStore.java: ## @@ -55,15 +55,19 @@ public interface EntityStore extends Closeable { * Note. Depends on the isolatio

Re: [PR] [#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method [gravitino]

2024-09-20 Thread via GitHub
jerqi closed pull request #4971: [#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method URL: https://github.com/apache/gravitino/pull/4971 -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768329772 ## core/src/main/java/org/apache/gravitino/EntityStore.java: ## @@ -55,15 +55,19 @@ public interface EntityStore extends Closeable { * Note. Depends on the isolatio

Re: [PR] [#4278] feat(filesystem): Refactor the `getFileLocation` logics in hadoop GVFS [gravitino]

2024-09-20 Thread via GitHub
xloya commented on code in PR #4320: URL: https://github.com/apache/gravitino/pull/4320#discussion_r1768310821 ## clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/GravitinoVirtualFileSystem.java: ## @@ -65,8 +69,10 @@ public class GravitinoVirtualF

Re: [I] [EPIC] Add CLI interface for Gravitino [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on issue #4943: URL: https://github.com/apache/gravitino/issues/4943#issuecomment-2362995109 My feeling is that if we use Java client for CLI, then we already handle most of the of the JSON serde and security things, so we can only focus on CLI implementation. But if we

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768227501 ## core/src/main/java/org/apache/gravitino/storage/relational/RelationalEntityStore.java: ## @@ -88,8 +89,12 @@ public void setSerDe(EntitySerDe entitySerDe) {

(gravitino) branch cherry-pick-branch-0.6-f54bfc152c2c2bd48c300ef8f4cb881d50b9cc83 deleted (was 95765758e)

2024-09-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch cherry-pick-branch-0.6-f54bfc152c2c2bd48c300ef8f4cb881d50b9cc83 in repository https://gitbox.apache.org/repos/asf/gravitino.git was 95765758e [Minor] docs: Fix doc misspelling (#4969) The r

Re: [I] [EPIC] Add CLI interface for Gravitino [gravitino]

2024-09-20 Thread via GitHub
mchades commented on issue #4943: URL: https://github.com/apache/gravitino/issues/4943#issuecomment-2363154744 > Link to design doc: https://docs.google.com/document/d/19CXHeg_5iphO8D3UD16rexVE23M4TMZXOU3X0lBqL6A/edit?usp=sharing IMO, the current design doesn't seem to be very differe

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768290773 ## core/src/main/java/org/apache/gravitino/EntityStore.java: ## @@ -55,15 +55,19 @@ public interface EntityStore extends Closeable { * Note. Depends on the isol

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768290773 ## core/src/main/java/org/apache/gravitino/EntityStore.java: ## @@ -55,15 +55,19 @@ public interface EntityStore extends Closeable { * Note. Depends on the isol

(gravitino) branch main updated: [#4973] improvement(client-java/server): Clear `CallerContext` in Java Client and Server when call `getFileLocation` finally (#4974)

2024-09-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 8aee4a3bb [#4973] improvement(client-java/server):

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768476364 ## core/src/main/java/org/apache/gravitino/storage/relational/mapper/h2/UserMetaH2Provider.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation

Re: [I] [Improvement] Clear `CallerContext` after the `getFileLocation` request and response [gravitino]

2024-09-20 Thread via GitHub
jerryshao closed issue #4973: [Improvement] Clear `CallerContext` after the `getFileLocation` request and response URL: https://github.com/apache/gravitino/issues/4973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [#4973] improvement(client-java/server): Clear `CallerContext` in Java Client and Server when call `getFileLocation` finally [gravitino]

2024-09-20 Thread via GitHub
jerryshao merged PR #4974: URL: https://github.com/apache/gravitino/pull/4974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on PR #4971: URL: https://github.com/apache/gravitino/pull/4971#issuecomment-2363579937 I think this problem also exists in branch-0.6, @yangyuxia would you please cherry-pick this commit and create a same PR against branch-0.6? Thanks. -- This is an automated message

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768476364 ## core/src/main/java/org/apache/gravitino/storage/relational/mapper/h2/UserMetaH2Provider.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation

Re: [I] [Improvement] Clear `CallerContext` after the `getFileLocation` request and response [gravitino]

2024-09-20 Thread via GitHub
jerryshao closed issue #4973: [Improvement] Clear `CallerContext` after the `getFileLocation` request and response URL: https://github.com/apache/gravitino/issues/4973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [I] [Bug report] Hive metastore authentication failed when creating a role [gravitino]

2024-09-20 Thread via GitHub
jerryshao closed issue #4960: [Bug report] Hive metastore authentication failed when creating a role URL: https://github.com/apache/gravitino/issues/4960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method [gravitino]

2024-09-20 Thread via GitHub
jerryshao merged PR #4971: URL: https://github.com/apache/gravitino/pull/4971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768481945 ## core/src/main/java/org/apache/gravitino/storage/relational/po/CombinedUserPO.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768487238 ## core/src/main/java/org/apache/gravitino/storage/relational/service/UserMetaService.java: ## @@ -246,6 +249,38 @@ public UserEntity updateUser( return newEntit

(gravitino) branch main updated (8aee4a3bb -> ca8d801c9)

2024-09-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from 8aee4a3bb [#4973] improvement(client-java/server): Clear `CallerContext` in Java Client and Server when call `getFile

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768487238 ## core/src/main/java/org/apache/gravitino/storage/relational/service/UserMetaService.java: ## @@ -246,6 +249,38 @@ public UserEntity updateUser( return newEntit

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768487238 ## core/src/main/java/org/apache/gravitino/storage/relational/service/UserMetaService.java: ## @@ -246,6 +249,38 @@ public UserEntity updateUser( return newEntit

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768487238 ## core/src/main/java/org/apache/gravitino/storage/relational/service/UserMetaService.java: ## @@ -246,6 +249,38 @@ public UserEntity updateUser( return newEntit

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768487238 ## core/src/main/java/org/apache/gravitino/storage/relational/service/UserMetaService.java: ## @@ -246,6 +249,38 @@ public UserEntity updateUser( return newEntit

(gravitino) branch main updated: [Minor] docs: Fix doc misspelling (#4969)

2024-09-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new f54bfc152 [Minor] docs: Fix doc misspelling (#4969

[PR] [Minor] docs: Fix doc misspelling [gravitino]

2024-09-20 Thread via GitHub
github-actions[bot] opened a new pull request, #4972: URL: https://github.com/apache/gravitino/pull/4972 ### What changes were proposed in this pull request? Found a misspelling in document. ### Why are the changes needed? Fix: doc misspelling ### Does this PR intr

(gravitino) branch cherry-pick-branch-0.6-f54bfc152c2c2bd48c300ef8f4cb881d50b9cc83 created (now 95765758e)

2024-09-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.6-f54bfc152c2c2bd48c300ef8f4cb881d50b9cc83 in repository https://gitbox.apache.org/repos/asf/gravitino.git at 95765758e [Minor] docs: Fix doc misspelling (#4969)

Re: [PR] [Minor] docs: Fix doc misspelling [gravitino]

2024-09-20 Thread via GitHub
jerryshao closed pull request #4972: [Minor] docs: Fix doc misspelling URL: https://github.com/apache/gravitino/pull/4972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[PR] [#4973] improvement(client-java/server): Remove `CallerContext` in Java Client and Server [gravitino]

2024-09-20 Thread via GitHub
xloya opened a new pull request, #4974: URL: https://github.com/apache/gravitino/pull/4974 ### What changes were proposed in this pull request? Currently, after the client completes the getFileLocation request and the server completes the getFileLocation response, the Thread Local Cal

[PR] fix(authorization-ranger):the descr field of ranger table x_group is not null [gravitino]

2024-09-20 Thread via GitHub
yangyuxia opened a new pull request, #4975: URL: https://github.com/apache/gravitino/pull/4975 ### What changes were proposed in this pull request? When calling the ranger CREATE_GROUP api, the desc field cannot be null ### Why are the changes needed? When calling the ran

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768454178 ## core/src/main/java/org/apache/gravitino/storage/relational/po/CombinedUserPO.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768452317 ## core/src/main/java/org/apache/gravitino/storage/relational/mapper/h2/UserMetaH2Provider.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768459496 ## core/src/main/java/org/apache/gravitino/storage/relational/service/UserMetaService.java: ## @@ -246,6 +249,38 @@ public UserEntity updateUser( return newE

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768677915 ## core/src/main/java/org/apache/gravitino/storage/relational/service/UserMetaService.java: ## @@ -246,6 +249,38 @@ public UserEntity updateUser( return newEntit

Re: [PR] [#4370]feat(iceberg): support view interface for Iceberg REST server [gravitino]

2024-09-20 Thread via GitHub
FANNG1 commented on code in PR #4937: URL: https://github.com/apache/gravitino/pull/4937#discussion_r1768687126 ## iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergViewOperations.java: ## @@ -0,0 +1,311 @@ +/* + * Licensed to the Apa

Re: [PR] [#4370]feat(iceberg): support view interface for Iceberg REST server [gravitino]

2024-09-20 Thread via GitHub
FANNG1 commented on PR #4937: URL: https://github.com/apache/gravitino/pull/4937#issuecomment-2363838334 @theoryxu , thanks for the PR, after supporting views, could Spark create the view in the Iceberg REST catalog? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768709753 ## core/src/main/java/org/apache/gravitino/authorization/UserGroupManager.java: ## @@ -109,6 +113,25 @@ User getUser(String metalake, String user) throws NoSuchUserExc

Re: [I] [Improvement] Test Gravitino on Docker on Windows. [gravitino]

2024-09-20 Thread via GitHub
khushikushwah commented on issue #1415: URL: https://github.com/apache/gravitino/issues/1415#issuecomment-2363938355 I mistakenly added the same repository is listed multiple times in different files. so, they show some warring(W: Target Packages (stable/binary-amd64/Packages) is configured

Re: [I] [EPIC] Add CLI interface for Gravitino [gravitino]

2024-09-20 Thread via GitHub
justinmclean commented on issue #4943: URL: https://github.com/apache/gravitino/issues/4943#issuecomment-2364745721 It is easier to use than`curl` as the user doesn't need to supply correctly format JSON, it fills in many of the default parameters, and its output is more user-friendly. --

Re: [PR] [#4759] feat(auth-ranger): Use Spark verify Ranger authorization Hive [gravitino]

2024-09-20 Thread via GitHub
FANNG1 commented on code in PR #4948: URL: https://github.com/apache/gravitino/pull/4948#discussion_r1769369654 ## server-common/src/main/java/org/apache/gravitino/server/web/JettyServer.java: ## @@ -260,6 +260,29 @@ private void initializeWebAppServletContextHandler() { se

Re: [PR] [#4759] feat(auth-ranger): Use Spark verify Ranger authorization Hive [gravitino]

2024-09-20 Thread via GitHub
FANNG1 commented on code in PR #4948: URL: https://github.com/apache/gravitino/pull/4948#discussion_r1769369981 ## integration-test-common/build.gradle.kts: ## @@ -29,9 +31,15 @@ dependencies { testImplementation(project(":api")) testImplementation(project(":clients:client

Re: [PR] [#4759] feat(auth-ranger): Use Spark verify Ranger authorization Hive [gravitino]

2024-09-20 Thread via GitHub
FANNG1 commented on code in PR #4948: URL: https://github.com/apache/gravitino/pull/4948#discussion_r1769368148 ## integration-test-common/build.gradle.kts: ## @@ -54,25 +62,39 @@ dependencies { exclude("org.elasticsearch") exclude("org.elasticsearch.client") excl

Re: [PR] [#4759] feat(auth-ranger): Use Spark verify Ranger authorization Hive [gravitino]

2024-09-20 Thread via GitHub
FANNG1 commented on code in PR #4948: URL: https://github.com/apache/gravitino/pull/4948#discussion_r1769369764 ## server-common/src/main/java/org/apache/gravitino/server/web/JettyServer.java: ## @@ -299,7 +322,7 @@ private void initializeWebAppServletContextHandler() { if

Re: [PR] [#4759] feat(auth-ranger): Use Spark verify Ranger authorization Hive [gravitino]

2024-09-20 Thread via GitHub
FANNG1 commented on code in PR #4948: URL: https://github.com/apache/gravitino/pull/4948#discussion_r1769370112 ## core/src/test/java/org/apache/gravitino/connector/authorization/TestAuthorization.java: ## @@ -73,7 +73,7 @@ public static void setUp() throws Exception { my

Re: [I] [EPIC] Add CLI interface for Gravitino [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on issue #4943: URL: https://github.com/apache/gravitino/issues/4943#issuecomment-2362996456 > The initial objective (as described above) is not to implement the full API, but we can expand on the initial API to eventually cover everything. If you want me to break it up

Re: [PR] [Minor] docs: Fix doc misspelling [gravitino]

2024-09-20 Thread via GitHub
jerryshao merged PR #4972: URL: https://github.com/apache/gravitino/pull/4972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [Minor] docs: Fix doc misspelling [gravitino]

2024-09-20 Thread via GitHub
jerryshao merged PR #4969: URL: https://github.com/apache/gravitino/pull/4969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method [gravitino]

2024-09-20 Thread via GitHub
yangyuxia closed pull request #4971: [#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method URL: https://github.com/apache/gravitino/pull/4971 -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768236068 ## core/src/main/java/org/apache/gravitino/storage/relational/RelationalEntityStore.java: ## @@ -88,8 +89,12 @@ public void setSerDe(EntitySerDe entitySerDe) { @Ov

Re: [PR] [#3973] improvement(core):support audit log [gravitino]

2024-09-20 Thread via GitHub
hanwxx commented on PR #4575: URL: https://github.com/apache/gravitino/pull/4575#issuecomment-2363087162 > @hanwxx , is there anything blocking the move forward?@hanwxx , is there anything blocking the move forward?@hanwxx ,有什么东西阻碍了前进吗? Submitted new code, please review it. -- This

Re: [PR] [apache#4960] fix(server): hive metastore authentication failed when checking whether securable object exists in createRole() method [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on PR #4971: URL: https://github.com/apache/gravitino/pull/4971#issuecomment-2363094678 Maybe this pull request is solved two issues. First, checks whether securable object exists in createRole() method. Second, the interacts with Ranger. Could you raise an another pull req

(gravitino) branch branch-0.6 updated: [Minor] docs: Fix doc misspelling (#4972)

2024-09-20 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch branch-0.6 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.6 by this push: new 2b40142b3 [Minor] docs: Fix doc misspe

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerryshao commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768446911 ## core/src/main/java/org/apache/gravitino/EntityStore.java: ## @@ -55,16 +55,39 @@ public interface EntityStore extends Closeable { * Note. Depends on the isol

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768668375 ## core/src/main/java/org/apache/gravitino/EntityStore.java: ## @@ -55,16 +55,39 @@ public interface EntityStore extends Closeable { * Note. Depends on the isolatio

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768677915 ## core/src/main/java/org/apache/gravitino/storage/relational/service/UserMetaService.java: ## @@ -246,6 +249,38 @@ public UserEntity updateUser( return newEntit

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768677915 ## core/src/main/java/org/apache/gravitino/storage/relational/service/UserMetaService.java: ## @@ -246,6 +249,38 @@ public UserEntity updateUser( return newEntit

Re: [PR] [#4759] feat(auth-ranger): Use Spark verify Ranger authorization Hive [gravitino]

2024-09-20 Thread via GitHub
xunliu commented on code in PR #4948: URL: https://github.com/apache/gravitino/pull/4948#discussion_r1768665627 ## catalogs/catalog-lakehouse-iceberg/src/test/java/org/apache/gravitino/catalog/lakehouse/iceberg/TestIcebergTable.java: ## @@ -76,13 +76,13 @@ public class TestIcebe

Re: [PR] [#3348] feat(core,server): Add the list operation of the user [gravitino]

2024-09-20 Thread via GitHub
jerqi commented on code in PR #4055: URL: https://github.com/apache/gravitino/pull/4055#discussion_r1768677915 ## core/src/main/java/org/apache/gravitino/storage/relational/service/UserMetaService.java: ## @@ -246,6 +249,38 @@ public UserEntity updateUser( return newEntit

Re: [PR] [#4759] feat(auth-ranger): Use Spark verify Ranger authorization Hive [gravitino]

2024-09-20 Thread via GitHub
xunliu commented on code in PR #4948: URL: https://github.com/apache/gravitino/pull/4948#discussion_r1769442948 ## server-common/src/main/java/org/apache/gravitino/server/web/JettyServer.java: ## @@ -299,7 +322,7 @@ private void initializeWebAppServletContextHandler() { if

Re: [PR] [#4759] feat(auth-ranger): Use Spark verify Ranger authorization Hive [gravitino]

2024-09-20 Thread via GitHub
xunliu commented on code in PR #4948: URL: https://github.com/apache/gravitino/pull/4948#discussion_r1769447974 ## integration-test-common/build.gradle.kts: ## @@ -29,9 +31,15 @@ dependencies { testImplementation(project(":api")) testImplementation(project(":clients:client

Re: [PR] [#4759] feat(auth-ranger): Use Spark verify Ranger authorization Hive [gravitino]

2024-09-20 Thread via GitHub
xunliu commented on code in PR #4948: URL: https://github.com/apache/gravitino/pull/4948#discussion_r1769449148 ## core/src/test/java/org/apache/gravitino/connector/authorization/TestAuthorization.java: ## @@ -73,7 +73,7 @@ public static void setUp() throws Exception { my

Re: [PR] [#4759] feat(auth-ranger): Use Spark verify Ranger authorization Hive [gravitino]

2024-09-20 Thread via GitHub
xunliu commented on code in PR #4948: URL: https://github.com/apache/gravitino/pull/4948#discussion_r1769429430 ## integration-test-common/build.gradle.kts: ## @@ -54,25 +62,39 @@ dependencies { exclude("org.elasticsearch") exclude("org.elasticsearch.client") excl