Re: [PR] Issue #4305 Added default statements to 4 switch case statements [gravitino]

2024-08-25 Thread via GitHub
justinmclean commented on PR #4668: URL: https://github.com/apache/gravitino/pull/4668#issuecomment-2308747009 Hi @manoharbvk we use Spotless to ensure consistant formatting of code. You'll need to run `./gradlew :core:spotlessApply` to fix the formating and commit the changes. -- This i

Re: [PR] [#4581]feat(iceberg) support Gravitino-based multi catalog support for Gravitino Iceberg REST server [gravitino]

2024-08-25 Thread via GitHub
FANNG1 merged PR #4598: URL: https://github.com/apache/gravitino/pull/4598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [I] [Improvement] support Gravitino-based multi catalog support for Gravitino Iceberg REST server [gravitino]

2024-08-25 Thread via GitHub
FANNG1 closed issue #4581: [Improvement] support Gravitino-based multi catalog support for Gravitino Iceberg REST server URL: https://github.com/apache/gravitino/issues/4581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] [Improvement] support Gravitino-based multi catalog support for Gravitino Iceberg REST server [gravitino]

2024-08-25 Thread via GitHub
FANNG1 closed issue #4581: [Improvement] support Gravitino-based multi catalog support for Gravitino Iceberg REST server URL: https://github.com/apache/gravitino/issues/4581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

(gravitino) branch main updated: [#4581]feat(iceberg): support Gravitino-based multi catalog support for Gravitino Iceberg REST server (#4598)

2024-08-25 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 1ec5b1152 [#4581]feat(iceberg): support Gravitino-

Re: [PR] [#4581]feat(iceberg) support Gravitino-based multi catalog support for Gravitino Iceberg REST server [gravitino]

2024-08-25 Thread via GitHub
FANNG1 commented on PR #4598: URL: https://github.com/apache/gravitino/pull/4598#issuecomment-2308797285 @theoryxu , thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730331792 ## authorizations/authorization-ranger/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerITEnv.java: ## @@ -50,16 +54,25 @@ public class

Re: [PR] [#4666] docs: correct reference from MySQL to PostgreSQL in JDBC cata… [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 merged PR #4667: URL: https://github.com/apache/gravitino/pull/4667 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graviti

(gravitino) branch main updated: [#4666] docs: correct reference from MySQL to PostgreSQL in JDBC cata… (#4667)

2024-08-25 Thread yuqi4733
This is an automated email from the ASF dual-hosted git repository. yuqi4733 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 5144ed5df [#4666] docs: correct reference from

[PR] [#4666] docs: correct reference from MySQL to PostgreSQL in JDBC cata… [gravitino]

2024-08-25 Thread via GitHub
github-actions[bot] opened a new pull request, #4669: URL: https://github.com/apache/gravitino/pull/4669 ### What changes were proposed in this pull request? The documents should be updated. ### Why are the changes needed? To correct reference from MySQL to Postgr

Re: [I] [documentation] incorrect reference in jdbc-postgresql-catalog.md [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 closed issue #4666: [documentation] incorrect reference in jdbc-postgresql-catalog.md URL: https://github.com/apache/gravitino/issues/4666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [I] [documentation] incorrect reference in jdbc-postgresql-catalog.md [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 closed issue #4666: [documentation] incorrect reference in jdbc-postgresql-catalog.md URL: https://github.com/apache/gravitino/issues/4666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

(gravitino) branch cherry-pick-branch-0.6-5144ed5dfd73ba1268b2e0aecd2076940f8ead90 created (now 18533ffad)

2024-08-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.6-5144ed5dfd73ba1268b2e0aecd2076940f8ead90 in repository https://gitbox.apache.org/repos/asf/gravitino.git at 18533ffad [#4666] docs: correct reference from MySQL

Re: [PR] [#4666] docs: correct reference from MySQL to PostgreSQL in JDBC cata… [gravitino]

2024-08-25 Thread via GitHub
FANNG1 closed pull request #4669: [#4666] docs: correct reference from MySQL to PostgreSQL in JDBC cata… URL: https://github.com/apache/gravitino/pull/4669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [#4666] docs: correct reference from MySQL to PostgreSQL in JDBC cata… [gravitino]

2024-08-25 Thread via GitHub
FANNG1 merged PR #4669: URL: https://github.com/apache/gravitino/pull/4669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

(gravitino) branch branch-0.6 updated: [#4666] docs: correct reference from MySQL to PostgreSQL in JDBC cata… (#4669)

2024-08-25 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a commit to branch branch-0.6 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.6 by this push: new 41046fb80 [#4666] docs: correct refere

Re: [I] [Bug report] Start the Gravitino Server failed in gravitino container due to java.lang.IllegalArgumentException: null (Daily pipeline 20240822) [gravitino]

2024-08-25 Thread via GitHub
danhuawang commented on issue #4659: URL: https://github.com/apache/gravitino/issues/4659#issuecomment-2309096579 @FANNG1 Would you like to help check this issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
xunliu commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730493414 ## authorizations/authorization-ranger/build.gradle.kts: ## @@ -69,24 +75,34 @@ dependencies { exclude("org.elasticsearch") exclude("org.elasticsearch.client

Re: [PR] [Bug] Avoid OOM (Out of Memory) for Playground-gravitino [gravitino-playground]

2024-08-25 Thread via GitHub
beryllw commented on PR #66: URL: https://github.com/apache/gravitino-playground/pull/66#issuecomment-2309120171 > 1. In which case you will get the OOM error? Use gravitino-playground default config and refresh the gravitino homepage several times. Gravitino server default memo

Re: [I] [Bug report] Start the Gravitino Server failed in gravitino container due to java.lang.IllegalArgumentException: null (Daily pipeline 20240822) [gravitino]

2024-08-25 Thread via GitHub
FANNG1 commented on issue #4659: URL: https://github.com/apache/gravitino/issues/4659#issuecomment-2309155514 maybe caused by https://github.com/apache/gravitino/pull/4651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [#4664] fix(server): Add the missing annotations fo access control interfaces [gravitino]

2024-08-25 Thread via GitHub
jerqi commented on code in PR #4665: URL: https://github.com/apache/gravitino/pull/4665#discussion_r1730564226 ## server/src/main/java/org/apache/gravitino/server/web/rest/PermissionOperations.java: ## @@ -40,8 +40,10 @@ import org.apache.gravitino.lock.LockType; import org.ap

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r173088 ## core/src/main/java/org/apache/gravitino/connector/BaseCatalog.java: ## @@ -181,53 +182,59 @@ public CatalogOperations ops() { public AuthorizationPlugin getA

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
xunliu commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730573584 ## core/src/main/java/org/apache/gravitino/connector/BaseCatalog.java: ## @@ -181,53 +182,59 @@ public CatalogOperations ops() { public AuthorizationPlugin getAut

Re: [PR] [#4664] fix(server): Add the missing annotations fo access control interfaces [gravitino]

2024-08-25 Thread via GitHub
xunliu commented on PR #4665: URL: https://github.com/apache/gravitino/pull/4665#issuecomment-2309179867 @jerqi Please fix CI failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [#4520] Imporvement(jdbc-catalogs): Shrink JDBC catalog binary package size to about 3MB. [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 commented on code in PR #4521: URL: https://github.com/apache/gravitino/pull/4521#discussion_r1730575483 ## catalogs/catalog-jdbc-doris/build.gradle.kts: ## @@ -61,7 +65,11 @@ tasks { } val copyCatalogLibs by registering(Copy::class) { dependsOn("jar", "runti

Re: [PR] [#4277] feat(client/server): Add the `getFileLocation` interface in the Java Client/Server [gravitino]

2024-08-25 Thread via GitHub
xloya commented on PR #4281: URL: https://github.com/apache/gravitino/pull/4281#issuecomment-2309181480 > Hi @xloya This PR is a little big. I would suggest to split into several small PRs. For this PR, I think we can focus on the definition and skeleton code, what do you think? OK,

Re: [PR] [#4664] fix(server): Add the missing annotations fo access control interfaces [gravitino]

2024-08-25 Thread via GitHub
jerqi commented on PR #4665: URL: https://github.com/apache/gravitino/pull/4665#issuecomment-2309181329 > @jerqi Please fix CI failed. Sorry, I fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730578462 ## core/src/main/java/org/apache/gravitino/connector/BaseCatalog.java: ## @@ -181,53 +182,59 @@ public CatalogOperations ops() { public AuthorizationPlugin getA

[PR] [MINOR] Add originator to the NOTICE file [gravitino]

2024-08-25 Thread via GitHub
jerryshao opened a new pull request, #4670: URL: https://github.com/apache/gravitino/pull/4670 ### What changes were proposed in this pull request? Add the originator of Gravitino to the NOTICE file. ### Why are the changes needed? ### Does this PR introduce _any_ user-fa

Re: [PR] [#4664] fix(server): Add the missing annotations fo access control interfaces [gravitino]

2024-08-25 Thread via GitHub
jerryshao commented on code in PR #4665: URL: https://github.com/apache/gravitino/pull/4665#discussion_r1730586147 ## conf/gravitino.conf.template: ## @@ -63,7 +63,7 @@ gravitino.catalog.cache.evictionIntervalMs = 360 # Whether Gravitino enable authorization or not graviti

Re: [PR] [#4664] fix(server): Add the missing annotations fo access control interfaces [gravitino]

2024-08-25 Thread via GitHub
jerqi commented on code in PR #4665: URL: https://github.com/apache/gravitino/pull/4665#discussion_r1730586908 ## conf/gravitino.conf.template: ## @@ -63,7 +63,7 @@ gravitino.catalog.cache.evictionIntervalMs = 360 # Whether Gravitino enable authorization or not gravitino.a

Re: [PR] [MINOR] Add originator of Gravitino to the NOTICE file [gravitino]

2024-08-25 Thread via GitHub
justinmclean commented on code in PR #4670: URL: https://github.com/apache/gravitino/pull/4670#discussion_r1730587270 ## NOTICE: ## @@ -4,8 +4,10 @@ Copyright 2024 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http:/

Re: [PR] [#4633] refactor(integration-test): remove integration-test module [gravitino]

2024-08-25 Thread via GitHub
mchades commented on code in PR #4628: URL: https://github.com/apache/gravitino/pull/4628#discussion_r1730587617 ## .github/workflows/trino-integration-test.yml: ## @@ -0,0 +1,104 @@ +name: Trino Integration Test + +# Controls when the workflow will run +on: + # Triggers the wo

Re: [PR] [#4633] refactor(integration-test): remove integration-test module [gravitino]

2024-08-25 Thread via GitHub
mchades commented on code in PR #4628: URL: https://github.com/apache/gravitino/pull/4628#discussion_r1730588467 ## integration-test-common/docker-script/init/hive/init.sh: ## Review Comment: because the webIT also uses Docker Compose. -- This is an automated message fr

Re: [PR] [#4633] refactor(integration-test): remove integration-test module [gravitino]

2024-08-25 Thread via GitHub
mchades commented on code in PR #4628: URL: https://github.com/apache/gravitino/pull/4628#discussion_r1730588333 ## integration-test-common/docker-script/docker-compose.yaml: ## Review Comment: because the webIT also uses Docker Compose. -- This is an automated mess

Re: [PR] [MINOR] Add originator of Gravitino to the NOTICE file [gravitino]

2024-08-25 Thread via GitHub
jerryshao commented on code in PR #4670: URL: https://github.com/apache/gravitino/pull/4670#discussion_r1730592082 ## NOTICE: ## @@ -4,8 +4,10 @@ Copyright 2024 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://ww

Re: [PR] [MINOR] Add originator of Gravitino to the NOTICE file [gravitino]

2024-08-25 Thread via GitHub
jerryshao commented on code in PR #4670: URL: https://github.com/apache/gravitino/pull/4670#discussion_r1730592082 ## NOTICE: ## @@ -4,8 +4,10 @@ Copyright 2024 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://ww

Re: [PR] [#4633] refactor(integration-test): remove integration-test module [gravitino]

2024-08-25 Thread via GitHub
jerqi commented on PR #4628: URL: https://github.com/apache/gravitino/pull/4628#issuecomment-2309203467 The test of the client will depend on server. I don't think it's correct behaviour. An integration test depends on multiple catalogs. We shouldn't remove integration-test module. -- Th

Re: [I] [Subtask] [spark-connector] support Paimon catalog [gravitino]

2024-08-25 Thread via GitHub
caican00 commented on issue #2404: URL: https://github.com/apache/gravitino/issues/2404#issuecomment-2309205382 Hi @SteNicholas @FANNG1 Can I work on this? I can split up some subtasks so that other contributors interested in it can do it together -- This is an automated message fro

[PR] [Minor] improvement(CI): Fix backend tests fail occasionally as a result of CI pipeline timeout. [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 opened a new pull request, #4671: URL: https://github.com/apache/gravitino/pull/4671 ### What changes were proposed in this pull request? Increase the timeout time for backend integration tests from 60 minutes to 90 minutes ### Why are the changes needed? Accord

Re: [PR] [MINOR] Add originator of Gravitino to the NOTICE file [gravitino]

2024-08-25 Thread via GitHub
justinmclean commented on code in PR #4670: URL: https://github.com/apache/gravitino/pull/4670#discussion_r1730597163 ## NOTICE: ## @@ -4,8 +4,10 @@ Copyright 2024 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http:/

Re: [PR] [TEST]Test CI stability [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 closed pull request #4260: [TEST]Test CI stability URL: https://github.com/apache/gravitino/pull/4260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] [#4633] refactor(integration-test): remove integration-test module [gravitino]

2024-08-25 Thread via GitHub
diqiu50 commented on code in PR #4628: URL: https://github.com/apache/gravitino/pull/4628#discussion_r1730605613 ## .github/workflows/trino-integration-test.yml: ## @@ -0,0 +1,104 @@ +name: Trino Integration Test + +# Controls when the workflow will run +on: + # Triggers the wo

Re: [PR] [#4633] refactor(integration-test): remove integration-test module [gravitino]

2024-08-25 Thread via GitHub
diqiu50 commented on code in PR #4628: URL: https://github.com/apache/gravitino/pull/4628#discussion_r1730608814 ## .github/workflows/trino-integration-test.yml: ## @@ -0,0 +1,104 @@ +name: Trino Integration Test + +# Controls when the workflow will run +on: + # Triggers the wo

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
jerqi commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730614620 ## .github/workflows/authorization-integration-test.yml: ## @@ -0,0 +1,110 @@ +name: Authorization Integration Test Review Comment: Could we reduce the number of th

Re: [PR] [#4633] refactor(integration-test): remove integration-test module [gravitino]

2024-08-25 Thread via GitHub
mchades commented on PR #4628: URL: https://github.com/apache/gravitino/pull/4628#issuecomment-2309231712 > The test of the client will depend on server. I don't think it's correct behaviour. An integration test depends on multiple catalogs. We shouldn't remove integration-test module.

Re: [PR] [#4633] refactor(integration-test): remove integration-test module [gravitino]

2024-08-25 Thread via GitHub
jerqi commented on PR #4628: URL: https://github.com/apache/gravitino/pull/4628#issuecomment-2309236739 > > The test of the client will depend on server. I don't think it's correct behaviour. An integration test depends on multiple catalogs. We shouldn't remove integration-test module. >

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
jerryshao commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730598765 ## .github/workflows/authorization-integration-test.yml: ## @@ -0,0 +1,110 @@ +name: Authorization Integration Test + +# Controls when the workflow will run +on: +

Re: [PR] [MINOR] Add originator of Gravitino to the NOTICE file [gravitino]

2024-08-25 Thread via GitHub
jerryshao commented on code in PR #4670: URL: https://github.com/apache/gravitino/pull/4670#discussion_r1730623300 ## NOTICE: ## @@ -4,8 +4,10 @@ Copyright 2024 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http://ww

Re: [PR] [#4633] refactor(integration-test): remove integration-test module [gravitino]

2024-08-25 Thread via GitHub
mchades commented on PR #4628: URL: https://github.com/apache/gravitino/pull/4628#issuecomment-2309243820 > > > The test of the client will depend on server. I don't think it's correct behaviour. An integration test depends on multiple catalogs. We shouldn't remove integration-test module.

Re: [PR] [Minor] improvement(CI): Fix backend tests fail occasionally as a result of CI pipeline timeout. [gravitino]

2024-08-25 Thread via GitHub
jerryshao commented on PR #4671: URL: https://github.com/apache/gravitino/pull/4671#issuecomment-2309244460 Why the MySQL IT takes too long time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [Minor] improvement(CI): Fix backend tests fail occasionally as a result of CI pipeline timeout. [gravitino]

2024-08-25 Thread via GitHub
jerryshao commented on PR #4671: URL: https://github.com/apache/gravitino/pull/4671#issuecomment-2309245243 Can you please create a separate issue to track this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [I] [Bug report] RoleOperation throw null exception [gravitino]

2024-08-25 Thread via GitHub
jerryshao closed issue #4664: [Bug report] RoleOperation throw null exception URL: https://github.com/apache/gravitino/issues/4664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [#4664] fix(server): Add the missing annotations fo access control interfaces [gravitino]

2024-08-25 Thread via GitHub
jerryshao merged PR #4665: URL: https://github.com/apache/gravitino/pull/4665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch main updated: [#4664] fix(server): Add the missing annotations fo access control interfaces (#4665)

2024-08-25 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new c00ff157f [#4664] fix(server): Add the missing ann

[PR] [#4664] fix(server): Add the missing annotations fo access control interfaces [gravitino]

2024-08-25 Thread via GitHub
github-actions[bot] opened a new pull request, #4672: URL: https://github.com/apache/gravitino/pull/4672 ### What changes were proposed in this pull request? Add the missing annotations for access control interfaces. Fix the document by the way. ### Why are the changes needed?

(gravitino) branch cherry-pick-branch-0.6-c00ff157f5dee94e46f9144cc8f4b6d5a58f3847 created (now e48655e35)

2024-08-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.6-c00ff157f5dee94e46f9144cc8f4b6d5a58f3847 in repository https://gitbox.apache.org/repos/asf/gravitino.git at e48655e35 [#4664] fix(server): Add the missing annota

Re: [PR] [#4664] fix(server): Add the missing annotations fo access control interfaces [gravitino]

2024-08-25 Thread via GitHub
jerryshao closed pull request #4672: [#4664] fix(server): Add the missing annotations fo access control interfaces URL: https://github.com/apache/gravitino/pull/4672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
xunliu commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730625969 ## .github/workflows/authorization-integration-test.yml: ## @@ -0,0 +1,110 @@ +name: Authorization Integration Test + +# Controls when the workflow will run +on: + #

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
xunliu commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730628432 ## .github/workflows/authorization-integration-test.yml: ## @@ -0,0 +1,110 @@ +name: Authorization Integration Test + +# Controls when the workflow will run +on: + #

Re: [PR] [Minor] improvement(CI): Fix backend tests fail occasionally as a result of CI pipeline timeout. [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 commented on PR #4671: URL: https://github.com/apache/gravitino/pull/4671#issuecomment-2309253214 > Why the MySQL IT takes too long time? However, we were unable to find a clear explanation for the situation. I reviewed the log but found no useful information. -- This is

Re: [PR] [Minor] improvement(CI): Fix backend tests fail occasionally as a result of CI pipeline timeout. [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 commented on PR #4671: URL: https://github.com/apache/gravitino/pull/4671#issuecomment-2309253551 > Can you please create a separate issue to track this issue and find out the root cause? Ok, I will create an issue to track it specially. -- This is an automated message fr

[I] [Bug report] CI pipeline for backend tests fail occasionally as a result of timeout. [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 opened a new issue, #4673: URL: https://github.com/apache/gravitino/issues/4673 ### Version main branch ### Describe what's wrong Please see: https://github.com/apache/gravitino/actions/runs/10552034338/job/29230290884?pr=4260 ### Error messag

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
xunliu commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730625836 ## .github/workflows/authorization-integration-test.yml: ## @@ -0,0 +1,110 @@ +name: Authorization Integration Test + +# Controls when the workflow will run +on: + #

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
xunliu commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730635893 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -802,25 +812,60 @@ private String buildConfPath(Map properties, String provider) {

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
xunliu commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730636057 ## core/src/main/java/org/apache/gravitino/connector/BaseCatalog.java: ## @@ -181,53 +182,59 @@ public CatalogOperations ops() { public AuthorizationPlugin getAut

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
mchades commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730637343 ## .github/workflows/authorization-integration-test.yml: ## @@ -0,0 +1,110 @@ +name: Authorization Integration Test Review Comment: Should the `Authorization Inte

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
xunliu commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730637524 ## gradle/libs.versions.toml: ## @@ -79,6 +79,7 @@ flink = "1.18.0" cglib = "2.2" ranger = "2.4.0" javax-jaxb-api = "2.3.1" +javax-ws-rs-api = "2.1.1" Review Comme

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
xunliu commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730642641 ## .github/workflows/authorization-integration-test.yml: ## @@ -0,0 +1,110 @@ +name: Authorization Integration Test Review Comment: @jerqi Please create an issue t

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
xunliu commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730644394 ## .github/workflows/authorization-integration-test.yml: ## @@ -0,0 +1,110 @@ +name: Authorization Integration Test + +# Controls when the workflow will run +on: + #

Re: [PR] [MINOR] Add originator of Gravitino to the NOTICE file [gravitino]

2024-08-25 Thread via GitHub
justinmclean commented on code in PR #4670: URL: https://github.com/apache/gravitino/pull/4670#discussion_r1730652172 ## NOTICE: ## @@ -4,8 +4,10 @@ Copyright 2024 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http:/

Re: [PR] [MINOR] Add originator of Gravitino to the NOTICE file [gravitino]

2024-08-25 Thread via GitHub
justinmclean commented on code in PR #4670: URL: https://github.com/apache/gravitino/pull/4670#discussion_r1730656173 ## NOTICE: ## @@ -4,8 +4,10 @@ Copyright 2024 The Apache Software Foundation This product includes software developed at The Apache Software Foundation (http:/

Re: [I] [Subtask] [spark-connector] support Paimon catalog [gravitino]

2024-08-25 Thread via GitHub
FANNG1 commented on issue #2404: URL: https://github.com/apache/gravitino/issues/2404#issuecomment-2309317580 > Hi @SteNicholas @FANNG1 Can I work on this? I can split up some subtasks so that other contributors interested in it can do it together cool, it's a good starting point to s

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
xunliu commented on PR #4651: URL: https://github.com/apache/gravitino/pull/4651#issuecomment-2309336868 @jerryshao Please help me review this PR, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] [Bug report] CI: test containers initialization error on Cron Integration Test 20240822 [gravitino]

2024-08-25 Thread via GitHub
mchades commented on issue #4640: URL: https://github.com/apache/gravitino/issues/4640#issuecomment-2309343035 It's because the Gravitino server does not start up successfully: > Exception in thread "main" java.lang.NoSuchMethodError: 'java.util.Map javax.ws.rs.core.Application.getPro

Re: [PR] [Minor] improvement(CI): Fix backend tests fail occasionally as a result of CI pipeline timeout. [gravitino]

2024-08-25 Thread via GitHub
jerryshao merged PR #4671: URL: https://github.com/apache/gravitino/pull/4671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch main updated: [Minor] improvement(CI): Fix backend tests fail occasionally as a result of CI pipeline timeout. (#4671)

2024-08-25 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new ee238544c [Minor] improvement(CI): Fix backend tes

Re: [PR] [MINOR] Add originator of Gravitino to the NOTICE file [gravitino]

2024-08-25 Thread via GitHub
JunpingDu commented on PR #4670: URL: https://github.com/apache/gravitino/pull/4670#issuecomment-2309386381 I am good with the new patch. Previous NOTICE update from datastrato to apache is not precisely - sorry that I am too busy to review that earlier. -- This is an automated messag

[PR] [Minor] improvement(CI): Fix backend tests fail occasionally as a result of CI pipeline timeout. [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 opened a new pull request, #4674: URL: https://github.com/apache/gravitino/pull/4674 ### What changes were proposed in this pull request? Increase the timeout time for backend integration tests from 60 minutes to 90 minutes ### Why are the changes needed? Accord

Re: [I] [Subtask] [spark-connector] support Paimon catalog [gravitino]

2024-08-25 Thread via GitHub
caican00 commented on issue #2404: URL: https://github.com/apache/gravitino/issues/2404#issuecomment-2309391560 > > Hi @SteNicholas @FANNG1 Can I work on this? I can split up some subtasks so that other contributors interested in it can do it together > > cool, it's a good starting po

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
jerqi commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730741175 ## .github/workflows/authorization-integration-test.yml: ## @@ -0,0 +1,110 @@ +name: Authorization Integration Test Review Comment: It's hard to test them with a si

Re: [I] [Subtask] [spark-connector] support Paimon catalog [gravitino]

2024-08-25 Thread via GitHub
SteNicholas commented on issue #2404: URL: https://github.com/apache/gravitino/issues/2404#issuecomment-2309434790 @caican00, you could create subtasks for this issue to make other contributors have chance to contribute. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
jerryshao commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730748521 ## catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java: ## @@ -94,7 +95,11 @@ public class JdbcCatalogPr

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
jerryshao commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730749137 ## catalogs/catalog-kafka/src/main/java/org/apache/gravitino/catalog/kafka/KafkaCatalogPropertiesMetadata.java: ## @@ -30,13 +30,17 @@ public class KafkaCatalogProp

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730749907 ## catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java: ## @@ -94,7 +95,11 @@ public class JdbcCatalogPro

Re: [PR] [#4662] improve(IT): Add ranger authorization Hive E2E test [gravitino]

2024-08-25 Thread via GitHub
yuqi1129 commented on code in PR #4651: URL: https://github.com/apache/gravitino/pull/4651#discussion_r1730756999 ## catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/JdbcCatalogPropertiesMetadata.java: ## @@ -94,7 +95,11 @@ public class JdbcCatalogPro

Re: [PR] [#4664] fix(server): Add the missing annotations fo access control interfaces [gravitino]

2024-08-25 Thread via GitHub
jerryshao merged PR #4672: URL: https://github.com/apache/gravitino/pull/4672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch branch-0.6 updated: [#4664] fix(server): Add the missing annotations fo access control interfaces (#4672)

2024-08-25 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch branch-0.6 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.6 by this push: new b79a36524 [#4664] fix(server): Add the

(gravitino) branch cherry-pick-branch-0.6-c00ff157f5dee94e46f9144cc8f4b6d5a58f3847 deleted (was e48655e35)

2024-08-25 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch cherry-pick-branch-0.6-c00ff157f5dee94e46f9144cc8f4b6d5a58f3847 in repository https://gitbox.apache.org/repos/asf/gravitino.git was e48655e35 [#4664] fix(server): Add the missing annotations