Re: [I] [Improvement] Calls to code marked @VisibleForTesting in production code [gravitino]

2024-08-07 Thread via GitHub
Naresh-kumar-Thodupunoori commented on issue #4408: URL: https://github.com/apache/gravitino/issues/4408#issuecomment-2272772740 Hey, as when I looked into the code I found @VisibleForTesting only in the loadCatalogBackend method of the PaimonCatalogOps.java file. So I am proposing to remov

Re: [PR] [#4384] fix(UI): Replace to password input for all jdbc-password value [gravitino]

2024-08-07 Thread via GitHub
jerryshao merged PR #4413: URL: https://github.com/apache/gravitino/pull/4413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch branch-0.6 updated: [#4384] fix(UI): Replace to password input for all jdbc-password value (#4413)

2024-08-07 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch branch-0.6 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.6 by this push: new a897a47f2 [#4384] fix(UI): Replace to

(gravitino) branch cherry-pick-branch-0.6-d6a0c95156632947c580f12070c65fe2f900df53 deleted (was 247666056)

2024-08-07 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch cherry-pick-branch-0.6-d6a0c95156632947c580f12070c65fe2f900df53 in repository https://gitbox.apache.org/repos/asf/gravitino.git was 247666056 [#4384] fix(UI): Replace to password input for a

[PR] feat: Calls to code marked @VisibleForTesting in production code [gravitino]

2024-08-07 Thread via GitHub
Naresh-kumar-Thodupunoori opened a new pull request, #4414: URL: https://github.com/apache/gravitino/pull/4414 # Issue -> https://github.com/apache/gravitino/issues/4408 # Pull Request Description **Title:** feat: Calls to code marked @VisibleForTesting in production code

Re: [PR] [#4374] feat(client): Add owner operations for client [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 commented on code in PR #4397: URL: https://github.com/apache/gravitino/pull/4397#discussion_r1706495207 ## api/src/main/java/org/apache/gravitino/exceptions/NoSuchMetadataObjectException.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#4374] feat(client): Add owner operations for client [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 commented on code in PR #4397: URL: https://github.com/apache/gravitino/pull/4397#discussion_r1706495207 ## api/src/main/java/org/apache/gravitino/exceptions/NoSuchMetadataObjectException.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#4374] feat(client): Add owner operations for client [gravitino]

2024-08-07 Thread via GitHub
jerqi commented on code in PR #4397: URL: https://github.com/apache/gravitino/pull/4397#discussion_r1706506416 ## clients/client-java/src/main/java/org/apache/gravitino/client/GravitinoClient.java: ## @@ -308,6 +313,32 @@ public Group revokeRolesFromGroup(List roles, String gro

Re: [PR] [#4374] feat(client): Add owner operations for client [gravitino]

2024-08-07 Thread via GitHub
jerqi commented on code in PR #4397: URL: https://github.com/apache/gravitino/pull/4397#discussion_r1706507742 ## clients/client-java/src/main/java/org/apache/gravitino/client/GravitinoClient.java: ## @@ -308,6 +313,32 @@ public Group revokeRolesFromGroup(List roles, String gro

Re: [PR] [#4404] improvement: Add startup ASCII logo [gravitino]

2024-08-07 Thread via GitHub
zivali commented on PR #4405: URL: https://github.com/apache/gravitino/pull/4405#issuecomment-2272832762 @jerryshao Ok! How about we move this to `bin/common.sh`. Both `gravitino.sh` and `gravitino-iceberg-rest-server.sh` use the `common.sh` script. -- This is an automated message from t

[PR] [MINOR] Use Debian as gravitino basic image ,otherwise lack of basic tools like 'wget','apt-get' [gravitino]

2024-08-07 Thread via GitHub
danhuawang opened a new pull request, #4415: URL: https://github.com/apache/gravitino/pull/4415 ### What changes were proposed in this pull request? Use the linux distribution include basic tools like wget ,apt-get as basic image The Debian linux distribution include basic tools li

Re: [PR] [MINOR] Use Debian as gravitino basic image ,otherwise lack of basic tools like 'wget','apt-get' [gravitino]

2024-08-07 Thread via GitHub
danhuawang commented on PR #4415: URL: https://github.com/apache/gravitino/pull/4415#issuecomment-2272842856 @FANNG1 Can you help review it ? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] [MINOR] build: Bump the version to 0.7.0-SNAPSHOT [gravitino]

2024-08-07 Thread via GitHub
jerryshao opened a new pull request, #4416: URL: https://github.com/apache/gravitino/pull/4416 ### What changes were proposed in this pull request? Bump the version to 0.7.0-SNAPSHOT and 0.7.0.dev for Java and Python build. ### Why are the changes needed? ### Does this PR

Re: [PR] [#3871] Improvement(spark-connector): Making Iceberg extended sqls compatible with different iceberg versions [gravitino]

2024-08-07 Thread via GitHub
caican00 closed pull request #3872: [#3871] Improvement(spark-connector): Making Iceberg extended sqls compatible with different iceberg versions URL: https://github.com/apache/gravitino/pull/3872 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] [#4404] improvement: Add startup ASCII logo [gravitino]

2024-08-07 Thread via GitHub
jerryshao commented on PR #4405: URL: https://github.com/apache/gravitino/pull/4405#issuecomment-2272850930 > @jerryshao Ok! How about we move this to `bin/common.sh`? Both `gravitino.sh` and `gravitino-iceberg-rest-server.sh` use the `common.sh` script. Yeah, that's what I mean. -

Re: [PR] [MINOR] Use Debian as gravitino basic image ,otherwise lack of basic tools like 'wget','apt-get' [gravitino]

2024-08-07 Thread via GitHub
FANNG1 commented on PR #4415: URL: https://github.com/apache/gravitino/pull/4415#issuecomment-2272861372 LGTM, @xunliu do you have time to review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [Bug report] initial error when run frontend IT [gravitino]

2024-08-07 Thread via GitHub
bknbkn commented on issue #3827: URL: https://github.com/apache/gravitino/issues/3827#issuecomment-2272952755 Now it seems to be able to run locally, just sometimes the trino container startup is unstable. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] [Bug report] CI: occasionally run trino tpcds testsets failed because clean up test env unsuccessfully [gravitino]

2024-08-07 Thread via GitHub
danhuawang closed issue #3792: [Bug report] CI: occasionally run trino tpcds testsets failed because clean up test env unsuccessfully URL: https://github.com/apache/gravitino/issues/3792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] [Bug report] CI: occasionally run trino tpcds testsets failed because clean up test env unsuccessfully [gravitino]

2024-08-07 Thread via GitHub
danhuawang commented on issue #3792: URL: https://github.com/apache/gravitino/issues/3792#issuecomment-2272959287 > Yes It means Trino sql test don't support rerun on the same environment, and should run on a clean environment. I closed this issue since ther

Re: [I] [Improvement] Calls to code marked @VisibleForTesting in production code [gravitino]

2024-08-07 Thread via GitHub
Naresh-kumar-Thodupunoori commented on issue #4408: URL: https://github.com/apache/gravitino/issues/4408#issuecomment-2272978875 Hey @justinmclean can you review my PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [#3854] feat(core): Add a cache service to cache the mapping of name identifer to id [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 commented on PR #3986: URL: https://github.com/apache/gravitino/pull/3986#issuecomment-2272998676 @jerqi @mchades Could you assist in reviewing this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [#3854] feat(core): Add a cache service to cache the mapping of name identifer to id [gravitino]

2024-08-07 Thread via GitHub
jerqi commented on PR #3986: URL: https://github.com/apache/gravitino/pull/3986#issuecomment-2273011200 How to handle rename operation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [#3854] feat(core): Add a cache service to cache the mapping of name identifer to id [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 commented on PR #3986: URL: https://github.com/apache/gravitino/pull/3986#issuecomment-2273015798 > How to handle rename operation? Please see the code: https://github.com/user-attachments/assets/49325641-e015-421f-89ba-56e15a150015";> -- This is an automated mes

(gravitino) branch main updated: [MINOR] Use Debian as gravitino basic image ,otherwise lack of basic tools like 'wget','apt-get' (#4415)

2024-08-07 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 0681de7af [MINOR] Use Debian as gravitino basic im

Re: [PR] [MINOR] Use Debian as gravitino basic image ,otherwise lack of basic tools like 'wget','apt-get' [gravitino]

2024-08-07 Thread via GitHub
FANNG1 merged PR #4415: URL: https://github.com/apache/gravitino/pull/4415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
FANNG1 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1706685916 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonTablePropertiesMetadata.java: ## @@ -35,15 +35,26 @@ public cla

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
FANNG1 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1706689454 ## catalogs/catalog-lakehouse-paimon/src/test/java/org/apache/gravitino/catalog/lakehouse/paimon/TestGravitinoPaimonTable.java: ## @@ -383,8 +383,13 @@ void testTableP

Re: [I] [Bug report] initial error when run frontend IT [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 commented on issue #3827: URL: https://github.com/apache/gravitino/issues/3827#issuecomment-2273041625 @LauraXia123 I have verified that we should run `gradle compileDistribution` before, and then we can run frontend tests like `CatalogsPageDorisTest` locally or the problem

Re: [I] [Improvement] Possible null pointer in UserContext.java [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 closed issue #4331: [Improvement] Possible null pointer in UserContext.java URL: https://github.com/apache/gravitino/issues/4331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix potential NullPointerException in UserContext by adding null check for parentContext. [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 commented on code in PR #4348: URL: https://github.com/apache/gravitino/pull/4348#discussion_r1706710096 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/UserContext.java: ## @@ -125,7 +125,7 @@ public static UserContext getUse

(gravitino) branch cherry-pick-branch-0.6-4249993aa868ba1f91eca663be696432d82a29ac created (now e840883e7)

2024-08-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.6-4249993aa868ba1f91eca663be696432d82a29ac in repository https://gitbox.apache.org/repos/asf/gravitino.git at e840883e7 Fix potential NullPointerException in UserC

(gravitino) branch main updated: Fix potential NullPointerException in UserContext by adding null check for parentContext. (#4348)

2024-08-07 Thread yuqi4733
This is an automated email from the ASF dual-hosted git repository. yuqi4733 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 4249993aa Fix potential NullPointerException in

Re: [PR] Fix potential NullPointerException in UserContext by adding null check for parentContext. [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 merged PR #4348: URL: https://github.com/apache/gravitino/pull/4348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graviti

[PR] Fix potential NullPointerException in UserContext by adding null check for parentContext. [gravitino]

2024-08-07 Thread via GitHub
github-actions[bot] opened a new pull request, #4418: URL: https://github.com/apache/gravitino/pull/4418 Title: [#4331] fix: add null check for parentContext in UserContext ### What changes were proposed in this pull request? This pull request adds a null check for the parentCon

Re: [PR] [#4331] fix(catalog-hadoop): Fix potential NullPointerException in UserContext by adding null check for parentContext. [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 closed pull request #4418: [#4331] fix(catalog-hadoop): Fix potential NullPointerException in UserContext by adding null check for parentContext. URL: https://github.com/apache/gravitino/pull/4418 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] [Bug report] jdbc-postgresql/00006_datatype.sql under catalog pg failed. [gravitino]

2024-08-07 Thread via GitHub
diqiu50 commented on issue #3930: URL: https://github.com/apache/gravitino/issues/3930#issuecomment-2273069182 This error is caused by the previous step's error of the #3929. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [#3379] feat(catalog-hadoop): Add S3 support for Fileset Hadoop catalog [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 commented on PR #4232: URL: https://github.com/apache/gravitino/pull/4232#issuecomment-2273069635 > https://github.com/apache/gravitino/blob/13f3b3f3118e2a7f8b63aa324e11c688159f4633/catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/SecureHadoopCatalogOperatio

Re: [PR] [MINOR] build: Bump the version to 0.7.0-SNAPSHOT [gravitino]

2024-08-07 Thread via GitHub
jerryshao commented on PR #4416: URL: https://github.com/apache/gravitino/pull/4416#issuecomment-2273072648 Please hold the merge, I still need to fix something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [#4331] fix(trino-connector): Fix the jdbc-postgresql/00004_query_pushdown.sql under catalog pg failed [gravitino]

2024-08-07 Thread via GitHub
diqiu50 opened a new pull request, #4419: URL: https://github.com/apache/gravitino/pull/4419 ### What changes were proposed in this pull request? Fix the jdbc-postgresql/4_query_pushdown.sql under catalog pg failed. Because the explain result of the join query has random left and

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1706733694 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonTablePropertiesMetadata.java: ## @@ -35,15 +35,26 @@ public c

Re: [PR] [#4386] Fix(spark-connector): spark connector build failed with scala2.13 [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on PR #4403: URL: https://github.com/apache/gravitino/pull/4403#issuecomment-2273100552 > Could you run pass the IT? seems there are still some problems in runtime. ![image](https://github.com/user-attachments/assets/deb98896-62ca-40c1-bbd3-401bb877c2cf) i te

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1706740125 ## catalogs/catalog-lakehouse-paimon/src/test/java/org/apache/gravitino/catalog/lakehouse/paimon/TestGravitinoPaimonTable.java: ## @@ -383,8 +383,13 @@ void testTabl

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1706733694 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonTablePropertiesMetadata.java: ## @@ -35,15 +35,26 @@ public c

Re: [I] [Improvement] TraceId Implementation for Audit Logs in Gravitino [gravitino]

2024-08-07 Thread via GitHub
FANNG1 commented on issue #3997: URL: https://github.com/apache/gravitino/issues/3997#issuecomment-2273104293 seems we could you `MDC` to implement this ```java protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException {

Re: [PR] [#4386] Fix(spark-connector): spark connector build failed with scala2.13 [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on PR #4403: URL: https://github.com/apache/gravitino/pull/4403#issuecomment-2273108836 @FANNG1 should we add the scala2.13 jobs to the pipeline? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Update HTTPClient.java [gravitino]

2024-08-07 Thread via GitHub
shaofengshi commented on code in PR #4407: URL: https://github.com/apache/gravitino/pull/4407#discussion_r1706745052 ## clients/client-java/src/main/java/org/apache/gravitino/client/HTTPClient.java: ## @@ -132,18 +132,17 @@ private HTTPClient( * @return The response body as

Re: [PR] Update HTTPClient.java [gravitino]

2024-08-07 Thread via GitHub
shaofengshi commented on code in PR #4407: URL: https://github.com/apache/gravitino/pull/4407#discussion_r1706745987 ## clients/client-java/src/main/java/org/apache/gravitino/client/HTTPClient.java: ## @@ -132,18 +132,17 @@ private HTTPClient( * @return The response body as

Re: [PR] [#4386] Fix(spark-connector): spark connector build failed with scala2.13 [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on code in PR #4403: URL: https://github.com/apache/gravitino/pull/4403#discussion_r1706749564 ## .github/workflows/spark-integration-test.yml: ## @@ -58,7 +58,7 @@ jobs: matrix: architecture: [linux/amd64] java-version: [ 8, 11, 17 ]

[PR] [3844]fix(catalog-mysql) Add the version checking for the MYSQL JDBC driver [gravitino]

2024-08-07 Thread via GitHub
diqiu50 opened a new pull request, #4420: URL: https://github.com/apache/gravitino/pull/4420 ### What changes were proposed in this pull request? Add the version checking for the MYSQL JDBC driver, if failed throw an exception ### Why are the changes needed? Fix: #38

(gravitino) branch cherry-pick-branch-0.6-f3b4c3a405fc9229806bcb520fc9c6bba0ab9440 created (now 713966fd1)

2024-08-07 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.6-f3b4c3a405fc9229806bcb520fc9c6bba0ab9440 in repository https://gitbox.apache.org/repos/asf/gravitino.git at 713966fd1 [#4374] feat(client): Add owner operations

[PR] [#4374] feat(client): Add owner operations for client [gravitino]

2024-08-07 Thread via GitHub
github-actions[bot] opened a new pull request, #4421: URL: https://github.com/apache/gravitino/pull/4421 ### What changes were proposed in this pull request? Add owner operations for client ### Why are the changes needed? Fix: #4374 ### Does this PR introduce _any_

Re: [PR] [#4374] feat(client): Add owner operations for client [gravitino]

2024-08-07 Thread via GitHub
xunliu merged PR #4397: URL: https://github.com/apache/gravitino/pull/4397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [I] [FEATURE] Add the client for the ownership [gravitino]

2024-08-07 Thread via GitHub
xunliu closed issue #4374: [FEATURE] Add the client for the ownership URL: https://github.com/apache/gravitino/issues/4374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] [FEATURE] Add the client for the ownership [gravitino]

2024-08-07 Thread via GitHub
xunliu closed issue #4374: [FEATURE] Add the client for the ownership URL: https://github.com/apache/gravitino/issues/4374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

(gravitino) branch main updated: [#4374] feat(client): Add owner operations for client (#4397)

2024-08-07 Thread liuxun
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new f3b4c3a40 [#4374] feat(client): Add owner operati

Re: [PR] [#4266] feat: simplify compilation by compiling scripts [gravitino]

2024-08-07 Thread via GitHub
shaofengshi commented on PR #4382: URL: https://github.com/apache/gravitino/pull/4382#issuecomment-2273128642 This is cool I think. I tried it on my laptop (Macbook), the display has some problem: https://github.com/user-attachments/assets/cc6fd61a-656b-49a1-8721-b00af8160d24";>

Re: [PR] [#4386] Fix(spark-connector): spark connector build failed with scala2.13 [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on code in PR #4403: URL: https://github.com/apache/gravitino/pull/4403#discussion_r1706749564 ## .github/workflows/spark-integration-test.yml: ## @@ -58,7 +58,7 @@ jobs: matrix: architecture: [linux/amd64] java-version: [ 8, 11, 17 ]

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on PR #4349: URL: https://github.com/apache/gravitino/pull/4349#issuecomment-2273194757 @FANNG1 could you help review again? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [#4331] fix(catalog-hadoop): Fix potential NullPointerException in UserContext by adding null check for parentContext. [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 merged PR #4418: URL: https://github.com/apache/gravitino/pull/4418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graviti

(gravitino) branch branch-0.6 updated: [#4331] fix(catalog-hadoop): Fix potential NullPointerException in UserContext by adding null check for parentContext. (#4418)

2024-08-07 Thread yuqi4733
This is an automated email from the ASF dual-hosted git repository. yuqi4733 pushed a commit to branch branch-0.6 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.6 by this push: new 62aa8fbe3 [#4331] fix(catalog-hadoo

Re: [PR] [#4409] refactor(JDBCBackend): replace switch with if statement [gravitino]

2024-08-07 Thread via GitHub
jerryshao commented on PR #4422: URL: https://github.com/apache/gravitino/pull/4422#issuecomment-2273221146 IMHO, I don't think it worths changing, I don't feel if...else is more readable than switch...case. Besides, the indention is not correct. -- This is an automated message from the A

Re: [PR] [#3379] feat(catalog-hadoop): Add S3 support for Fileset Hadoop catalog [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 commented on code in PR #4232: URL: https://github.com/apache/gravitino/pull/4232#discussion_r1706824919 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/AuthenticationConfig.java: ## @@ -36,7 +36,8 @@ public class Authenticati

Re: [PR] [MINOR] build: Bump the version to 0.7.0-SNAPSHOT [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 commented on code in PR #4416: URL: https://github.com/apache/gravitino/pull/4416#discussion_r1706839607 ## clients/client-python/gravitino/exceptions/base.py: ## @@ -101,4 +101,3 @@ class UnauthorizedException(GravitinoRuntimeException): class BadRequestException(Gr

Re: [PR] [#3379] feat(catalog-hadoop): Add S3 support for Fileset Hadoop catalog [gravitino]

2024-08-07 Thread via GitHub
jerqi commented on code in PR #4232: URL: https://github.com/apache/gravitino/pull/4232#discussion_r1706849498 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/AuthenticationConfig.java: ## @@ -36,7 +36,8 @@ public class AuthenticationC

Re: [PR] [#3379] feat(catalog-hadoop): Add S3 support for Fileset Hadoop catalog [gravitino]

2024-08-07 Thread via GitHub
jerqi commented on code in PR #4232: URL: https://github.com/apache/gravitino/pull/4232#discussion_r1706853013 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/AuthenticationConfig.java: ## @@ -36,7 +36,8 @@ public class AuthenticationC

Re: [PR] [#3079] Fix: Add equals method to GravitinoVersion.java [gravitino]

2024-08-07 Thread via GitHub
harshpanchal04 commented on PR #4368: URL: https://github.com/apache/gravitino/pull/4368#issuecomment-2273285501 > @harshpanchal04 Please reorganize the PR description, especially the part `How was this patch tested`. Updated the description. -- This is an automated message from th

Re: [PR] [#3379] feat(catalog-hadoop): Add S3 support for Fileset Hadoop catalog [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 commented on code in PR #4232: URL: https://github.com/apache/gravitino/pull/4232#discussion_r1706889622 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/authentication/AuthenticationConfig.java: ## @@ -36,7 +36,8 @@ public class Authenticati

Re: [PR] [#4409] refactor(JDBCBackend): replace switch with if statement [gravitino]

2024-08-07 Thread via GitHub
mishrababhishek commented on PR #4422: URL: https://github.com/apache/gravitino/pull/4422#issuecomment-2273363024 @jerryshao it was listed in issues section i have just refactor the code as it was requested and about indention it was vs code default i am really new in open source

[PR] [#3827] fix(integration-test): Fix bugs about running frontend tests locally. [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 opened a new pull request, #4423: URL: https://github.com/apache/gravitino/pull/4423 ### What changes were proposed in this pull request? Run `gradle :web:build` first as some frontend test depends on web page. ### Why are the changes needed? Fix the bugs.

Re: [I] [Improvement] TrinoIT should use the latest CI image of Hive [gravitino]

2024-08-07 Thread via GitHub
mchades commented on issue #4424: URL: https://github.com/apache/gravitino/issues/4424#issuecomment-2273383506 @diqiu50 could you plz take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] [Bug report] The property URI of Hive catalog should be mutable in frontend page [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 opened a new issue, #4425: URL: https://github.com/apache/gravitino/issues/4425 ### Version main branch ### Describe what's wrong ![Uploading image.png…]() ### Error message and/or stacktrace Please see above ### How to reproduce P

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
FANNG1 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1706965109 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonTablePropertiesMetadata.java: ## @@ -35,15 +35,26 @@ public cla

Re: [PR] [#4227] improvement(client-python): Add Catalog Error Handler and related exceptions, test cases in client-python [gravitino]

2024-08-07 Thread via GitHub
jingjia88 commented on code in PR #4345: URL: https://github.com/apache/gravitino/pull/4345#discussion_r1706987806 ## clients/client-python/gravitino/exceptions/base.py: ## @@ -95,10 +95,17 @@ class UnknownError(RuntimeError): """An exception thrown when other unknown excep

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1706997856 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonTablePropertiesMetadata.java: ## @@ -35,15 +35,26 @@ public c

Re: [PR] [#4386] Fix(spark-connector): spark connector build failed with scala2.13 [gravitino]

2024-08-07 Thread via GitHub
FANNG1 commented on PR #4403: URL: https://github.com/apache/gravitino/pull/4403#issuecomment-2273475514 > > Could you run pass the IT? seems there are still some problems in runtime. > > ![image](https://private-user-images.githubusercontent.com/94670132/355769781-deb98896-62ca-40c1

Re: [PR] [#4386] Fix(spark-connector): spark connector build failed with scala2.13 [gravitino]

2024-08-07 Thread via GitHub
FANNG1 commented on code in PR #4403: URL: https://github.com/apache/gravitino/pull/4403#discussion_r1707001099 ## .github/workflows/spark-integration-test.yml: ## @@ -58,7 +58,7 @@ jobs: matrix: architecture: [linux/amd64] java-version: [ 8, 11, 17 ] -

Re: [PR] [#4386] Fix(spark-connector): spark connector build failed with scala2.13 [gravitino]

2024-08-07 Thread via GitHub
FANNG1 commented on code in PR #4403: URL: https://github.com/apache/gravitino/pull/4403#discussion_r1707008825 ## .github/workflows/spark-integration-test.yml: ## @@ -58,7 +58,7 @@ jobs: matrix: architecture: [linux/amd64] java-version: [ 8, 11, 17 ] -

Re: [PR] feat: Calls to code marked @VisibleForTesting in production code [gravitino]

2024-08-07 Thread via GitHub
Naresh-kumar-Thodupunoori closed pull request #4414: feat: Calls to code marked @VisibleForTesting in production code URL: https://github.com/apache/gravitino/pull/4414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1706997856 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonTablePropertiesMetadata.java: ## @@ -35,15 +35,26 @@ public c

Re: [PR] [#4386] Fix(spark-connector): spark connector build failed with scala2.13 [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on code in PR #4403: URL: https://github.com/apache/gravitino/pull/4403#discussion_r1707077652 ## .github/workflows/spark-integration-test.yml: ## @@ -58,7 +58,7 @@ jobs: matrix: architecture: [linux/amd64] java-version: [ 8, 11, 17 ]

[PR] feat: Calls to code marked @VisibleForTesting in production code [gravitino]

2024-08-07 Thread via GitHub
Naresh-kumar-Thodupunoori opened a new pull request, #4426: URL: https://github.com/apache/gravitino/pull/4426 # Issue -> https://github.com/apache/gravitino/issues/4408 # Pull Request Description **Title:** feat: Calls to code marked @VisibleForTesting in production code

Re: [I] [Improvement] Calls to code marked @VisibleForTesting in production code [gravitino]

2024-08-07 Thread via GitHub
Naresh-kumar-Thodupunoori commented on issue #4408: URL: https://github.com/apache/gravitino/issues/4408#issuecomment-2273589856 hey @justinmclean I have created a new PR and check for gradle build locally and it is working fine..! -- This is an automated message from the Apache Git S

Re: [PR] [MINOR] build: Bump the version to 0.7.0-SNAPSHOT [gravitino]

2024-08-07 Thread via GitHub
jerryshao commented on code in PR #4416: URL: https://github.com/apache/gravitino/pull/4416#discussion_r1707172291 ## clients/client-python/gravitino/exceptions/base.py: ## @@ -101,4 +101,3 @@ class UnauthorizedException(GravitinoRuntimeException): class BadRequestException(G

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
FANNG1 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1707235856 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/utils/TableOpsUtils.java: ## @@ -18,20 +18,124 @@ */ package org.ap

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1707257378 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/utils/TableOpsUtils.java: ## @@ -18,20 +18,124 @@ */ package org.

Re: [PR] [#4266] feat: simplify compilation by compiling scripts [gravitino]

2024-08-07 Thread via GitHub
featherchen commented on PR #4382: URL: https://github.com/apache/gravitino/pull/4382#issuecomment-2273993591 > This is cool I think. I tried it on my laptop (Macbook), the display has some problem: > https://private-user-images.githubusercontent.com/5411805/355774329-cc6fd61a-656b-49a1-8

Re: [I] [Improvement] CatalogConnectorManager.java has no unit test / coverage [gravitino]

2024-08-07 Thread via GitHub
silenceland commented on issue #2181: URL: https://github.com/apache/gravitino/issues/2181#issuecomment-2273996575 Hello, I'm a fresh hand to this project and I'm very interested in it. I would like to try out this issue. Please assign it to me. Thank you! -- This is an automated message

Re: [I] [Improvement] Simplify compilation by compiling scripts [gravitino]

2024-08-07 Thread via GitHub
featherchen commented on issue #4266: URL: https://github.com/apache/gravitino/issues/4266#issuecomment-2274003854 > 1. It's a good idea to list some commonly used build options and combinations in the `kts` file. > > 2. Putting all build options in a conspicuous place like in the

Re: [PR] [#4409] refactor(JDBCBackend): replace switch with if statement [gravitino]

2024-08-07 Thread via GitHub
justinmclean commented on PR #4422: URL: https://github.com/apache/gravitino/pull/4422#issuecomment-2274598423 Hi @mishrababhishek, that is for your contribution, but you have changed more than what was asked for here. There is no need to change all switch statements, just the one with a si

Re: [I] [Improvement] Calls to code marked @VisibleForTesting in production code [gravitino]

2024-08-07 Thread via GitHub
justinmclean commented on issue #4408: URL: https://github.com/apache/gravitino/issues/4408#issuecomment-2274626490 `setLoginUser` is marked @VisibleForTesting so it would be good to fix that as well. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
FANNG1 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1708247151 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonTablePropertiesMetadata.java: ## @@ -35,15 +35,27 @@ public cla

Re: [PR] [MINOR] build: Bump the version to 0.7.0-SNAPSHOT [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 commented on code in PR #4416: URL: https://github.com/apache/gravitino/pull/4416#discussion_r1708328150 ## clients/client-python/gravitino/exceptions/base.py: ## @@ -101,4 +101,3 @@ class UnauthorizedException(GravitinoRuntimeException): class BadRequestException(Gr

Re: [PR] [3844]fix(catalog-mysql) Add the version checking for the MYSQL JDBC driver [gravitino]

2024-08-07 Thread via GitHub
yuqi1129 commented on code in PR #4420: URL: https://github.com/apache/gravitino/pull/4420#discussion_r1708334200 ## catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/MySQLProtocolCompatibleCatalogOperations.java: ## @@ -47,6 +49,18 @@ public MySQLProt

Re: [I] [Improvement] TrinoIT should use the latest CI image of Hive [gravitino]

2024-08-07 Thread via GitHub
diqiu50 commented on issue #4424: URL: https://github.com/apache/gravitino/issues/4424#issuecomment-2274738518 OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [3844]fix(catalog-mysql) Add the version checking for the MYSQL JDBC driver [gravitino]

2024-08-07 Thread via GitHub
diqiu50 commented on code in PR #4420: URL: https://github.com/apache/gravitino/pull/4420#discussion_r1708377848 ## catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/MySQLProtocolCompatibleCatalogOperations.java: ## @@ -47,6 +49,18 @@ public MySQLProto

Re: [PR] [#3854] feat(core): Add a cache service to cache the mapping of name identifer to id [gravitino]

2024-08-07 Thread via GitHub
mchades commented on code in PR #3986: URL: https://github.com/apache/gravitino/pull/3986#discussion_r1708381230 ## core/src/main/java/org/apache/gravitino/storage/relational/service/NameIdMappingService.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [#4386] Fix(spark-connector): spark connector build failed with scala2.13 [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on code in PR #4403: URL: https://github.com/apache/gravitino/pull/4403#discussion_r1708391416 ## .github/workflows/spark-integration-test.yml: ## @@ -92,9 +92,13 @@ jobs: run: | if [ "${{ matrix.scala-version }}" == "2.12" ];then

Re: [PR] [#3916] feat(catalog-lakehouse-paimon): Support alter table for Paimon Catalog [gravitino]

2024-08-07 Thread via GitHub
caican00 commented on code in PR #4349: URL: https://github.com/apache/gravitino/pull/4349#discussion_r1708397726 ## catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonTablePropertiesMetadata.java: ## @@ -35,15 +35,27 @@ public c

Re: [PR] [#3854] feat(core): Add a cache service to cache the mapping of name identifer to id [gravitino]

2024-08-07 Thread via GitHub
mchades commented on code in PR #3986: URL: https://github.com/apache/gravitino/pull/3986#discussion_r1708410567 ## core/src/main/java/org/apache/gravitino/storage/relational/service/NameIdMappingService.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [#3854] feat(core): Add a cache service to cache the mapping of name identifer to id [gravitino]

2024-08-07 Thread via GitHub
mchades commented on code in PR #3986: URL: https://github.com/apache/gravitino/pull/3986#discussion_r170849 ## core/src/main/java/org/apache/gravitino/storage/relational/service/NameIdMappingService.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundati

  1   2   >