FANNG1 merged PR #6205:
URL: https://github.com/apache/gravitino/pull/6205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
jerryshao closed pull request #6205: [doc] Revise the glossary documentation
URL: https://github.com/apache/gravitino/pull/6205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
justinmclean merged PR #5837:
URL: https://github.com/apache/gravitino/pull/5837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gra
tengqm commented on PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#issuecomment-2574340103
All comments addressed as suggested. Many thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903701983
##
docs/glossary.md:
##
@@ -264,65 +353,57 @@ license: "This software is licensed under the Apache
License version 2."
- A distinct and separable part of a p
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903699305
##
docs/glossary.md:
##
@@ -74,187 +215,135 @@ license: "This software is licensed under the Apache
License version 2."
## Docker container
-- A lightweigh
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903696558
##
docs/glossary.md:
##
@@ -74,187 +215,135 @@ license: "This software is licensed under the Apache
License version 2."
## Docker container
-- A lightweigh
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903696094
##
docs/glossary.md:
##
@@ -74,187 +215,135 @@ license: "This software is licensed under the Apache
License version 2."
## Docker container
-- A lightweigh
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903695870
##
docs/glossary.md:
##
@@ -74,187 +215,135 @@ license: "This software is licensed under the Apache
License version 2."
## Docker container
-- A lightweigh
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903694997
##
docs/glossary.md:
##
@@ -74,187 +215,135 @@ license: "This software is licensed under the Apache
License version 2."
## Docker container
-- A lightweigh
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903695526
##
docs/glossary.md:
##
@@ -74,187 +215,135 @@ license: "This software is licensed under the Apache
License version 2."
## Docker container
-- A lightweigh
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903694745
##
docs/glossary.md:
##
@@ -74,187 +215,135 @@ license: "This software is licensed under the Apache
License version 2."
## Docker container
-- A lightweigh
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903694214
##
docs/glossary.md:
##
@@ -74,187 +215,135 @@ license: "This software is licensed under the Apache
License version 2."
## Docker container
-- A lightweigh
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903692670
##
docs/glossary.md:
##
@@ -50,15 +189,17 @@ license: "This software is licensed under the Apache
License version 2."
## Columns
-- The individual fields o
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903691871
##
docs/glossary.md:
##
@@ -50,15 +189,17 @@ license: "This software is licensed under the Apache
License version 2."
## Columns
-- The individual fields o
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903691871
##
docs/glossary.md:
##
@@ -50,15 +189,17 @@ license: "This software is licensed under the Apache
License version 2."
## Columns
-- The individual fields o
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903691396
##
docs/glossary.md:
##
@@ -50,15 +189,17 @@ license: "This software is licensed under the Apache
License version 2."
## Columns
-- The individual fields o
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903691031
##
docs/glossary.md:
##
@@ -4,41 +4,180 @@ date: 2023-11-28
license: "This software is licensed under the Apache License version 2."
---
+## API
+
+- Applica
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903690244
##
docs/glossary.md:
##
@@ -4,41 +4,180 @@ date: 2023-11-28
license: "This software is licensed under the Apache License version 2."
---
+## API
+
+- Applica
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903689864
##
docs/glossary.md:
##
@@ -4,41 +4,180 @@ date: 2023-11-28
license: "This software is licensed under the Apache License version 2."
---
+## API
+
+- Applica
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903689056
##
docs/glossary.md:
##
@@ -4,41 +4,180 @@ date: 2023-11-28
license: "This software is licensed under the Apache License version 2."
---
+## API
+
+- Applica
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903688578
##
docs/glossary.md:
##
@@ -4,41 +4,180 @@ date: 2023-11-28
license: "This software is licensed under the Apache License version 2."
---
+## API
+
+- Applica
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1903688142
##
docs/glossary.md:
##
@@ -4,41 +4,180 @@ date: 2023-11-28
license: "This software is licensed under the Apache License version 2."
---
+## API
+
+- Applica
jerryshao commented on PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#issuecomment-2551272756
@justinmclean would you please help to review again? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
tengqm commented on PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#issuecomment-2540239981
Okay, let me revise this further. Breaking those long sentences to simple
English.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
justinmclean commented on PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#issuecomment-2540219307
Changes like this cause the issue:
https://github.com/user-attachments/assets/d67a50d1-baeb-4107-82d9-9f85c2f845a1";
/>
--
This is an automated message from the Apache Git
justinmclean commented on PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#issuecomment-2540217237
That change is fine. The issue occurs when you break up a sentence over
several lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
tengqm commented on PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#issuecomment-2540213446
Check this change and tell me ... how this change is breaking your IDE
syntax checker?
Can you elaborate how this "line breaks" hurts anything?
https://github.com/user-attachmen
tengqm commented on PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#issuecomment-2540210062
> IDE wrap lines, so that's not really an issue. As I explained elsewhere,
if you break up lines, tools like grammar and style checkers that we use will
not work. Some people who contrib
justinmclean commented on PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#issuecomment-2540172192
IDE wrap lines, so that's not really an issue. As I explained elsewhere, if
you break up lines, tools like grammar and style checkers that we use will not
work.
--
This is an au
tengqm commented on PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#issuecomment-2538474599
> Please do not break sentences over multiple lines as this breaks some
tooling.
No. I don't agree with this. Long lines are hard to review, hard to
maintain, hard to read even in
tengqm commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1881791485
##
docs/glossary.md:
##
@@ -104,11 +249,15 @@ license: "This software is licensed under the Apache
License version 2."
- The distribution of data or services acros
justinmclean commented on code in PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#discussion_r1881029378
##
docs/glossary.md:
##
@@ -104,11 +249,15 @@ license: "This software is licensed under the Apache
License version 2."
- The distribution of data or services
justinmclean commented on PR #5837:
URL: https://github.com/apache/gravitino/pull/5837#issuecomment-2537231031
Please do not break sentences over multiple lines as this breaks some
tooling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
34 matches
Mail list logo
