Re: [PR] fix: use compose v2 syntax [gravitino-playground]

2025-04-22 Thread via GitHub
shaofengshi commented on PR #79: URL: https://github.com/apache/gravitino-playground/pull/79#issuecomment-2820572354 The problem has already been solved with issue #102 with commit d38a70e3ede4f22bfc1d3229d1919db5d5059984, so I will close this PR. -- This is an automated message from the

Re: [PR] fix: use compose v2 syntax [gravitino-playground]

2025-04-22 Thread via GitHub
shaofengshi closed pull request #79: fix: use compose v2 syntax URL: https://github.com/apache/gravitino-playground/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] fix: use compose v2 syntax [gravitino-playground]

2024-12-28 Thread via GitHub
unknowntpo commented on PR #79: URL: https://github.com/apache/gravitino-playground/pull/79#issuecomment-2564603598 LGTM, ping @xunliu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] fix: use compose v2 syntax [gravitino-playground]

2024-12-28 Thread via GitHub
jhchee commented on PR #79: URL: https://github.com/apache/gravitino-playground/pull/79#issuecomment-2564387168 Thanks @kahnwong, I can attest your change is working! However, I'm not a contributor of this project, so will likely need other to approve this PR. Gentle ping @unknowntpo if

Re: [PR] fix: use compose v2 syntax [gravitino-playground]

2024-12-28 Thread via GitHub
kahnwong commented on PR #79: URL: https://github.com/apache/gravitino-playground/pull/79#issuecomment-2564369975 @jhchee rebased the pr and apply compose syntax migration. Please kindly review this PR. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] fix: use compose v2 syntax [gravitino-playground]

2024-12-28 Thread via GitHub
kahnwong commented on PR #79: URL: https://github.com/apache/gravitino-playground/pull/79#issuecomment-2564348525 > Hihi @kahnwong Are you still working on this? This will be QoL improvement for users that use docker compose v2. I'm still working on this. I noticed from the latest co

Re: [PR] fix: use compose v2 syntax [gravitino-playground]

2024-12-27 Thread via GitHub
jhchee commented on PR #79: URL: https://github.com/apache/gravitino-playground/pull/79#issuecomment-2563903731 Hihi @kahnwong Are you still working on this? This will be QoL improvement for users that use docker compose v2. -- This is an automated message from the Apache Git Service. To