Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-02-05 Thread via GitHub
justinmclean commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2638767083 Note also that is a 2 clause BSD license not an MIT license. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-02-05 Thread via GitHub
justinmclean commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2638764665 The license can be obtain from their repo and includes the copyright line. See https://salsa.debian.org/debian/krb5/-/blob/master/NOTICE Copyright (C) 1985-2024 by the Massac

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-02-05 Thread via GitHub
zzzk1 commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2636060460 > > The MIT license needs to include the correct copyright line. We also need a copy of it in the licenses directory and the files listed in the LICENSE file. > > @justinmclean

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-02-05 Thread via GitHub
yuqi1129 commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2636049843 > The MIT license needs to include the correct copyright line. We also need a copy of it in the licenses directory and the files listed in the LICENSE file. @justinmclean

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-01-29 Thread via GitHub
justinmclean commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2623497494 The MIT license needs to include the correct copyright line. We also need a copy of it in the licenses directory and the files listed in the LICENSE file. -- This is an automated

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-01-25 Thread via GitHub
yuqi1129 commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2614201606 > @yuqi1129 seemed sure the files were copied from [here](https://packages.ubuntu.com/search?suite=oracular§ion=all&arch=any&keywords=krb5-kdc&searchon=names), is that incorrect?

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-01-25 Thread via GitHub
justinmclean commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2614189914 So where were the files copied from? At least one of them looks to come from https://salsa.debian.org/debian/krb5/-/blob/master/src/config-files/kdc.conf -- This is an automated

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-01-25 Thread via GitHub
justinmclean commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2614195809 @yuqi1129 seemed sure the files were copied from [here](https://packages.ubuntu.com/search?suite=oracular§ion=all&arch=any&keywords=krb5-kdc&searchon=names), is that incorrect? -

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-01-25 Thread via GitHub
justinmclean commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2614195428 So the issue is: 1. These files were copied from somewhere but we're not 100% sure where from. 2. We can't put ASF headers on them as it's 3rd party code. 3. Because of 1 an

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-01-25 Thread via GitHub
jerryshao commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2614190266 It is hard to say it is copied from other projects, because they all look the same. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-01-25 Thread via GitHub
jerryshao commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2614185000 Please be aware that these files are just Kerberos configuration files to make CI work, not the code copying from Kerberos source code. -- This is an automated message from the Apac

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-01-25 Thread via GitHub
yuqi1129 commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2614177603 > See also [infra.apache.org/licensing-howto.html#permissive-deps](https://infra.apache.org/licensing-howto.html#permissive-deps) for what needs to be done to LICENSE (i.e. MIT license

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-01-24 Thread via GitHub
justinmclean commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2613373422 See [also](https://infra.apache.org/licensing-howto.html#permissive-deps) for what needs to be done to LICENSE (i.e. MIT license needs to be added).e -- This is an automated mess

Re: [PR] [#6330] chore: add MIT license to missing files [gravitino]

2025-01-24 Thread via GitHub
zzzk1 commented on PR #6355: URL: https://github.com/apache/gravitino/pull/6355#issuecomment-2612948544 I think we should add MIT license for kdc.conf, only one now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the