Re: [PR] [#5739] feat(model-catalog): Implement the model catalog logic [gravitino]

2024-12-18 Thread via GitHub
mchades merged PR #5848: URL: https://github.com/apache/gravitino/pull/5848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitin

Re: [PR] [#5739] feat(model-catalog): Implement the model catalog logic [gravitino]

2024-12-17 Thread via GitHub
jerryshao commented on PR #5848: URL: https://github.com/apache/gravitino/pull/5848#issuecomment-2547890860 > I noticed that we have the listModelVersions operation, but why don't we have a listModelAlias method? There's no specific reason why this "listModelAliases" API is not added,

Re: [PR] [#5739] feat(model-catalog): Implement the model catalog logic [gravitino]

2024-12-17 Thread via GitHub
jerryshao commented on code in PR #5848: URL: https://github.com/apache/gravitino/pull/5848#discussion_r1888155923 ## catalogs/catalog-model/build.gradle.kts: ## @@ -40,11 +40,17 @@ dependencies { exclude(group = "*") } - compileOnly(libs.guava) - + implementation(li

Re: [PR] [#5739] feat(model-catalog): Implement the model catalog logic [gravitino]

2024-12-16 Thread via GitHub
mchades commented on code in PR #5848: URL: https://github.com/apache/gravitino/pull/5848#discussion_r1888020466 ## catalogs/catalog-model/build.gradle.kts: ## @@ -40,11 +40,17 @@ dependencies { exclude(group = "*") } - compileOnly(libs.guava) - + implementation(libs

Re: [PR] [#5739] feat(model-catalog): Implement the model catalog logic [gravitino]

2024-12-16 Thread via GitHub
jerryshao commented on PR #5848: URL: https://github.com/apache/gravitino/pull/5848#issuecomment-2545404545 @yuqi1129 @mchades @xloya can you please help to review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[PR] [#5739] feat(model-catalog): Implement the model catalog logic [gravitino]

2024-12-12 Thread via GitHub
jerryshao opened a new pull request, #5848: URL: https://github.com/apache/gravitino/pull/5848 ### What changes were proposed in this pull request? This PR adds the model catalog implementation. ### Why are the changes needed? This is a part of work to support model manag