Re: [PR] [#5704] improve(core): Support enum catalog provider name [gravitino]

2024-12-05 Thread via GitHub
xunliu closed pull request #5705: [#5704] improve(core): Support enum catalog provider name URL: https://github.com/apache/gravitino/pull/5705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] [#5704] improve(core): Support enum catalog provider name [gravitino]

2024-12-02 Thread via GitHub
tengqm commented on code in PR #5705: URL: https://github.com/apache/gravitino/pull/5705#discussion_r1867201456 ## catalogs/catalog-jdbc-postgresql/src/main/java/org/apache/gravitino/catalog/postgresql/PostgreSqlCatalog.java: ## @@ -37,7 +37,7 @@ public class PostgreSqlCatalog e

Re: [PR] [#5704] improve(core): Support enum catalog provider name [gravitino]

2024-12-02 Thread via GitHub
tengqm commented on code in PR #5705: URL: https://github.com/apache/gravitino/pull/5705#discussion_r1867200809 ## catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/DorisCatalog.java: ## @@ -43,7 +43,7 @@ public class DorisCatalog extends JdbcCatalog {

Re: [PR] [#5704] improve(core): Support enum catalog provider name [gravitino]

2024-11-29 Thread via GitHub
jerryshao commented on code in PR #5705: URL: https://github.com/apache/gravitino/pull/5705#discussion_r1863266053 ## api/src/main/java/org/apache/gravitino/CatalogProvider.java: ## @@ -26,7 +26,36 @@ */ @Evolving public interface CatalogProvider { + enum CatalogName { +

[PR] [#5704] improve(core): Support enum catalog provider name [gravitino]

2024-11-28 Thread via GitHub
xunliu opened a new pull request, #5705: URL: https://github.com/apache/gravitino/pull/5705 ### What changes were proposed in this pull request? 1. Add an enum Type in the CatalogProvider interface. ### Why are the changes needed? Fix: #5704 ### Does this PR introd