Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

yuqi1129 commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2531560854 Merge it into main, @pithecuse527 Thanks for your hard work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

yuqi1129 merged PR #5645: URL: https://github.com/apache/gravitino/pull/5645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graviti

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1877174429 ## rfc/rfc-2/Entity-key-encoding-for-kv-store-deprecated.md: ## @@ -17,13 +17,19 @@ under the License. --> -# RFC-1: Entity Key Encoding design for KV stor

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

jerryshao commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1877169419 ## rfc/rfc-2/Entity-key-encoding-for-kv-store-deprecated.md: ## @@ -17,13 +17,19 @@ under the License. --> -# RFC-1: Entity Key Encoding design for KV store +

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1875334550 ## rfc/rfc-2/Entity-key-encoding-for-kv-store-deprecated.md: ## @@ -17,13 +17,19 @@ under the License. --> -# RFC-1: Entity Key Encoding design for KV stor

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1875334550 ## rfc/rfc-2/Entity-key-encoding-for-kv-store-deprecated.md: ## @@ -17,13 +17,19 @@ under the License. --> -# RFC-1: Entity Key Encoding design for KV stor

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

jerryshao commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1875182050 ## rfc/rfc-2/Entity-key-encoding-for-kv-store-deprecated.md: ## @@ -17,13 +17,19 @@ under the License. --> -# RFC-1: Entity Key Encoding design for KV store +

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1874607879 ## rfc/rfc-2/Entity-key-encoding-for-kv-store-deprecated.md: ## @@ -17,13 +17,19 @@ under the License. --> -# RFC-1: Entity Key Encoding design for KV stor

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1874235050 ## rfc/rfc-2/Entity-key-encoding-for-kv-store-deprecated.md: ## @@ -17,13 +17,19 @@ under the License. --> -# RFC-1: Entity Key Encoding design for KV stor

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

tengqm commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1873236781 ## rfc/rfc-2/Entity-key-encoding-for-kv-store-deprecated.md: ## @@ -17,13 +17,19 @@ under the License. --> -# RFC-1: Entity Key Encoding design for KV store +# R

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

jerryshao commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1872724415 ## rfc/rfc-2/Entity-key-encoding-for-kv-store-deprecated.md: ## @@ -17,13 +17,19 @@ under the License. --> -# RFC-1: Entity Key Encoding design for KV store +

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

tengqm commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1872469955 ## rfc/rfc-2/Entity-key-encoding-for-kv-store-deprecated.md: ## @@ -17,13 +17,19 @@ under the License. --> -# RFC-1: Entity Key Encoding design for KV store +# R

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

jerryshao commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1870587306 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1870552089 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

yuqi1129 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1870550456 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

jerryshao commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1870517118 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1870516108 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1870516108 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1870516108 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

jerryshao commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1870514327 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

yuqi1129 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1869512381 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2517278824 Feel free to let me know if there are further requests :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

yuqi1129 commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2517275766 > Looks like the CI is passed, @yuqi1129 can you please help to check if everything is OK? Got it. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

jerryshao commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2517272473 Looks like the CI is passed, @yuqi1129 can you please help to check if everything is OK? -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

yuqi1129 closed pull request #5645: [#5633] remove the key-value storage backend logic URL: https://github.com/apache/gravitino/pull/5645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

jerryshao commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2513807223 Looks like we still have some build issues, @pithecuse527 would you please make the CI pass? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1861967023 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r186195 ## core/src/main/java/org/apache/gravitino/Configs.java: ## @@ -168,17 +148,6 @@ private Configs() {} .stringConf() .createWithDefault(DEFA

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1861760932 ## docs/gravitino-server-config.md: ## @@ -55,7 +55,6 @@ The following table lists the storage configuration items: | `gravitino.entity.store`

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1861400986 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

jerryshao commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1860018515 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

yuqi1129 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1859795390 ## rfc/rfc-3/Transaction-implementation-on-kv.md: ## @@ -1,140 +0,0 @@ -

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

yuqi1129 commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2502549968 > @yuqi1129 I have applied your feedback. But one more question. > > > Also, please carefully check the code, I notice that RocksDB JNI is still in some Licese files. > >

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2502556303 Thanks for letting me know. I’ve rebased this branch. Feel free to share any further comments or issues. -- This is an automated message from the Apache Git Service. To

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2502508535 @yuqi1129 I have applied your feedback. But one more question. > Also, please carefully check the code, I notice that RocksDB JNI is still in some Licese files. I

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

yuqi1129 commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2502493852 > @yuqi1129 > > Thanks for the help. > > As I go through, I wonder why we need to delete the `RandomIdGenerator` class. I think it is needed for the [GravitinoEnv](https:

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2502184724 @yuqi1129 Thanks for the help. As I go through, I wonder why we need to delete the RandomIdGenerator class. I think it is needed for the [GravitinoEnv](https://git

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1859403637 ## catalogs/catalog-hive/build.gradle.kts: ## @@ -122,7 +122,6 @@ dependencies { exclude("org.apache.hadoop") exclude("org.apache.zookeeper") excl

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

yuqi1129 commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1857572126 ## catalogs/catalog-hive/build.gradle.kts: ## @@ -122,7 +122,6 @@ dependencies { exclude("org.apache.hadoop") exclude("org.apache.zookeeper") exclude(

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

yuqi1129 commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2499401978 @pithecuse527 , Hi, thanks for your contribution, I have checked the code and the following can be further improved - The following class can also be dropped. https://github.

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

jerryshao commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2496598552 @yuqi1129 please spend time on this PR, to help @pithecuse527 to get this done, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2493966408 @jerryshao Hello, I have removed the module `meta` and its related implementations. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

jerryshao commented on PR #5645: URL: https://github.com/apache/gravitino/pull/5645#issuecomment-2492933461 Thanks @pithecuse527 for the contribution. I think the `meta` module is also not needed any more, and also the related codes like serde, you can remove them all. -- This is an auto

[PR] [#5633] remove the key-value storage backend logic [gravitino]

pithecuse527 opened a new pull request, #5645: URL: https://github.com/apache/gravitino/pull/5645 ### What changes were proposed in this pull request? Remove Key-Value storage backend storage implementations ### Why are the changes needed? Fix: #5633 ### Does t