Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
jerryshao merged PR #5690: URL: https://github.com/apache/gravitino/pull/5690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
FANNG1 commented on PR #5690: URL: https://github.com/apache/gravitino/pull/5690#issuecomment-2514686659 > @FANNG1 can you please update the PR description to reflect your updated API? done -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
jerryshao commented on PR #5690: URL: https://github.com/apache/gravitino/pull/5690#issuecomment-2514668416 @FANNG1 can you please update the PR description to reflect your updated API? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
FANNG1 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1867717523 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
jerryshao commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1867695946 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
FANNG1 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1867643701 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
jerryshao commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1867570182 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
jerryshao commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1867569256 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
jerryshao commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1867567988 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
FANNG1 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1867550038 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
FANNG1 commented on PR #5690: URL: https://github.com/apache/gravitino/pull/5690#issuecomment-2514291648 @jerryshao @yuqi1129 , all comments are addressed, please help to review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
jerryshao commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1867406301 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-02 Thread via GitHub
FANNG1 commented on PR #5690: URL: https://github.com/apache/gravitino/pull/5690#issuecomment-2513719869 @jerryshao do you have time to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-02 Thread via GitHub
yuqi1129 commented on PR #5690: URL: https://github.com/apache/gravitino/pull/5690#issuecomment-2513665842 I'm fine with the current implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-01 Thread via GitHub
FANNG1 commented on PR #5690: URL: https://github.com/apache/gravitino/pull/5690#issuecomment-2510352693 @jerryshao could you help to review this, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-11-27 Thread via GitHub
yuqi1129 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1860253530 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-11-27 Thread via GitHub
FANNG1 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1860539584 ## api/src/main/java/org/apache/gravitino/exceptions/CredentialDeserializeException.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-11-27 Thread via GitHub
yuqi1129 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1860329716 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-11-27 Thread via GitHub
FANNG1 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1860320951 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-11-27 Thread via GitHub
FANNG1 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1860318314 ## api/src/main/java/org/apache/gravitino/exceptions/CredentialDeserializeException.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-11-27 Thread via GitHub
FANNG1 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1860318314 ## api/src/main/java/org/apache/gravitino/exceptions/CredentialDeserializeException.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-11-27 Thread via GitHub
FANNG1 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1860276883 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-11-27 Thread via GitHub
yuqi1129 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1860255658 ## api/src/main/java/org/apache/gravitino/exceptions/CredentialDeserializeException.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-11-27 Thread via GitHub
FANNG1 commented on PR #5690: URL: https://github.com/apache/gravitino/pull/5690#issuecomment-2503280055 @jerryshao @yuqi1129 please help to review this, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-11-27 Thread via GitHub
FANNG1 opened a new pull request, #5690: URL: https://github.com/apache/gravitino/pull/5690 ### What changes were proposed in this pull request? add credential API ### Why are the changes needed? Fix: #5619 ### Does this PR introduce _any_ user-facing change? no