Re: [PR] [#5602] feat(core): Add storage schema for model (part-1) [gravitino]

2024-12-01 Thread via GitHub
jerryshao merged PR #5689: URL: https://github.com/apache/gravitino/pull/5689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#5602] feat(core): Add storage schema for model (part-1) [gravitino]

2024-11-28 Thread via GitHub
yuqi1129 commented on code in PR #5689: URL: https://github.com/apache/gravitino/pull/5689#discussion_r1862306069 ## core/src/main/java/org/apache/gravitino/storage/relational/service/ModelMetaService.java: ## @@ -0,0 +1,188 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [#5602] feat(core): Add storage schema for model (part-1) [gravitino]

2024-11-28 Thread via GitHub
jerryshao closed pull request #5689: [#5602] feat(core): Add storage schema for model (part-1) URL: https://github.com/apache/gravitino/pull/5689 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [#5602] feat(core): Add storage schema for model (part-1) [gravitino]

2024-11-27 Thread via GitHub
xloya commented on PR #5689: URL: https://github.com/apache/gravitino/pull/5689#issuecomment-2505404623 I have no more question, LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [#5602] feat(core): Add storage schema for model (part-1) [gravitino]

2024-11-27 Thread via GitHub
jerryshao commented on PR #5689: URL: https://github.com/apache/gravitino/pull/5689#issuecomment-2505386430 @yuqi1129 @xloya would you please help to review again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [#5602] feat(core): Add storage schema for model (part-1) [gravitino]

2024-11-27 Thread via GitHub
xloya commented on code in PR #5689: URL: https://github.com/apache/gravitino/pull/5689#discussion_r1861464831 ## scripts/h2/schema-0.8.0-h2.sql: ## @@ -289,3 +289,51 @@ CREATE TABLE IF NOT EXISTS `owner_meta` ( KEY `idx_oid` (`owner_id`), KEY `idx_meid` (`metadata_obj

Re: [PR] [#5602] feat(core): Add storage schema for model (part-1) [gravitino]

2024-11-27 Thread via GitHub
jerryshao commented on code in PR #5689: URL: https://github.com/apache/gravitino/pull/5689#discussion_r1860343732 ## scripts/h2/schema-0.8.0-h2.sql: ## @@ -289,3 +289,51 @@ CREATE TABLE IF NOT EXISTS `owner_meta` ( KEY `idx_oid` (`owner_id`), KEY `idx_meid` (`metadata

Re: [PR] [#5602] feat(core): Add storage schema for model (part-1) [gravitino]

2024-11-27 Thread via GitHub
yuqi1129 commented on code in PR #5689: URL: https://github.com/apache/gravitino/pull/5689#discussion_r1860292173 ## scripts/h2/schema-0.8.0-h2.sql: ## @@ -289,3 +289,51 @@ CREATE TABLE IF NOT EXISTS `owner_meta` ( KEY `idx_oid` (`owner_id`), KEY `idx_meid` (`metadata_

[PR] [#5602] feat(core): Add storage schema for model (part-1) [gravitino]

2024-11-27 Thread via GitHub
jerryshao opened a new pull request, #5689: URL: https://github.com/apache/gravitino/pull/5689 ### What changes were proposed in this pull request? This PR adds the 1st part of storage schema for model metadata. ### Why are the changes needed? Fix: #5602 ### Does