FANNG1 commented on PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2497291062
@LiuQhahah merged to main, thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
FANNG1 merged PR #5590:
URL: https://github.com/apache/gravitino/pull/5590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
LiuQhahah commented on PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2497085704
HI @jerryshao @FANNG1
I have updated it.
please help to review it again.
sorry.
Thanks,
Qiang
--
This is an automated message from the Apache Git Service.
To res
jerryshao commented on PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2496591926
There're some UT failures that need to be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
LiuQhahah commented on PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2495929374
> @LiuQhahah ,LGTM except minor comments, could you fix it ?
Hi @FANNG1
I have fixed the issue.
Please review it again.
Thanks,
Qiang
--
This is an automa
FANNG1 commented on PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2495496911
@LiuQhahah ,LGTM except minor comments, could you fix it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
FANNG1 commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1855203020
##
core/src/test/java/org/apache/gravitino/listener/api/event/TestPartitionEvent.java:
##
@@ -117,6 +117,14 @@ void testAddPartitionEvent() {
checkPartitionInfo(p
FANNG1 commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1855202743
##
core/src/test/java/org/apache/gravitino/listener/api/event/TestPartitionEvent.java:
##
@@ -117,6 +117,14 @@ void testAddPartitionEvent() {
checkPartitionInfo(p
LiuQhahah commented on PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2492976776
> @LiuQhahah as #5580 is merged first, could you rebase the code and add
more work:
>
> 1. add operationType method to all specific partition event.
>
> ```
> @Overr
tengqm commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851434652
##
core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
FANNG1 commented on PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2491037993
@LiuQhahah as #5580 is merged first, could you rebase the code and add more
work:
1. add operationType method to all specific partition event.
```
@Override
public Operat
tengqm commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851900160
##
core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
FANNG1 commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851910770
##
core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
FANNG1 commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851848929
##
core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
FANNG1 commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851848929
##
core/src/main/java/org/apache/gravitino/listener/api/event/AddPartitionPreEvent.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
tengqm commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851716384
##
core/src/main/java/org/apache/gravitino/listener/api/event/PartitionPreEvent.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
FANNG1 commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851596611
##
core/src/main/java/org/apache/gravitino/listener/api/event/PartitionPreEvent.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
tengqm commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1851436553
##
core/src/main/java/org/apache/gravitino/listener/api/event/PartitionPreEvent.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
jerryshao commented on PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#issuecomment-2490030244
Please update the PR to fix the conflict, @LiuQhahah .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
LiuQhahah commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1850449350
##
core/src/main/java/org/apache/gravitino/listener/api/event/PartitionPreEvent.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
FANNG1 commented on code in PR #5590:
URL: https://github.com/apache/gravitino/pull/5590#discussion_r1847758778
##
core/src/main/java/org/apache/gravitino/listener/api/event/PartitionPreEvent.java:
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
21 matches
Mail list logo
