Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

shaofengshi merged PR #5717: URL: https://github.com/apache/gravitino/pull/5717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@grav

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

shaofengshi commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868639579 ## docs/cli.md: ## @@ -426,6 +437,11 @@ gcli table set --name catalog_postgres.hr.salaries --property test --value value gcli table remove --name catalog_postgr

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

justinmclean commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868588933 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java: ## @@ -50,6 +50,7 @@ public class GravitinoOptions { public static final String R

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

tengqm commented on PR #5717: URL: https://github.com/apache/gravitino/pull/5717#issuecomment-2515997223 lgtm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

justinmclean commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868585072 ## clients/cli/src/main/java/org/apache/gravitino/cli/ReadTableCSV.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

tengqm commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868582426 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java: ## @@ -50,6 +50,7 @@ public class GravitinoOptions { public static final String ROLE =

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

tengqm commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868580952 ## clients/cli/src/main/java/org/apache/gravitino/cli/ReadTableCSV.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

justinmclean commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868580055 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateTable.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

justinmclean commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868574599 ## clients/cli/src/main/java/org/apache/gravitino/cli/ReadTableCSV.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

justinmclean commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868571598 ## clients/cli/src/main/java/org/apache/gravitino/cli/ReadTableCSV.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

justinmclean commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868570054 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java: ## @@ -50,6 +50,7 @@ public class GravitinoOptions { public static final String R

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

tengqm commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868533351 ## clients/cli/src/main/java/org/apache/gravitino/cli/ReadTableCSV.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

justinmclean commented on PR #5717: URL: https://github.com/apache/gravitino/pull/5717#issuecomment-2515645401 @shaofengshi this is ready for review. The failed CI is due to a network error and unrelated to the code changes. -- This is an automated message from the Apache Git Service. To

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

justinmclean commented on PR #5717: URL: https://github.com/apache/gravitino/pull/5717#issuecomment-2513809631 Note there will be less changes to review once the column PR is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

justinmclean commented on PR #5717: URL: https://github.com/apache/gravitino/pull/5717#issuecomment-2513804888 Most of the commits are from other PRs that have been approved. There is no real easy way, as I could not rebase, given this was developed several months ago. The easiest way to re

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

tengqm commented on PR #5717: URL: https://github.com/apache/gravitino/pull/5717#issuecomment-2513733049 @justinmclean Is there a way to split this PR to smaller ones for ease of review and change management? A PR with 208 commits, 2800+ lines of change is too big to be reviewed effectively

[PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

justinmclean opened a new pull request, #5717: URL: https://github.com/apache/gravitino/pull/5717 ### What changes were proposed in this pull request? Add the ability to create a table via the Gravitino CLI. ### Why are the changes needed? so we can create tables via the