Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
shaofengshi merged PR #5352: URL: https://github.com/apache/gravitino/pull/5352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@grav

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean commented on PR #5352: URL: https://github.com/apache/gravitino/pull/5352#issuecomment-2510263564 @shaofengshi all fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-12-01 Thread via GitHub
justinmclean commented on code in PR #5352: URL: https://github.com/apache/gravitino/pull/5352#discussion_r1865023962 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/SetTopicProperty.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-11-29 Thread via GitHub
shaofengshi commented on code in PR #5352: URL: https://github.com/apache/gravitino/pull/5352#discussion_r1863206534 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTopicProperties.java: ## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-11-29 Thread via GitHub
shaofengshi commented on code in PR #5352: URL: https://github.com/apache/gravitino/pull/5352#discussion_r1863203555 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/RemoveTopicProperty.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-11-29 Thread via GitHub
shaofengshi commented on code in PR #5352: URL: https://github.com/apache/gravitino/pull/5352#discussion_r1863204271 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/SetTopicProperty.java: ## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-11-28 Thread via GitHub
justinmclean commented on PR #5352: URL: https://github.com/apache/gravitino/pull/5352#issuecomment-2507102231 @shaofengshi this is ready to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-11-12 Thread via GitHub
justinmclean commented on PR #5352: URL: https://github.com/apache/gravitino/pull/5352#issuecomment-2472475974 @shaofengshi once the first topic PR and the owner PR is merged this is ready to review or you could just review the topic property parts -- This is an automated message from the

[PR] [#5294] Add topic property command to Gravitino CLI [gravitino]

2024-10-29 Thread via GitHub
justinmclean opened a new pull request, #5352: URL: https://github.com/apache/gravitino/pull/5352 ### What changes were proposed in this pull request? Add topic property command to Gravitino CLI ### Why are the changes needed? To expand Gravitino CLI. Fix: #5294