Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-22 Thread via GitHub
FANNG1 commented on PR #5208: URL: https://github.com/apache/gravitino/pull/5208#issuecomment-2430751384 @lsyulong thanks for your work! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-22 Thread via GitHub
FANNG1 merged PR #5208: URL: https://github.com/apache/gravitino/pull/5208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-22 Thread via GitHub
lsyulong commented on PR #5208: URL: https://github.com/apache/gravitino/pull/5208#issuecomment-2429179888 > @lsyulong, thanks for your PR. There are similar problems in `JdbcCatalog`. Would you like to fix them together in this PR? https://github.com/apache/gravitino/blob/main/catalogs/cat

Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-22 Thread via GitHub
FANNG1 commented on PR #5208: URL: https://github.com/apache/gravitino/pull/5208#issuecomment-2428699400 @lsyulong, thanks for your PR. There are similar problems in `JdbcCatalog`. Would you like to fix them together in this PR? https://github.com/apache/gravitino/blob/main/catalogs/cata

Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-21 Thread via GitHub
lsyulong commented on code in PR #5208: URL: https://github.com/apache/gravitino/pull/5208#discussion_r1810036724 ## catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogOperations.java: ## @@ -589,6 +590,6 @@ public void

Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-21 Thread via GitHub
lsyulong commented on code in PR #5208: URL: https://github.com/apache/gravitino/pull/5208#discussion_r1810030361 ## catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogOperations.java: ## @@ -589,6 +590,6 @@ public void

Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-21 Thread via GitHub
lsyulong commented on code in PR #5208: URL: https://github.com/apache/gravitino/pull/5208#discussion_r1810030361 ## catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogOperations.java: ## @@ -589,6 +590,6 @@ public void

Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-21 Thread via GitHub
FANNG1 commented on code in PR #5208: URL: https://github.com/apache/gravitino/pull/5208#discussion_r1810025808 ## catalogs/catalog-lakehouse-iceberg/src/main/java/org/apache/gravitino/catalog/lakehouse/iceberg/IcebergCatalogOperations.java: ## @@ -589,6 +590,6 @@ public void te

Re: [PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-21 Thread via GitHub
jerryshao commented on PR #5208: URL: https://github.com/apache/gravitino/pull/5208#issuecomment-2428188205 @FANNG1 please help to review this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [#5172]fix bug:Iceberg catalog audit user is not correct [gravitino]

2024-10-21 Thread via GitHub
lsyulong opened a new pull request, #5208: URL: https://github.com/apache/gravitino/pull/5208 ### What changes were proposed in this pull request? [#5172]fix bug:Iceberg catalog audit user is not correct ### Why are the changes needed? Fix: #5172 ### Does this