jerryshao merged PR #4995:
URL: https://github.com/apache/gravitino/pull/4995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1800306465
##
common/src/main/java/org/apache/gravitino/credential/Credential.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1800302418
##
api/src/main/java/org/apache/gravitino/credential/CredentialConstants.java:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
justinmclean commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799749768
##
common/src/main/java/org/apache/gravitino/credential/Credential.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
jerryshao commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799605313
##
api/src/main/java/org/apache/gravitino/credential/CredentialConstants.java:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
jerryshao commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799593989
##
api/src/main/java/org/apache/gravitino/credential/CredentialConstants.java:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
FANNG1 commented on PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#issuecomment-2410737834
@jerryshao comments are addressed, please help to review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799165801
##
core/src/main/java/org/apache/gravitino/credential/LocationContext.java:
##
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799165166
##
common/src/main/java/org/apache/gravitino/credential/Credential.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799120113
##
common/src/main/java/org/apache/gravitino/credential/Credential.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
jerryshao commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799104878
##
common/src/main/java/org/apache/gravitino/credential/Credential.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799096933
##
common/src/main/java/org/apache/gravitino/credential/Credential.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
jerryshao commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1798941527
##
core/src/main/java/org/apache/gravitino/credential/Context.java:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
jerryshao commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1798925186
##
common/src/main/java/org/apache/gravitino/credential/Credential.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
jerryshao commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1798876861
##
common/build.gradle.kts:
##
@@ -28,6 +28,7 @@ plugins {
dependencies {
implementation(project(":api"))
+ implementation(project(":catalogs:catalog-common"
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1798910543
##
common/build.gradle.kts:
##
@@ -28,6 +28,7 @@ plugins {
dependencies {
implementation(project(":api"))
+ implementation(project(":catalogs:catalog-common"))
jerryshao commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1798876861
##
common/build.gradle.kts:
##
@@ -28,6 +28,7 @@ plugins {
dependencies {
implementation(project(":api"))
+ implementation(project(":catalogs:catalog-common"
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1793044758
##
core/src/main/java/org/apache/gravitino/credential/CredentialProvider.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1793025519
##
common/src/main/java/org/apache/gravitino/credential/Credential.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1793025519
##
common/src/main/java/org/apache/gravitino/credential/Credential.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1793008835
##
common/src/main/java/org/apache/gravitino/credential/Credential.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1792998137
##
common/build.gradle.kts:
##
@@ -28,6 +28,7 @@ plugins {
dependencies {
implementation(project(":api"))
+ implementation(project(":catalogs:catalog-common"))
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1792973905
##
core/src/main/java/org/apache/gravitino/credential/CredentialProvider.java:
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1792973195
##
core/src/main/java/org/apache/gravitino/credential/CredentialProviderFactory.java:
##
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
FANNG1 commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1792961793
##
common/src/main/java/org/apache/gravitino/credential/Credential.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
jerryshao commented on code in PR #4995:
URL: https://github.com/apache/gravitino/pull/4995#discussion_r1792745595
##
common/src/main/java/org/apache/gravitino/credential/Credential.java:
##
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
FANNG1 opened a new pull request, #4995:
URL: https://github.com/apache/gravitino/pull/4995
### What changes were proposed in this pull request?
support credential vending framework
### Why are the changes needed?
Fix: #4992
### Does this PR introduce _any_ user-faci
27 matches
Mail list logo
