Abyss-lord commented on PR #6037:
URL: https://github.com/apache/gravitino/pull/6037#issuecomment-2566823600
Hi @justinmclean @tengqm ,I’ve finished updating the code. Please take a
look at the PR again when you have time.
--
This is an automated message from the Apache Git Service.
To re
tengqm commented on code in PR #6057:
URL: https://github.com/apache/gravitino/pull/6057#discussion_r1900312736
##
core/src/main/java/org/apache/gravitino/storage/relational/service/MetadataObjectService.java:
##
@@ -52,7 +52,7 @@ public static long getMetadataObjectId(
L
cool9850311 commented on issue #5937:
URL: https://github.com/apache/gravitino/issues/5937#issuecomment-2566812130
working on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
cool9850311 opened a new pull request, #6057:
URL: https://github.com/apache/gravitino/pull/6057
What changes were proposed in this pull request?
use fullName instead of names.get(0) when get role Why are the changes
needed?
Fix: #6004
Does this PR introduce any user-facing chan
This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 44f5ab30e [#6027] improvement(CLI): fix Gravitin
justinmclean closed issue #6027: [Bug report] Gravitino CLI get wrong
catalogName when set metalake name by --name option
URL: https://github.com/apache/gravitino/issues/6027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
justinmclean closed issue #6027: [Bug report] Gravitino CLI get wrong
catalogName when set metalake name by --name option
URL: https://github.com/apache/gravitino/issues/6027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
justinmclean merged PR #6048:
URL: https://github.com/apache/gravitino/pull/6048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gra
justinmclean commented on code in PR #6037:
URL: https://github.com/apache/gravitino/pull/6037#discussion_r1900290235
##
clients/cli/src/main/java/org/apache/gravitino/cli/commands/TagEntity.java:
##
@@ -94,6 +97,9 @@ public void handle() {
exitWithError(ErrorMessages.UNK
justinmclean commented on code in PR #6037:
URL: https://github.com/apache/gravitino/pull/6037#discussion_r1900290027
##
clients/cli/src/main/java/org/apache/gravitino/cli/commands/TagEntity.java:
##
@@ -94,6 +97,9 @@ public void handle() {
exitWithError(ErrorMessages.UNK
VigneshSK17 commented on PR #6047:
URL: https://github.com/apache/gravitino/pull/6047#issuecomment-2566682360
Added `clients/cli/src/main/resources/model_help.txt` and updated
`docs/cli.md` with Model. Let me know if any other documentation needs to be
updated.
Also happy new year ev
Abyss-lord commented on code in PR #6053:
URL: https://github.com/apache/gravitino/pull/6053#discussion_r1900160991
##
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListModel.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
sunxiaojian commented on code in PR #5914:
URL: https://github.com/apache/gravitino/pull/5914#discussion_r1900156335
##
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/iceberg/IcebergPropertiesConverter.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the A
yuqi1129 commented on PR #5997:
URL: https://github.com/apache/gravitino/pull/5997#issuecomment-2566488260
@FANNG1 @jerryshao
Please help to review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
yuqi1129 commented on PR #5974:
URL: https://github.com/apache/gravitino/pull/5974#issuecomment-2566487916
@jerryshao @FANNG1
Test is done, please help to review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tengqm commented on PR #6029:
URL: https://github.com/apache/gravitino/pull/6029#issuecomment-2566467868
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
orenccl commented on PR #6001:
URL: https://github.com/apache/gravitino/pull/6001#issuecomment-2566452554
Hi @jerryshao,
I've checked `client-python`, only `types.py` needs to be corrected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
orenccl commented on PR #6001:
URL: https://github.com/apache/gravitino/pull/6001#issuecomment-2566451101
Thanks.
Actually, this code uses forward references on purpose, so I will leave it
as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Aireed closed issue #6056: [Bug report] spark can't access table created by
spark client
URL: https://github.com/apache/gravitino/issues/6056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Aireed opened a new issue, #6056:
URL: https://github.com/apache/gravitino/issues/6056
### Version
main branch
### Describe what's wrong
1. configure hive_catalog stored in gravitino in spark_default.conf
2. use hive_catalog which under the metalake
3. use {databa
FANNG1 commented on code in PR #6029:
URL: https://github.com/apache/gravitino/pull/6029#discussion_r1900100606
##
bundles/aliyun/src/main/java/org/apache/gravitino/oss/credential/OSSTokenProvider.java:
##
@@ -166,6 +167,8 @@ private String createPolicy(Set readLocations,
Set w
tengqm commented on code in PR #6029:
URL: https://github.com/apache/gravitino/pull/6029#discussion_r1900076440
##
bundles/aliyun/src/main/java/org/apache/gravitino/oss/credential/OSSTokenProvider.java:
##
@@ -166,6 +167,8 @@ private String createPolicy(Set readLocations,
Set w
FANNG1 commented on PR #6033:
URL: https://github.com/apache/gravitino/pull/6033#issuecomment-2566384543
@jerryshao @yuqi1129 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
tengqm commented on code in PR #6029:
URL: https://github.com/apache/gravitino/pull/6029#discussion_r1900075551
##
bundles/aliyun/src/main/java/org/apache/gravitino/oss/credential/OSSTokenProvider.java:
##
@@ -150,13 +151,13 @@ private String createPolicy(Set readLocations,
Set
FANNG1 commented on PR #6029:
URL: https://github.com/apache/gravitino/pull/6029#issuecomment-2566381150
it's ready to review now, @tengqm @sunxiaojian @jerryshao @yuqi1129 PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tengqm commented on PR #6051:
URL: https://github.com/apache/gravitino/pull/6051#issuecomment-2566357742
/lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
tengqm commented on code in PR #6052:
URL: https://github.com/apache/gravitino/pull/6052#discussion_r1900049193
##
docs/manage-model-metadata-using-gravitino.md:
##
@@ -0,0 +1,637 @@
+---
+title: Manage model metadata using Gravitino
+slug: /manage-model-metadata-using-gravitino
FANNG1 opened a new issue, #6055:
URL: https://github.com/apache/gravitino/issues/6055
### What would you like to be improved?
OSS fsspec needs extra permission like `getBucketInfo`
### How should we improve?
_No response_
--
This is an automated message from the Apach
FANNG1 commented on code in PR #6029:
URL: https://github.com/apache/gravitino/pull/6029#discussion_r1900054747
##
bundles/aliyun/src/main/java/org/apache/gravitino/oss/credential/OSSTokenProvider.java:
##
@@ -166,6 +168,7 @@ private String createPolicy(Set readLocations,
Set w
jerqi commented on code in PR #6045:
URL: https://github.com/apache/gravitino/pull/6045#discussion_r1900053828
##
core/src/main/java/org/apache/gravitino/hook/CatalogHookDispatcher.java:
##
@@ -126,8 +126,20 @@ public boolean dropCatalog(NameIdentifier ident) {
@Override
p
tengqm commented on code in PR #6053:
URL: https://github.com/apache/gravitino/pull/6053#discussion_r1900045029
##
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListModel.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
tengqm commented on code in PR #6045:
URL: https://github.com/apache/gravitino/pull/6045#discussion_r1900043958
##
core/src/main/java/org/apache/gravitino/hook/CatalogHookDispatcher.java:
##
@@ -126,8 +126,20 @@ public boolean dropCatalog(NameIdentifier ident) {
@Override
yuqi1129 opened a new issue, #6054:
URL: https://github.com/apache/gravitino/issues/6054
### What would you like to be improved?
py4j.protocol.Py4JJavaError: An error occurred while calling o69.csv.
: java.io.IOException: Error getting StorageObject: : bucket:
strato-iceberg, objec
Abyss-lord commented on PR #6053:
URL: https://github.com/apache/gravitino/pull/6053#issuecomment-2566257210
> I don't think we need a new get command, just use the existing list and
detail commands.
Thank you Justin, I'll change the get command to details.
--
This is an automated
justinmclean commented on PR #6053:
URL: https://github.com/apache/gravitino/pull/6053#issuecomment-2566255904
I don't think we need a new get command, just use the existing list and
detail commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
Abyss-lord commented on PR #6053:
URL: https://github.com/apache/gravitino/pull/6053#issuecomment-2566254073
Hi @justinmclean @tengqm @shaofengshi , could you please review this PR when
you have time? I’d really appreciate your feedback.
--
This is an automated message from the Apache
Abyss-lord opened a new pull request, #6053:
URL: https://github.com/apache/gravitino/pull/6053
### What changes were proposed in this pull request?
add get and list command to model.
- get: `gcli model get -m demo_metalake --name catalog.schema`, Displays
the name of the Mode
jerryshao commented on code in PR #6051:
URL: https://github.com/apache/gravitino/pull/6051#discussion_r1899979115
##
catalogs/catalog-model/src/test/java/org/apache/gravtitino/catalog/model/integration/test/ModelCatalogOperationsIT.java:
##
@@ -0,0 +1,371 @@
+/*
+ * Licensed to
mchades commented on code in PR #6051:
URL: https://github.com/apache/gravitino/pull/6051#discussion_r1899976124
##
catalogs/catalog-model/src/test/java/org/apache/gravtitino/catalog/model/integration/test/ModelCatalogOperationsIT.java:
##
@@ -0,0 +1,371 @@
+/*
+ * Licensed to t
jerryshao opened a new pull request, #6052:
URL: https://github.com/apache/gravitino/pull/6052
### What changes were proposed in this pull request?
Add the docs for model management.
### Why are the changes needed?
This is part of work to support model management in Gravi
40 matches
Mail list logo
