Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

2024-12-28 Thread via GitHub
unknowntpo commented on code in PR #5905: URL: https://github.com/apache/gravitino/pull/5905#discussion_r1899073067 ## clients/filesystem-fuse/src/fuse_api_handle.rs: ## @@ -30,10 +30,174 @@ use fuse3::{Errno, FileType, Inode, SetAttr, Timestamp}; use futures_util::stream; use

Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

2024-12-28 Thread via GitHub
unknowntpo commented on code in PR #5905: URL: https://github.com/apache/gravitino/pull/5905#discussion_r1899071512 ## clients/filesystem-fuse/src/fuse_api_handle.rs: ## @@ -30,10 +30,174 @@ use fuse3::{Errno, FileType, Inode, SetAttr, Timestamp}; use futures_util::stream; use

Re: [PR] [#5873] feat(gvfs-fuse): add debug log for FuseApiHandle [gravitino]

2024-12-28 Thread via GitHub
unknowntpo commented on code in PR #5905: URL: https://github.com/apache/gravitino/pull/5905#discussion_r1899071079 ## clients/filesystem-fuse/src/fuse_api_handle.rs: ## @@ -30,10 +30,174 @@ use fuse3::{Errno, FileType, Inode, SetAttr, Timestamp}; use futures_util::stream; use

Re: [I] [Improvement] Setting the same tags multiple times in the Gravitino CLi gives unexpected output [gravitino]

2024-12-28 Thread via GitHub
Abyss-lord commented on issue #6030: URL: https://github.com/apache/gravitino/issues/6030#issuecomment-2564617781 @justinmclean I would like to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[I] [Improvement] Setting the same tags multiple times in the Gravitino CLi gives unexpected output [gravitino]

2024-12-28 Thread via GitHub
Abyss-lord opened a new issue, #6030: URL: https://github.com/apache/gravitino/issues/6030 ### What would you like to be improved? Running the command `gcli tag set --metalake metalake_demo --name catalog --tagB --tagC` multiple times gives unexpected output. ![image](https://git

Re: [PR] [#5831] fix(CLI): Fix CLi gives unexpected output when input tag set command [gravitino]

2024-12-28 Thread via GitHub
Abyss-lord commented on PR #5897: URL: https://github.com/apache/gravitino/pull/5897#issuecomment-2564616690 Hi @justinmclean @shaofengshi , I’ve finished updating the code. Please take a look at the PR again when you have time. -- This is an automated message from the Apache Git Service.

Re: [PR] fix: use compose v2 syntax [gravitino-playground]

2024-12-28 Thread via GitHub
unknowntpo commented on PR #79: URL: https://github.com/apache/gravitino-playground/pull/79#issuecomment-2564603598 LGTM, ping @xunliu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] [Improvement] Add Support for Inspecting Tables in Datalake Formats like Iceberg [gravitino]

2024-12-28 Thread via GitHub
FANNG1 commented on issue #4798: URL: https://github.com/apache/gravitino/issues/4798#issuecomment-2564600204 I'm afraid I can't provide a timeline currently, it depends on the requirements of the community, could you provide your scenarios? -- This is an automated message from the Apach

Re: [PR] [#5982] feat (gvfs-fuse): Implement Gravitino fileset file system [gravitino]

2024-12-28 Thread via GitHub
FANNG1 commented on code in PR #5984: URL: https://github.com/apache/gravitino/pull/5984#discussion_r1899053370 ## clients/filesystem-fuse/src/gvfs_fileset_fs.rs: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor lice

Re: [PR] [#5982] feat (gvfs-fuse): Implement Gravitino fileset file system [gravitino]

2024-12-28 Thread via GitHub
FANNG1 commented on code in PR #5984: URL: https://github.com/apache/gravitino/pull/5984#discussion_r1899053172 ## clients/filesystem-fuse/src/gvfs_fileset_fs.rs: ## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor lice

Re: [I] [Bug report] Gravitino CLI get wrong catalogName when set metalake name by --name option [gravitino]

2024-12-28 Thread via GitHub
Abyss-lord commented on issue #6027: URL: https://github.com/apache/gravitino/issues/6027#issuecomment-2564587856 @justinmclean , I would like to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2024-12-28 Thread via GitHub
FANNG1 commented on code in PR #5974: URL: https://github.com/apache/gravitino/pull/5974#discussion_r1899046771 ## bundles/aliyun/src/main/java/org/apache/gravitino/oss/fs/OSSSessionCredentialProvider.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [#5973] feat(hadoop-catalog): Support using dynamic credential when using fileset with cloud storage [gravitino]

2024-12-28 Thread via GitHub
FANNG1 commented on PR #5974: URL: https://github.com/apache/gravitino/pull/5974#issuecomment-2564574655 Do you plan to support the static credential like `S3SecretKey` and some storage properties not included in the credential like `s3-region` in the new PR? -- This is an automated mess

Re: [PR] [#5902] feat: Add tag failure event to Gravitino server [gravitino]

2024-12-28 Thread via GitHub
FANNG1 commented on PR #5944: URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2564572784 > @FANNG1 I run the Frontend IT test successfully in local, but it does not pass here 2 times, and it says connection timeout, do I need to change anything? no, it's network failur

Re: [PR] fix: use compose v2 syntax [gravitino-playground]

2024-12-28 Thread via GitHub
jhchee commented on PR #79: URL: https://github.com/apache/gravitino-playground/pull/79#issuecomment-2564387168 Thanks @kahnwong, I can attest your change is working! However, I'm not a contributor of this project, so will likely need other to approve this PR. Gentle ping @unknowntpo if

Re: [I] [Improvement] Add Support for Inspecting Tables in Datalake Formats like Iceberg [gravitino]

2024-12-28 Thread via GitHub
dataageek commented on issue #4798: URL: https://github.com/apache/gravitino/issues/4798#issuecomment-2564375370 Thank you for the efforts on the project! I'm following up on this issue to check if there have been any recent updates or progress. Is there an estimated timeline or plan for im

Re: [PR] [#5902] feat: Add tag failure event to Gravitino server [gravitino]

2024-12-28 Thread via GitHub
cool9850311 commented on PR #5944: URL: https://github.com/apache/gravitino/pull/5944#issuecomment-2564371371 @FANNG1 I run the Frontend IT test successfully in local, do I need to change anything? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] fix: use compose v2 syntax [gravitino-playground]

2024-12-28 Thread via GitHub
kahnwong commented on PR #79: URL: https://github.com/apache/gravitino-playground/pull/79#issuecomment-2564369975 @jhchee rebased the pr and apply compose syntax migration. Please kindly review this PR. -- This is an automated message from the Apache Git Service. To respond to the messag

[PR] [SIP] Fix OSS token privilege [gravitino]

2024-12-28 Thread via GitHub
FANNG1 opened a new pull request, #6029: URL: https://github.com/apache/gravitino/pull/6029 ### What changes were proposed in this pull request? (Please outline the changes and how this PR fixes the issue.) ### Why are the changes needed? (Please clarify why the c

Re: [PR] fix: use compose v2 syntax [gravitino-playground]

2024-12-28 Thread via GitHub
kahnwong commented on PR #79: URL: https://github.com/apache/gravitino-playground/pull/79#issuecomment-2564348525 > Hihi @kahnwong Are you still working on this? This will be QoL improvement for users that use docker compose v2. I'm still working on this. I noticed from the latest co

Re: [PR] [#6024] feat(iceberg): refactor Iceberg credential code to reuse credential component in Gravitino server [gravitino]

2024-12-28 Thread via GitHub
FANNG1 commented on PR #6021: URL: https://github.com/apache/gravitino/pull/6021#issuecomment-2564346940 > Seems like there's some conflicts need to be resolved. updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [#5985] improvement(CLI): Fix role command that supports handling multiple values [gravitino]

2024-12-28 Thread via GitHub
justinmclean merged PR #5988: URL: https://github.com/apache/gravitino/pull/5988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [PR] [#6014] refactor: CLI output methods for no data hints [gravitino]

2024-12-28 Thread via GitHub
justinmclean merged PR #6015: URL: https://github.com/apache/gravitino/pull/6015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

(gravitino) branch main updated: [#6014] refactor: CLI output methods for no data hints (#6015)

2024-12-28 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 69e93f9631 [#6014] refactor: CLI output methods

Re: [I] [Improvement] The role command supports handling multiple values simultaneously. [gravitino]

2024-12-28 Thread via GitHub
justinmclean closed issue #5985: [Improvement] The role command supports handling multiple values simultaneously. URL: https://github.com/apache/gravitino/issues/5985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

(gravitino) branch main updated: [#5985] improvement(CLI): Fix role command that supports handling multiple values (#5988)

2024-12-28 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new f6e201bfce [#5985] improvement(CLI): Fix role co

Re: [I] [Improvement] The role command supports handling multiple values simultaneously. [gravitino]

2024-12-28 Thread via GitHub
justinmclean closed issue #5985: [Improvement] The role command supports handling multiple values simultaneously. URL: https://github.com/apache/gravitino/issues/5985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [#5965] subtask(web): ML model support for web UI [gravitino]

2024-12-28 Thread via GitHub
orenccl commented on code in PR #6025: URL: https://github.com/apache/gravitino/pull/6025#discussion_r1898537514 ## web/web/src/app/metalakes/metalake/MetalakeView.js: ## @@ -124,7 +140,9 @@ const MetalakeView = () => { routeParams.schema ? `{{${routeParams.sche

Re: [PR] [#5965] subtask(web): ML model support for web UI [gravitino]

2024-12-28 Thread via GitHub
orenccl commented on code in PR #6025: URL: https://github.com/apache/gravitino/pull/6025#discussion_r1898532044 ## docs/webui.md: ## @@ -527,19 +575,137 @@ Displays a confirmation dialog, clicking on the `DROP` button drops this fileset ![delete-fileset](./assets/webui/delete

Re: [PR] [#6024] feat(iceberg): refactor Iceberg credential code to reuse credential component in Gravitino server [gravitino]

2024-12-28 Thread via GitHub
jerryshao commented on PR #6021: URL: https://github.com/apache/gravitino/pull/6021#issuecomment-2564274319 Seems like there's some conflicts need to be resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [#5965] subtask(web): ML model support for web UI [gravitino]

2024-12-28 Thread via GitHub
orenccl commented on code in PR #6025: URL: https://github.com/apache/gravitino/pull/6025#discussion_r1898531624 ## docs/webui.md: ## @@ -527,19 +575,137 @@ Displays a confirmation dialog, clicking on the `DROP` button drops this fileset ![delete-fileset](./assets/webui/delete

(gravitino) branch main updated: [#5989] The credential type of ADLSTokenCredentialProvider is not equal to the credential type of ADLSTokenCredential (#5990)

2024-12-28 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 486c042cb2 [#5989] The credential type of ADLSToke

Re: [I] [Bug report] The credential type of ADLSTokenCredentialProvider is not equal to the credential type of ADLSTokenCredential [gravitino]

2024-12-28 Thread via GitHub
jerryshao closed issue #5989: [Bug report] The credential type of ADLSTokenCredentialProvider is not equal to the credential type of ADLSTokenCredential URL: https://github.com/apache/gravitino/issues/5989 -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [#5989] The credential type of ADLSTokenCredentialProvider is not equal to the credential type of ADLSTokenCredential [gravitino]

2024-12-28 Thread via GitHub
jerryshao merged PR #5990: URL: https://github.com/apache/gravitino/pull/5990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#5889] feat(client-python): Add model management Python API [gravitino]

2024-12-28 Thread via GitHub
jerryshao commented on code in PR #6009: URL: https://github.com/apache/gravitino/pull/6009#discussion_r1898876975 ## clients/client-python/gravitino/namespace.py: ## @@ -34,13 +33,13 @@ def __init__(self, levels: List[str]): self._levels = levels def to_json(sel