Re: [I] [Bug report] Failed to drop clean PG catalog due to "public" schema. [gravitino]

2024-12-05 Thread via GitHub
mchades commented on issue #5780: URL: https://github.com/apache/gravitino/issues/5780#issuecomment-2522413351 The `public` schema is intentionally preserved, see #2314 I believe the user should be able to drop the PG catalog once there is only a public schema in it, especially since

Re: [PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5783: URL: https://github.com/apache/gravitino/pull/5783#discussion_r1872726075 ## docs/cli.md: ## @@ -688,10 +694,23 @@ gcli group grant --group groupA --role admin ``` Remove a role from a group + ```bash gcli group revoke --gro

Re: [PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5783: URL: https://github.com/apache/gravitino/pull/5783#discussion_r1872726075 ## docs/cli.md: ## @@ -688,10 +694,23 @@ gcli group grant --group groupA --role admin ``` Remove a role from a group + ```bash gcli group revoke --gro

Re: [PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5783: URL: https://github.com/apache/gravitino/pull/5783#discussion_r1872726075 ## docs/cli.md: ## @@ -688,10 +694,23 @@ gcli group grant --group groupA --role admin ``` Remove a role from a group + ```bash gcli group revoke --gro

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

2024-12-05 Thread via GitHub
jerryshao commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1872724415 ## rfc/rfc-2/Entity-key-encoding-for-kv-store-deprecated.md: ## @@ -17,13 +17,19 @@ under the License. --> -# RFC-1: Entity Key Encoding design for KV store +

[PR] [#5775] feat(auth): Chain authorization plugin [gravitino]

2024-12-05 Thread via GitHub
xunliu opened a new pull request, #5786: URL: https://github.com/apache/gravitino/pull/5786 ### What changes were proposed in this pull request? 1. Add Chain auth plugin module 2. Add AuthorizationPropertiesMeta 3. Add ITs ### Why are the changes needed? Fix: #5775

[PR] [#5754] [Improvement] Fix rewrite_config.py with the correct shebang line [gravitino]

2024-12-05 Thread via GitHub
liuchunhao opened a new pull request, #5785: URL: https://github.com/apache/gravitino/pull/5785 ### What changes were proposed in this pull request? modified: - __dev/docker/iceberg-rest-server/rewrite_config.py__ Correct the shebang line to specify the correct sh

Re: [PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
jerqi commented on code in PR #5783: URL: https://github.com/apache/gravitino/pull/5783#discussion_r1872713397 ## docs/cli.md: ## @@ -688,10 +694,23 @@ gcli group grant --group groupA --role admin ``` Remove a role from a group + ```bash gcli group revoke --group grou

Re: [I] [Improvement] Modify the ColumnSize of JdbcTypeBean to be of type int. [gravitino]

2024-12-05 Thread via GitHub
sunxiaojian commented on issue #5784: URL: https://github.com/apache/gravitino/issues/5784#issuecomment-2522281208 > may I assign this issue to you? @sunxiaojian @mchades ok, please assign it to me -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5783: URL: https://github.com/apache/gravitino/pull/5783#discussion_r1872693530 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/GrantPrivilegesToRole.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5783: URL: https://github.com/apache/gravitino/pull/5783#discussion_r1872692124 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/RevokePrivilegesFromRole.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5783: URL: https://github.com/apache/gravitino/pull/5783#discussion_r1872688143 ## docs/cli.md: ## @@ -688,10 +694,23 @@ gcli group grant --group groupA --role admin ``` Remove a role from a group + ```bash gcli group revoke --gro

Re: [PR] [#5659] improvement(catalog-mysql) : support load MySQL BOOLEAN data in Trino [gravitino]

2024-12-05 Thread via GitHub
mchades commented on code in PR #5773: URL: https://github.com/apache/gravitino/pull/5773#discussion_r1872691273 ## catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/converter/MysqlTypeConverter.java: ## @@ -43,6 +45,12 @@ public class MysqlTypeConvert

Re: [I] [Improvement] Modify the ColumnSize of JdbcTypeBean to be of type int. [gravitino]

2024-12-05 Thread via GitHub
mchades commented on issue #5784: URL: https://github.com/apache/gravitino/issues/5784#issuecomment-2522272948 may I assign this issue to you? @sunxiaojian -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5783: URL: https://github.com/apache/gravitino/pull/5783#discussion_r1872688143 ## docs/cli.md: ## @@ -688,10 +694,23 @@ gcli group grant --group groupA --role admin ``` Remove a role from a group + ```bash gcli group revoke --gro

Re: [PR] [#5659] improvement(catalog-mysql) : support load MySQL BOOLEAN data in Trino [gravitino]

2024-12-05 Thread via GitHub
sunxiaojian commented on code in PR #5773: URL: https://github.com/apache/gravitino/pull/5773#discussion_r1872678791 ## catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/converter/MysqlTypeConverter.java: ## @@ -43,6 +45,12 @@ public class MysqlTypeCon

Re: [PR] [#5659] improvement(catalog-mysql) : support load MySQL BOOLEAN data in Trino [gravitino]

2024-12-05 Thread via GitHub
sunxiaojian commented on code in PR #5773: URL: https://github.com/apache/gravitino/pull/5773#discussion_r1872678791 ## catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/converter/MysqlTypeConverter.java: ## @@ -43,6 +45,12 @@ public class MysqlTypeCon

Re: [PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
shaofengshi commented on code in PR #5783: URL: https://github.com/apache/gravitino/pull/5783#discussion_r1872669335 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/GrantPrivilegesToRole.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
shaofengshi commented on code in PR #5783: URL: https://github.com/apache/gravitino/pull/5783#discussion_r1872668929 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/RevokePrivilegesFromRole.java: ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
shaofengshi commented on code in PR #5783: URL: https://github.com/apache/gravitino/pull/5783#discussion_r1872668102 ## docs/cli.md: ## @@ -688,10 +694,23 @@ gcli group grant --group groupA --role admin ``` Remove a role from a group + ```bash gcli group revoke --grou

(gravitino) branch main updated (99a999a1e -> 70838ef21)

2024-12-05 Thread shaofengshi
This is an automated email from the ASF dual-hosted git repository. shaofengshi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git from 99a999a1e [#5772] fix: missing param (#5776) add 70838ef21 [#5384] Support Kerberos authentication in the

Re: [PR] [#5384] Support Kerberos authentication in the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
shaofengshi merged PR #5766: URL: https://github.com/apache/gravitino/pull/5766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@grav

Re: [PR] [#5659] improvement(catalog-mysql) : support load MySQL BOOLEAN data in Trino [gravitino]

2024-12-05 Thread via GitHub
mchades commented on code in PR #5773: URL: https://github.com/apache/gravitino/pull/5773#discussion_r1872644624 ## catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/converter/MysqlTypeConverter.java: ## @@ -43,6 +45,12 @@ public class MysqlTypeConvert

Re: [PR] [#5760] fix(catalog): fix drop catalog error [gravitino]

2024-12-05 Thread via GitHub
mchades commented on code in PR #5761: URL: https://github.com/apache/gravitino/pull/5761#discussion_r1872640617 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -677,11 +678,42 @@ public boolean dropCatalog(NameIdentifier ident, boolean force)

Re: [PR] [#5760] fix(catalog): fix drop catalog error [gravitino]

2024-12-05 Thread via GitHub
mchades commented on code in PR #5761: URL: https://github.com/apache/gravitino/pull/5761#discussion_r1872639045 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -677,11 +678,42 @@ public boolean dropCatalog(NameIdentifier ident, boolean force)

Re: [PR] [#5760] fix(catalog): fix drop catalog error [gravitino]

2024-12-05 Thread via GitHub
mchades commented on code in PR #5761: URL: https://github.com/apache/gravitino/pull/5761#discussion_r1872629757 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -677,11 +678,42 @@ public boolean dropCatalog(NameIdentifier ident, boolean force)

Re: [PR] [#5622] feat(client): support credential client in Gravition java client [gravitino]

2024-12-05 Thread via GitHub
FANNG1 commented on code in PR #5753: URL: https://github.com/apache/gravitino/pull/5753#discussion_r1872625248 ## api/src/main/java/org/apache/gravitino/credential/GCSTokenCredential.java: ## @@ -33,35 +33,48 @@ public class GCSTokenCredential implements Credential { /** GCS

Re: [PR] [#5760] fix(catalog): fix drop catalog error [gravitino]

2024-12-05 Thread via GitHub
tengqm commented on code in PR #5761: URL: https://github.com/apache/gravitino/pull/5761#discussion_r1872625636 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -677,11 +678,42 @@ public boolean dropCatalog(NameIdentifier ident, boolean force)

Re: [PR] [#5760] fix(catalog): fix drop catalog error [gravitino]

2024-12-05 Thread via GitHub
tengqm commented on code in PR #5761: URL: https://github.com/apache/gravitino/pull/5761#discussion_r1872619030 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -677,11 +678,42 @@ public boolean dropCatalog(NameIdentifier ident, boolean force)

Re: [PR] [#5760] fix(catalog): fix drop catalog error [gravitino]

2024-12-05 Thread via GitHub
mchades commented on code in PR #5761: URL: https://github.com/apache/gravitino/pull/5761#discussion_r1872616693 ## catalogs/catalog-jdbc-mysql/src/test/java/org/apache/gravitino/catalog/mysql/integration/test/CatalogMysqlIT.java: ## @@ -196,10 +197,10 @@ private void createCata

Re: [PR] [#5447][#5720][#5727] create topic, disable create table for hudi, enable schema properties and comment for partial paimon [gravitino]

2024-12-05 Thread via GitHub
tengqm commented on PR #5771: URL: https://github.com/apache/gravitino/pull/5771#issuecomment-2522159127 lgtm again. thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#5760] fix(catalog): fix drop catalog error [gravitino]

2024-12-05 Thread via GitHub
mchades commented on code in PR #5761: URL: https://github.com/apache/gravitino/pull/5761#discussion_r1872615211 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -677,11 +678,42 @@ public boolean dropCatalog(NameIdentifier ident, boolean force)

Re: [PR] [#5760] fix(catalog): fix drop catalog error [gravitino]

2024-12-05 Thread via GitHub
mchades commented on code in PR #5761: URL: https://github.com/apache/gravitino/pull/5761#discussion_r1872614553 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -677,11 +678,42 @@ public boolean dropCatalog(NameIdentifier ident, boolean force)

Re: [PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on PR #5783: URL: https://github.com/apache/gravitino/pull/5783#issuecomment-2522114019 @shaofengshi ready to review when the CI is done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] [#5162] Add grant and revoke privileges to the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
justinmclean opened a new pull request, #5783: URL: https://github.com/apache/gravitino/pull/5783 ### What changes were proposed in this pull request? Add grant and revoke privileges to the Gravitino CLI. ### Why are the changes needed? To complete the role commands.

Re: [PR] [#5745] feat(CLI): Table format output for ListCatalogs command [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5759: URL: https://github.com/apache/gravitino/pull/5759#discussion_r1872546746 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -201,7 +201,7 @@ private void handleCatalogCommand() { String outputF

Re: [PR] [#5745] feat(CLI): Table format output for ListCatalogs command [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5759: URL: https://github.com/apache/gravitino/pull/5759#discussion_r1872546746 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -201,7 +201,7 @@ private void handleCatalogCommand() { String outputF

Re: [I] [EPIC] Support web ui for creating table [gravitino]

2024-12-05 Thread via GitHub
orenccl closed issue #5449: [EPIC] Support web ui for creating table URL: https://github.com/apache/gravitino/issues/5449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] [Subtask] Support for nested table column types [gravitino]

2024-12-05 Thread via GitHub
orenccl commented on issue #5708: URL: https://github.com/apache/gravitino/issues/5708#issuecomment-2522086691 Closed because there are currently no plans to do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [Subtask] Support for nested table column types [gravitino]

2024-12-05 Thread via GitHub
orenccl closed issue #5708: [Subtask] Support for nested table column types URL: https://github.com/apache/gravitino/issues/5708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#5447][#5720][#5727] create topic, disable create table for hudi, enable schema properties and comment for partial paimon [gravitino]

2024-12-05 Thread via GitHub
LauraXia123 commented on PR #5771: URL: https://github.com/apache/gravitino/pull/5771#issuecomment-2522077409 @tengqm @orenccl Thanks for your time, I resolved all the issues based on the comment. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [#5768] improvement(CLI): improve formatted output [gravitino]

2024-12-05 Thread via GitHub
Abyss-lord commented on PR #5770: URL: https://github.com/apache/gravitino/pull/5770#issuecomment-2522066750 > hi @Abyss-lord Can you send your email address to me? I think to discuss with you. My email: [liu...@apache.org](mailto:liu...@apache.org), Tanks! hi, @xunliu I just sent you

[I] [Bug report] Failed to drop clean PG catalog due to "public" schema. [gravitino]

2024-12-05 Thread via GitHub
danhuawang opened a new issue, #5780: URL: https://github.com/apache/gravitino/issues/5780 ### Version main branch ### Describe what's wrong Failed to drop clean catalog due to PG "public" schema. https://github.com/user-attachments/assets/84503015-d935-4310-8209-

[PR] Rebase branch-gvfs-fuse-dev from main [gravitino]

2024-12-05 Thread via GitHub
diqiu50 opened a new pull request, #5781: URL: https://github.com/apache/gravitino/pull/5781 Rebase branch-gvfs-fuse-dev from main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [#5622] feat(client): support credential client in Gravition java client [gravitino]

2024-12-05 Thread via GitHub
FANNG1 commented on code in PR #5753: URL: https://github.com/apache/gravitino/pull/5753#discussion_r1872522623 ## api/src/main/java/org/apache/gravitino/credential/GCSTokenCredential.java: ## @@ -33,35 +33,48 @@ public class GCSTokenCredential implements Credential { /** GCS

Re: [PR] [#5745] feat(CLI): Table format output for ListCatalogs command [gravitino]

2024-12-05 Thread via GitHub
tengqm commented on code in PR #5759: URL: https://github.com/apache/gravitino/pull/5759#discussion_r1872530990 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -201,7 +201,7 @@ private void handleCatalogCommand() { String outputFormat

Re: [PR] [#5659] improvement(catalog-mysql) : support load MySQL BOOLEAN data in Trino [gravitino]

2024-12-05 Thread via GitHub
diqiu50 commented on PR #5773: URL: https://github.com/apache/gravitino/pull/5773#issuecomment-2522060695 Please enable the boolean type of the Trino integration test for mysql catalog. The data type of `f7` should be `BOOLEA` https://github.com/apache/gravitino/blob/99a999a1ea05cf8d

Re: [I] [Bug report] Failed to drop clean PG catalog due to "public" schema. [gravitino]

2024-12-05 Thread via GitHub
danhuawang commented on issue #5780: URL: https://github.com/apache/gravitino/issues/5780#issuecomment-2522058892 @mchades Can you help track this issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] [Subtask] support OSS secret key credential [gravitino]

2024-12-05 Thread via GitHub
sunxiaojian commented on issue #5778: URL: https://github.com/apache/gravitino/issues/5778#issuecomment-2522037620 @FANNG1 please assign it to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [#5745] feat(CLI): Table format output for ListCatalogs command [gravitino]

2024-12-05 Thread via GitHub
xunliu commented on code in PR #5759: URL: https://github.com/apache/gravitino/pull/5759#discussion_r1872479836 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -201,7 +201,7 @@ private void handleCatalogCommand() { String outputFormat

Re: [PR] [#5685] Refact the way CLI commands are called to catch more errors / be more future proof [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5688: URL: https://github.com/apache/gravitino/pull/5688#discussion_r1872478329 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -140,41 +145,78 @@ private void handleMetalakeCommand() { String url

Re: [PR] [#5685] Refact the way CLI commands are called to catch more errors / be more future proof [gravitino]

2024-12-05 Thread via GitHub
tengqm commented on code in PR #5688: URL: https://github.com/apache/gravitino/pull/5688#discussion_r1872471520 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -140,41 +145,78 @@ private void handleMetalakeCommand() { String url = getU

Re: [PR] [#5633] remove the key-value storage backend logic [gravitino]

2024-12-05 Thread via GitHub
tengqm commented on code in PR #5645: URL: https://github.com/apache/gravitino/pull/5645#discussion_r1872469955 ## rfc/rfc-2/Entity-key-encoding-for-kv-store-deprecated.md: ## @@ -17,13 +17,19 @@ under the License. --> -# RFC-1: Entity Key Encoding design for KV store +# R

Re: [PR] [#5622] feat(client): support credential client in Gravition java client [gravitino]

2024-12-05 Thread via GitHub
yuqi1129 commented on code in PR #5753: URL: https://github.com/apache/gravitino/pull/5753#discussion_r1872467080 ## api/src/main/java/org/apache/gravitino/credential/S3SecretKeyCredential.java: ## @@ -44,13 +45,17 @@ public class S3SecretKeyCredential implements Credential {

Re: [PR] [#5731]feat(auth-ranger): RangerAuthorizationHDFSPlugin supports Fileset authorization [gravitino]

2024-12-05 Thread via GitHub
theoryxu commented on code in PR #5733: URL: https://github.com/apache/gravitino/pull/5733#discussion_r1872465929 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHadoopSQLMetadataObject.java: ## @@ -35,7 +35,9 @@ public enum T

Re: [PR] [#5768] improvement(CLI): improve formatted output [gravitino]

2024-12-05 Thread via GitHub
xunliu commented on PR #5770: URL: https://github.com/apache/gravitino/pull/5770#issuecomment-2521919321 hi @Abyss-lord Can you send your email address to me? I think to discuss with you. My email: liu...@apache.org, Tanks! -- This is an automated message from the Apache Git Service

[I] [Improvement] add OSS support for IcebergRESTService docker image [gravitino]

2024-12-05 Thread via GitHub
FANNG1 opened a new issue, #5779: URL: https://github.com/apache/gravitino/issues/5779 ### What would you like to be improved? After #5625 , Iceberg REST server supports OSS token credentials, we'd better support it in docker image, works to do: 1. prepare bundle jars 2. add con

Re: [I] [Bug report] http client out of time [gravitino]

2024-12-05 Thread via GitHub
FANNG1 commented on issue #5765: URL: https://github.com/apache/gravitino/issues/5765#issuecomment-2521910834 `jstack` may provides some help to check which operation is obtaining the lock. BYW @mchades the default value of `client.pool-size` seems too small, is it expected? -- This is

Re: [I] [Improvement] HTTPClient.java has no unit tests/coverage [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on issue #2182: URL: https://github.com/apache/gravitino/issues/2182#issuecomment-2521907102 OK I think we can close this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] [Improvement] HTTPClient.java has no unit tests/coverage [gravitino]

2024-12-05 Thread via GitHub
justinmclean closed issue #2182: [Improvement] HTTPClient.java has no unit tests/coverage URL: https://github.com/apache/gravitino/issues/2182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] [#5622] feat(client): support credential client in Gravition java client [gravitino]

2024-12-05 Thread via GitHub
tengqm commented on code in PR #5753: URL: https://github.com/apache/gravitino/pull/5753#discussion_r1872437640 ## api/src/main/java/org/apache/gravitino/credential/GCSTokenCredential.java: ## @@ -33,35 +33,48 @@ public class GCSTokenCredential implements Credential { /** GCS

[PR] [SIP] Credential python client [gravitino]

2024-12-05 Thread via GitHub
FANNG1 opened a new pull request, #5777: URL: https://github.com/apache/gravitino/pull/5777 ### What changes were proposed in this pull request? (Please outline the changes and how this PR fixes the issue.) ### Why are the changes needed? (Please clarify why the c

Re: [PR] [#5585] fix(hadoop-catalog): Support multiple hadoop versions in runtime and add jars files into resources directory. [gravitino]

2024-12-05 Thread via GitHub
tengqm commented on code in PR #5758: URL: https://github.com/apache/gravitino/pull/5758#discussion_r1872410957 ## bundles/aws-bundle/src/main/java/org/apache/gravitino/s3/fs/S3FileSystemProvider.java: ## @@ -41,18 +42,49 @@ public class S3FileSystemProvider implements FileSyst

Re: [I] [Improvement] Fix rewrite_config.py with the correct shebang line [gravitino]

2024-12-05 Thread via GitHub
liuchunhao commented on issue #5754: URL: https://github.com/apache/gravitino/issues/5754#issuecomment-2521857977 Sure! I'd be happy to handle it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [#5745] feat(CLI): Table format output for ListCatalogs command [gravitino]

2024-12-05 Thread via GitHub
tengqm commented on code in PR #5759: URL: https://github.com/apache/gravitino/pull/5759#discussion_r1872405397 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -201,7 +201,7 @@ private void handleCatalogCommand() { String outputFormat

Re: [I] [Improvement] HTTPClient.java has no unit tests/coverage [gravitino]

2024-12-05 Thread via GitHub
chenyuan99 commented on issue #2182: URL: https://github.com/apache/gravitino/issues/2182#issuecomment-2521847540 @justinmclean agree, it already got coverage in https://github.com/apache/gravitino/blob/6990036d5637e4a70690cad2f198466ac3612d1b/clients/client-java/src/test/java/org/apache/gra

Re: [PR] [#5760] fix(catalog): fix drop catalog error [gravitino]

2024-12-05 Thread via GitHub
tengqm commented on code in PR #5761: URL: https://github.com/apache/gravitino/pull/5761#discussion_r1872401267 ## core/src/main/java/org/apache/gravitino/catalog/CatalogManager.java: ## @@ -677,11 +678,42 @@ public boolean dropCatalog(NameIdentifier ident, boolean force)

Re: [I] [Improvement] Fix rewrite_config.py with the correct shebang line [gravitino]

2024-12-05 Thread via GitHub
FANNG1 commented on issue #5754: URL: https://github.com/apache/gravitino/issues/5754#issuecomment-2521836679 Good catch! would you like to fix it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [#5760] fix(catalog): fix drop catalog error [gravitino]

2024-12-05 Thread via GitHub
tengqm commented on code in PR #5761: URL: https://github.com/apache/gravitino/pull/5761#discussion_r1872397682 ## catalogs/catalog-jdbc-mysql/src/test/java/org/apache/gravitino/catalog/mysql/integration/test/CatalogMysqlIT.java: ## @@ -196,10 +197,10 @@ private void createCatal

Re: [PR] [#5659] improvement(catalog-mysql) : support load MySQL BOOLEAN data in Trino [gravitino]

2024-12-05 Thread via GitHub
tengqm commented on code in PR #5773: URL: https://github.com/apache/gravitino/pull/5773#discussion_r1872395461 ## catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/converter/MysqlTypeConverter.java: ## @@ -43,6 +45,12 @@ public class MysqlTypeConverte

Re: [I] [Improvement] Remove all tags from an entity in the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on issue #5529: URL: https://github.com/apache/gravitino/issues/5529#issuecomment-2521662979 That code looks correct to me. I just tried this out, and it works fine for me. I think you may be creating the tags but not tagging the catalog? so in your code tags would be

(gravitino) branch main updated: [#5772] fix: missing param (#5776)

2024-12-05 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 99a999a1e [#5772] fix: missing param (#5776) 99

Re: [PR] [#5384] Support Kerberos authentication in the Gravitino CLI. [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on PR #5766: URL: https://github.com/apache/gravitino/pull/5766#issuecomment-2521571824 @shaofengshi this is ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872220784 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [I] [Bug report] Missing @param Tag Warning in Command.java [gravitino]

2024-12-05 Thread via GitHub
justinmclean closed issue #5772: [Bug report] Missing @param Tag Warning in Command.java URL: https://github.com/apache/gravitino/issues/5772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] [Bug report] Missing @param Tag Warning in Command.java [gravitino]

2024-12-05 Thread via GitHub
justinmclean closed issue #5772: [Bug report] Missing @param Tag Warning in Command.java URL: https://github.com/apache/gravitino/issues/5772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] [#5772] fix: missing param [gravitino]

2024-12-05 Thread via GitHub
justinmclean merged PR #5776: URL: https://github.com/apache/gravitino/pull/5776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872169368 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872219872 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872218789 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872219487 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872201573 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872218789 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872217906 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872217416 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872217072 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872213437 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872209796 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872208428 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872206989 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872204575 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872203366 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872204371 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872202612 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872202158 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872196235 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872173371 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872189878 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872188009 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-05 Thread via GitHub
justinmclean commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1872176835 ## docs/how-to-install.md: ## @@ -6,145 +6,170 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from s

  1   2   >