Re: [PR] [#5731]feat(auth-ranger): RangerAuthorizationHDFSPlugin supports Fileset authorization [gravitino]

2024-12-03 Thread via GitHub
theoryxu commented on code in PR #5733: URL: https://github.com/apache/gravitino/pull/5733#discussion_r1868867479 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java: ## @@ -0,0 +1,202 @@ +package org.

Re: [PR] [#5731]feat(auth-ranger): RangerAuthorizationHDFSPlugin supports Fileset authorization [gravitino]

2024-12-03 Thread via GitHub
xunliu commented on PR #5733: URL: https://github.com/apache/gravitino/pull/5733#issuecomment-2516399059 @theoryxu Please rebase your PR to the latest main branch, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] [#5624] feat(bundles): support ADLS credential provider [gravitino]

2024-12-03 Thread via GitHub
FANNG1 commented on code in PR #5737: URL: https://github.com/apache/gravitino/pull/5737#discussion_r1868831560 ## iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/integration/test/IcebergRESTADLSIT.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

Re: [PR] [#5731]feat(auth-ranger): RangerAuthorizationHDFSPlugin supports Fileset authorization [gravitino]

2024-12-03 Thread via GitHub
xunliu commented on code in PR #5733: URL: https://github.com/apache/gravitino/pull/5733#discussion_r1868818041 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerMetadataObject.java: ## @@ -41,7 +41,9 @@ enum Type { /** A t

Re: [PR] [#5201] feat(client-python): Implement expressions in python client [gravitino]

2024-12-03 Thread via GitHub
xunliu commented on code in PR #5646: URL: https://github.com/apache/gravitino/pull/5646#discussion_r1868793998 ## clients/client-python/gravitino/api/expressions/function_expression.py: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] [#5201] feat(client-python): Implement expressions in python client [gravitino]

2024-12-03 Thread via GitHub
SophieTech88 commented on PR #5646: URL: https://github.com/apache/gravitino/pull/5646#issuecomment-2516323555 The Integration Test failure is related to the List typing things in literal.py file. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [#5560] Add support for extra catalogs in the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
shaofengshi commented on code in PR #5752: URL: https://github.com/apache/gravitino/pull/5752#discussion_r1868796086 ## docs/cli.md: ## @@ -296,6 +296,30 @@ gcli catalog create -name postgres --provider postgres --properties jdbc-url=jd gcli catalog create --name kafka --prov

Re: [PR] [#5750] feat(auth): Add metalake name in the authorization plugin [gravitino]

2024-12-03 Thread via GitHub
xunliu commented on PR #5751: URL: https://github.com/apache/gravitino/pull/5751#issuecomment-2516296850 @jerqi I supplement `MetalakeHookDispatcher::alterMetalake()` Please help me review again, Thanks! -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [#5201] feat(client-python): Implement expressions in python client [gravitino]

2024-12-03 Thread via GitHub
SophieTech88 commented on code in PR #5646: URL: https://github.com/apache/gravitino/pull/5646#discussion_r1868774787 ## clients/client-python/gravitino/api/types/types.py: ## @@ -123,7 +123,7 @@ def get(cls) -> "ShortType": return cls(True) @classmethod

Re: [PR] [#5624] feat(bundles): support ADLS credential provider [gravitino]

2024-12-03 Thread via GitHub
orenccl commented on PR #5737: URL: https://github.com/apache/gravitino/pull/5737#issuecomment-2516273357 Hi @FANNG1 , This PR is ready for review now, please take a look. 🙇‍♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [#5201] feat(client-python): Implement expressions in python client [gravitino]

2024-12-03 Thread via GitHub
SophieTech88 commented on code in PR #5646: URL: https://github.com/apache/gravitino/pull/5646#discussion_r1868770901 ## clients/client-python/gravitino/api/types/types.py: ## @@ -123,7 +123,7 @@ def get(cls) -> "ShortType": return cls(True) @classmethod

Re: [PR] [#5624] feat(bundles): support ADLS credential provider [gravitino]

2024-12-03 Thread via GitHub
orenccl commented on code in PR #5737: URL: https://github.com/apache/gravitino/pull/5737#discussion_r1868764757 ## api/src/main/java/org/apache/gravitino/credential/ADLSTokenCredential.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5624] feat(bundles): support ADLS credential provider [gravitino]

2024-12-03 Thread via GitHub
orenccl commented on code in PR #5737: URL: https://github.com/apache/gravitino/pull/5737#discussion_r1868764757 ## api/src/main/java/org/apache/gravitino/credential/ADLSTokenCredential.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5624] feat(bundles): support ADLS credential provider [gravitino]

2024-12-03 Thread via GitHub
orenccl commented on code in PR #5737: URL: https://github.com/apache/gravitino/pull/5737#discussion_r1868764757 ## api/src/main/java/org/apache/gravitino/credential/ADLSTokenCredential.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [Help Wanted][#5624] feat(bundles): support ADSL credential provider [gravitino]

2024-12-03 Thread via GitHub
orenccl commented on code in PR #5737: URL: https://github.com/apache/gravitino/pull/5737#discussion_r1868753625 ## api/src/main/java/org/apache/gravitino/credential/ADLSTokenCredential.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[I] [Bug report] The API for creating an Iceberg catalog has a deprecated parameter "warehouse" that is required in the HTTP payload [gravitino]

2024-12-03 Thread via GitHub
liuchunhao opened a new issue, #5756: URL: https://github.com/apache/gravitino/issues/5756 ### Version main branch ### Describe what's wrong The property key `warehouse` was removed with `rest` assigned as a catalog-backend on Web UI, but REST API call for creating a cat

Re: [PR] [#5201] feat(client-python): Implement expressions in python client [gravitino]

2024-12-03 Thread via GitHub
SophieTech88 commented on code in PR #5646: URL: https://github.com/apache/gravitino/pull/5646#discussion_r1868747950 ## clients/client-python/gravitino/api/expressions/expression.py: ## @@ -0,0 +1,51 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more co

Re: [PR] [Help Wanted][#5624] feat(bundles): support ADSL credential provider [gravitino]

2024-12-03 Thread via GitHub
orenccl closed pull request #5737: [Help Wanted][#5624] feat(bundles): support ADSL credential provider URL: https://github.com/apache/gravitino/pull/5737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [#5560] Add support for extra catalogs in the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean commented on PR #5752: URL: https://github.com/apache/gravitino/pull/5752#issuecomment-2516195708 @shaofengshi / @tengqm this is ready to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] [#5201] feat(client-python): Implement expressions in python client [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on code in PR #5646: URL: https://github.com/apache/gravitino/pull/5646#discussion_r1868687438 ## clients/client-python/gravitino/api/expressions/function_expression.py: ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
shaofengshi merged PR #5717: URL: https://github.com/apache/gravitino/pull/5717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@grav

(gravitino) branch main updated: [#5383] Add create table command to the Gravitino CLI (#5717)

2024-12-03 Thread shaofengshi
This is an automated email from the ASF dual-hosted git repository. shaofengshi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 054c6f7df [#5383] Add create table command t

Re: [PR] [#5683] Improvement: Remove gravitino-web-*.jar from Gravitino release files [gravitino]

2024-12-03 Thread via GitHub
yuqi1129 closed pull request #5748: [#5683] Improvement: Remove gravitino-web-*.jar from Gravitino release files URL: https://github.com/apache/gravitino/pull/5748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [I] [Improvement] Remove `gravitino-web` jar from release package [gravitino]

2024-12-03 Thread via GitHub
yuqi1129 closed issue #5683: [Improvement] Remove `gravitino-web` jar from release package URL: https://github.com/apache/gravitino/issues/5683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] [#5683] Improvement: Remove gravitino-web-*.jar from Gravitino release files [gravitino]

2024-12-03 Thread via GitHub
yuqi1129 commented on PR #5748: URL: https://github.com/apache/gravitino/pull/5748#issuecomment-2516136254 > This issue works fine on my local environment. The changes I pushed are based on the logic from the other issue #5490 , and I have ensured that web JAR packages are not included. @yu

Re: [I] [Improvement] Remove `gravitino-web` jar from release package [gravitino]

2024-12-03 Thread via GitHub
yuqi1129 commented on issue #5683: URL: https://github.com/apache/gravitino/issues/5683#issuecomment-2516136848 Close it as it's not an issue in the main branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Improvement] Display audit information for users and groups in Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean commented on issue #5527: URL: https://github.com/apache/gravitino/issues/5527#issuecomment-2516087849 @Pjaygit I going to assume from the lack of response you are no longer working on this. If anyone else want to work on this just ask. -- This is an automated message from th

Re: [PR] [#5279] improvement(cli): Display sort order information for Tables in the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean merged PR #5709: URL: https://github.com/apache/gravitino/pull/5709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [I] [Improvement] Display sort order for tables in the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean closed issue #5279: [Improvement] Display sort order for tables in the Gravitino CLI URL: https://github.com/apache/gravitino/issues/5279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

(gravitino) branch main updated: [#5279] improvement(cli): Display sort order information for Tables in the Gravitino CLI (#5709)

2024-12-03 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 7759d0b94 [#5279] improvement(cli): Display sort

Re: [I] [Improvement] Display sort order for tables in the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean closed issue #5279: [Improvement] Display sort order for tables in the Gravitino CLI URL: https://github.com/apache/gravitino/issues/5279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [Help Wanted][#5624] feat(bundles): support ADSL credential provider [gravitino]

2024-12-03 Thread via GitHub
orenccl commented on code in PR #5737: URL: https://github.com/apache/gravitino/pull/5737#discussion_r1868592959 ## api/src/main/java/org/apache/gravitino/credential/ADLSTokenCredential.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5683] Improvement: Remove gravitino-web-*.jar from Gravitino release files [gravitino]

2024-12-03 Thread via GitHub
TungYuChiang commented on PR #5748: URL: https://github.com/apache/gravitino/pull/5748#issuecomment-2516064754 This issue works fine on my local environment. The changes I pushed are based on the logic from the other issue #5490 , and I have ensured that web JAR packages are not included.

Re: [PR] [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout [gravitino]

2024-12-03 Thread via GitHub
diqiu50 commented on code in PR #5738: URL: https://github.com/apache/gravitino/pull/5738#discussion_r1868651872 ## clients/filesystem-fuse/Cargo.toml: ## @@ -29,8 +29,13 @@ repository = "https://github.com/apache/gravitino"; name = "gvfs-fuse" path = "src/main.rs" +[lib] +n

Re: [PR] [#5683] Improvement: Remove gravitino-web-*.jar from Gravitino release files [gravitino]

2024-12-03 Thread via GitHub
TungYuChiang commented on PR #5748: URL: https://github.com/apache/gravitino/pull/5748#issuecomment-2516059176 @jerryshao Thank you for the reminder, I have made the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
shaofengshi commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868639579 ## docs/cli.md: ## @@ -426,6 +437,11 @@ gcli table set --name catalog_postgres.hr.salaries --property test --value value gcli table remove --name catalog_postgr

Re: [PR] [#5750] feat(auth): Add metalake name in the authorization plugin [gravitino]

2024-12-03 Thread via GitHub
jerqi commented on PR #5751: URL: https://github.com/apache/gravitino/pull/5751#issuecomment-2516045823 > > How to handle the case if we rename a metalake? > > @jerqi I already add rename metalake operation in the `onMetadataUpdated`. > > ``` > public Boolean onMetadataUpda

Re: [PR] [#5750] feat(auth): Add metalake name in the authorization plugin [gravitino]

2024-12-03 Thread via GitHub
xunliu commented on PR #5751: URL: https://github.com/apache/gravitino/pull/5751#issuecomment-2516040254 > How to handle the case if we rename a metalake? @jerqi I already add rename metalake operation in the `onMetadataUpdated`. ``` public Boolean onMetadataUpdated(Metadat

[PR] [SIP] supports credential java client [gravitino]

2024-12-03 Thread via GitHub
FANNG1 opened a new pull request, #5753: URL: https://github.com/apache/gravitino/pull/5753 ### What changes were proposed in this pull request? (Please outline the changes and how this PR fixes the issue.) ### Why are the changes needed? (Please clarify why the c

Re: [PR] [#5201] feat(client-python): Implement expressions in python client [gravitino]

2024-12-03 Thread via GitHub
xunliu commented on PR #5646: URL: https://github.com/apache/gravitino/pull/5646#issuecomment-2516025721 hi @tengqm Do you want to have another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868588933 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java: ## @@ -50,6 +50,7 @@ public class GravitinoOptions { public static final String R

Re: [PR] [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout [gravitino]

2024-12-03 Thread via GitHub
FANNG1 commented on code in PR #5738: URL: https://github.com/apache/gravitino/pull/5738#discussion_r1868613267 ## clients/filesystem-fuse/Cargo.toml: ## @@ -29,8 +29,13 @@ repository = "https://github.com/apache/gravitino"; name = "gvfs-fuse" path = "src/main.rs" +[lib] +na

Re: [PR] [Improvement] Remove gravitino-web-*.jar from Gravitino release files [gravitino]

2024-12-03 Thread via GitHub
jerryshao commented on PR #5748: URL: https://github.com/apache/gravitino/pull/5748#issuecomment-2516012964 @TungYuChiang can you please change the PR title to follow the format like other PRs? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] [Subtask] Support credential API for Gravitino server [gravitino]

2024-12-03 Thread via GitHub
jerryshao closed issue #5619: [Subtask] Support credential API for Gravitino server URL: https://github.com/apache/gravitino/issues/5619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [#5750] feat(auth): Add metalake name in the authorization plugin [gravitino]

2024-12-03 Thread via GitHub
jerqi commented on PR #5751: URL: https://github.com/apache/gravitino/pull/5751#issuecomment-2516003366 How to handle the case if we rename a metalake? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

(gravitino) branch main updated: [#5619] feat(api): supports credential api for Gravitino (#5690)

2024-12-03 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 8750ae874 [#5619] feat(api): supports credential a

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
jerryshao merged PR #5690: URL: https://github.com/apache/gravitino/pull/5690 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch main updated: [MINOR] fix(doc): Fix the binary data type mapping error of the gravitino and paimon tables in the paimon catalog document. (#5741)

2024-12-03 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new ed1bad0cb [MINOR] fix(doc): Fix the binary data ty

Re: [PR] [MINOR] fix(doc): Fix the binary data type mapping error of the gravitino and paimon tables in the paimon catalog document. [gravitino]

2024-12-03 Thread via GitHub
jerryshao merged PR #5741: URL: https://github.com/apache/gravitino/pull/5741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [Help Wanted][#5624] feat(bundles): support ADSL credential provider [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on code in PR #5737: URL: https://github.com/apache/gravitino/pull/5737#discussion_r1868593444 ## api/src/main/java/org/apache/gravitino/credential/ADLSTokenCredential.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [Help Wanted][#5624] feat(bundles): support ADSL credential provider [gravitino]

2024-12-03 Thread via GitHub
orenccl commented on code in PR #5737: URL: https://github.com/apache/gravitino/pull/5737#discussion_r1868592959 ## api/src/main/java/org/apache/gravitino/credential/ADLSTokenCredential.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on PR #5717: URL: https://github.com/apache/gravitino/pull/5717#issuecomment-2515997223 lgtm. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout [gravitino]

2024-12-03 Thread via GitHub
diqiu50 commented on code in PR #5738: URL: https://github.com/apache/gravitino/pull/5738#discussion_r1868591708 ## clients/filesystem-fuse/Cargo.toml: ## @@ -29,8 +29,13 @@ repository = "https://github.com/apache/gravitino"; name = "gvfs-fuse" path = "src/main.rs" +[lib] +n

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868585072 ## clients/cli/src/main/java/org/apache/gravitino/cli/ReadTableCSV.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

(gravitino) branch main updated: [hotfix] fix camelCase method names from getfieldName to getFieldName (#5740)

2024-12-03 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new a36fbcfa6 [hotfix] fix camelCase method names from

Re: [PR] [hotfix] fix camelCase method names from getfieldName to getFieldName [gravitino]

2024-12-03 Thread via GitHub
jerryshao merged PR #5740: URL: https://github.com/apache/gravitino/pull/5740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868582426 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java: ## @@ -50,6 +50,7 @@ public class GravitinoOptions { public static final String ROLE =

Re: [PR] [#5560] Add support for extra catalogs in the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean commented on PR #5752: URL: https://github.com/apache/gravitino/pull/5752#issuecomment-2515981209 Yes it is based on https://github.com/apache/gravitino/pull/5717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868580952 ## clients/cli/src/main/java/org/apache/gravitino/cli/ReadTableCSV.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868580055 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateTable.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [#5731]feat(auth-ranger): RangerAuthorizationHDFSPlugin supports Fileset authorization [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on code in PR #5733: URL: https://github.com/apache/gravitino/pull/5733#discussion_r1868571637 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationHDFSPlugin.java: ## @@ -0,0 +1,202 @@ +package org.ap

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868574599 ## clients/cli/src/main/java/org/apache/gravitino/cli/ReadTableCSV.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868571598 ## clients/cli/src/main/java/org/apache/gravitino/cli/ReadTableCSV.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [Help Wanted][#5624] feat(bundles): support ADSL credential provider [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on code in PR #5737: URL: https://github.com/apache/gravitino/pull/5737#discussion_r1868564082 ## api/src/main/java/org/apache/gravitino/credential/ADLSTokenCredential.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868570054 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java: ## @@ -50,6 +50,7 @@ public class GravitinoOptions { public static final String R

Re: [PR] [hotfix] fix camelCase method names from getfieldName to getFieldName [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on PR #5740: URL: https://github.com/apache/gravitino/pull/5740#issuecomment-2515925330 Thanks. lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [Improvement] Remove gravitino-web-*.jar from Gravitino release files [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on PR #5748: URL: https://github.com/apache/gravitino/pull/5748#issuecomment-2515921187 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] [#5098] improvement(doc): add note for Doris type mapping [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on PR #5749: URL: https://github.com/apache/gravitino/pull/5749#issuecomment-2515920144 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [#5750] feat(auth): Add metalake name in the authorization plugin [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on PR #5751: URL: https://github.com/apache/gravitino/pull/5751#issuecomment-2515918583 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [#5560] Add support for extra catalogs in the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on PR #5752: URL: https://github.com/apache/gravitino/pull/5752#issuecomment-2515915888 Is this PR based on #5717? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on code in PR #5717: URL: https://github.com/apache/gravitino/pull/5717#discussion_r1868533351 ## clients/cli/src/main/java/org/apache/gravitino/cli/ReadTableCSV.java: ## @@ -0,0 +1,152 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[PR] [#5560] Add support for extra catalogs in the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean opened a new pull request, #5752: URL: https://github.com/apache/gravitino/pull/5752 ### What changes were proposed in this pull request? Expand Gravitino CLI support. ### Why are the changes needed? Add support for all current catalogs. Fix: #5560

Re: [PR] feat(helm-chart): remove helm-chart support [gravitino-playground]

2024-12-03 Thread via GitHub
unknowntpo commented on code in PR #110: URL: https://github.com/apache/gravitino-playground/pull/110#discussion_r1868536237 ## init/hive/init.sh: ## @@ -21,7 +21,6 @@ sed -i '$d' /usr/local/sbin/start.sh sed -i '$d' /usr/local/sbin/start.sh Review Comment: > Is it necess

Re: [PR] feat(helm-chart): remove helm-chart support [gravitino-playground]

2024-12-03 Thread via GitHub
unknowntpo commented on code in PR #110: URL: https://github.com/apache/gravitino-playground/pull/110#discussion_r1868535855 ## init/hive/init.sh: ## @@ -21,7 +21,6 @@ sed -i '$d' /usr/local/sbin/start.sh sed -i '$d' /usr/local/sbin/start.sh cp /tmp/hive/core-site.xml /tmp/h

Re: [I] [Improvement] Remove all tags from an entity in the Gravitino CLI. [gravitino]

2024-12-03 Thread via GitHub
justinmclean commented on issue #5529: URL: https://github.com/apache/gravitino/issues/5529#issuecomment-2515811641 You would just need to check if teh tag option exists, if it doesn't, then delete all tags. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] [#5383] Add create table command to the Gravitino CLI [gravitino]

2024-12-03 Thread via GitHub
justinmclean commented on PR #5717: URL: https://github.com/apache/gravitino/pull/5717#issuecomment-2515645401 @shaofengshi this is ready for review. The failed CI is due to a network error and unrelated to the code changes. -- This is an automated message from the Apache Git Service. To

Re: [I] [Improvement] Remove all tags from an entity in the Gravitino CLI. [gravitino]

2024-12-03 Thread via GitHub
suvaidkhan commented on issue #5529: URL: https://github.com/apache/gravitino/issues/5529#issuecomment-2515108329 @justinmclean appreciate the detailed response. I was going towards adding a new command as both delete and remove are already being used in the handleTagCommand() functi

[PR] [#5750] feat(auth): Add metalake name in the authorization plugin [gravitino]

2024-12-03 Thread via GitHub
xunliu opened a new pull request, #5751: URL: https://github.com/apache/gravitino/pull/5751 ### What changes were proposed in this pull request? Add metalake name variable in the `BaseAuthorization::newPlugin()` params. ### Why are the changes needed? Fix: #5750 ##

Re: [PR] [ #5625] feat(bundles) support Aliyun oss credential provider [gravitino]

2024-12-03 Thread via GitHub
sunxiaojian commented on code in PR #5701: URL: https://github.com/apache/gravitino/pull/5701#discussion_r1867827508 ## core/src/main/java/org/apache/gravitino/credential/config/OSSCredentialConfig.java: ## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
FANNG1 commented on PR #5690: URL: https://github.com/apache/gravitino/pull/5690#issuecomment-2514686659 > @FANNG1 can you please update the PR description to reflect your updated API? done -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
jerryshao commented on PR #5690: URL: https://github.com/apache/gravitino/pull/5690#issuecomment-2514668416 @FANNG1 can you please update the PR description to reflect your updated API? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-03 Thread via GitHub
Huanli-Meng commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1867743799 ## docs/how-to-install.md: ## @@ -6,145 +6,151 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from sc

[I] [Improvement] Add metalake name in the authorization plugin [gravitino]

2024-12-03 Thread via GitHub
xunliu opened a new issue, #5750: URL: https://github.com/apache/gravitino/issues/5750 ### What would you like to be improved? Now, Gravitino authorization plugin didn't contain `matalake` name. But authorization HDFS plugin needs metalake name to call `GravitinoEnv.getInstance().f

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-03 Thread via GitHub
Huanli-Meng commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1867740775 ## docs/how-to-install.md: ## @@ -6,145 +6,151 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from sc

Re: [PR] [#5289][Improvement] CatalogMysqlDriverIT miss driver url [gravitino]

2024-12-03 Thread via GitHub
mchades commented on PR #5431: URL: https://github.com/apache/gravitino/pull/5431#issuecomment-2514583093 hi @lsyulong , is there any progress with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on PR #5726: URL: https://github.com/apache/gravitino/pull/5726#issuecomment-2514580864 lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
FANNG1 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1867717523 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-03 Thread via GitHub
Huanli-Meng commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1867698660 ## docs/how-to-install.md: ## @@ -6,145 +6,151 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from sc

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-03 Thread via GitHub
Huanli-Meng commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1867695093 ## docs/how-to-install.md: ## @@ -6,145 +6,151 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from sc

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
jerryshao commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1867695946 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-03 Thread via GitHub
Huanli-Meng commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1867694748 ## docs/how-to-install.md: ## @@ -6,145 +6,151 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from sc

Re: [PR] [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout [gravitino]

2024-12-03 Thread via GitHub
FANNG1 commented on code in PR #5738: URL: https://github.com/apache/gravitino/pull/5738#discussion_r1867677989 ## clients/filesystem-fuse/Cargo.toml: ## @@ -29,8 +29,13 @@ repository = "https://github.com/apache/gravitino"; name = "gvfs-fuse" path = "src/main.rs" +[lib] +na

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-03 Thread via GitHub
tengqm commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1867674940 ## docs/how-to-install.md: ## @@ -6,145 +6,151 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from scratch

[PR] [Improvement] Remove gravitino-web-*.jar from Gravitino release files [gravitino]

2024-12-03 Thread via GitHub
TungYuChiang opened a new pull request, #5748: URL: https://github.com/apache/gravitino/pull/5748 ### Why are the changes needed? close #5683 ### Does this PR introduce _any_ user-facing change? None ### How was this patch tested? Using following co

[I] [EPIC] Gravitino CLI Table formatted output [gravitino]

2024-12-03 Thread via GitHub
xunliu opened a new issue, #5747: URL: https://github.com/apache/gravitino/issues/5747 ### Describe the proposal Management all subtask for Gravitino CLI Table formatted output ### Task list - [ ] #5506 - [ ] #5745 - [ ] #5746 -- This is an automated message fro

Re: [PR] [MINOR] docs: --refine the how to install guide [gravitino]

2024-12-03 Thread via GitHub
Huanli-Meng commented on code in PR #5726: URL: https://github.com/apache/gravitino/pull/5726#discussion_r1867651212 ## docs/how-to-install.md: ## @@ -6,145 +6,151 @@ license: "This software is licensed under the Apache License version 2." ## Install Apache Gravitino from sc

Re: [PR] [#5619] feat(api): supports credential api for Gravitino [gravitino]

2024-12-03 Thread via GitHub
FANNG1 commented on code in PR #5690: URL: https://github.com/apache/gravitino/pull/5690#discussion_r1867643701 ## api/src/main/java/org/apache/gravitino/credential/SupportsCredentials.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[I] [FEATURE] Support table format output for Audit command [gravitino]

2024-12-03 Thread via GitHub
waukin opened a new issue, #5746: URL: https://github.com/apache/gravitino/issues/5746 ### Describe the feature The current Audit command in the Gravitino CLI supports only plain format output. I plan to add support for table format output to the `MetalakeAudit`, `CatalogAudit`, `

[I] [FEATURE] Support table format output for ListCatalogs command [gravitino]

2024-12-03 Thread via GitHub
waukin opened a new issue, #5745: URL: https://github.com/apache/gravitino/issues/5745 ### Describe the feature The current `ListCatalogs` command in the Gravitino CLI supports only plain format output. I plan to add support for table format output to the `ListCatalogs` command.

Re: [PR] [ #5625] feat(bundles) support Aliyun oss credential provider [gravitino]

2024-12-03 Thread via GitHub
FANNG1 commented on PR #5701: URL: https://github.com/apache/gravitino/pull/5701#issuecomment-2514392294 I couldn't run pass the test in deploy mode, ` ./gradlew :iceberg:iceberg-rest-server:test --tests "org.apache.gravitino.iceberg.integration.test.IcebergRESTOSSIT.testSnapshot" -PtestMo

  1   2   >